canon 0.1.14 → 0.1.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81995d22ec29adb9b2fb60f0ed8bc0219fe28e468c89a2001901b0f4521c757b
-  data.tar.gz: fabc6e6c77e92848783e747459377caa787330d3360f83f544b6372cc68ba227
+  metadata.gz: 0eb3c717365f052953d3deaf83a897112709c1a6084b472b99ddfdc2c9e43b67
+  data.tar.gz: fe4b2b513193b87692cd1fcb11569898e69c6818bea08ae3dccc753ad935f6e0
 SHA512:
-  metadata.gz: d33e2fcd54ae3b5cab9fdcfe980b1a8d1f2f97b1389ea430ecfda093b275e77f93e49e5a4f1171797df3fcb7f8d0ef28654301dbb846c16a4eb751018ea10129
-  data.tar.gz: 85ffc85bf577b631c9aee7e16f81e0be163de2025154dd197962943c533cd3a1aa0d79799d084194780ff8654e766b0ac3ac36b635425d47e64009c71a4edb6d
+  metadata.gz: 2c6d351b873ebb745c5abcdb2ff6cdbcf4ce53da1ad7f070c0b1eefeeeb776e315fa62c8d82c24b216e6e93cf5ac1790ebe3c6a171a142036ef0abc356d5a9e6
+  data.tar.gz: 6c0228d16e387e2a7919786cb57636e5c3183f0a1a1e119684fb0e01122a5ac23ffc08849f9df55bf413495024de30c4bf2e420172e13a9197d48b30636f845a

data/.rubocop_todo.yml

@@ -1,64 +1,24 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-02-17 14:18:53 UTC using RuboCop version 1.81.7.
+# on 2026-03-21 03:07:35 UTC using RuboCop version 1.85.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 1
-# Configuration parameters: Severity.
 Gemspec/RequiredRubyVersion:
   Exclude:
     - 'canon.gemspec'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/ArgumentAlignment:
-  Exclude:
-    - 'lib/canon/xml/element_matcher.rb'
-
-# Offense count: 23
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith.
-# SupportedStylesAlignWith: either, start_of_block, start_of_line
-Layout/BlockAlignment:
-  Exclude:
-    - 'spec/canon/fixtures/isodoc_spec.rb'
-    - 'spec/canon/table_class_attribute_bug_spec.rb'
-
-# Offense count: 23
+# Offense count: 773
 # This cop supports safe autocorrection (--autocorrect).
-Layout/BlockEndNewline:
-  Exclude:
-    - 'spec/canon/fixtures/isodoc_spec.rb'
-    - 'spec/canon/table_class_attribute_bug_spec.rb'
-
-# Offense count: 46
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Width, AllowedPatterns.
-Layout/IndentationWidth:
-  Exclude:
-    - 'spec/canon/fixtures/isodoc_spec.rb'
-    - 'spec/canon/table_class_attribute_bug_spec.rb'
-
-# Offense count: 780
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
+# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Enabled: false
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/canon/xml/element_matcher.rb'
-
-# Offense count: 48
+# Offense count: 49
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
 Lint/DuplicateBranch:
   Enabled: false
@@ -87,45 +47,44 @@ Lint/UnreachableCode:
   Exclude:
     - 'lib/canon/diff_formatter/debug_output.rb'
 
-# Offense count: 7
+# Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
 # NotImplementedExceptions: NotImplementedError
 Lint/UnusedMethodArgument:
   Exclude:
-    - 'lib/canon/comparison.rb'
     - 'lib/canon/diff/path_builder.rb'
     - 'lib/canon/diff_formatter/by_line/base_formatter.rb'
     - 'lib/canon/diff_formatter/by_line/xml_formatter.rb'
     - 'lib/canon/diff_formatter/by_object/base_formatter.rb'
 
-# Offense count: 215
+# Offense count: 229
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Enabled: false
 
-# Offense count: 21
+# Offense count: 22
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 84
 
-# Offense count: 183
+# Offense count: 187
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-# Offense count: 369
+# Offense count: 394
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 115
+  Max: 95
 
-# Offense count: 44
+# Offense count: 45
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 9
 
-# Offense count: 149
+# Offense count: 154
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
   Enabled: false
@@ -139,16 +98,6 @@ Naming/MethodParameterName:
     - 'lib/canon/comparison/xml_comparator/attribute_comparator.rb'
     - 'lib/canon/xml/namespace_handler.rb'
 
-# Offense count: 1
-# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros, UseSorbetSigs.
-# NamePrefix: is_, has_, have_, does_
-# ForbiddenPrefixes: is_, has_, have_, does_
-# AllowedMethods: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicatePrefix:
-  Exclude:
-    - 'lib/canon/comparison/html_comparator.rb'
-
 # Offense count: 6
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
@@ -159,13 +108,12 @@ Naming/VariableNumber:
     - 'lib/canon/comparison/markup_comparator.rb'
     - 'lib/canon/comparison/xml_comparator/diff_node_builder.rb'
 
-# Offense count: 13
+# Offense count: 2
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
   Exclude:
     - 'lib/canon/comparison/html_comparator.rb'
     - 'lib/canon/xml/xml_base_handler.rb'
-    - 'spec/canon/table_class_attribute_bug_spec.rb'
 
 # Offense count: 68
 # Configuration parameters: Prefixes, AllowedPatterns.
@@ -184,10 +132,10 @@ RSpec/DescribeMethod:
     - 'spec/canon/comparison/multiple_differences_spec.rb'
     - 'spec/canon/diff_formatter/character_map_customization_spec.rb'
 
-# Offense count: 696
+# Offense count: 695
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Max: 67
+  Max: 43
 
 # Offense count: 8
 # This cop supports safe autocorrection (--autocorrect).
@@ -240,7 +188,7 @@ RSpec/MultipleDescribes:
 RSpec/MultipleExpectations:
   Max: 15
 
-# Offense count: 70
+# Offense count: 71
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 13
@@ -259,13 +207,12 @@ RSpec/NamedSubject:
 RSpec/NestedGroups:
   Max: 4
 
-# Offense count: 11
+# Offense count: 10
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
 RSpec/NoExpectationExample:
   Exclude:
     - 'spec/canon/context_grouping_spec.rb'
-    - 'spec/canon/fixtures/isodoc_spec.rb'
     - 'spec/canon/informative_diffs_debug_spec.rb'
     - 'spec/canon/isodoc_blockquotes_spec.rb'
     - 'spec/canon/match_scenarios_spec.rb'
@@ -283,28 +230,17 @@ RSpec/SpecFilePathFormat:
     - 'spec/canon/yaml/formatter_spec.rb'
     - 'spec/xml_c14n_spec.rb'
 
-# Offense count: 120
+# Offense count: 126
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
+    - 'spec/canon/comparison/diff_node_builder_spec.rb'
     - 'spec/canon/comparison/whitespace_sensitivity_spec.rb'
     - 'spec/canon/diff/diff_classifier_spec.rb'
     - 'spec/canon/diff/path_builder_spec.rb'
     - 'spec/canon/diff/xml_serialization_formatter_spec.rb'
     - 'spec/canon/tree_diff/operation_converter_spec.rb'
 
-# Offense count: 44
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# AllowedMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'spec/canon/fixtures/isodoc_spec.rb'
-    - 'spec/canon/table_class_attribute_bug_spec.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowComments.

data/README.adoc

@@ -901,6 +901,63 @@ After checking out the repo, run `bin/setup` to install dependencies. Then run
 `rake spec` to run the tests. You can also run `bin/console` for an interactive
 prompt.
 
+== Performance
+
+Canon includes a comprehensive performance benchmarking system to prevent regressions in XML/HTML parsing and comparison algorithms.
+
+=== Running Benchmarks
+
+[source,bash]
+----
+# Run all benchmarks (10s per test, takes ~5 minutes)
+bundle exec rake performance:run
+
+# Quick benchmark (2s per test, takes ~30 seconds)
+bundle exec rake performance:quick
+
+# Compare against main branch (for PRs)
+bundle exec rake performance:compare
+
+# Run specific category
+bundle exec rake performance:category[xml_parsing]
+
+# Output formats
+bundle exec rake performance:json
+bundle exec rake performance:yaml
+----
+
+=== Benchmark Categories
+
+* **XML Parsing**: DOM vs SAX, simple vs large documents
+* **HTML Parsing**: Simple vs complex (with scripts/tables)
+* **XML/HTML Comparison**: Identical, similar, different documents
+* **Format Canonicalization**: XML C14N, JSON, YAML
+
+=== SAX Parser
+
+Canon includes a SAX-based XML parser (`Canon::Xml::SaxBuilder`) that provides
+significantly faster XML parsing by avoiding intermediate Nokogiri DOM trees.
+
+[source,ruby]
+----
+require 'canon/xml/sax_builder'
+
+# Parse XML directly to Canon::Xml::Node tree
+root = Canon::Xml::SaxBuilder.parse(xml_string)
+
+# For C14N (strips DOCTYPE to avoid DTD default attribute expansion)
+root = Canon::Xml::SaxBuilder.parse(xml_string, strip_doctype: true)
+----
+
+Performance improvement: ~6x faster than DOM parsing + conversion for large documents.
+
+=== CI Integration
+
+Performance benchmarks run automatically on:
+
+* **Pull requests**: Compares against `main` branch and fails if regression exceeds 10%
+* **Main branch pushes**: Logs baseline metrics for performance tracking
+
 == Contributing
 
 Bug reports and pull requests are welcome on GitHub at

data/Rakefile

@@ -9,4 +9,6 @@ require "rubocop/rake_task"
 
 RuboCop::RakeTask.new
 
+Dir.glob("lib/tasks/**/*.rake").each { |r| load r }
+
 task default: %i[spec rubocop]

data/docs/features/index.adoc

@@ -92,6 +92,16 @@ Error handling and validation.
 * Format detection
 * Error messages
 
+=== Performance
+
+link:performance/[**Performance**]::
+Performance benchmarking and optimization.
++
+* SAX-based XML parser
+* Benchmark categories
+* CI integration
+* Regression detection
+
 == Quick Configuration Examples
 
 === Test-Friendly Comparison

data/docs/features/performance.adoc

@@ -0,0 +1,161 @@
+---
+layout: default
+title: Performance
+nav_order: 100
+---
+= Performance
+
+Canon includes a comprehensive performance benchmarking system to prevent regressions in XML/HTML parsing and comparison algorithms.
+
+== Running Benchmarks
+
+[source,bash]
+----
+# Run all benchmarks (10s per test, ~5 minutes total)
+bundle exec rake performance:run
+
+# Quick benchmark (2s per test, ~30 seconds)
+bundle exec rake performance:quick
+
+# Compare against main branch (for PRs, fails on regression)
+bundle exec rake performance:compare
+
+# Run specific category
+bundle exec rake performance:category[xml_parsing]
+
+# Output in different formats
+bundle exec rake performance:json
+bundle exec rake performance:yaml
+----
+
+== Benchmark Categories
+
+=== XML Parsing
+
+* **DOM (simple)**: Standard Nokogiri DOM parsing
+* **SAX (simple)**: SAX-based streaming parser
+* **DOM (large)**: Large document DOM parsing
+* **SAX (large)**: Large document SAX parsing
+
+SAX parser is typically ~20-50% faster than DOM for XML parsing.
+
+=== HTML Parsing
+
+* **Simple HTML**: Basic HTML document parsing
+* **Complex HTML**: HTML with scripts, styles, and tables
+
+=== XML/HTML Comparison
+
+* **Identical**: Comparing the same document to itself
+* **Similar**: Comparing documents with minor differences
+* **Different**: Comparing documents with different namespaces/structure
+
+=== Format Canonicalization
+
+* **XML C14N**: W3C Canonical XML
+* **JSON**: JSON formatting
+* **YAML**: YAML formatting
+
+== SAX Parser
+
+Canon includes a SAX-based XML parser (`Canon::Xml::SaxBuilder`) that provides
+significantly faster XML parsing by avoiding intermediate Nokogiri DOM trees.
+
+=== How It Works
+
+Traditional parsing:
+[source]
+----
+XML String → Nokogiri DOM (~60ms) → Canon::Xml::Node (~1200ms) = ~1260ms
+----
+
+SAX parsing:
+[source]
+----
+XML String → Nokogiri SAX → Canon::Xml::Node (~200ms) = ~200ms
+----
+
+=== Usage
+
+[source,ruby]
+----
+require 'canon/xml/sax_builder'
+
+# Parse XML directly to Canon::Xml::Node tree
+root = Canon::Xml::SaxBuilder.parse(xml_string)
+
+# With options
+root = Canon::Xml::SaxBuilder.parse(xml_string,
+  preserve_whitespace: true,
+  strip_doctype: true  # For C14N compatibility
+)
+----
+
+=== Options
+
+`preserve_whitespace`:: Keep whitespace-only text nodes (default: false)
+`strip_doctype`:: Remove DOCTYPE declaration (for C14N, avoids DTD default attribute expansion)
+
+== CI Integration
+
+Performance benchmarks run automatically on:
+
+=== Pull Requests
+
+When a PR is opened, the performance workflow compares benchmarks against the `main` branch.
+If any benchmark regresses by more than 10%, the check fails with a clear error message.
+
+[source,bash]
+----
+# CI output shows comparison
+Comparing against: Previous branch (main).
+Threshold: 10% regression allowed
+
+XML Parsing: SAX (large)
+  base: 1042.30 IPS
+  curr: 1285.20 IPS
+  change: +23.31%
+  ✅ OK
+----
+
+=== Main Branch
+
+On pushes to `main`, benchmarks run to log baseline metrics for performance tracking.
+
+== Threshold Configuration
+
+The default regression threshold is 10%. Configure via rake task:
+
+[source,bash]
+----
+# Custom threshold (e.g., 5%)
+RUBYOPT="-rbenchmark-runner" bundle exec rake performance:compare
+----
+
+Or modify `lib/tasks/performance_comparator.rb`:
+
+[source,ruby]
+----
+DEFAULT_THRESHOLD = 0.10 # 10%
+----
+
+== Adding New Benchmarks
+
+Add test methods to `lib/tasks/benchmark_runner.rb`:
+
+[source,ruby]
+----
+# In BENCHMARKS hash
+BENCHMARKS = {
+  xml_parsing: [
+    # ... existing tests ...
+    { name: "New Test", method: :my_new_test, desc: "Description" },
+  ],
+}.freeze
+
+# Add test method
+def my_new_test
+  xml = DataGenerator.generate_xml(items: @items)
+  measure { Canon::Xml::SaxBuilder.parse(xml) }
+end
+----

data/lib/canon/color_detector.rb

@@ -82,7 +82,7 @@ module Canon
       # @return [Boolean] true if colors appear to be supported
       def detect_from_env
         # Check TERM variable
-        term = ENV["TERM"]
+        term = ENV.fetch("TERM", nil)
         if term && NO_COLOR_TERMS.any? { |t| term.include?(t) }
           # Known no-color terminals
           return false
@@ -100,7 +100,7 @@ module Canon
         end
 
         # Check for known color-capable terminals
-        colorterm = ENV["COLORTERM"]
+        colorterm = ENV.fetch("COLORTERM", nil)
         return true if COLOR_TERM_VALUES.include?(colorterm)
 
         # Default: assume colors are supported on modern terminals
@@ -125,7 +125,7 @@ module Canon
       # - Generic CI: check for specific TeamCity/Terminal variables
       #
       # @return [Boolean] true if CI environment likely supports colors
-      def detect_ci_colors
+      def detect_ci_colors # rubocop:disable Naming/PredicateMethod
         # Most modern CI systems support ANSI colors
         # Only disable for explicitly known non-color CI
         return false if ENV["TERM"] == "dumb"

data/lib/canon/comparison/comparison_result.rb

@@ -44,10 +44,8 @@ html_version: nil, match_options: nil, algorithm: :dom, original_strings: nil)
           if diff.is_a?(Canon::Diff::DiffNode)
             diff.normative?
           # Legacy Hash format - always considered normative (structural differences)
-          elsif diff.is_a?(Hash)
-            true
           else
-            false
+            diff.is_a?(Hash)
           end
         end
       end

data/lib/canon/comparison/dimensions/attribute_order_dimension.rb

@@ -37,7 +37,7 @@ module Canon
         # @param order1 [Array<Symbol>] First attribute order
         # @param order2 [Array<Symbol>] Second attribute order
         # @return [Boolean] true if attribute order is exactly the same
-        def compare_strict(order1, order2)
+        def compare_strict(order1, order2) # rubocop:disable Naming/PredicateMethod
           order1 == order2
         end
 

data/lib/canon/comparison/dimensions/attribute_presence_dimension.rb

@@ -37,7 +37,7 @@ module Canon
         # @param names1 [Array<Symbol>] First attribute names
         # @param names2 [Array<Symbol>] Second attribute names
         # @return [Boolean] true if attribute names are exactly equal
-        def compare_strict(names1, names2)
+        def compare_strict(names1, names2) # rubocop:disable Naming/PredicateMethod
           names1.sort == names2.sort
         end
 

data/lib/canon/comparison/dimensions/comments_dimension.rb

@@ -37,7 +37,7 @@ module Canon
         # @param comments1 [Array<String>] First comments array
         # @param comments2 [Array<String>] Second comments array
         # @return [Boolean] true if comments are exactly equal
-        def compare_strict(comments1, comments2)
+        def compare_strict(comments1, comments2) # rubocop:disable Naming/PredicateMethod
           comments1 == comments2
         end
 
@@ -48,7 +48,7 @@ module Canon
         # @param comments1 [Array<String>] First comments array
         # @param comments2 [Array<String>] Second comments array
         # @return [Boolean] true if normalized comments are equal
-        def compare_normalize(comments1, comments2)
+        def compare_normalize(comments1, comments2) # rubocop:disable Naming/PredicateMethod
           normalize_comments(comments1) == normalize_comments(comments2)
         end
 

data/lib/canon/comparison/dimensions/element_position_dimension.rb

@@ -39,7 +39,7 @@ module Canon
         # @param pos1 [Integer] First position
         # @param pos2 [Integer] Second position
         # @return [Boolean] true if positions are equal
-        def compare_strict(pos1, pos2)
+        def compare_strict(pos1, pos2) # rubocop:disable Naming/PredicateMethod
           pos1 == pos2
         end
 

data/lib/canon/comparison/dimensions/registry.rb

@@ -67,7 +67,7 @@ module Canon
         # @param node2 [Object] Second node
         # @param behavior [Symbol] Comparison behavior
         # @return [Boolean] true if nodes match for this dimension
-        def self.compare(dimension_name, node1, node2, behavior)
+        def self.compare(dimension_name, node1, node2, behavior) # rubocop:disable Naming/PredicateMethod
           dimension = get(dimension_name)
           dimension.equivalent?(node1, node2, behavior)
         end

data/lib/canon/comparison/dimensions/structural_whitespace_dimension.rb

@@ -41,7 +41,7 @@ module Canon
         # @param ws1 [Array<String>] First whitespace array
         # @param ws2 [Array<String>] Second whitespace array
         # @return [Boolean] true if structural whitespace is exactly equal
-        def compare_strict(ws1, ws2)
+        def compare_strict(ws1, ws2) # rubocop:disable Naming/PredicateMethod
           ws1 == ws2
         end
 
@@ -52,7 +52,7 @@ module Canon
         # @param ws1 [Array<String>] First whitespace array
         # @param ws2 [Array<String>] Second whitespace array
         # @return [Boolean] true if normalized structural whitespace is equal
-        def compare_normalize(ws1, ws2)
+        def compare_normalize(ws1, ws2) # rubocop:disable Naming/PredicateMethod
           normalize_whitespace(ws1) == normalize_whitespace(ws2)
         end
 

data/lib/canon/comparison/dimensions/text_content_dimension.rb

@@ -37,7 +37,7 @@ module Canon
         # @param text1 [String, nil] First text
         # @param text2 [String, nil] Second text
         # @return [Boolean] true if texts are exactly equal
-        def compare_strict(text1, text2)
+        def compare_strict(text1, text2) # rubocop:disable Naming/PredicateMethod
           text1.to_s == text2.to_s
         end
 
@@ -49,7 +49,7 @@ module Canon
         # @param text1 [String, nil] First text
         # @param text2 [String, nil] Second text
         # @return [Boolean] true if normalized texts are equal
-        def compare_normalize(text1, text2)
+        def compare_normalize(text1, text2) # rubocop:disable Naming/PredicateMethod
           normalized1 = normalize_text(text1)
           normalized2 = normalize_text(text2)
 

data/lib/canon/comparison/format_detector.rb

@@ -52,7 +52,7 @@ module Canon
         # @return [Symbol] Format type
         def detect_string(str)
           # Use cache for format detection
-          Cache.fetch(:format_detect, Cache.key_for_format_detection(str)) do
+          Cache.fetch(:format_detect, Cache.key_for_format_detection(str)) do # rubocop:disable Lint/UselessDefaultValueArgument
             detect_string_uncached(str)
           end
         end