candy_check 0.5.0 → 0.6.0

data/spec/app_store/verification_spec.rb

@@ -1,13 +1,13 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::AppStore::Verification do
   subject { CandyCheck::AppStore::Verification.new(endpoint, data, secret) }
-  let(:endpoint) { 'https://some.endpoint' }
-  let(:data)     { 'some_data'   }
-  let(:secret)   { 'some_secret' }
+  let(:endpoint) { "https://some.endpoint" }
+  let(:data)     { "some_data"   }
+  let(:secret)   { "some_secret" }
 
-  it 'returns a verification failure for status != 0' do
-    with_mocked_response('status' => 21_000) do |client, recorded|
+  it "returns a verification failure for status != 0" do
+    with_mocked_response("status" => 21_000) do |client, recorded|
       result = subject.call!
       _(client.receipt_data).must_equal data
       _(client.secret).must_equal secret
@@ -19,7 +19,7 @@ describe CandyCheck::AppStore::Verification do
     end
   end
 
-  it 'returns a verification failure when receipt is missing' do
+  it "returns a verification failure when receipt is missing" do
     with_mocked_response({}) do |client, recorded|
       result = subject.call!
       _(client.receipt_data).must_equal data
@@ -32,20 +32,32 @@ describe CandyCheck::AppStore::Verification do
     end
   end
 
-  it 'returns a receipt when status is 0 and receipt exists' do
-    response = { 'status' => 0, 'receipt' => { 'item_id' => 'some_id' } }
+  it "returns a receipt when status is 0 and receipt exists" do
+    response = { "status" => 0, "receipt" => { "item_id" => "some_id" } }
     with_mocked_response(response) do
       result = subject.call!
       _(result).must_be_instance_of CandyCheck::AppStore::Receipt
-      _(result.item_id).must_equal('some_id')
+      _(result.item_id).must_equal("some_id")
     end
   end
 
   private
 
+  let(:dummy_client_class) do
+    Struct.new(:response) do
+      attr_reader :receipt_data, :secret
+
+      def verify(receipt_data, secret)
+        @receipt_data = receipt_data
+        @secret = secret
+        response
+      end
+    end
+  end
+
   def with_mocked_response(response)
     recorded = []
-    dummy    = DummyClient.new(response)
+    dummy    = dummy_client_class.new(response)
     stub     = proc do |*args|
       recorded << args
       dummy

data/spec/app_store/verifier_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::AppStore::Verifier do
   subject { CandyCheck::AppStore::Verifier.new(config) }
@@ -6,32 +6,32 @@ describe CandyCheck::AppStore::Verifier do
     CandyCheck::AppStore::Config.new(environment: environment)
   end
   let(:environment) { :production }
-  let(:data)     { 'some_data'   }
-  let(:secret)   { 'some_secret' }
+  let(:data)     { "some_data"   }
+  let(:secret)   { "some_secret" }
   let(:receipt)  { CandyCheck::AppStore::Receipt.new({}) }
   let(:receipt_collection) { CandyCheck::AppStore::ReceiptCollection.new({}) }
   let(:production_endpoint) do
-    'https://buy.itunes.apple.com/verifyReceipt'
+    "https://buy.itunes.apple.com/verifyReceipt"
   end
   let(:sandbox_endpoint) do
-    'https://sandbox.itunes.apple.com/verifyReceipt'
+    "https://sandbox.itunes.apple.com/verifyReceipt"
   end
 
-  it 'holds the config' do
+  it "holds the config" do
     _(subject.config).must_be_same_as config
   end
 
-  describe 'sandbox' do
+  describe "sandbox" do
     let(:environment) { :sandbox }
 
-    it 'uses sandbox endpoint without retry on success' do
+    it "uses sandbox endpoint without retry on success" do
       with_mocked_verifier(receipt) do
         _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded([sandbox_endpoint, data, secret])
       end
     end
 
-    it 'only uses sandbox endpoint for normal failures' do
+    it "only uses sandbox endpoint for normal failures" do
       failure = get_failure(21_000)
       with_mocked_verifier(failure) do
         _(subject.verify(data, secret)).must_be_same_as failure
@@ -39,29 +39,29 @@ describe CandyCheck::AppStore::Verifier do
       end
     end
 
-    it 'retries production endpoint for redirect error' do
+    it "retries production endpoint for redirect error" do
       failure = get_failure(21_008)
       with_mocked_verifier(failure, receipt) do
         _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded(
           [sandbox_endpoint, data, secret],
-          [production_endpoint, data, secret]
+          [production_endpoint, data, secret],
         )
       end
     end
   end
 
-  describe 'production' do
+  describe "production" do
     let(:environment) { :production }
 
-    it 'uses production endpoint without retry on success' do
+    it "uses production endpoint without retry on success" do
       with_mocked_verifier(receipt) do
         _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded([production_endpoint, data, secret])
       end
     end
 
-    it 'only uses production endpoint for normal failures' do
+    it "only uses production endpoint for normal failures" do
       failure = get_failure(21_000)
       with_mocked_verifier(failure) do
         _(subject.verify(data, secret)).must_be_same_as failure
@@ -69,31 +69,31 @@ describe CandyCheck::AppStore::Verifier do
       end
     end
 
-    it 'retries production endpoint for redirect error' do
+    it "retries production endpoint for redirect error" do
       failure = get_failure(21_007)
       with_mocked_verifier(failure, receipt) do
         _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded(
           [production_endpoint, data, secret],
-          [sandbox_endpoint, data, secret]
+          [sandbox_endpoint, data, secret],
         )
       end
     end
   end
 
-  describe 'subscription' do
+  describe "subscription" do
     let(:environment) { :production }
 
-    it 'uses production endpoint without retry on success' do
+    it "uses production endpoint without retry on success" do
       with_mocked_verifier(receipt_collection) do
         _(subject.verify_subscription(
-          data, secret
-        )).must_be_same_as receipt_collection
+            data, secret
+          )).must_be_same_as receipt_collection
         assert_recorded([production_endpoint, data, secret, nil])
       end
     end
 
-    it 'only uses production endpoint for normal failures' do
+    it "only uses production endpoint for normal failures" do
       failure = get_failure(21_000)
       with_mocked_verifier(failure) do
         _(subject.verify_subscription(data, secret)).must_be_same_as failure
@@ -101,23 +101,23 @@ describe CandyCheck::AppStore::Verifier do
       end
     end
 
-    it 'retries production endpoint for redirect error' do
+    it "retries production endpoint for redirect error" do
       failure = get_failure(21_007)
       with_mocked_verifier(failure, receipt) do
         _(subject.verify_subscription(data, secret)).must_be_same_as receipt
         assert_recorded(
           [production_endpoint, data, secret, nil],
-          [sandbox_endpoint, data, secret, nil]
+          [sandbox_endpoint, data, secret, nil],
         )
       end
     end
 
-    it 'passed the product_ids' do
-      product_ids = ['product_1']
+    it "passed the product_ids" do
+      product_ids = ["product_1"]
       with_mocked_verifier(receipt_collection) do
         _(subject.verify_subscription(
-          data, secret, product_ids
-        )).must_be_same_as receipt_collection
+            data, secret, product_ids
+          )).must_be_same_as receipt_collection
         assert_recorded([production_endpoint, data, secret, product_ids])
       end
     end
@@ -125,15 +125,23 @@ describe CandyCheck::AppStore::Verifier do
 
   private
 
-  def with_mocked_verifier(*results)
+  let(:dummy_verification_class) do
+    Struct.new(:endpoint, :data, :secret, :product_ids) do
+      attr_accessor :results
+
+      def call!
+        results.shift
+      end
+    end
+  end
+
+  def with_mocked_verifier(*results, &block)
     @recorded ||= []
     stub = proc do |*args|
       @recorded << args
-      DummyAppStoreVerification.new(*args).tap { |v| v.results = results }
-    end
-    CandyCheck::AppStore::Verification.stub :new, stub do
-      yield
+      dummy_verification_class.new(*args).tap { |v| v.results = results }
     end
+    CandyCheck::AppStore::Verification.stub :new, stub, &block
   end
 
   def assert_recorded(*calls)
@@ -143,20 +151,4 @@ describe CandyCheck::AppStore::Verifier do
   def get_failure(code)
     CandyCheck::AppStore::VerificationFailure.fetch(code)
   end
-
-  class DummyAppStoreVerification
-    attr_reader :endpoint, :data, :secret, :product_ids
-    attr_accessor :results
-
-    def initialize(endpoint, data, secret, product_ids = nil)
-      @endpoint = endpoint
-      @data = data
-      @secret = secret
-      @product_ids = product_ids
-    end
-
-    def call!
-      results.shift
-    end
-  end
 end

data/spec/cli/app_spec.rb

@@ -1,42 +1,40 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::CLI::App do
   subject { CandyCheck::CLI::App.new }
 
-  it 'supports the version command' do
+  it "supports the version command" do
     stub_command(CandyCheck::CLI::Commands::Version) do
       _(subject.version).must_equal :stubbed
       _(@arguments).must_be_empty
     end
   end
 
-  it 'supports the app_store command' do
+  it "supports the app_store command" do
     stub_command(CandyCheck::CLI::Commands::AppStore) do
-      _(subject.app_store('receipt')).must_equal :stubbed
-      _(@arguments).must_equal ['receipt']
+      _(subject.app_store("receipt")).must_equal :stubbed
+      _(@arguments).must_equal ["receipt"]
     end
   end
 
-  it 'supports the play_store command' do
+  it "supports the play_store command" do
     stub_command(CandyCheck::CLI::Commands::PlayStore) do
-      _(subject.play_store('package', 'id', 'token')).must_equal :stubbed
-      _(@arguments).must_equal ['package', 'id', 'token']
+      _(subject.play_store("package", "id", "token")).must_equal :stubbed
+      _(@arguments).must_equal %w(package id token)
     end
   end
 
-  it 'returns true when call .exit_on_failure?' do
+  it "returns true when call .exit_on_failure?" do
     _(CandyCheck::CLI::App.exit_on_failure?).must_equal true
   end
 
   private
 
-  def stub_command(target)
+  def stub_command(target, &block)
     stub = proc do |*args|
       @arguments = args
       :stubbed
     end
-    target.stub :run, stub do
-      yield
-    end
+    target.stub :run, stub, &block
   end
 end

data/spec/cli/commands/app_store_spec.rb

@@ -1,56 +1,55 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::CLI::Commands::AppStore do
   include WithCommand
   subject { CandyCheck::CLI::Commands::AppStore }
   let(:arguments) { [receipt, options] }
-  let(:receipt) { 'data' }
+  let(:receipt) { "data" }
   let(:options) do
     {
-      environment: :sandbox
+      environment: :sandbox,
     }
   end
+  let(:dummy_verifier_class) do
+    Struct.new(:config) do
+      attr_reader :arguments
+
+      def verify(*arguments)
+        @arguments = arguments
+        { result: :stubbed }
+      end
+    end
+  end
 
   before do
     stub = proc do |*args|
-      @verifier = DummyAppStoreVerifier.new(*args)
+      @verifier = dummy_verifier_class.new(*args)
     end
     CandyCheck::AppStore::Verifier.stub :new, stub do
       run_command!
     end
   end
 
-  describe 'default' do
-    it 'uses the receipt and the options' do
+  describe "default" do
+    it "uses the receipt and the options" do
       _(@verifier.config.environment).must_equal :sandbox
       _(@verifier.arguments).must_equal [receipt, nil]
-      _(out.lines).must_equal ['Hash:', { result: :stubbed }]
+      _(out.lines).must_equal ["Hash:", { result: :stubbed }]
     end
   end
 
-  describe 'with secret' do
+  describe "with secret" do
     let(:options) do
       {
         environment: :production,
-        secret: 'notasecret'
+        secret: "notasecret",
       }
     end
 
-    it 'uses the secret for verification' do
+    it "uses the secret for verification" do
       _(@verifier.config.environment).must_equal :production
-      _(@verifier.arguments).must_equal [receipt, 'notasecret']
-      _(out.lines).must_equal ['Hash:', { result: :stubbed }]
-    end
-  end
-
-  private
-
-  DummyAppStoreVerifier = Struct.new(:config) do
-    attr_reader :arguments
-
-    def verify(*arguments)
-      @arguments = arguments
-      { result: :stubbed }
+      _(@verifier.arguments).must_equal [receipt, "notasecret"]
+      _(out.lines).must_equal ["Hash:", { result: :stubbed }]
     end
   end
 end

data/spec/cli/commands/play_store_spec.rb

@@ -2,7 +2,9 @@ require "spec_helper"
 
 describe CandyCheck::CLI::Commands::PlayStore do
   include WithCommand
-  subject { CandyCheck::CLI::Commands::PlayStore.new(package_name, product_id, token, "json_key_file" => json_key_file) }
+  subject do
+    CandyCheck::CLI::Commands::PlayStore.new(package_name, product_id, token, "json_key_file" => json_key_file)
+  end
   let(:package_name) { "my_package_name" }
   let(:product_id) { "my_product_id" }
   let(:token) { "my_token" }

data/spec/cli/commands/version_spec.rb

@@ -1,10 +1,10 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::CLI::Commands::Version do
   include WithCommand
   subject { CandyCheck::CLI::Commands::Version }
 
-  it 'prints the gem\'s version' do
+  it "prints the gem's version" do
     run_command!
     _(out.lines).must_equal [CandyCheck::VERSION]
   end

data/spec/cli/out_spec.rb

@@ -1,34 +1,34 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::CLI::Out do
   subject { CandyCheck::CLI::Out.new(out) }
   let(:out) { StringIO.new }
 
-  it 'defaults to use STDOUT' do
+  it "defaults to use STDOUT" do
     _(CandyCheck::CLI::Out.new.out).must_be_same_as $stdout
   end
 
-  it 'holds the outlet' do
+  it "holds the outlet" do
     _(subject.out).must_be_same_as out
   end
 
-  it 'prints to outlet' do
-    subject.print 'some text'
-    subject.print 'another line'
+  it "prints to outlet" do
+    subject.print "some text"
+    subject.print "another line"
     close
     _(out.readlines).must_equal [
       "some text\n",
-      "another line\n"
+      "another line\n",
     ]
   end
 
-  it 'pretty prints to outlet' do
+  it "pretty prints to outlet" do
     subject.pretty dummy: 1
     subject.pretty [1, 2, 3]
     close
     _(out.readlines).must_equal [
       "{:dummy=>1}\n",
-      "[1, 2, 3]\n"
+      "[1, 2, 3]\n",
     ]
   end
 

data/spec/play_store/acknowledger_spec.rb

@@ -21,7 +21,9 @@ describe CandyCheck::PlayStore::Acknowledger do
       end
     end
     it "when already acknowledged" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n    \"errors\": [\n      {\n        \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"invalidPurchaseState\",\n        \"location\": \"token\",\n        \"locationType\": \"parameter\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/already_acknowledged") do
         result = subject.acknowledge_product_purchase(package_name: package_name, product_id: product_id, token: token)
@@ -33,7 +35,9 @@ describe CandyCheck::PlayStore::Acknowledger do
       end
     end
     it "when it has been refunded" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The product purchase is not owned by the user.\",\n    \"errors\": [\n      {\n        \"message\": \"The product purchase is not owned by the user.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"productNotOwnedByUser\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/refunded") do
         result = subject.acknowledge_product_purchase(package_name: package_name, product_id: product_id, token: token)

data/spec/play_store/product_acknowledgements/acknowledgement_spec.rb

@@ -27,7 +27,9 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Acknowledgement do
       end
     end
     it "when already acknowledged" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n    \"errors\": [\n      {\n        \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"invalidPurchaseState\",\n        \"location\": \"token\",\n        \"locationType\": \"parameter\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/already_acknowledged") do
         result = subject.call!
@@ -39,7 +41,9 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Acknowledgement do
       end
     end
     it "when it has been refunded" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The product purchase is not owned by the user.\",\n    \"errors\": [\n      {\n        \"message\": \"The product purchase is not owned by the user.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"productNotOwnedByUser\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/refunded") do
         result = subject.call!

data/spec/play_store/product_acknowledgements/response_spec.rb

@@ -5,23 +5,23 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Response do
     CandyCheck::PlayStore::ProductAcknowledgements::Response.new(result: result, error_data: error_data)
   end
 
-  describe '#acknowledged?' do
-    context 'when result present' do
-      let(:result) { '' }
+  describe "#acknowledged?" do
+    context "when result present" do
+      let(:result) { "" }
       let(:error_data)  { nil }
 
-      it 'returns true' do
+      it "returns true" do
         result = subject.acknowledged?
 
         _(result).must_be_true
       end
     end
 
-    context 'when result is not present' do
+    context "when result is not present" do
       let(:result) { nil }
-      let(:error_data)  { nil }
+      let(:error_data) { nil }
 
-      it 'returns false' do
+      it "returns false" do
         result = subject.acknowledged?
 
         _(result).must_be_false
@@ -29,34 +29,35 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Response do
     end
   end
 
-  describe '#error' do
-    context 'when error present' do
+  describe "#error" do
+    context "when error present" do
       let(:result) { nil }
       let(:error_data) do
         Module.new do
           def status_code
             400
           end
+
           def body
-            'A String describing the issue'
+            "A String describing the issue"
           end
           module_function :status_code, :body
         end
       end
 
-      it 'returns the expected data' do
+      it "returns the expected data" do
         result = subject.error
 
         _(result[:status_code]).must_equal(400)
-        _(result[:body]).must_equal('A String describing the issue')
+        _(result[:body]).must_equal("A String describing the issue")
       end
     end
 
-    context 'when error is not present' do
-      let(:result) { '' }
+    context "when error is not present" do
+      let(:result) { "" }
       let(:error_data)  { nil }
 
-      it 'returns false' do
+      it "returns false" do
         result = subject.error
 
         _(result).must_be_nil

data/spec/play_store/product_purchases/product_purchase_spec.rb

@@ -5,13 +5,13 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
 
   describe "valid and non-consumed product" do
     let(:fake_product_purchase) do
-      FakeProductPurchase.new(
+      OpenStruct.new(
         consumption_state: 0,
         developer_payload: "payload that gets stored and returned",
         kind: "androidpublisher#productPurchase",
         order_id: "ABC123",
         purchase_state: 0,
-        purchase_time_millis: 1421676237413,
+        purchase_time_millis: 1_421_676_237_413,
       )
     end
 
@@ -51,13 +51,13 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
 
   describe "valid and consumed product" do
     let(:fake_product_purchase) do
-      FakeProductPurchase.new(
+      OpenStruct.new(
         consumption_state: 1,
         developer_payload: "payload that gets stored and returned",
         kind: "androidpublisher#productPurchase",
         order_id: "ABC123",
         purchase_state: 0,
-        purchase_time_millis: 1421676237413,
+        purchase_time_millis: 1_421_676_237_413,
       )
     end
 
@@ -72,13 +72,13 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
 
   describe "non-valid product" do
     let(:fake_product_purchase) do
-      FakeProductPurchase.new(
+      OpenStruct.new(
         consumption_state: 0,
         developer_payload: "payload that gets stored and returned",
         kind: "androidpublisher#productPurchase",
         order_id: "ABC123",
         purchase_state: 1,
-        purchase_time_millis: 1421676237413,
+        purchase_time_millis: 1_421_676_237_413,
       )
     end
 
@@ -86,25 +86,4 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
       _(subject.valid?).must_be_false
     end
   end
-
-  private
-
-  class FakeProductPurchase
-    FIELDS = [
-      :consumption_state,
-      :developer_payload,
-      :kind,
-      :order_id,
-      :purchase_state,
-      :purchase_time_millis,
-    ].freeze
-
-    attr_accessor(*FIELDS)
-
-    def initialize(hash)
-      FIELDS.each do |key|
-        self.public_send("#{key}=", hash[key])
-      end
-    end
-  end
 end