candy_check 0.1.1 → 0.4.0

data/spec/app_store/receipt_collection_spec.rb

@@ -8,64 +8,91 @@ describe CandyCheck::AppStore::ReceiptCollection do
       [{
         'expires_date' => '2014-04-15 12:52:40 Etc/GMT',
         'expires_date_pst' => '2014-04-15 05:52:40 America/Los_Angeles',
+        'purchase_date' => '2014-04-14 12:52:40 Etc/GMT',
         'is_trial_period' => 'false'
       }, {
         'expires_date' => '2015-04-15 12:52:40 Etc/GMT',
         'expires_date_pst' => '2015-04-15 05:52:40 America/Los_Angeles',
+        'purchase_date' => '2015-04-14 12:52:40 Etc/GMT',
         'is_trial_period' => 'false'
       }]
     end
 
     it 'is expired' do
-      subject.expired?.must_be_true
+      _(subject.expired?).must_be_true
     end
 
     it 'is not a trial' do
-      subject.trial?.must_be_false
+      _(subject.trial?).must_be_false
     end
 
     it 'has positive overdue days' do
       overdue = subject.overdue_days
-      overdue.must_be_instance_of Fixnum
+      _(overdue).must_be_instance_of Fixnum
       assert overdue > 0
     end
 
     it 'has a last expires date' do
       expected = DateTime.new(2015, 4, 15, 12, 52, 40)
-      subject.expires_at.must_equal expected
+      _(subject.expires_at).must_equal expected
     end
 
     it 'is expired? at same pointin time' do
       Timecop.freeze(Time.utc(2015, 4, 15, 12, 52, 40)) do
-        subject.expired?.must_be_true
+        _(subject.expired?).must_be_true
       end
     end
   end
 
+  describe 'unordered receipts' do
+    let(:attributes) do
+      [{
+           'expires_date' => '2015-04-15 12:52:40 Etc/GMT',
+           'expires_date_pst' => '2015-04-15 05:52:40 America/Los_Angeles',
+           'purchase_date' => '2015-04-14 12:52:40 Etc/GMT',
+           'is_trial_period' => 'false'
+       }, {
+           'expires_date' => '2014-04-15 12:52:40 Etc/GMT',
+           'expires_date_pst' => '2014-04-15 05:52:40 America/Los_Angeles',
+           'purchase_date' => '2014-04-14 12:52:40 Etc/GMT',
+           'is_trial_period' => 'false'
+       }]
+    end
+
+    it 'the expires date is the latest one in time' do
+      expected = DateTime.new(2015, 4, 15, 12, 52, 40)
+      _(subject.expires_at).must_equal expected
+    end
+
+  end
+
   describe 'unexpired trial subscription' do
     two_days_from_now = DateTime.now + 2
 
     let(:attributes) do
       [{
         'expires_date' => '2016-04-15 12:52:40 Etc/GMT',
+        'purchase_date' => '2016-04-15 12:52:40 Etc/GMT',
         'is_trial_period' => 'true'
       }, {
         'expires_date' =>
           two_days_from_now.strftime('%Y-%m-%d %H:%M:%S Etc/GMT'),
+        'purchase_date' => '2016-04-15 12:52:40 Etc/GMT',
         'is_trial_period' => 'true'
       }]
     end
 
     it 'has not expired' do
-      subject.expired?.must_be_false
+      _(subject.expired?).must_be_false
     end
 
     it 'it is a trial' do
-      subject.trial?.must_be_true
+      _(subject.trial?).must_be_true
     end
 
     it 'expires in two days' do
-      subject.overdue_days.must_equal(-2)
+      _(subject.overdue_days).must_equal(-2)
     end
   end
+
 end

data/spec/app_store/receipt_spec.rb

@@ -31,62 +31,62 @@ describe CandyCheck::AppStore::Receipt do
 
   describe 'valid transaction' do
     it 'is valid' do
-      subject.valid?.must_be_true
+      _(subject.valid?).must_be_true
     end
 
     it 'returns the item\'s id' do
-      subject.item_id.must_equal 'some_item_id'
+      _(subject.item_id).must_equal 'some_item_id'
     end
 
     it 'returns the item\'s product_id' do
-      subject.product_id.must_equal 'some_product'
+      _(subject.product_id).must_equal 'some_product'
     end
 
     it 'returns the quantity' do
-      subject.quantity.must_equal 1
+      _(subject.quantity).must_equal 1
     end
 
     it 'returns the app version' do
-      subject.app_version.must_equal '2.0'
+      _(subject.app_version).must_equal '2.0'
     end
 
     it 'returns the bundle identifier' do
-      subject.bundle_identifier.must_equal 'some.test.app'
+      _(subject.bundle_identifier).must_equal 'some.test.app'
     end
 
     it 'returns the purchase date' do
       expected = DateTime.new(2015, 1, 9, 11, 40, 46)
-      subject.purchase_date.must_equal expected
+      _(subject.purchase_date).must_equal expected
     end
 
     it 'returns the original purchase date' do
       expected = DateTime.new(2015, 1, 8, 11, 40, 46)
-      subject.original_purchase_date.must_equal expected
+      _(subject.original_purchase_date).must_equal expected
     end
 
     it 'returns the transaction id' do
-      subject.transaction_id.must_equal 'some_transaction_id'
+      _(subject.transaction_id).must_equal 'some_transaction_id'
     end
 
     it 'returns the original transaction id' do
-      subject.original_transaction_id.must_equal 'some_original_transaction_id'
+      _(subject.original_transaction_id).must_equal 'some_original_transaction_id'
     end
 
     it 'return nil for cancellation date' do
-      subject.cancellation_date.must_be_nil
+      _(subject.cancellation_date).must_be_nil
     end
 
     it 'returns raw attributes' do
-      subject.attributes.must_be_same_as attributes
+      _(subject.attributes).must_be_same_as attributes
     end
 
     it 'returns the subscription expiration date' do
       expected = DateTime.new(2016, 6, 9, 13, 59, 40)
-      subject.expires_date.must_equal expected
+      _(subject.expires_date).must_equal expected
     end
 
     it 'returns the trial status' do
-      subject.is_trial_period.must_be_false
+      _(subject.is_trial_period).must_be_false
     end
   end
 
@@ -96,12 +96,12 @@ describe CandyCheck::AppStore::Receipt do
     end
 
     it 'isn\'t valid' do
-      subject.valid?.must_be_false
+      _(subject.valid?).must_be_false
     end
 
     it 'return nil for cancellation date' do
       expected = DateTime.new(2015, 1, 12, 11, 40, 46)
-      subject.cancellation_date.must_equal expected
+      _(subject.cancellation_date).must_equal expected
     end
   end
 end

data/spec/app_store/subscription_verification_spec.rb

@@ -11,26 +11,26 @@ describe CandyCheck::AppStore::SubscriptionVerification do
   it 'returns a verification failure for status != 0' do
     with_mocked_response('status' => 21_000) do |client, recorded|
       result = subject.call!
-      client.receipt_data.must_equal data
-      client.secret.must_equal secret
+      _(client.receipt_data).must_equal data
+      _(client.secret).must_equal secret
 
-      recorded.first.must_equal [endpoint]
+      _(recorded.first).must_equal [endpoint]
 
-      result.must_be_instance_of CandyCheck::AppStore::VerificationFailure
-      result.code.must_equal 21_000
+      _(result).must_be_instance_of CandyCheck::AppStore::VerificationFailure
+      _(result.code).must_equal 21_000
     end
   end
 
   it 'returns a verification failure when receipt is missing' do
     with_mocked_response({}) do |client, recorded|
       result = subject.call!
-      client.receipt_data.must_equal data
-      client.secret.must_equal secret
+      _(client.receipt_data).must_equal data
+      _(client.secret).must_equal secret
 
-      recorded.first.must_equal [endpoint]
+      _(recorded.first).must_equal [endpoint]
 
-      result.must_be_instance_of CandyCheck::AppStore::VerificationFailure
-      result.code.must_equal(-1)
+      _(result).must_be_instance_of CandyCheck::AppStore::VerificationFailure
+      _(result.code).must_equal(-1)
     end
   end
 
@@ -38,17 +38,50 @@ describe CandyCheck::AppStore::SubscriptionVerification do
     response = {
       'status' => 0,
       'latest_receipt_info' => [
-        { 'item_id' => 'some_id' },
-        { 'item_id' => 'some_other_id' }
+        { 'item_id' => 'some_id', 'purchase_date' => '2016-04-15 12:52:40 Etc/GMT' },
+        { 'item_id' => 'some_other_id', 'purchase_date' => '2016-04-15 12:52:40 Etc/GMT' }
       ]
     }
     with_mocked_response(response) do
       result = subject.call!
-      result.must_be_instance_of CandyCheck::AppStore::ReceiptCollection
-      result.receipts.must_be_instance_of Array
+      _(result).must_be_instance_of CandyCheck::AppStore::ReceiptCollection
+      _(result.receipts).must_be_instance_of Array
+      _(result.receipts.size).must_equal(2)
       last = result.receipts.last
-      last.must_be_instance_of CandyCheck::AppStore::Receipt
-      last.item_id.must_equal('some_other_id')
+      _(last).must_be_instance_of CandyCheck::AppStore::Receipt
+      _(last.item_id).must_equal('some_other_id')
+    end
+  end
+
+  describe 'filtered product_ids' do
+    subject do
+      CandyCheck::AppStore::SubscriptionVerification.new(
+        endpoint,
+        data,
+        secret,
+        product_ids
+      )
+    end
+    let(:product_ids) { ['product_1'] }
+
+    it 'returns only filtered reciepts when specifc product_ids are reqested' do
+      response = {
+        'status' => 0,
+        'latest_receipt_info' => [
+          { 'item_id' => 'some_id', 'product_id' => 'product_1', 'purchase_date' => '2016-04-15 12:52:40 Etc/GMT' },
+          { 'item_id' => 'some_other_id', 'product_id' => 'product_1', 'purchase_date' => '2016-04-15 12:52:40 Etc/GMT' },
+          { 'item_id' => 'some_id', 'product_id' => 'product_2', 'purchase_date' => '2016-04-15 12:52:40 Etc/GMT' }
+        ]
+      }
+      with_mocked_response(response) do
+        result = subject.call!
+        _(result).must_be_instance_of CandyCheck::AppStore::ReceiptCollection
+        _(result.receipts).must_be_instance_of Array
+        _(result.receipts.size).must_equal(2)
+        last = result.receipts.last
+        _(last).must_be_instance_of CandyCheck::AppStore::Receipt
+        _(last.item_id).must_equal('some_other_id')
+      end
     end
   end
 

data/spec/app_store/verifcation_failure_spec.rb

@@ -9,20 +9,20 @@ describe CandyCheck::AppStore::VerificationFailure do
   it 'fetched an failure with message for every known code' do
     known.each do |code|
       got = subject.fetch(code)
-      got.code.must_equal code
-      got.message.wont_equal 'Unknown error'
+      _(got.code).must_equal code
+      _(got.message).wont_equal 'Unknown error'
     end
   end
 
   it 'fetched an failure for unknown codes' do
     got = subject.fetch(1234)
-    got.code.must_equal 1234
-    got.message.must_equal 'Unknown error'
+    _(got.code).must_equal 1234
+    _(got.message).must_equal 'Unknown error'
   end
 
   it 'fetched an failure for nil code' do
     got = subject.fetch(nil)
-    got.code.must_equal(-1)
-    got.message.must_equal 'Unknown error'
+    _(got.code).must_equal(-1)
+    _(got.message).must_equal 'Unknown error'
   end
 end

data/spec/app_store/verification_spec.rb

@@ -9,26 +9,26 @@ describe CandyCheck::AppStore::Verification do
   it 'returns a verification failure for status != 0' do
     with_mocked_response('status' => 21_000) do |client, recorded|
       result = subject.call!
-      client.receipt_data.must_equal data
-      client.secret.must_equal secret
+      _(client.receipt_data).must_equal data
+      _(client.secret).must_equal secret
 
-      recorded.first.must_equal [endpoint]
+      _(recorded.first).must_equal [endpoint]
 
-      result.must_be_instance_of CandyCheck::AppStore::VerificationFailure
-      result.code.must_equal 21_000
+      _(result).must_be_instance_of CandyCheck::AppStore::VerificationFailure
+      _(result.code).must_equal 21_000
     end
   end
 
   it 'returns a verification failure when receipt is missing' do
     with_mocked_response({}) do |client, recorded|
       result = subject.call!
-      client.receipt_data.must_equal data
-      client.secret.must_equal secret
+      _(client.receipt_data).must_equal data
+      _(client.secret).must_equal secret
 
-      recorded.first.must_equal [endpoint]
+      _(recorded.first).must_equal [endpoint]
 
-      result.must_be_instance_of CandyCheck::AppStore::VerificationFailure
-      result.code.must_equal(-1)
+      _(result).must_be_instance_of CandyCheck::AppStore::VerificationFailure
+      _(result.code).must_equal(-1)
     end
   end
 
@@ -36,8 +36,8 @@ describe CandyCheck::AppStore::Verification do
     response = { 'status' => 0, 'receipt' => { 'item_id' => 'some_id' } }
     with_mocked_response(response) do
       result = subject.call!
-      result.must_be_instance_of CandyCheck::AppStore::Receipt
-      result.item_id.must_equal('some_id')
+      _(result).must_be_instance_of CandyCheck::AppStore::Receipt
+      _(result.item_id).must_equal('some_id')
     end
   end
 

data/spec/app_store/verifier_spec.rb

@@ -18,7 +18,7 @@ describe CandyCheck::AppStore::Verifier do
   end
 
   it 'holds the config' do
-    subject.config.must_be_same_as config
+    _(subject.config).must_be_same_as config
   end
 
   describe 'sandbox' do
@@ -26,7 +26,7 @@ describe CandyCheck::AppStore::Verifier do
 
     it 'uses sandbox endpoint without retry on success' do
       with_mocked_verifier(receipt) do
-        subject.verify(data, secret).must_be_same_as receipt
+        _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded([sandbox_endpoint, data, secret])
       end
     end
@@ -34,7 +34,7 @@ describe CandyCheck::AppStore::Verifier do
     it 'only uses sandbox endpoint for normal failures' do
       failure = get_failure(21_000)
       with_mocked_verifier(failure) do
-        subject.verify(data, secret).must_be_same_as failure
+        _(subject.verify(data, secret)).must_be_same_as failure
         assert_recorded([sandbox_endpoint, data, secret])
       end
     end
@@ -42,7 +42,7 @@ describe CandyCheck::AppStore::Verifier do
     it 'retries production endpoint for redirect error' do
       failure = get_failure(21_008)
       with_mocked_verifier(failure, receipt) do
-        subject.verify(data, secret).must_be_same_as receipt
+        _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded(
           [sandbox_endpoint, data, secret],
           [production_endpoint, data, secret]
@@ -56,7 +56,7 @@ describe CandyCheck::AppStore::Verifier do
 
     it 'uses production endpoint without retry on success' do
       with_mocked_verifier(receipt) do
-        subject.verify(data, secret).must_be_same_as receipt
+        _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded([production_endpoint, data, secret])
       end
     end
@@ -64,7 +64,7 @@ describe CandyCheck::AppStore::Verifier do
     it 'only uses production endpoint for normal failures' do
       failure = get_failure(21_000)
       with_mocked_verifier(failure) do
-        subject.verify(data, secret).must_be_same_as failure
+        _(subject.verify(data, secret)).must_be_same_as failure
         assert_recorded([production_endpoint, data, secret])
       end
     end
@@ -72,7 +72,7 @@ describe CandyCheck::AppStore::Verifier do
     it 'retries production endpoint for redirect error' do
       failure = get_failure(21_007)
       with_mocked_verifier(failure, receipt) do
-        subject.verify(data, secret).must_be_same_as receipt
+        _(subject.verify(data, secret)).must_be_same_as receipt
         assert_recorded(
           [production_endpoint, data, secret],
           [sandbox_endpoint, data, secret]
@@ -86,31 +86,41 @@ describe CandyCheck::AppStore::Verifier do
 
     it 'uses production endpoint without retry on success' do
       with_mocked_verifier(receipt_collection) do
-        subject.verify_subscription(
+        _(subject.verify_subscription(
           data, secret
-        ).must_be_same_as receipt_collection
-        assert_recorded([production_endpoint, data, secret])
+        )).must_be_same_as receipt_collection
+        assert_recorded([production_endpoint, data, secret, nil])
       end
     end
 
     it 'only uses production endpoint for normal failures' do
       failure = get_failure(21_000)
       with_mocked_verifier(failure) do
-        subject.verify_subscription(data, secret).must_be_same_as failure
-        assert_recorded([production_endpoint, data, secret])
+        _(subject.verify_subscription(data, secret)).must_be_same_as failure
+        assert_recorded([production_endpoint, data, secret, nil])
       end
     end
 
     it 'retries production endpoint for redirect error' do
       failure = get_failure(21_007)
       with_mocked_verifier(failure, receipt) do
-        subject.verify_subscription(data, secret).must_be_same_as receipt
+        _(subject.verify_subscription(data, secret)).must_be_same_as receipt
         assert_recorded(
-          [production_endpoint, data, secret],
-          [sandbox_endpoint, data, secret]
+          [production_endpoint, data, secret, nil],
+          [sandbox_endpoint, data, secret, nil]
         )
       end
     end
+
+    it 'passed the product_ids' do
+      product_ids = ['product_1']
+      with_mocked_verifier(receipt_collection) do
+        _(subject.verify_subscription(
+          data, secret, product_ids
+        )).must_be_same_as receipt_collection
+        assert_recorded([production_endpoint, data, secret, product_ids])
+      end
+    end
   end
 
   private
@@ -127,15 +137,24 @@ describe CandyCheck::AppStore::Verifier do
   end
 
   def assert_recorded(*calls)
-    @recorded.must_equal calls
+    _(@recorded).must_equal calls
   end
 
   def get_failure(code)
     CandyCheck::AppStore::VerificationFailure.fetch(code)
   end
 
-  DummyAppStoreVerification = Struct.new(:endpoint, :data, :secret) do
+  class DummyAppStoreVerification
+    attr_reader :endpoint, :data, :secret, :product_ids
     attr_accessor :results
+
+    def initialize(endpoint, data, secret, product_ids = nil)
+      @endpoint = endpoint
+      @data = data
+      @secret = secret
+      @product_ids = product_ids
+    end
+
     def call!
       results.shift
     end