candy_check 0.0.3 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 969308635b85f978891e85242d9c541ce65134e7
-  data.tar.gz: 7b2a51f891d620be0980e38a680cf3afb339989a
+  metadata.gz: 414f845cc6a6fa6a27f814866675412925ed8a85
+  data.tar.gz: a2699ef81d97d170e964bf08bcbd5949284f00ac
 SHA512:
-  metadata.gz: ab94b279bcdc25ad5743bc626948a5a9f74a8dba47d5645ba9f0b71ff1764de46ab48a4e0183e167c08386969407264b02466d8020c155f8c320f9da438f2b42
-  data.tar.gz: 6480da7126d6796de02df876612813bfbd42e65a893186adebefcda54342263703265948779f576a527360172e3d7a5c4545d21df15c4d37a2bc4f0b43c09a2e
+  metadata.gz: 9449d7d55b94fa560d8be6bdc2f1d082287e78561f6c935d4a2ca3836759ddd0ac3d6385052624436257c21f889e4e5bd087d48b57fe4b6736fd580b554d496d
+  data.tar.gz: 15579d8441886b67bcb4d28a9c9404cc836e553821e4d9c46e8dfec8090fb929b5d6ac1baa7fc5c58c396869a79840143400b1bb632d32f4c016b4cd00b1dfcc

data/.rubocop.yml

@@ -2,5 +2,6 @@ AllCops:
   Exclude:
     - 'spec/support/*'
     - 'bin/*'
+    - 'vendor/*'
 Style/Documentation:
   Enabled: false

data/.travis.yml

@@ -1,16 +1,17 @@
 language: ruby
 sudo: false
+cache: bundler
 rvm:
   - '2.2'
   - '2.1'
   - '2.0'
-  - '1.9.3'
   - ruby-head
   - rbx-2
-  - jruby-19mode
+  - jruby-20mode
+  - jruby-21mode
   - jruby-head
 matrix:
   allow_failures:
     - rvm: ruby-head
     - rvm: jruby-head
-  fast_finish: true
+  fast_finish: true

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2015 Jonas Thiel
+Copyright (c) 2016 Jonas Thiel
 
 MIT License
 
@@ -19,4 +19,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -155,4 +155,4 @@ rake
 
 ## Copyright
 
-Copyright © 2015 Jonas Thiel. See LICENSE.txt for details.
+Copyright © 2016 Jonas Thiel. See LICENSE.txt for details.

data/candy_check.gemspec

@@ -13,12 +13,14 @@ Gem::Specification.new do |spec|
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(/^(test|spec|features)\//)
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.0')
+
   spec.add_dependency 'multi_json',        '~> 1.10'
-  spec.add_dependency 'google-api-client', '~> 0.8'
+  spec.add_dependency 'google-api-client', '~> 0.8.6'
   spec.add_dependency 'thor',              '~> 0.19'
 
   spec.add_development_dependency 'rubocop',         '~> 0.28'

data/lib/candy_check/app_store/client.rb

@@ -1,4 +1,5 @@
 require 'multi_json'
+require 'net/http'
 
 module CandyCheck
   module AppStore
@@ -6,7 +7,7 @@ module CandyCheck
     # servers (either sandbox or production).
     class Client
       # Mimetype for JSON objects
-      JSON_MIME_TYPE = 'application/json'
+      JSON_MIME_TYPE = 'application/json'.freeze
 
       # Initialize a new client bound to an endpoint
       # @param endpoint_url [String]
@@ -32,7 +33,7 @@ module CandyCheck
 
       def build_http_connector
         Net::HTTP.new(@uri.host, @uri.port).tap do |net|
-          net.use_ssl      = true
+          net.use_ssl = true
           net.verify_mode = OpenSSL::SSL::VERIFY_PEER
         end
       end

data/lib/candy_check/app_store/verification.rb

@@ -18,7 +18,8 @@ module CandyCheck
       # @param receipt_data [String] the raw data to be verified
       # @param secret [String] the optional shared secret
       def initialize(endpoint_url, receipt_data, secret = nil)
-        @endpoint_url, @receipt_data = endpoint_url, receipt_data
+        @endpoint_url = endpoint_url
+        @receipt_data = receipt_data
         @secret = secret
       end
 

data/lib/candy_check/app_store/verification_failure.rb

@@ -1,11 +1,21 @@
 module CandyCheck
   module AppStore
     # Represents a failing call against the verification server
-    class VerificationFailure < Struct.new(:code, :message)
-      # @!attribute code
-      #   @return [Fixnum] the code of the failure
-      # @!attribute message
-      #   @return [String] the message of the failure
+    class VerificationFailure
+      # @return [Fixnum] the code of the failure
+      attr_reader :code
+
+      # @return [String] the message of the failure
+      attr_reader :message
+
+      # Initializes a new instance which bases on a JSON result
+      # from Apple servers
+      # @param code [Fixnum]
+      # @param message [String]
+      def initialize(code, message)
+        @code = code
+        @message = message
+      end
 
       class << self
         # Gets a known failure or build an unknown failure

data/lib/candy_check/app_store/verifier.rb

@@ -4,9 +4,9 @@ module CandyCheck
     # The call return either an {Receipt} or a {VerificationFailure}
     class Verifier
       # HTTPS endpoint for production receipts
-      PRODUCTION_ENDPOINT = 'https://buy.itunes.apple.com/verifyReceipt'
+      PRODUCTION_ENDPOINT = 'https://buy.itunes.apple.com/verifyReceipt'.freeze
       # HTTPS endpoint for sandbox receipts
-      SANDBOX_ENDPOINT = 'https://sandbox.itunes.apple.com/verifyReceipt'
+      SANDBOX_ENDPOINT = 'https://sandbox.itunes.apple.com/verifyReceipt'.freeze
       # Status code from production endpoint when receiving a sandbox
       # receipt which occurs during the app's review process
       REDIRECT_TO_SANDBOX_CODE = 21_007
@@ -57,8 +57,11 @@ module CandyCheck
       end
 
       def redirect_code
-        config.production? ? REDIRECT_TO_SANDBOX_CODE :
-                             REDIRECT_TO_PRODUCTION_CODE
+        if config.production?
+          REDIRECT_TO_SANDBOX_CODE
+        else
+          REDIRECT_TO_PRODUCTION_CODE
+        end
       end
 
       def redirect?(failure)

data/lib/candy_check/cli/app.rb

@@ -4,7 +4,7 @@ module CandyCheck
   module CLI
     # Main class for the executable 'candy_check'
     # @example
-    #   $ candy_check help
+    #   $> candy_check help
     class App < Thor
       package_name 'CandyCheck'
 

data/lib/candy_check/cli/commands/play_store.rb

@@ -14,7 +14,9 @@ module CandyCheck
         # @option options [String] :application_name for the API call
         # @option options [String] :application_version for the API call
         def initialize(package, product_id, token, options)
-          @package, @product_id, @token = package, product_id, token
+          @package = package
+          @product_id = product_id
+          @token = token
           super(options)
         end
 

data/lib/candy_check/play_store/client.rb

@@ -15,13 +15,13 @@ module CandyCheck
       class DiscoveryError < RuntimeError; end
 
       # API endpoint
-      API_URL      = 'https://accounts.google.com/o/oauth2/token'
+      API_URL      = 'https://accounts.google.com/o/oauth2/token'.freeze
       # API scope for Android services
-      API_SCOPE    = 'https://www.googleapis.com/auth/androidpublisher'
+      API_SCOPE    = 'https://www.googleapis.com/auth/androidpublisher'.freeze
       # API discovery namespace
-      API_DISCOVER = 'androidpublisher'
+      API_DISCOVER = 'androidpublisher'.freeze
       # API version
-      API_VERSION  = 'v2'
+      API_VERSION  = 'v2'.freeze
 
       # Initializes a client using a configuration.
       # @param config [ClientConfig]
@@ -85,7 +85,7 @@ module CandyCheck
 
       def validate_rpc!
         return if rpc.purchases.products.get
-        fail DiscoveryError, 'Unable to get the API discovery'
+        raise DiscoveryError, 'Unable to get the API discovery'
       rescue NoMethodError
         raise DiscoveryError, 'Unable to get the API discovery'
       end

data/lib/candy_check/play_store/verification.rb

@@ -17,7 +17,9 @@ module CandyCheck
       # @param token [String]
       def initialize(client, package, product_id, token)
         @client = client
-        @package, @product_id, @token = package, product_id, token
+        @package = package
+        @product_id = product_id
+        @token = token
       end
 
       # Performs the verification against the remote server

data/lib/candy_check/play_store/verifier.rb

@@ -45,7 +45,7 @@ module CandyCheck
       end
 
       def boot_error(message)
-        fail BootRequiredError, message
+        raise BootRequiredError, message
       end
     end
   end

data/lib/candy_check/utils/config.rb

@@ -24,7 +24,7 @@ module CandyCheck
       # @raise [ArgumentError] if attribute is missing
       def validates_presence(name)
         return if send(name)
-        fail ArgumentError, "Configuration field #{name} is missing"
+        raise ArgumentError, "Configuration field #{name} is missing"
       end
 
       # Checks for the inclusion of an attribute
@@ -32,7 +32,7 @@ module CandyCheck
       # @param values [Array] of possible values
       def validates_inclusion(name, *values)
         return if values.include?(send(name))
-        fail ArgumentError, "Configuration field #{name} should be "\
+        raise ArgumentError, "Configuration field #{name} should be "\
                             "one of: #{values.join(', ')}"
       end
     end

data/lib/candy_check/version.rb

@@ -1,4 +1,4 @@
 module CandyCheck
   # The current gem's version
-  VERSION = '0.0.3'
+  VERSION = '0.0.5'.freeze
 end

data/spec/app_store/client_spec.rb

@@ -9,7 +9,20 @@ describe CandyCheck::AppStore::Client do
     'some_secret_password'
   end
   let(:response) do
-    '{"status": 0}'
+    '{
+    "receipt": {
+        "item_id": "521129812"
+    },
+    "status": 0
+}'
+  end
+  let(:expected) do
+    {
+      'status' => 0,
+      'receipt' => {
+        'item_id' => '521129812'
+      }
+    }
   end
 
   subject { CandyCheck::AppStore::Client.new(endpoint_url) }
@@ -25,8 +38,7 @@ describe CandyCheck::AppStore::Client do
         .to_return(
           body: response
         )
-      result   = subject.verify(receipt_data)
-      expected = { 'status' => 0 }
+      result = subject.verify(receipt_data)
       result.must_equal expected
     end
 
@@ -41,8 +53,7 @@ describe CandyCheck::AppStore::Client do
         .to_return(
           body: response
         )
-      result   = subject.verify(receipt_data, password)
-      expected = { 'status' => 0 }
+      result = subject.verify(receipt_data, password)
       result.must_equal expected
     end
   end

data/spec/app_store/verification_spec.rb

@@ -43,11 +43,12 @@ describe CandyCheck::AppStore::Verification do
 
   private
 
-  class DummyClient < Struct.new(:response)
+  DummyClient = Struct.new(:response) do
     attr_reader :receipt_data, :secret
 
     def verify(receipt_data, secret)
-      @receipt_data, @secret = receipt_data, secret
+      @receipt_data = receipt_data
+      @secret = secret
       response
     end
   end
@@ -56,7 +57,7 @@ describe CandyCheck::AppStore::Verification do
     recorded = []
     dummy    = DummyClient.new(response)
     stub     = proc do |*args|
-      recorded <<  args
+      recorded << args
       dummy
     end
     CandyCheck::AppStore::Client.stub :new, stub do

data/spec/app_store/verifier_spec.rb

@@ -101,7 +101,7 @@ describe CandyCheck::AppStore::Verifier do
     CandyCheck::AppStore::VerificationFailure.fetch(code)
   end
 
-  class DummyAppStoreVerification < Struct.new(:endpoint, :data, :secret)
+  DummyAppStoreVerification = Struct.new(:endpoint, :data, :secret) do
     attr_accessor :results
     def call!
       results.shift

data/spec/cli/commands/app_store_spec.rb

@@ -45,7 +45,7 @@ describe CandyCheck::CLI::Commands::AppStore do
 
   private
 
-  class DummyAppStoreVerifier < Struct.new(:config)
+  DummyAppStoreVerifier = Struct.new(:config) do
     attr_reader :arguments
 
     def verify(*arguments)

data/spec/cli/commands/play_store_spec.rb

@@ -36,7 +36,7 @@ describe CandyCheck::CLI::Commands::PlayStore do
 
   private
 
-  class DummyPlayStoreVerifier < Struct.new(:config)
+  DummyPlayStoreVerifier = Struct.new(:config) do
     attr_reader :arguments, :booted
 
     def boot!

data/spec/play_store/client_spec.rb

@@ -72,7 +72,7 @@ describe CandyCheck::PlayStore::Client do
     result['purchaseState'].must_equal 0
     result['consumptionState'].must_equal 0
     result['developerPayload'].must_equal \
-     'payload that gets stored and returned'
+      'payload that gets stored and returned'
     result['purchaseTimeMillis'].must_equal '1421676237413'
     result['kind'].must_equal 'androidpublisher#productPurchase'
   end

data/spec/play_store/verification_spec.rb

@@ -66,14 +66,16 @@ describe CandyCheck::PlayStore::Verification do
 
   private
 
-  class DummyGoogleClient < Struct.new(:response)
+  DummyGoogleClient = Struct.new(:response) do
     attr_reader :package, :product_id, :token
 
     def boot!
     end
 
     def verify(package, product_id, token)
-      @package, @product_id, @token = package, product_id, token
+      @package = package
+      @product_id = product_id
+      @token = token
       response
     end
   end

data/spec/play_store/verifier_spec.rb

@@ -78,15 +78,15 @@ describe CandyCheck::PlayStore::Verifier do
     @recorded.must_equal calls
   end
 
-  class DummyPlayStoreVerification < Struct.new(:client, :package,
-                                                :product_id, :token)
+  DummyPlayStoreVerification = Struct.new(:client, :package,
+                                          :product_id, :token) do
     attr_accessor :results
     def call!
       results.shift
     end
   end
 
-  class DummyPlayStoreClient < Struct.new(:config)
+  DummyPlayStoreClient = Struct.new(:config) do
     attr_reader :booted
     def boot!
       @booted = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: candy_check
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - Jonas Thiel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-27 00:00:00.000000000 Z
+date: 2016-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.8.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.8.6
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -254,7 +254,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -262,7 +262,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Check and verify in-app receipts