cancan_strong_parameters 0.2.4 → 0.3

data/README.md

@@ -58,6 +58,20 @@ Or install it yourself as:
       attr_accessible :title, :body, :tags_attributes
    end
    ```
+
+## Checkboxes
+
+_Credit: @jlee42_
+
+With 0.3, `cancan_strong_parameters` now supports checkboxes in forms, like `tag_ids`.
+
+In order to avoid confusion with other nested attributes in a call to `permit_params`, please use the actual `Array` class object:
+
+```ruby
+class BlogPost < ActiveModel::Base
+  permit_params :title, :content, tag_ids: Array
+end
+```
         
 ## Testing
 

data/cancan_strong_parameters.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |gem|
   gem.homepage      = "https://github.com/colinyoung/cancan_strong_parameters"
   
   gem.add_dependency "cancan"
-  gem.add_dependency "strong_parameters"
+  gem.add_dependency "strong_parameters", ">= 0.1.6"
   gem.add_dependency "activesupport"
   
   gem.add_development_dependency "require_all"

data/lib/cancan_strong_parameters/controller.rb

@@ -77,17 +77,11 @@ module CancanStrongParameters
           
           defaults = CancanStrongParameters::Controller::HASH_DEFAULTS
           
-          # @todo We have to stringify everything for 1.8.7 due to a bug in `strong_parameters`.
-          # More at https://github.com/rails/strong_parameters/pull/51
-          hash = hash.attributized.stringified
-          
           prepend_before_filter(filter_options) do
             resource_name = self.class.resource_name
             
-            # @todo We have to stringify everything for 1.8.7 due to a bug in `strong_parameters`.
-            # More at https://github.com/rails/strong_parameters/pull/51
-            parameters = keys.flatten.map! {|k| k.to_s } + defaults
-            parameters << ActionController::Parameters.new(hash)
+            parameters = keys.flatten + defaults
+            parameters << ActionController::Parameters.new(hash.attributized)
             
             # original: parameters = keys.flatten + defaults
             #           parameters << hash
@@ -103,9 +97,9 @@ module CancanStrongParameters
           prepend_before_filter(filter_options) do
             resource_name = self.class.resource_name
             if params.has_key?(resource_name)
-              self.params[resource_name] = params[resource_name].send method, *keys.stringified
+              self.params[resource_name] = params[resource_name].send method, *keys
             else
-              self.params = params.send method, *keys.stringified
+              self.params = params.send method, *keys
             end
           end
         end
@@ -146,7 +140,11 @@ class Hash
     
     Hash.new.tap do |h|
       self.each do |k,v|
-        h[:"#{k}_attributes"] = self[k].attributized + defaults
+        if v.respond_to? :attributized
+          h[:"#{k}_attributes"] = v.attributized + defaults
+        else
+          h[k] = v == Array ? [] : v
+        end
       end
     end
   end
@@ -208,38 +206,3 @@ class String
     !!(self =~ /^[0-9a-f]+$/)
   end
 end
-
-# @todo Can be remove when new version of `strong_parameters` (>=0.1.5) is released.
-class Hash
-  def stringified
-    Hash.new.tap do |h|
-      each do |key, value|
-        value = case value
-        when Symbol
-          value.to_s
-        when Hash
-          value.indifferent
-        when Array
-          value.stringified
-        end
-        h[key.to_s] = value
-      end
-    end
-  end
-end
-
-class Array
-  def stringified
-    Array.new.tap do |a|
-      each do |value|
-        value = if value.is_a? Hash
-          value.stringified.indifferent 
-        else
-          value.to_s
-        end
-        
-        a << value
-      end
-    end
-  end
-end

data/lib/cancan_strong_parameters/version.rb

@@ -1,3 +1,3 @@
 module CancanStrongParameters
-  VERSION = "0.2.4"
+  VERSION = "0.3"
 end

data/test/app/controllers/posts_controller.rb

@@ -5,7 +5,8 @@ class PostsController < ActionController::Base
     :comments => [
       :body, 
       { :tags => [ :name ] } # This is fugly, use 1.9!
-    ]
+    ],
+    :label_ids => Array
     
   def create
     @post = Post.new(params[:post])

data/test/app/models/post.rb

@@ -3,8 +3,8 @@ class Post
   include ActiveModel::MassAssignmentSecurity
   include ActiveModel::AttributeMethods
   
-  attr_accessor :title, :body
-  attr_accessible :title, :body
+  attr_accessor :title, :body, :label_ids
+  attr_accessible :title, :body, :label_ids
   
   def initialize(attributes = {})
     @attributes = attributes

data/test/functional/posts_controller_test.rb

@@ -111,4 +111,15 @@ class PostsControllerTest < ActionController::TestCase
     }
     assigns(:post_attributes).indifferent.must_have_same_content_as expected.indifferent
   end
+
+  test "it can permit and post checkbox vars (ending in _ids)" do
+    params = {
+      :post => {
+        :label_ids => ['1','2','3']
+      }
+    }
+
+    post :create, params
+    assigns(:post_attributes).indifferent['label_ids'].must_equal ['1','2','3']
+  end
 end

data/test/rails_helper.rb

@@ -20,7 +20,7 @@ require "rack/test"
 root = File.expand_path(File.dirname(__FILE__))
 
 # Define the application and configuration
-module Config
+module Test
   class Application < ::Rails::Application
     # configuration here if needed
     config.active_support.deprecation = :stderr 
@@ -28,9 +28,9 @@ module Config
 end
 
 # Initialize the application
-Config::Application.initialize!
+Test::Application.initialize!
 
-Config::Application.routes.draw do
+Test::Application.routes.draw do
   resources :posts
   
   match 'title/:id', :to => 'title#update', :via => :put

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cancan_strong_parameters
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: '0.3'
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-14 00:00:00.000000000 Z
+date: 2013-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cancan
@@ -34,7 +34,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -42,7 +42,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.6
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -174,7 +174,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: make CanCan work with strong_parameters