cancan-permits 0.3.1 → 0.3.2

data/Changelog.txt

@@ -1,3 +1,9 @@
+## Nov 25, 2010
+
+Fixed some generator issues and split generator into:
+* Licenses
+* Permits
+
 ## Nov 24, 2010
 
 The generator has now been tested with Rails 3.0.3 and works. Previously there was an issue with missing generator dependencies in the Rakefile.

data/README.markdown

@@ -184,31 +184,64 @@ To configure permits to allow localhost to manage objects:
 
 Please provide suggestions and feedback on how to improve this :)
 
+## Generators
+
+The gem comes with the following generators
+
+* cancan:permits
+* cancan:licenses
+
 ## Permits Generator
 
 Options
-* --orm         : The ORM to use (active_record, data_mapper, mongoid, mongo_mapper) - creates a Rails initializer
-* --initializer : A Rails 3 initializer file for Permits is generated by default. Use --no-initializer option to disable this
-* --roles       : The roles for which to generate permits ; default Guest (read all) and Admin (manage all) 
-* --licenses    : The licenses to generate; default UserAdmin and Blogging licenses are generated
+* --orm             : The ORM to use (active_record, data_mapper, mongoid, mongo_mapper) - creates a Rails initializer
+* --initializer     : A Rails 3 initializer file for Permits is generated by default. Use --no-initializer option to disable this
+* --roles           : The roles for which to generate permits ; default Guest (read all) and Admin (manage all) 
+* --default-permits : By default :guest and :admin permits are generated. Use --no-default-permits option to disable this
+
+<code>$ rails g cancan:permits --orm active_record --roles guest author admin</code>
 
+### What does the generator generate?
+
+To get an understanding of what the generator generates for a Rails 3 application, try to run the spec permit_generator_spec.rb with rspec 2 as follows:
+
+<code>$ rspec spec/generators/cancan/permits_generator_spec.rb</code>
+
+In the file <code>permits_generator_spec.rb</code> make the following change <code>config.remove_temp_dir = false</code>
+This will prevent the rails /tmp dir from being deleted after the test run, so you can inspect what is generated in the Rails app. 
+
+## Licenses Generator
+
+Options
+* --licenses    : The licenses to generate; default UserAdmin and Blogging licenses are generated
 * --default-licenses  : By default exemplar licenses are generated. Use --no-default-licenses option to disable this
-* --default-permits   : By default :guest and :admin permits are generated. Use --no-default-permits option to disable this
 
-<code>$ rails g permits --orm active_record --roles guest author admin</code>
+Run examples:
+
+Generate default licenses:
+
+<code>$ rails g cancan:licenses</code>
+
+Genereate specific licenses (no defaults):
+
+<code>$ rails g cancan:licenses profile_administration article_editing --no-default-licenses</code>
+
+Create both specific and default licenses:
+
+<code>$ rails g cancan:licenses profile_administration article_editing</code>
 
 ### What does the generator generate?
 
 To get an understanding of what the generator generates for a Rails 3 application, try to run the spec permit_generator_spec.rb with rspec 2 as follows:
 
-<code>$ rspec spec/generators/permit_generator_spec.rb</code>
+<code>$ rspec spec/generators/cancan/licenses_generator_spec.rb</code>
 
-In the file <code>permit_generator_spec.rb</code> make the following change <code>config.remove_temp_dir = false</code>
+In the file <code>licenses_generator_spec.rb</code> make the following change <code>config.remove_temp_dir = false</code>
 This will prevent the rails /tmp dir from being deleted after the test run, so you can inspect what is generated in the Rails app. 
 
 # TODO ?
 
-The Permits generator should attempt to discover which roles are currently defined as available to the system (Generic Roles API, User#roles etc.) and generate permits for those roles. Any roles specified in the --roles option should be merged with the roles available in the app.
+The Permits generator should attempt to attempt to uncover which roles are currently defined as available to the system (Generic Roles API, User#roles etc.) and generate permits for those roles. Any roles specified in the --roles option should be merged with the roles available in the app.
 
 ## Note on Patches/Pull Requests
  

data/Rakefile

@@ -7,7 +7,7 @@ begin
     gem.email = "kmandrup@gmail.com"
     gem.homepage = "http://github.com/kristianmandrup/cancan-permits"
     gem.authors = ["Kristian Mandrup"]
-    gem.add_development_dependency "rspec",           ">= 2.0.0"
+    gem.add_development_dependency "rspec",           ">= 2.0.1"
     gem.add_development_dependency 'code-spec',       "~> 0.2.5"
     gem.add_development_dependency 'rails-app-spec',  "~> 0.3.0"
 

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/cancan-permits.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{cancan-permits}
-  s.version = "0.3.1"
+  s.version = "0.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kristian Mandrup"]
@@ -41,10 +41,12 @@ Gem::Specification.new do |s|
      "lib/cancan-permits/rspec/matchers/have_license.rb",
      "lib/cancan-permits/rspec/matchers/have_license_class.rb",
      "lib/cancan-permits/rspec/matchers/have_license_file.rb",
-     "lib/generators/permits/permits_generator.rb",
-     "lib/generators/permits/templates/blogging_license.rb",
-     "lib/generators/permits/templates/permit.rb",
-     "lib/generators/permits/templates/user_admin_license.rb",
+     "lib/generators/cancan/licenses/licenses_generator.rb",
+     "lib/generators/cancan/licenses/templates/blogging_license.rb",
+     "lib/generators/cancan/licenses/templates/license.rb",
+     "lib/generators/cancan/licenses/templates/user_admin_license.rb",
+     "lib/generators/cancan/permits/permits_generator.rb",
+     "lib/generators/cancan/permits/templates/permit.rb",
      "spec/active_record/db/database.yml",
      "spec/active_record/migrations/001_create_user.rb",
      "spec/active_record/migrations/002_create_comment.rb",
@@ -64,7 +66,8 @@ Gem::Specification.new do |s|
      "spec/fixtures/permits/guest_permit.rb",
      "spec/fixtures/permits/super_admin_permit.rb",
      "spec/fixtures/permits/system_permit.rb",
-     "spec/generators/permit_generator_spec.rb",
+     "spec/generators/cancan/licenses_generator_spec.rb",
+     "spec/generators/cancan/permits_generator_spec.rb",
      "spec/generic/api/basic/config.rb",
      "spec/generic/api/basic/xgroup.rb",
      "spec/generic/api/basic/xgroup_orm.rb",
@@ -114,7 +117,8 @@ Gem::Specification.new do |s|
      "spec/fixtures/permits/guest_permit.rb",
      "spec/fixtures/permits/super_admin_permit.rb",
      "spec/fixtures/permits/system_permit.rb",
-     "spec/generators/permit_generator_spec.rb",
+     "spec/generators/cancan/licenses_generator_spec.rb",
+     "spec/generators/cancan/permits_generator_spec.rb",
      "spec/generic/api/basic/config.rb",
      "spec/generic/api/basic/xgroup.rb",
      "spec/generic/api/basic/xgroup_orm.rb",
@@ -145,7 +149,7 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rspec>, [">= 2.0.0"])
+      s.add_development_dependency(%q<rspec>, [">= 2.0.1"])
       s.add_development_dependency(%q<code-spec>, ["~> 0.2.5"])
       s.add_development_dependency(%q<rails-app-spec>, ["~> 0.3.0"])
       s.add_runtime_dependency(%q<cancan>, ["~> 1.4.1"])
@@ -155,7 +159,7 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<activesupport>, [">= 3.0.1"])
       s.add_runtime_dependency(%q<logging_assist>, [">= 0.1.6"])
     else
-      s.add_dependency(%q<rspec>, [">= 2.0.0"])
+      s.add_dependency(%q<rspec>, [">= 2.0.1"])
       s.add_dependency(%q<code-spec>, ["~> 0.2.5"])
       s.add_dependency(%q<rails-app-spec>, ["~> 0.3.0"])
       s.add_dependency(%q<cancan>, ["~> 1.4.1"])
@@ -166,7 +170,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<logging_assist>, [">= 0.1.6"])
     end
   else
-    s.add_dependency(%q<rspec>, [">= 2.0.0"])
+    s.add_dependency(%q<rspec>, [">= 2.0.1"])
     s.add_dependency(%q<code-spec>, ["~> 0.2.5"])
     s.add_dependency(%q<rails-app-spec>, ["~> 0.3.0"])
     s.add_dependency(%q<cancan>, ["~> 1.4.1"])

data/lib/cancan-permits/rspec/matchers/have_license_file.rb

@@ -12,8 +12,12 @@ module RSpec::RubyContentMatchers
         @name = name
       end
 
+      def license_dir
+        File.join(app_dir, 'licenses')
+      end
+
       def license_file name
-        File.join(app_dir, 'licenses', "#{name}_license.rb")
+        File.join(license_dir, "#{name}_license.rb")
       end
 
       def matches? obj, &block
@@ -21,11 +25,58 @@ module RSpec::RubyContentMatchers
         found = File.file? file_name
         yield File.read(file_name) if block && found
         found
-      end  
+      end 
+      
+      def failure_message
+        "No license file found for #{name} in #{license_dir} as expected"
+      end   
+      
+      def negative_failure_message
+        "License file #{name} found in #{license_dir} but was not expected"
+      end 
+      
     end
 
     def have_license_file name
       HaveLicenseFile.new name
     end
+
+    class HaveLicenseFiles
+      include ::Rails3::Assist::Artifact::Directory
+      include ::Rails3::Assist::Directory
+      
+      attr_reader :names
+  
+      def initialize *names
+        @names = names.flatten
+      end
+
+      def license_dir
+        File.join(app_dir, 'licenses')
+      end
+
+      def license_file name
+        File.join(license_dir, "#{name}_license.rb")
+      end
+
+      def matches? obj, &block
+        names.flatten.each do |name|
+          return false if !File.file? license_file(name)
+        end        
+        true
+      end 
+      
+      def failure_message
+        "License files #{names} not found in #{license_dir} as expected"
+      end   
+      
+      def negative_failure_message
+        "License files #{names} found in #{license_dir} but was not expected"
+      end 
+    end
+
+    def have_license_files *names
+      HaveLicenseFiles.new names
+    end
   end
 end

data/lib/generators/cancan/licenses/licenses_generator.rb

@@ -0,0 +1,58 @@
+require 'rails/generators/base'
+require 'sugar-high/array'
+require 'active_support/inflector'
+require 'rails3_artifactor'
+require 'logging_assist'
+
+module Cancan
+  module Generators
+    class LicensesGenerator < Rails::Generators::Base
+      desc "Creates Licenses for use with CanCan and Permits"
+
+      argument     :licenses,           :type => :array,      :default => [],     :desc => "Licenses"
+      class_option :default_licenses,   :type => :boolean,    :default => true,   :desc => "Create default exemplar licenses"
+
+      source_root File.dirname(__FILE__) + '/templates'
+
+      def main_flow      
+        if default_licenses?
+          default_licenses.each{|license| default_license license }
+        end  
+
+        licenses.each do |license|      
+          template_license(license) # if !skip_license?(license)
+        end    
+      end
+  
+      protected
+
+      include Rails3::Assist::BasicLogger
+      extend Rails3::Assist::UseMacro
+  
+      use_helpers :app, :file, :special
+
+      attr_accessor :license_name
+
+      def skip_license? license
+        default_licenses? && default_licenses.include?(license.to_sym) 
+      end
+
+      def default_licenses
+        [:user_admin, :blogging]
+      end        
+
+      def default_licenses?
+        options[:default_licenses]    
+      end
+
+      def template_license name  
+        self.license_name = name        
+        template "license.rb", "app/licenses/#{name}_license.rb"
+      end
+  
+      def default_license name 
+        template "#{name}_license.rb", "app/licenses/#{name}_license.rb"
+      end
+    end
+  end
+end

data/lib/generators/cancan/licenses/templates/license.rb

@@ -0,0 +1,8 @@
+class <%= license_name.to_s.camelize %>License < License::Base
+  def initialize name
+    super
+  end
+
+  def enforce!
+  end
+end

data/lib/generators/cancan/permits/permits_generator.rb

@@ -0,0 +1,127 @@
+require 'rails/generators/base'
+require 'sugar-high/array'
+require 'active_support/inflector'
+require 'rails3_artifactor'
+require 'logging_assist'
+
+module Cancan
+  module Generators
+    class PermitsGenerator < Rails::Generators::Base
+      desc "Creates a Permit for each role in 'app/permits' and ensures that the permit folder is added to Rails load path."
+
+      argument     :roles,        :type => :array,      :default => [],               :desc => "Roles to create permits for"
+
+      # ORM to use
+      class_option :orm,          :type => :string,     :default => 'active_record',  :desc => "ORM to use"
+      class_option :initializer,  :type => :boolean,    :default => true,             :desc => "Create Permits initializer"
+
+      class_option :default_permits,    :type => :boolean,    :default => true, :desc => "Create default permits for guest and admin roles"
+
+      source_root File.dirname(__FILE__) + '/templates'
+
+      def main_flow      
+        default_roles.each do |role|
+          template_permit role
+        end
+
+        template_permit :any,     :any_permit 
+        template_permit :system,  :barebones_permit
+    
+        permit_logic = base_logic
+        get_roles.each do |role|      
+          template_permit(role) if !skip_permit?(role)
+        end    
+
+        permits_initializer if permits_initializer?
+      end
+  
+      protected
+
+      include Rails3::Assist::BasicLogger
+      extend Rails3::Assist::UseMacro
+  
+      use_helpers :app, :file, :special
+
+      attr_accessor :permit_name, :permit_logic
+
+      def default_roles
+        [:guest, :admin]
+      end
+
+      def permits_initializer?
+        options[:initializer]
+      end
+
+      def skip_permit? permit
+        default_permits? && default_roles.include?(permit.to_sym) 
+      end
+
+
+      # TODO: merge with any registered roles in application
+      def get_roles
+        roles.uniq.to_symbols
+      end
+
+      def default_permits?
+        options[:default_permits]    
+      end
+
+      def orm
+        options[:orm]
+      end
+
+      def permits_initializer
+        create_initializer :permits do 
+          "Permits::Ability.orm = :#{orm}"
+        end
+      end 
+
+      def template_permit name, template_name=nil
+        permit_logic = send "#{name}_logic" if [:admin, :system, :any].include?(name)
+        self.permit_name = name
+
+        template "permit.rb", "app/permits/#{name}_permit.rb"
+      end 
+
+      def any_logic
+        ""
+      end
+
+      def system_logic
+        %{
+          # allow to manage all and return :break to 
+          # abort calling any other permissions
+  
+          request = options[:request]
+          if request && request.host.localhost? && localhost_manager?
+            can(:manage, :all) 
+            return :break
+          end    
+    }
+      end
+
+      def base_logic
+        %{
+          return if !role_match? user
+
+          # can :create, Comment
+          # owns(user, Comment)
+    }
+      end
+  
+      def admin_logic
+        %{
+          return if !role_match? user
+          can :manage, :all
+    }
+      end
+
+        def guest_logic
+          %{
+            return if !role_match? user
+            can :read, :all
+      }
+        end
+    end
+  end
+end

data/spec/generators/cancan/licenses_generator_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper' 
+require 'generator-spec'
+
+require_generator :cancan => :licenses
+
+RSpec::Generator.configure do |config|
+  config.debug = true
+  config.remove_temp_dir = true #false
+  config.default_rails_root(__FILE__) 
+  config.lib = File.dirname(__FILE__) + '/../lib'
+  config.logger = :stdout  # :file
+end
+
+
+describe 'Licenses generator' do   
+  use_helpers :controller, :special, :file
+    
+  setup_generator :licenses do
+    tests Cancan::Generators::LicensesGenerator
+  end
+
+  describe "Licenses: Profile Administration and Article Editing" do
+    before :each do
+      @generator = with_generator do |g|    
+        g.run_generator "profile_administration article_editing --no-default-licenses".args
+      end
+    end
+
+    it "should have created license files" do
+      @generator.should have_license_files :profile_administration, :article_editing
+       @generator.should_not have_license_files :blogging, :user_admin
+    end    
+  end
+
+  describe "Licenses: Profile Administration and Article Editing" do
+    before :each do
+      @generator = with_generator do |g|    
+        g.run_generator "profile_administration article_editing".args
+      end
+    end
+
+    it "should have created license files" do
+      @generator.should have_license_files :profile_administration, :article_editing, :blogging, :user_admin
+    end
+    
+    it "should have created license file :profile_administration with the right class" do      
+      @generator.should have_license_file :profile_administration do |license|
+        license.should have_license_class :profile_administration
+      end
+    end
+    
+    it "should have created license file :article_editing with the right class" do      
+      @generator.should have_license_file :article_editing do |license|      
+        license.should have_license_class :article_editing
+      end
+    end
+  end  
+end

data/spec/generators/{permit_generator_spec.rb → cancan/permits_generator_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper' 
 require 'generator-spec'
 
-require_generator :permits
+require_generator :cancan => :permits
 
 RSpec::Generator.configure do |config|
   config.debug = true
@@ -16,14 +16,13 @@ describe 'Permits generator' do
   use_helpers :controller, :special, :file
     
   setup_generator :permits do
-    tests PermitsGenerator
+    tests Cancan::Generators::PermitsGenerator
   end
 
   describe 'result of running generator with default profile' do
     before :each do
       @generator = with_generator do |g|    
-        arguments = "--orm mongoid".args
-        g.run_generator arguments
+        g.run_generator "--orm mongoid".args
       end
     end
     
@@ -42,7 +41,7 @@ describe 'Permits generator' do
     context "Registered roles :editor, :admin" do
       before :each do
         @generator = with_generator do |g|    
-          g.run_generator "--roles admin editor".args
+          g.run_generator "admin editor".args
         end
       end
   
@@ -55,16 +54,6 @@ describe 'Permits generator' do
           editor_permit.should_not have_licenses :user_admin, :blogging 
         end
       end
-
-      it "should have created the License file with the :user_admin and :blogging licenses used by the :editor permit" do
-        @generator.should have_license_file :user_admin do |license_file|      
-          license_file.should have_license_class :user_admin
-        end
-
-        @generator.should have_license_file :blogging do |license_file|      
-          license_file.should have_license_class :blogging
-        end
-      end
     end #ctx
   end    
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 1
-  version: 0.3.1
+  - 2
+  version: 0.3.2
 platform: ruby
 authors: 
 - Kristian Mandrup
@@ -28,8 +28,8 @@ dependencies:
         segments: 
         - 2
         - 0
-        - 0
-        version: 2.0.0
+        - 1
+        version: 2.0.1
   type: :development
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -186,10 +186,12 @@ files:
 - lib/cancan-permits/rspec/matchers/have_license.rb
 - lib/cancan-permits/rspec/matchers/have_license_class.rb
 - lib/cancan-permits/rspec/matchers/have_license_file.rb
-- lib/generators/permits/permits_generator.rb
-- lib/generators/permits/templates/blogging_license.rb
-- lib/generators/permits/templates/permit.rb
-- lib/generators/permits/templates/user_admin_license.rb
+- lib/generators/cancan/licenses/licenses_generator.rb
+- lib/generators/cancan/licenses/templates/blogging_license.rb
+- lib/generators/cancan/licenses/templates/license.rb
+- lib/generators/cancan/licenses/templates/user_admin_license.rb
+- lib/generators/cancan/permits/permits_generator.rb
+- lib/generators/cancan/permits/templates/permit.rb
 - spec/active_record/db/database.yml
 - spec/active_record/migrations/001_create_user.rb
 - spec/active_record/migrations/002_create_comment.rb
@@ -209,7 +211,8 @@ files:
 - spec/fixtures/permits/guest_permit.rb
 - spec/fixtures/permits/super_admin_permit.rb
 - spec/fixtures/permits/system_permit.rb
-- spec/generators/permit_generator_spec.rb
+- spec/generators/cancan/licenses_generator_spec.rb
+- spec/generators/cancan/permits_generator_spec.rb
 - spec/generic/api/basic/config.rb
 - spec/generic/api/basic/xgroup.rb
 - spec/generic/api/basic/xgroup_orm.rb
@@ -285,7 +288,8 @@ test_files:
 - spec/fixtures/permits/guest_permit.rb
 - spec/fixtures/permits/super_admin_permit.rb
 - spec/fixtures/permits/system_permit.rb
-- spec/generators/permit_generator_spec.rb
+- spec/generators/cancan/licenses_generator_spec.rb
+- spec/generators/cancan/permits_generator_spec.rb
 - spec/generic/api/basic/config.rb
 - spec/generic/api/basic/xgroup.rb
 - spec/generic/api/basic/xgroup_orm.rb

data/lib/generators/permits/permits_generator.rb

@@ -1,150 +0,0 @@
-require 'rails/generators/base'
-require 'sugar-high/array'
-require 'active_support/inflector'
-require 'rails3_artifactor'
-require 'logging_assist'
-
-class PermitsGenerator < Rails::Generators::Base
-  desc "Creates a Permit for each role in 'app/permits' and ensures that the permit folder is added to Rails load path."
-
-  class_option :roles,        :type => :array,      :default => [],               :desc => "Roles to create permits for"
-  class_option :licenses,     :type => :array,      :default => [],               :desc => "Licenses"
-
-  # ORM to use
-  class_option :orm,          :type => :string,     :default => 'active_record',  :desc => "ORM to use"
-  class_option :initializer,  :type => :boolean,    :default => true,             :desc => "Create Permits initializer"
-
-  class_option :default_permits,    :type => :boolean,    :default => true, :desc => "Create default permits for guest and admin roles"
-  class_option :default_licenses,   :type => :boolean,    :default => true, :desc => "Create default exemplar licenses"
-
-  source_root File.dirname(__FILE__) + '/templates'
-
-  def main_flow      
-    default_roles.each do |role|
-      template_permit role
-    end
-
-    template_permit :any,     :any_permit 
-    template_permit :system,  :barebones_permit
-    
-    permit_logic = base_logic
-    roles.each do |role|      
-      template_permit(role) if !skip_permit?(role)
-    end    
-
-    if default_licenses?
-      template_license :user_admin
-      template_license :blogging
-    end  
-
-    licenses.each do |license|      
-      template_license(license) if !skip_license?(license)
-    end    
-
-    permits_initializer if permits_initializer?
-  end
-  
-  protected
-
-  include Rails3::Assist::BasicLogger
-  extend Rails3::Assist::UseMacro
-  
-  use_helpers :app, :file, :special
-
-  attr_accessor :permit_name, :permit_logic
-
-  def default_roles
-    [:guest, :admin]
-  end
-
-  def permits_initializer?
-    options[:initializer]
-  end
-
-  def skip_license? license
-    default_licenses? && default_licenses.include?(license.to_sym) 
-  end
-
-  def skip_permit? permit
-    default_permits? && default_roles.include?(permit.to_sym) 
-  end
-
-
-  # TODO: merge with any registered roles in application
-  def roles
-    options[:roles].uniq.to_symbols
-  end
-
-  def default_licenses?
-    options[:default_licenses]    
-  end
-
-  def default_permits?
-    options[:default_permits]    
-  end
-
-  def licenses
-    options[:licenses]    
-  end
-  
-  def orm
-    options[:orm]
-  end
-
-  def permits_initializer
-    create_initializer :permits do 
-      "Permits::Ability.orm = :#{orm}"
-    end
-  end 
-
-  def template_license name 
-    template "#{name}_license.rb", "app/licenses/#{name}_license.rb"
-  end
-
-  def template_permit name, template_name=nil
-    permit_logic = send "#{name}_logic" if [:admin, :system, :any].include?(name)
-    self.permit_name = name
-
-    template "permit.rb", "app/permits/#{name}_permit.rb"
-  end 
-
-  def any_logic
-    ""
-  end
-
-  def system_logic
-    %{
-      # allow to manage all and return :break to 
-      # abort calling any other permissions
-  
-      request = options[:request]
-      if request && request.host.localhost? && localhost_manager?
-        can(:manage, :all) 
-        return :break
-      end    
-}
-  end
-
-  def base_logic
-    %{
-      return if !role_match? user
-
-      # can :create, Comment
-      # owns(user, Comment)
-}
-  end
-  
-  def admin_logic
-    %{
-      return if !role_match? user
-      can :manage, :all
-}
-  end
-
-    def guest_logic
-      %{
-        return if !role_match? user
-        can :read, :all
-  }
-    end
-end