can_opener 0.0.2 → 0.0.3

data/README.markdown

@@ -52,7 +52,38 @@ Then declare your Ability class, but include `CanOpener` rather than `CanCan::Ab
     end
     
 Remember that CanCan processes abilities in a top down fashion, so add your general abilities up top, and then things you want to override everything (like banning a user) at the bottom.  You can add line by line or multiple on one line if you wish.
+
+### But I want to check the IP Address, Project, etc, in the ability!
+
+Inherit `CanOpener::Ability` , setup your accessors, use the `aditional_ability_arguments` class method.  Consider the following contrived example:
+
+    class TakesIpAddress < CanOpener::Ability
+      attr_reader :ip_address      
+      aditional_ability_arguments :ip_address
+    end
+
+    class SuperAdmin < TakesIpAddress
+      def abilities
+        # Wide open, just for testing
+        can :manage, :foo
+      end
+    end
+
+    class IPBouncer < TakesIpAddress
+      def abilities
+        cannot :manage, :foo unless ip_address =~ /^192\.168\./
+      end
+    end
+
+    class TwoParamAbility
+      include CanOpener
   
+      configure_abilities do |c|
+        c.add SuperAdmin
+        c.add IPBouncer
+      end
+    end
+    
 Why?
 ----
 
@@ -62,4 +93,3 @@ Todo
 ----
 
 * Perhaps a generator for CanOpener::Ability subclasses.
-* Allow easy initializer overriding to allow additional values passed to the ability (Project, IP Address, etc)

data/lib/can_opener.rb

@@ -27,9 +27,9 @@ module CanOpener
     end
   end
 
-  def initialize(user)
+  def initialize(*args)
     self.class.ability_classes.each do |ability_class|
-      ability_class.new(self, user)
+      ability_class.new(self, *args)
     end
   end
 end

data/lib/can_opener/ability.rb

@@ -6,11 +6,32 @@ module CanOpener
 
     attr_accessor :user
     protected :user=
-  
-    def initialize(base, user)
+    
+    def initialize(base, *args)
       @base = base
-      self.user = user
+      setup_vars(*args)
       abilities
     end
+    
+    def self.aditional_ability_arguments(*args)
+      @@additional_arguments = [:user]
+      args.each_with_index do |arg, idx|
+        raise ArgumentError, "user cannot be an additional argument as it is required as the first arg" if arg.to_sym == :user
+        @@additional_arguments << arg.to_sym
+      end
+    end
+    
+    protected
+    
+    def setup_vars(*args)
+      if @@additional_arguments && @@additional_arguments.length > 0
+        @@additional_arguments.each_with_index do |arg, idx|
+          self.class.send(:attr_accessor, arg)
+          self.send("#{arg}=", args[idx])
+        end
+      else
+        @user = args[0]
+      end
+    end
   end
 end

data/lib/can_opener/version.rb

@@ -1,3 +1,3 @@
 module CanOpener
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/can_opener_spec.rb

@@ -138,4 +138,41 @@ describe CanOpener do
       ability.should be_able_to(:read, :foo)
     end
   end
+  
+  describe "passing objects to the ability" do
+    class TakesIpAddress < CanOpener::Ability
+      attr_reader :ip_address      
+      aditional_ability_arguments :ip_address
+    end
+    
+    class SuperAdmin < TakesIpAddress
+      def abilities
+        # Wide open, just for testing
+        can :manage, :foo
+      end
+    end
+    
+    class IPBouncer < TakesIpAddress
+      def abilities
+        cannot :manage, :foo unless ip_address =~ /^192\.168\./
+      end
+    end
+
+    class TwoParamAbility
+      include CanOpener
+      
+      configure_abilities do |c|
+        c.add SuperAdmin
+        c.add IPBouncer
+      end
+    end
+    
+    it "should allow an object in addition to the user" do
+      ability = TwoParamAbility.new(admin_user, "1.2.3.4")
+      ability.should_not be_able_to(:manage, :foo)
+      
+      ability = TwoParamAbility.new(admin_user, "192.168.1.1")
+      ability.should be_able_to(:manage, :foo)
+    end
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: can_opener
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - Brendon Murphy