can_messenger 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15f09405e67a906115972dc84790769875d1dcdb5cbd78a57827ccdf910d7e05
-  data.tar.gz: faa23fc30c89b5a81875ff2664e5f97cac2970cb6161599887a1c02da9b5f36c
+  metadata.gz: b79b0febdca3de5f068c142413eef6f959461518e3928cd9beed52b14ee8ceef
+  data.tar.gz: aca5cf8fde09f75b6f0d7a81ab1bca9e6a59fc2d3d811a72321eb6b9d6b88ba9
 SHA512:
-  metadata.gz: bb33fdda392ca2acaea5357a661b5b9dda245c41db5b000802e4d12886d58b16c49d5238312aa254f062fdc9f46c9f05b9f140f202a0ad73e1ceda9b81d397ca
-  data.tar.gz: 4823263138efc7d61756d473e2e6235487921f7d8e6d8350260dcd80d491bee6927cbf5606671a242576fdb3f3fb5437212f77c008856c3bfa1d2b9a5b5d4924
+  metadata.gz: 864bd3e56da612dee5e02bd6e575eff32adab311c3090e2a874704ee7fb6f84895146294a83362be40faef5477e3951c69203f6ecd4ad094a79067d4a5928d1e
+  data.tar.gz: c1bc154e2b42b3373aadd0e27572d66221d3859fb5272f0594fc5d1adb1a4e1382de1e04e02e7e2171bf28b6f2a1cfc33500b4c4af0f0acd3edf35ea3b87c1f4

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 ## [Unreleased]
 
+## [2.1.0] - 2026-02-23
+
+### Changed
+
+- Promote the first stable docs snapshot version to `2.1.0`.
+- Tighten DBC signal bounds validation and report exact out-of-range bit positions.
+
+### Fixed
+
+- Fix DBC big-endian (`@0`) bit mapping for multi-byte signals.
+- Reject unsigned DBC signal values that exceed the field's bit-length range instead of silently wrapping.
+- Align `Messenger` RBS signatures with runtime behavior (`adapter:` support and correct private method surface).
+- Update DBC specs to cover the corrected big-endian behavior and unsigned overflow errors.
+
 ## [2.0.0] - 2026-02-02
 
 ### Changed
@@ -150,6 +164,8 @@
 ## [0.1.0] - 2024-11-10
 
 - Initial release
+  [Unreleased]: https://github.com/fk1018/can_messenger/compare/v2.1.0...HEAD
+  [2.1.0]: https://github.com/fk1018/can_messenger/compare/v2.0.0...v2.1.0
   [2.0.0]: https://github.com/fk1018/can_messenger/compare/v1.3.0...v2.0.0
   [1.3.0]: https://github.com/fk1018/can_messenger/compare/v1.2.1...v1.3.0
   [1.2.1]: https://github.com/fk1018/can_messenger/compare/v1.2.0...v1.2.1

data/README.md

@@ -13,6 +13,7 @@
 ## Requirements
 
 - Ruby 4.0.1 or higher.
+- Docker (optional, for containerized development without installing Ruby locally).
 
 ## Installation
 
@@ -206,7 +207,58 @@ Before using `can_messenger`, please note the following:
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test:rspec` to execute the test suite.
+### Docker-first workflow (no local Ruby required)
+
+Build the development image:
+
+```bash
+docker compose build app
+```
+
+Run RuboCop:
+
+```bash
+docker compose run --rm lint
+```
+
+Run the test suite:
+
+```bash
+docker compose run --rm test
+```
+
+Build the gem:
+
+```bash
+docker compose run --rm build
+```
+
+Install docs dependencies (Docusaurus):
+
+```bash
+docker compose run --rm docs npm ci
+```
+
+Build the docs site:
+
+```bash
+docker compose run --rm docs npm run build
+```
+
+Preview docs locally:
+
+```bash
+docker compose run --rm --service-ports docs npm run start
+```
+
+### Local Ruby workflow
+
+If you already have Ruby installed locally, you can still use:
+
+```bash
+bin/setup
+bundle exec rake test:rspec
+```
 
 ## Contributing
 

data/lib/can_messenger/dbc.rb

@@ -283,15 +283,15 @@ module CanMessenger
     # @return [void]
     # @raise [ArgumentError] If signal bits exceed message boundaries or start_bit is negative
     def validate_signal_bounds(message_size_bytes)
-      max_bit = start_bit + length - 1
-      max_allowed_bit = (message_size_bytes * 8) - 1
-
       raise ArgumentError, "Signal #{name}: start_bit (#{start_bit}) cannot be negative" if start_bit.negative?
+      raise ArgumentError, "Signal #{name}: length (#{length}) must be positive" if length <= 0
 
-      return unless max_bit > max_allowed_bit
+      max_allowed_bit = max_allowed_bit_for(message_size_bytes)
+      invalid_position = invalid_bit_position(max_allowed_bit)
+      return unless invalid_position
 
       raise ArgumentError,
-            "Signal #{name}: signal bits #{start_bit}..#{max_bit} exceed message size " \
+            "Signal #{name}: bit position #{invalid_position} exceeds message size " \
             "(#{message_size_bytes} bytes = #{max_allowed_bit + 1} bits)"
     end
 
@@ -328,9 +328,15 @@ module CanMessenger
     # @return [void]
     # @raise [ArgumentError] If an unsigned value is negative
     def validate_unsigned_value(raw)
-      return unless sign == :unsigned && raw.negative?
+      return unless sign == :unsigned
+
+      raise ArgumentError, "Unsigned value cannot be negative: #{raw}" if raw.negative?
 
-      raise ArgumentError, "Unsigned value cannot be negative: #{raw}"
+      max_val = (1 << length) - 1
+      return if raw <= max_val
+
+      raise ArgumentError,
+            "Unsigned value #{raw} out of range [0..#{max_val}] for #{length}-bit field"
     end
 
     # Validates signed values to ensure they fit in the signal's bit range.
@@ -396,19 +402,12 @@ module CanMessenger
       if endianness == :little
         start_bit + bit_offset
       else
-        # For big-endian signals, the bit numbering within a byte follows MSB-first
-        # ordering. This means that the most significant bit (MSB) is numbered 7,
-        # and the least significant bit (LSB) is numbered 0. To calculate the absolute
-        # bit position, we first determine the position of the MSB in the starting byte.
-        #
-        # The formula ((start_bit / 8) * 8) calculates the starting byte's base bit
-        # position (aligned to the nearest multiple of 8). Adding (7 - (start_bit % 8))
-        # adjusts this base position to point to the MSB of the starting byte.
-        #
-        # Finally, we subtract the bit offset to account for the signal's length and
-        # position within the message.
-        base = ((start_bit / 8) * 8) + (7 - (start_bit % 8))
-        base - bit_offset
+        # DBC big-endian (`@0`) start_bit is in sawtooth numbering and points at the
+        # signal MSB. Convert to sequential network numbering, move toward the LSB,
+        # then convert back to the little-endian bit index used by byte writes.
+        network_start = sawtooth_to_network_bitnum(start_bit)
+        network_bit = network_start + (length - 1 - bit_offset)
+        sawtooth_to_network_bitnum(network_bit)
       end
     end
 
@@ -511,5 +510,22 @@ module CanMessenger
       msb_set = (value >> (length - 1)).allbits?(1)
       msb_set ? value - (1 << length) : value
     end
+
+    def sawtooth_to_network_bitnum(bitnum)
+      (8 * (bitnum / 8)) + (7 - (bitnum % 8))
+    end
+
+    def invalid_bit_position(max_allowed_bit)
+      length.times do |i|
+        bit_pos = calculate_bit_position(i)
+        return bit_pos if bit_pos.negative? || bit_pos > max_allowed_bit
+      end
+
+      nil
+    end
+
+    def max_allowed_bit_for(message_size_bytes)
+      (message_size_bytes * 8) - 1
+    end
   end
 end

data/lib/can_messenger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CanMessenger
-  VERSION = "2.0.0"
+  VERSION = "2.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: can_messenger
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - fk1018