can_has_validations 1.7.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb51b71bb23aabfeb3e1bde9ad0f03119d4011d60c7117971c606266eb0c477a
-  data.tar.gz: 5b101d95e237b874ff096f9658c064709aef19228c3444f6ed6878fb1f5cc1c5
+  metadata.gz: b019c7cb6040ee0139aaaeb3cac5e115cc144cf0b4fb8eef8a6182772704eeb3
+  data.tar.gz: 7b9cf22f18f2d29092f71c4eacbb26fafb3ea0bf667ae8cc4d203b80c84b9eff
 SHA512:
-  metadata.gz: 82e3dc6177df9d32216bbefbbfeef97ccb4bebf22d5b8431c9d59393fd619f2d465b52f3c26eb84c551f35c154279e54c5689d595e699de0b65d211bc115c0ef
-  data.tar.gz: fe709a9a7225cf2ea6eb7828c4d741b11c07181a32710d394972ddb424bc282d44d9f163388451671577ff0ebf96c28b3921f46d60b63e61f8be2384a0702e08
+  metadata.gz: 3604c217ef68acdccc4db9e87309522223722a00f1ab74b6cffb03a67e75450d629168a1f32afcaaf0833d0761e9b9d98cffc23ac65a0473c978d2263381d7d8
+  data.tar.gz: 1458eb8d69395bf07d745a8b84308aed359f801fdf103577c789a99d4440667a65c8f655f5f21cede6b6c6f83a5dc450bcd9eccb45d7eb30c54ee393326ebdd7

data/lib/can_has_validations/validators/email_validator.rb

@@ -1,38 +1,40 @@
 # Ensure an attribute is generally formatted as an email.
 # eg: validates :user_email, email: true
+#     validates :user_email, email: {allow_unicode: true}
 
 require_relative 'hostname_validator'
 
 module ActiveModel::Validations
   class EmailValidator < ActiveModel::EachValidator
 
-    EMAIL_REGEXP       = /\A([a-z0-9._+-]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i
-    SEGMENT_REGEXP     = /\A[a-z0-9+_-]+\z/i
-    LABEL_REGEXP       = HostnameValidator::LABEL_REGEXP
+    EMAIL_REGEXP       = /\A([a-z0-9._+-]+)@((?:[a-z0-9-]+\.)+[a-z]{2,})\z/i
+    SEGMENT_REGEXP     = /\A[a-z0-9_+-]+\z/i
+    LABEL_REGEXP       = %r{\A([a-zA-Z0-9]([a-zA-Z0-9-]+)?)?[a-zA-Z0-9]\z}
+      # HostnameValidator::LABEL_REGEXP minus _/
     FINAL_LABEL_REGEXP = HostnameValidator::FINAL_LABEL_REGEXP
 
     def validate_each(record, attribute, value)
-      unless email_valid?(value)
+      unless email_valid?(value, **options.slice(:allow_unicode))
         record.errors.add(attribute, :invalid_email, **options.merge(value: value))
       end
     end
 
-    def email_valid?(value)
+    def email_valid?(value, allow_unicode: false)
       return unless value
-      recipient, domain = value.split('@', 2)
+      recipient, domain = value.to_s.split('@', 2)
       is_valid = true
 
       recipient ||= ''
       is_valid &&= recipient.length <= 255
       is_valid &&= recipient !~ /\.\./
-      is_valid &&= !recipient.starts_with?('.') 
-      is_valid &&= !recipient.ends_with?('.') 
+      is_valid &&= !recipient.starts_with?('.')
+      is_valid &&= !recipient.ends_with?('.')
       recipient.split('.').each do |segment|
         is_valid &&= segment =~ SEGMENT_REGEXP
       end
 
       domain ||= ''
-      if defined?(Addressable::IDNA)
+      if allow_unicode && defined?(Addressable::IDNA)
         domain &&= Addressable::IDNA.to_ascii(domain)
       end
       labels = domain.split('.')

data/lib/can_has_validations/validators/hostname_validator.rb

@@ -12,7 +12,7 @@
 # If the addressable gem is present, will automatically turn unicode domains
 #   into their punycode (xn--) equivalent. Otherwise, unicode characters will
 #   cause the validation to fail.
-#   
+#
 # eg: validates :domain, hostname: true
 #     validates :domain, hostname: {allow_wildcard: true}
 #       allows '*.example.com'
@@ -52,7 +52,7 @@ module ActiveModel::Validations
       if defined?(Addressable::IDNA)
         value &&= Addressable::IDNA.to_ascii(value)
       end
-      labels = value.split('.')
+      labels = value.split('.', -1)
 
       is_valid = true
       is_valid &&= value.length <= 255

data/lib/can_has_validations/version.rb

@@ -1,3 +1,3 @@
 module CanHasValidations
-  VERSION = '1.7.0'
+  VERSION = '1.8.1'
 end

data/test/dummy/log/test.log

@@ -1,22 +1,14 @@
-   (1.0ms)  SELECT sqlite_version(*)
-  TRANSACTION (0.1ms)  begin transaction
+  TRANSACTION (0.0ms)  begin transaction
 ---------------------------------
 CanHasValidationsTest: test_truth
 ---------------------------------
   TRANSACTION (0.0ms)  rollback transaction
-   (0.8ms)  SELECT sqlite_version(*)
-  TRANSACTION (0.1ms)  begin transaction
+  TRANSACTION (0.0ms)  begin transaction
 ---------------------------------
 CanHasValidationsTest: test_truth
 ---------------------------------
   TRANSACTION (0.0ms)  rollback transaction
-   (0.6ms)  SELECT sqlite_version(*)
-  TRANSACTION (0.1ms)  begin transaction
----------------------------------
-CanHasValidationsTest: test_truth
----------------------------------
-  TRANSACTION (0.0ms)  rollback transaction
-  TRANSACTION (0.1ms)  begin transaction
+  TRANSACTION (0.0ms)  begin transaction
 ---------------------------------
 CanHasValidationsTest: test_truth
 ---------------------------------

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: can_has_validations
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.8.1
 platform: ruby
 authors:
 - thomas morgan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-20 00:00:00.000000000 Z
+date: 2023-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -19,7 +19,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -119,7 +119,6 @@ files:
 - test/dummy/config/routes.rb
 - test/dummy/config/storage.yml
 - test/dummy/db/test.sqlite3
-- test/dummy/log/development.log
 - test/dummy/log/test.log
 - test/dummy/public/404.html
 - test/dummy/public/422.html
@@ -147,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Assorted Rails 5.x-7.x validators
@@ -185,7 +184,6 @@ test_files:
 - test/dummy/config/storage.yml
 - test/dummy/config.ru
 - test/dummy/db/test.sqlite3
-- test/dummy/log/development.log
 - test/dummy/log/test.log
 - test/dummy/public/404.html
 - test/dummy/public/422.html

data/test/dummy/log/development.log

@@ -1,8 +0,0 @@
-DEPRECATION WARNING: Using legacy connection handling is deprecated. Please set
-`legacy_connection_handling` to `false` in your application.
-
-The new connection handling does not support `connection_handlers`
-getter and setter.
-
-Read more about how to migrate at: https://guides.rubyonrails.org/active_record_multiple_databases.html#migrate-to-the-new-connection-handling
- (called from require at script/rails:6)