can_has_validations 1.0.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98d343f6a4e3bded76cac6973926550938ba481bc9357585c3d83fb8427f48e1
-  data.tar.gz: dc5648966508e9db4ff6972475f1df6b813fa9beb7bd5b83192eb5483ad09e08
+  metadata.gz: 2c82e1883d7ee1fa1dd3a098f4f9bfd716b63321cec4b2aa4ff873351144f9fc
+  data.tar.gz: b4ab341c9a388e8e3bdcd8f10fbaa4ca1c2b7ab5f6db345ae3f7d84b65fc26b5
 SHA512:
-  metadata.gz: 4b6bf6510a992f70ffb418010bc05ae0f97ddb181c7d0482c93ff87756abac7024b8c3e9cf32caee7cfefac7a93bf60b0292475732ea9dc3a39a2009196f6893
-  data.tar.gz: 4a157d72a5ec06a71e3e07a93e4f9fa009fedc7e637b4188d7a7aad2aadb3f55b612e94f3eb3a54dcd1581874ae646f001d00efa956e31e2eb65633b5551a276
+  metadata.gz: 23684cebc4fce328fa9d9333a48332f7070c354c7876b5f0ee878917e7fdd6b2ae1256b33b99e9ed086bc1a6a323c440c4746b93851e4734182d9783ff5e22a2
+  data.tar.gz: '0941308278c6c9ea1a7b9b0a4b157b28e83bbe061a52f3dee0ffc2c9961e54f742fa7698516c02f5c8909795fe9297ec4093f744b323bb57a17c920dabaf4035'

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2012-2019 thomas morgan
+Copyright 2012-2021 thomas morgan
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -10,6 +10,7 @@ Validations provided:
 * Existence
 * Grandparent
 * Hostname
+* IP address
 * Ordering
 * URL
 * Write Once
@@ -147,6 +148,9 @@ TLD, so as to not fail as ICANN continues to add TLDs.
     # allows '_abc.example.com'
     validates :domain, hostname: {allow_underscore: true}
 
+    # allows '4.0/25.3.2.1.example.com'
+    validates :domain, hostname: {allow_slash: true}
+
     # allows 'a.example.com', but not 'example.com'
     validates :domain, hostname: {segments: 3..100}
 
@@ -158,6 +162,34 @@ TLD, so as to not fail as ICANN continues to add TLDs.
     # use 4 or 6 for ipv4 or ipv6 only
 
 
+## IP address validator ##
+
+Ensures an attribute is generally formatted as a IP or IP block.
+
+    # allows '1.2.3.4' or '::1'
+    validates :ip, ipaddr: true
+
+    # allows '1.2.3.0/24' or '2001:db8::/64'
+    validates :cidr, ipaddr: {allow_block: true}
+
+    # if an ip block, the attribute must be fully contained within an allowed block.
+    # allows '10.0.0.1' and '10.0.0.0/24', but not '10.0.0.0/15'
+    validates :private_ip, ipaddr: {
+      allow_block: true,
+      within: [IPAddr.new('10.0.0.0/16'), '127.0.0.1']
+        # allowed IPs and blocks may be IPAddrs or Strings
+    }
+
+    # the inverse of :within
+    validates :public_ip6, ipaddr: {without: ['fc00::/7']]}
+
+    # :within and :without may also be procs or method names
+    validates :ip, ipaddr: {
+      within: :some_method,
+      without: ->(record){ ... }
+    }
+
+
 ## Ordering validators ##
 
 Ensures two attribute values maintain a relative order to one another. This is
@@ -183,7 +215,7 @@ Always skips over nil values; use `:presence` to validate those.
 
 ## URL validator ##
 
-Ensure an attribute is generally formatted as a URL. If `addressable/uri` is
+Ensures an attribute is generally formatted as a URL. If `addressable/uri` is
 already loaded, it will be used to parse IDN's. Additionally, allowed schemes
 can be specified; they default to ['http','https'].
 
@@ -205,8 +237,8 @@ can be specified; they default to ['http','https'].
 
 ## Write Once validator ##
 
-Ensure that once a value is written, it becomes readonly. There are two uses
-for this. 
+Ensures that once a value is written, it becomes readonly. There are a few
+uses for this.
 
 The first is as an equivalent to `attr_readonly :user_id` except that it also
 produces a validation error instead of silently ignoring the change as
@@ -221,6 +253,10 @@ sorts.
 
     validates :user_id, allow_nil: true, write_once: true
 
+The third use is to allow a nil value, and treat the nil also as write-once.
+
+    validates :source, write_once: {immutable_nil: true}
+
 
 ## Error messages
 
@@ -232,6 +268,9 @@ Default messages are as follows:
         messages:
           invalid_email: "is an invalid email"
           invalid_hostname: "is an invalid hostname"
+          invalid_ip: "is an invalid IP"
+          ip_not_allowed: "is not an allowed IP"
+          single_ip_required: "must be a single IP"
           invalid_url: "is an invalid URL"
           unchangeable: "cannot be changed"
           before: "must be before %{attribute2}"

data/lib/can_has_validations.rb

@@ -1,6 +1,6 @@
 require 'active_model/validations'
 
-%w(array email existence grandparent hostname ordering url write_once).each do |validator|
+%w(array email existence grandparent hostname ipaddr ordering url write_once).each do |validator|
   require "can_has_validations/validators/#{validator}_validator"
 end
 

data/lib/can_has_validations/locale/en.yml

@@ -3,8 +3,10 @@ en:
     messages:
       invalid_email: "is an invalid email"
       invalid_hostname: "is an invalid hostname"
+      invalid_ip: "is an invalid IP"
+      ip_not_allowed: "is not an allowed IP"
+      single_ip_required: "must be a single IP"
       invalid_url: "is an invalid URL"
       unchangeable: "cannot be changed"
       before: "must be before %{attribute2}"
       after: "must be after %{attribute2}"
-      

data/lib/can_has_validations/validators/array_validator.rb

@@ -70,8 +70,7 @@ module ActiveModel
       private
 
       def count_errors(record)
-        # more efficient than calling record.errors.size
-        record.errors.messages.sum{|key, val| val.blank? ? 0 : val.size }
+        record.errors.count
       end
 
       def _parse_validates_options(options)

data/lib/can_has_validations/validators/email_validator.rb

@@ -1,15 +1,55 @@
 # Ensure an attribute is generally formatted as an email.
 # eg: validates :user_email, email: true
 
+require_relative 'hostname_validator'
+
 module ActiveModel::Validations
   class EmailValidator < ActiveModel::EachValidator
 
-    EMAIL_REGEXP = /\A([a-z0-9._+-]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i
+    EMAIL_REGEXP       = /\A([a-z0-9._+-]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i
+    SEGMENT_REGEXP     = /\A[a-z0-9+_-]+\z/i
+    LABEL_REGEXP       = HostnameValidator::LABEL_REGEXP
+    FINAL_LABEL_REGEXP = HostnameValidator::FINAL_LABEL_REGEXP
 
     def validate_each(record, attribute, value)
-      unless value =~ EMAIL_REGEXP
+      unless email_valid?(value)
         record.errors.add(attribute, :invalid_email, options.merge(value: value))
       end
     end
+
+    def email_valid?(value)
+      return unless value
+      recipient, domain = value.split('@', 2)
+      is_valid = true
+
+      recipient ||= ''
+      is_valid &&= recipient.length <= 255
+      is_valid &&= recipient !~ /\.\./
+      is_valid &&= !recipient.starts_with?('.') 
+      is_valid &&= !recipient.ends_with?('.') 
+      recipient.split('.').each do |segment|
+        is_valid &&= segment =~ SEGMENT_REGEXP
+      end
+
+      domain ||= ''
+      if defined?(Addressable::IDNA)
+        domain &&= Addressable::IDNA.to_ascii(domain)
+      end
+      labels = domain.split('.')
+      is_valid &&= domain.length <= 255
+      is_valid &&= domain !~ /\.\./
+      is_valid &&= labels.size.in? 2..100
+      labels.each_with_index do |label, idx|
+        is_valid &&= label.length <= 63
+        if idx+1==labels.size
+          is_valid &&= label =~ FINAL_LABEL_REGEXP
+        else
+          is_valid &&= label =~ LABEL_REGEXP
+        end
+      end
+
+      is_valid
+    end
+
   end
 end

data/lib/can_has_validations/validators/grandparent_validator.rb

@@ -16,7 +16,8 @@ module ActiveModel::Validations
         if cousin.nil?
           options[:allow_nil]
         else
-          association.send(options[:parent]) == cousin.send(options[:parent])
+          association &&
+            association.send(options[:parent]) == cousin.send(options[:parent])
         end
       end
       unless all_match

data/lib/can_has_validations/validators/hostname_validator.rb

@@ -18,6 +18,8 @@
 #       allows '*.example.com'
 #     validates :domain, hostname: {allow_underscore: true}
 #       allows '_abc.example.com'
+#     validates :domain, hostname: {allow_slash: true}
+#       allows '4.0/25.3.2.1.example.com'  # rfc2317
 #     validates :domain, hostname: {segments: 3..100}
 #       allows 'a.example.com', but not 'example.com'
 #     validates :domain, hostname: {allow_ip: true}  # or 4 or 6 for ipv4 or ipv6 only
@@ -30,9 +32,9 @@ require 'resolv'
 module ActiveModel::Validations
   class HostnameValidator < ActiveModel::EachValidator
 
-    LABEL_REGEXP = /\A([a-zA-Z0-9_]([a-zA-Z0-9_-]+)?)?[a-zA-Z0-9]\z/
-    FINAL_LABEL_REGEXP = /\A(xn--[a-zA-Z0-9]{2,}|[a-zA-Z]{2,})\z/
-    RESERVED_OPTIONS = %i(allow_ip allow_underscore allow_wildcard)
+    LABEL_REGEXP = %r{\A([a-zA-Z0-9_]([a-zA-Z0-9_/-]+)?)?[a-zA-Z0-9]\z}
+    FINAL_LABEL_REGEXP = %r{\A(xn--[a-zA-Z0-9]{2,}|[a-zA-Z]{2,})\z}
+    RESERVED_OPTIONS = %i(allow_ip allow_slash allow_underscore allow_wildcard)
 
     def validate_each(record, attribute, value)
       case options[:allow_ip]
@@ -55,6 +57,7 @@ module ActiveModel::Validations
       is_valid &&= value.length <= 255
       is_valid &&= value !~ /\.\./
       is_valid &&= value !~ /_/ unless options[:allow_underscore]
+      is_valid &&= value !~ %r{/} unless options[:allow_slash]
       is_valid &&= labels.size.in? segments
       labels.each_with_index do |label, idx|
         is_valid &&= label.length <= 63

data/lib/can_has_validations/validators/ipaddr_validator.rb

@@ -0,0 +1,91 @@
+# Ensure an attribute is generally formatted as a IP or IP block.
+# eg: validates :ip, ipaddr: true
+#     validates :cidr, ipaddr: {allow_block: true}
+#     validates :private_ip, ipaddr: {within: [IPAddr.new('10.0.0.0/8'), '127.0.0.1']}
+#       ip must be within any one of the provided ips/blocks
+#       if ip is block, it must be fully contained within any one of the provided blocks
+#     validates :public_ip6, ipaddr: {without: ['fc00::/7']]}
+#       ip must be outside all of the provided ips/blocks
+#       if ip is block, it must be fully outside all of the provided blocks
+
+require 'ipaddr'
+
+module ActiveModel::Validations
+  class IpaddrValidator < ActiveModel::EachValidator
+
+    def initialize(options)
+      options[:within]  = normalize_within options[:within], :within
+      options[:without] = normalize_within options[:without], :without
+      super
+    end
+
+    def validate_each(record, attribute, value)
+      allowed_ips    = resolve_array record, options[:within]
+      disallowed_ips = resolve_array record, options[:without]
+
+      ip = case value
+        when IPAddr
+          ip
+        when String
+          IPAddr.new(value) rescue nil
+      end
+      unless ip
+        record.errors.add(attribute, :invalid_ip, options.merge(value: value))
+        return
+      end
+
+      if !options[:allow_block] && (ip.ipv4? && ip.prefix!=32 or ip.ipv6? && ip.prefix!=128)
+        record.errors.add(attribute, :single_ip_required, options.merge(value: value))
+      end
+      if allowed_ips && allowed_ips.none?{|blk| blk.include? ip}
+        record.errors.add(attribute, :ip_not_allowed, options.merge(value: value))
+      elsif disallowed_ips && disallowed_ips.any?{|blk| blk.include? ip}
+        record.errors.add(attribute, :ip_not_allowed, options.merge(value: value))
+      end
+    end
+
+
+    private
+
+    def normalize_within(val, key)
+      if val.nil? || val.respond_to?(:call) || val.is_a?(Symbol)
+        val
+      else
+        Array(val).flatten.map do |i|
+          case i
+          when IPAddr
+            i
+          when String
+            IPAddr.new i
+          else
+            raise "Unexpected value for #{key.inspect} : #{i}"
+          end
+        end
+      end
+    end
+
+    def resolve_array(record, val)
+      res = if val.respond_to?(:call)
+        val.call(record)
+      elsif val.is_a?(Symbol)
+        record.send(val)
+      else
+        val
+      end
+    end
+
+  end
+end
+
+# tests for & fixes broken IPAddr <= 1.2.2
+if IPAddr.new('192.168.2.0/32').include? '192.168.2.0/24'
+  # warn 'IPAddr <= 1.2.2 is broken; monkey-patching'
+  class IPAddr
+    def include?(other)
+      range = to_range
+      other = coerce_other(other).to_range
+      range.begin <= other.begin && range.end >= other.end
+    end
+    alias === include?
+  end
+end

data/lib/can_has_validations/validators/write_once_validator.rb

@@ -12,14 +12,20 @@ module ActiveModel::Validations
     #   nil to be allowed. prevent this.
     def validate(record)
       attributes.each do |attribute|
-        value = record.read_attribute_for_validation(attribute)
-        validate_each(record, attribute, value)
+        validate_each(record, attribute, nil)
       end
     end
 
-    def validate_each(record, attribute, value)
-      if record.persisted? && record.send("#{attribute}_changed?")
-        if options[:immutable_nil] || !record.send("#{attribute}_was").nil?
+    def validate_each(record, attribute, _)
+      return unless record.persisted?
+      if !record.respond_to?("#{attribute}_changed?") && record.respond_to?("#{attribute}_id_changed?")
+        attr2 = "#{attribute}_id"
+      else
+        attr2 = attribute
+      end
+      if record.send("#{attr2}_changed?")
+        if options[:immutable_nil] || !record.send("#{attr2}_was").nil?
+          value = record.read_attribute_for_validation(attribute)
           record.errors.add(attribute, :unchangeable, options.except(:immutable_nil).merge!(value: value))
         end
       end

data/lib/can_has_validations/version.rb

@@ -1,3 +1,3 @@
 module CanHasValidations
-  VERSION = '1.0.0'
+  VERSION = '1.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: can_has_validations
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.1
 platform: ruby
 authors:
 - thomas morgan
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-16 00:00:00.000000000 Z
+date: 2021-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -19,7 +19,7 @@ dependencies:
         version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '6.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '6.2'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -44,7 +44,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Assorted Rails 5.x-6.x validators.
+description: 'Assorted Rails 5.x-6.x validators: Array, Email, Existence, Grandparent,
+  Hostname, IP address, Ordering, URL, Write Once'
 email:
 - tm@iprog.com
 executables: []
@@ -61,6 +62,7 @@ files:
 - lib/can_has_validations/validators/existence_validator.rb
 - lib/can_has_validations/validators/grandparent_validator.rb
 - lib/can_has_validations/validators/hostname_validator.rb
+- lib/can_has_validations/validators/ipaddr_validator.rb
 - lib/can_has_validations/validators/ordering_validator.rb
 - lib/can_has_validations/validators/url_validator.rb
 - lib/can_has_validations/validators/write_once_validator.rb
@@ -98,9 +100,10 @@ files:
 - test/dummy/script/rails
 - test/test_helper.rb
 homepage: https://github.com/zarqman/can_has_validations
-licenses: []
+licenses:
+- MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -115,8 +118,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: Assorted Rails 5.x-6.x validators
 test_files: