can_has_state 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b2d2008ba870961e06cebe22f027b133b46c5f078315938c9338edfd99678f5
-  data.tar.gz: 2d4e7dbfd0bb896e01dfdaf66933b3b483f71915579f5d66d42fde1cbd0416de
+  metadata.gz: 516a5676e62907d7868c5a0812c760e292b87c8c785cb246c5eb3bd2db2d7a41
+  data.tar.gz: 1e4b230a4a4c933b1db2884b2f7490439c9fb2f4f18b1ee686286decc2640903
 SHA512:
-  metadata.gz: 9e18bb675dd1acc0b84bb8539f67ca9c483f7ff618927b9baef5cdc738ba7a723cac0cccbaed68dfd0291925a2af5a8cda4ebf22b250ead0d39d813e389ecd86
-  data.tar.gz: 2cc03d656532de9061758242d7daaab074f979665323a071d432b1c220e050951da7750ca6f38c5ef1c8e1e4633f76ce16bd8f404fbe9e5e31ba8fe0a6426f17
+  metadata.gz: cb9ef6c65385ef382a01d9f73c40da6217136f9939fea20eb6aae0183ce57f492e119302fc560f9273b2f6c2933cde3fa2c50daf3e0f13d038cf19dbfa377d5b
+  data.tar.gz: f1aee70c43b00b6ae153c63583db1d1bf4bd9adb072fa4b5adf33eecd1b4f3c1668aa1aba54438b296158ad858475a1d52333ce95f0e2e9959d1d1fb8b7d499b

data/lib/can_has_state/machine.rb

@@ -111,23 +111,23 @@ module CanHasState
       end
     end
 
-    def can_has_state_errors
-      err = {}
+    def can_has_state_errors(reset: true)
+      @can_has_state_errors = {} if reset || !@can_has_state_errors
       state_machines.each do |column, sm|
         from, to = send("#{column}_was"), send(column)
         if !sm.known?(to)
-          err[column] = [:invalid_state]
+          @can_has_state_errors[column] = [:invalid_state]
         elsif from == to
           next
         elsif !sm.allow?(self, to) #state_machine_allow?(column, to)
-          err[column] = [sm.message(to), {from: "'#{from}'", to: "'#{to}'"}]
+          @can_has_state_errors[column] = [sm.message(to), {from: "'#{from}'", to: "'#{to}'"}]
         end
       end
-      err
+      @can_has_state_errors
     end
 
     def validate_state_machines
-      can_has_state_errors.each do |column, (msg, opts)|
+      can_has_state_errors(reset: false).each do |column, (msg, opts)|
         errors.add column, msg, **(opts||{})
       end
     end

data/lib/can_has_state/version.rb

@@ -1,3 +1,3 @@
 module CanHasState
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/test/can_has_state_test.rb

@@ -406,6 +406,74 @@ class CanHasStateTest < Minitest::Test
   end
 
 
+  def test_errors_resolved_in_later_callback_are_kept
+    # Triggers are skipped when the state_machine has validation errors.
+    # Whether or not to skip is decided in an early before_validation callback.
+    # Even if a later callback resolves the validation error, it's important to
+    # still bubble up the errors since triggers did not run.
+    kl = build_from_skeleton do
+      attr_accessor :have_beans, :coffee_in_hand
+      extend_state_machine :state do
+        state :incredible,
+          require: proc{ coffee_in_hand > 0 }
+      end
+      before_validation { self.coffee_in_hand += 1 if have_beans }
+      def initialize
+        @coffee_in_hand = 0
+      end
+    end
+    m = kl.new
+    m.state = 'incredible'
+    refute m.valid?
+    assert m.errors.of_kind?(:state, :invalid_transition)
+    assert_equal 0, m.coffee_in_hand
+
+    m = kl.new
+    m.have_beans = true
+    m.state = 'incredible'
+    refute m.valid?
+    assert m.errors.of_kind?(:state, :invalid_transition)
+    assert_equal 1, m.coffee_in_hand
+  end
+
+  def test_rerunning_triggers_clears_pre_callback_errors
+    # To resolve the issue above, it is possible to re-eval the state_machine
+    # and run triggers if validations now pass. This is highly discouraged as
+    # complex callback callback interactions like this should be refactored out
+    # if at all possible.
+    # Not an officially supported solution and subject to change, but
+    # documented here to show that it is (presently) possible.
+    kl = build_from_skeleton do
+      attr_accessor :have_beans, :coffee_in_hand, :we_are_incredible
+      extend_state_machine :state do
+        state :incredible,
+          require: proc{ coffee_in_hand > 0 },
+          on_enter: proc{ self.we_are_incredible = true }
+      end
+      before_validation do
+        self.coffee_in_hand += 1 if have_beans
+        run_state_triggers
+      end
+      def initialize
+        @coffee_in_hand = 0
+      end
+    end
+    m = kl.new
+    m.state = 'incredible'
+    refute m.valid?
+    assert m.errors.of_kind?(:state, :invalid_transition)
+    assert_equal 0, m.coffee_in_hand
+    refute m.we_are_incredible
+
+    m = kl.new
+    m.have_beans = true
+    m.state = 'incredible'
+    assert m.valid?
+    assert_equal 1, m.coffee_in_hand
+    assert m.we_are_incredible
+  end
+
+
 
   def build_from_skeleton(&block)
     Class.new(Skeleton).tap do |kl|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: can_has_state
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - thomas morgan