camunda-workflow 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c08d0a47fdc375095f8a12a412e8fd338cba6c01de753777a2c007a184d6caa
-  data.tar.gz: 34141274cb6a630312651883a7502819e9b236fb870275a82d9561f4adae6561
+  metadata.gz: 258061e8801a974e302c84e184e90c60771aea045ac8ac51bd92afdcbfc4acc9
+  data.tar.gz: 9aa801c96ff96951ce08f7ed35d69d36772b9122aa4ac51addf62979ad7b63d5
 SHA512:
-  metadata.gz: aa811d101d80ea3e5bd6408c17e28215118a2c223d469bb9e60a7f8ad5ebcc991264fb3f19cd31a2a6f5fccc8f5e085220e04421fd4fa183327297fb18a28535
-  data.tar.gz: 833f866515b6555a0e05f893aef5d3a6603b6f933708ed5b77641fb8d9b4db4b06935bb632ef04973097a013fdc7a35858a0d1d8d918f3f0c680f616f4ca1c29
+  metadata.gz: 8e77b9f038bad10d3e3606a4dc9ee3e594c050006dcaa0018733f41fc3f37d13db6392d3e76b15e1b88362b6623433e8495e664fa294e9197db849da7d71598e
+  data.tar.gz: 3769a359d104c320094b44a33b4145caa7d36cf4b96b5054d6df452325973ea0ec4efc3903ef180488bf112e90c3840fa94ca95f72ca2db97ac515a646d7e546

data/CHANGELOG.md

@@ -6,6 +6,7 @@
 
 **Merged pull requests:**
 
+- Correct find\_by\_business\_key\_and\_task\_definition\_key! [\#5](https://github.com/amalagaura/camunda-workflow/pull/5) ([amalagaura](https://github.com/amalagaura))
 - added authentication via templates for spring\_boot generator and Her [\#4](https://github.com/amalagaura/camunda-workflow/pull/4) ([curatingbits](https://github.com/curatingbits))
 - Refactor to return proper Her models after responses [\#3](https://github.com/amalagaura/camunda-workflow/pull/3) ([amalagaura](https://github.com/amalagaura))
 - Added tests for Camunda workflow [\#2](https://github.com/amalagaura/camunda-workflow/pull/2) ([curatingbits](https://github.com/curatingbits))

data/lib/camunda/external_task.rb

@@ -17,11 +17,11 @@ class Camunda::ExternalTask < Camunda::Model
     Camunda::Workflow.configuration.lock_duration.in_milliseconds
   end
 
-  def failure(exception, input_variables)
-    variables_information = "Input variables are #{input_variables.inspect}\n\n"
+  def failure(exception, input_variables={})
+    variables_information = "Input variables are #{input_variables.inspect}\n\n" if input_variables.present?
     self.class.post_raw("#{collection_path}/#{id}/failure",
                         workerId: worker_id, errorMessage: exception.message,
-                        errorDetails: variables_information + exception.full_message)[:response]
+                        errorDetails: variables_information.to_s + exception.full_message)[:response]
   end
 
   def bpmn_error(bpmn_exception)
@@ -33,6 +33,9 @@ class Camunda::ExternalTask < Camunda::Model
   def complete(variables={})
     self.class.post_raw("#{collection_path}/#{id}/complete",
                         workerId: worker_id, variables: serialize_variables(variables))[:response]
+        .tap do |response|
+      raise SubmissionError, response.body[:data][:message] unless response.success?
+    end
   end
 
   def worker_id
@@ -80,4 +83,7 @@ class Camunda::ExternalTask < Camunda::Model
       raise Camunda::MissingImplementationClass, task_class_name unless klass
     end
   end
+
+  class SubmissionError < StandardError
+  end
 end

data/lib/camunda/external_task_job.rb

@@ -7,6 +7,9 @@ module Camunda::ExternalTaskJob
     report_completion id, output_variables
   rescue Camunda::BpmnError => e
     report_bpmn_error id, e
+  rescue Camunda::ExternalTask::SubmissionError => e
+    # We re-raise this so it is not rescued below
+    raise e
   rescue StandardError => e
     report_failure id, e, input_variables
   end

data/lib/camunda/poller.rb

@@ -2,7 +2,11 @@ class Camunda::Poller
   def self.fetch_and_execute(topics, lock_duration: nil, long_polling_duration: nil)
     loop do
       Camunda::ExternalTask
-        .fetch_and_lock(topics, lock_duration: lock_duration, long_polling_duration: long_polling_duration).each(&:queue_task)
+        .fetch_and_lock(topics, lock_duration: lock_duration, long_polling_duration: long_polling_duration).each do |task|
+        task.queue_task
+      rescue Camunda::MissingImplementationClass => e
+        task.failure(e)
+      end
     end
   end
 end

data/lib/camunda/task.rb

@@ -14,10 +14,13 @@ class Camunda::Task < Camunda::Model
   def complete!(vars={})
     self.class.post_raw("#{self.class.collection_path}/#{id}/complete", variables: serialize_variables(vars))[:response]
         .tap do |response|
-      raise MissingTask unless response.success?
+      raise SubmissionError, response.body[:data][:message] unless response.success?
     end
   end
 
   class MissingTask < StandardError
   end
+
+  class SubmissionError < StandardError
+  end
 end

data/lib/camunda/workflow/version.rb

@@ -1,5 +1,5 @@
 module Camunda
   module Workflow
-    VERSION = '0.1.2'.freeze
+    VERSION = '0.1.3'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: camunda-workflow
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Ankur Sethi
@@ -129,14 +129,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.75.1
+        version: '0.77'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.75.1
+        version: '0.77'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.37.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.37.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement