callstacking-rails 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3aa23402f8e1518b61f61a8e08c4005e770e4ce82224ec41fb4bcb6b95508dd
-  data.tar.gz: 907f3f6bf310fcd6965385c47962921b2d82bcd4c1f141ceafd9d0e12b2b3ae9
+  metadata.gz: 88265ec5da1ad5e4b040bffdb034f0abb9ff11ba7485839b1c565c774dd612ab
+  data.tar.gz: a21ca44694d8b92e2ecba34523adc33ba1bb72c0e0d1cfdb364ba268fa1107e0
 SHA512:
-  metadata.gz: 8074f647ccc9acd05dd37f00ac690ffce7f3f3d4cb7007c853e671ce43a2837e433500185d0b443403f77e7392bde0d3a9f451e1d830974e73a25c0419950562
-  data.tar.gz: d54423cf2f7f8e4fe0f42accb36c477463d0642a482ea18f56585a835f9af812d6d4e2211f6a06b863f7850b83fcbd6c1ab5ec9cc351d0481f7896174154f8dc
+  metadata.gz: 99dcba1223722f85f50fb89200c408d81720028b3f7e6b9291d4a73dae5e1449a9c2152ff6baf07f890be0d718b0df1038f3c5d4b2011cce101cb56742ace0ee
+  data.tar.gz: a545aec1de30363f71eeb4831424d65f2841292c894a50ba7d1859f820306307e2f66ec4f5a5ccade2bda14b439f1a24b40df3d57de9ede4aaa34a75bc243f5d

data/README.md

@@ -74,12 +74,12 @@ Opens a browser window to register as a callstacking.com user.
 > callstacking-rails setup
 
 Interactively prompts you for your callstacking.com username/password.
-Stores auth details in `~/.callstacking-rails`.
+Stores auth details in `~/.callstacking`.
 
 You can have multiple environments.
 The default is `development`.
 
-The `development:` section in the `~/.callstacking-rails` config contains your credentials.
+The `development:` section in the `~/.callstacking` config contains your credentials.
 
 By setting the RAILS_ENV environment you can maintain multiple settings.
 

data/lib/callstacking/rails/instrument.rb

@@ -36,7 +36,9 @@ module Callstacking
           spans = tmp_module.instance_variable_get(:@spans)
           klass = tmp_module.instance_variable_get(:@klass)
 
-          spans.call_entry(klass, method_name, p || path, l || line_no)
+          arguments = Callstacking::Rails::Instrument.arguments_for(method(__method__).super_method, args)
+          
+          spans.call_entry(klass, method_name, arguments, p || path, l || line_no)
           return_val = super(*args, &block)
           spans.call_return(klass, method_name, p || path, l || line_no, return_val)
 
@@ -68,6 +70,16 @@ module Callstacking
         relevant.each { |method| instrument_method(method, application_level: application_level) }
       end
 
+      def self.arguments_for(m, args)
+        param_names = m.parameters&.map(&:last)
+        return {} if param_names.nil?
+
+        param_names.map.with_index do |param, index|
+          next if [:&, :*, :**].include?(param)
+          [param, args[index]]
+        end.compact.to_h
+      end
+
       private
 
       def all_methods

data/lib/callstacking/rails/settings.rb

@@ -11,7 +11,7 @@ module Callstacking
         attr_accessor :settings
       end
 
-      SETTINGS_FILE = "#{Dir.home}/.callstacking-rails"
+      SETTINGS_FILE = "#{Dir.home}/.callstacking"
       PRODUCTION_URL = "https://callstacking.com"
 
       def url

data/lib/callstacking/rails/spans.rb

@@ -20,10 +20,10 @@ module Callstacking
         @nesting_level
       end
 
-      def call_entry(klass, method_name, path, line_no)
+      def call_entry(klass, method_name, arguments, path, line_no)
         @nesting_level+=1
         @previous_entry = previous_event(klass, method_name)
-        @call_entry_callback.call(@nesting_level, increment_order_num, klass, method_name, path, line_no)
+        @call_entry_callback.call(@nesting_level, increment_order_num, klass, method_name, arguments, path, line_no)
       end
 
       def call_return(klass, method_name, path, line_no, return_val)
@@ -40,25 +40,6 @@ module Callstacking
         @call_return_callback = block
       end
 
-      def arguments_for(trace)
-        param_names = trace&.parameters&.map(&:last)
-        return {} if param_names.nil?
-
-        param_names.map do |param|
-          next if [:&, :*, :**].include?(param)
-          [param, trace.binding.local_variable_get(param.to_s)]
-        end.compact.to_h
-      end
-
-      def locals_for(trace)
-        local_names = trace&.binding&.local_variables
-        return {} if local_names.nil?
-
-        local_names.map do |local|
-          [local, trace.binding.local_variable_get(local)]
-        end.to_h
-      end
-
       private
       def previous_event(klass, method_name)
         "#{klass}:#{method_name}"

data/lib/callstacking/rails/trace.rb

@@ -41,8 +41,8 @@ module Callstacking
           create_message(start_request_message(payload), spans.increment_order_num, @traces)
         end
 
-        @spans.on_call_entry do |nesting_level, order_num, klass, method_name, path, line_no|
-          create_call_entry(nesting_level, order_num, klass, method_name, path, line_no, @traces)
+        @spans.on_call_entry do |nesting_level, order_num, klass, method_name, arguments, path, line_no|
+          create_call_entry(nesting_level, order_num, klass, method_name, arguments, path, line_no, @traces)
         end
 
         @spans.on_call_return do |coupled_callee, nesting_level, order_num, klass, method_name, path, line_no, return_val|
@@ -82,13 +82,13 @@ module Callstacking
         end
       end
 
-      def create_call_entry(nesting_level, order_num, klass, method_name, path, line_no, traces)
+      def create_call_entry(nesting_level, order_num, klass, method_name, arguments, path, line_no, traces)
         lock.synchronize do
           traces << { trace_entry: { trace_entryable_type: 'TraceCallEntry',
                                      order_num: order_num,
                                      nesting_level: nesting_level,
                                      trace_entryable_attributes: {
-                                       #args: arguments_for(t),
+                                       args: arguments,
                                        klass: klass_name(klass),
                                        line_number: line_no,
                                        path: path,

data/lib/callstacking/rails/traces_helper.rb

@@ -15,11 +15,11 @@ module Callstacking
 
         body = []
         body << (content_tag( :div, data: { turbo:false },
-                    style: 'background-color: #FFF; font-size: 20pt; top: 50%; right: 10px; font-size: 36pt;
+                    style: 'top: 50%; right: 10px; font-size: 24pt; :hover{text-shadow: 1px 1px 2px #000000};
                             padding: 0px; position: fixed; height: 50px; width: 40px; cursor: pointer;',
                     onclick: 'document.getElementById("callstacking-debugger").style.display = "unset";
                               document.getElementById("callstacking-close").style.display = "unset";') do
-          "<<"
+          "💥"
         end)
         
         body << (content_tag(:iframe, src: frame_url, id: 'callstacking-debugger', data: { turbo:false },

data/lib/callstacking/rails/version.rb

@@ -1,5 +1,5 @@
 module Callstacking
   module Rails
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: callstacking-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jim Jones
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-19 00:00:00.000000000 Z
+date: 2023-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -52,7 +52,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Rolling debugger that shows the full state of each call.
+description: Quickly visualize which methods call which, their parameters, and return
+  values.
 email:
 - jim.jones1@gmail.com
 executables:
@@ -111,5 +112,6 @@ requirements: []
 rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
-summary: Rolling debugger that shows the full state of each call per request.
+summary: Quickly visualize which methods call which, their parameters, and return
+  values.
 test_files: []