callcredit 0.3.3 → 0.3.4

data/spec/request_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 
 describe Callcredit::Request do
+  before { configure_callcredit }
   let(:request) { Callcredit::Request.new(connection, config) }
-  let(:config) { Callcredit::Config.new }
+  let(:config) { Callcredit.config }
   let(:connection) { Callcredit::Client.new(config).send(:connection) }
 
   let(:response_hash) { { status: status, body: body } }
@@ -10,20 +11,35 @@ describe Callcredit::Request do
   let(:body) { "<Results><Errors/></Results>" }
   before { stub_request(:get, config[:api_endpoint]).to_return(response_hash) }
 
-  let(:check_data) { { personal_data: { date_of_birth: date_of_birth } } }
+  let(:check_data) do
+    { personal_data: {
+        first_name: "Grey",
+        last_name: "Baker",
+        date_of_birth: date_of_birth,
+        postcode: "EC2A 1DX",
+        building_number: "22-25"
+      }
+    }
+  end
+
   let(:date_of_birth) { "01/01/2000" }
 
   describe '#build_request_xml' do
-    subject(:build_request_xml) do
-      request.build_request_xml(:id_enhanced, check_data).to_s
+    subject(:request_xml) do
+      request.build_request_xml(:id_enhanced, check_data)
     end
-    let(:request_xml) { load_fixture('request.xml') }
+    let(:xml_schema) { load_fixture('request.xsd') }
+    let(:xsd) { Nokogiri::XML::Schema(xml_schema) }
 
-    it { should == request_xml }
+    it "generates a valid XML request" do
+      xsd.validate(request_xml).should == []
+    end
 
     context "with a date object for date_of_birth" do
       let(:date_of_birth) { Date.parse("01/01/2000") }
-      it { should == request_xml }
+      it "generates a valid XML request" do
+        xsd.validate(request_xml).should == []
+      end
     end
   end
 

data/spec/spec_helper.rb

@@ -3,7 +3,12 @@ require 'webmock/rspec'
 RSpec.configure { |config| config.include WebMock::API }
 
 def configure_callcredit
-  Callcredit.configure { |config| config[:first_name] = "Grey" }
+  Callcredit.configure do |config|
+    config[:company] = "GoCardless"
+    config[:username] = "Username"
+    config[:password] = "Password"
+    config[:application_name] = "Application"
+  end
 end
 
 def load_fixture(*filename)

data/spec/validations_spec.rb

@@ -0,0 +1,108 @@
+require 'spec_helper'
+
+describe Callcredit::Validations do
+  let(:check_data) do
+    { personal_data: {
+        first_name: "Grey",
+        last_name: "Baker",
+        date_of_birth: date_of_birth,
+        postcode: "EC2A 1DX",
+        building_number: "22-25"
+      }
+    }
+  end
+  let(:date_of_birth) { "01/01/2000" }
+
+  describe '#clean_date_of_birth' do
+    subject { Callcredit::Validations.clean_date_of_birth(date_of_birth) }
+
+    context "with a date object" do
+      let(:date_of_birth) { Date.parse("01/01/2000") }
+      it { should == date_of_birth.strftime("%d/%m/%Y") }
+    end
+
+    context "with a parseable string" do
+      let(:date_of_birth) { "01-01-2000" }
+      it { should == "01/01/2000" }
+    end
+
+    context "with a load of rubbish" do
+      let(:date_of_birth) { "A couple of weeks ago" }
+      it "raises an error" do
+        expect { subject }.to raise_error Callcredit::InvalidRequestError
+      end
+    end
+  end
+
+  describe '#clean_first_name' do
+    subject { Callcredit::Validations.clean_first_name(first_name) }
+
+    context "without a first name" do
+      let(:first_name) { nil }
+      it "raises an error" do
+        expect { subject }.to raise_error Callcredit::InvalidRequestError
+      end
+    end
+
+    context "with a simple first name" do
+      let(:first_name) { "Grey" }
+      it { should == first_name }
+    end
+
+    context "with a first name with non-ASCII characters" do
+      let(:first_name) { "Gréy" }
+      it { should == "Grey" }
+    end
+
+    context "without a very long first name" do
+      let(:first_name) { "A" * 31 }
+      it "raises an error" do
+        expect { subject }.to raise_error Callcredit::InvalidRequestError
+      end
+    end
+
+    context "without a first name with numbers in it" do
+      let(:first_name) { "David the 3rd" }
+      it "raises an error" do
+        expect { subject }.to raise_error Callcredit::InvalidRequestError
+      end
+    end
+  end
+
+  describe '#clean_middle_names' do
+    subject { Callcredit::Validations.clean_middle_names(name) }
+
+    context "without a middle name" do
+      let(:name) { nil }
+      it { should == nil }
+    end
+  end
+
+  describe '#clean_postcode' do
+    subject { Callcredit::Validations.clean_postcode(postcode) }
+
+    context "without a post code" do
+      let(:postcode) { nil }
+      it "raises an error" do
+        expect { subject }.to raise_error Callcredit::InvalidRequestError
+      end
+    end
+
+    context "with a correct post code" do
+      let(:postcode) { "EC2A 1DX" }
+      it { should == postcode }
+    end
+
+    context "with a padded post code" do
+      let(:postcode) { "EC2A 1DX    " }
+      it { should == "EC2A 1DX" }
+    end
+
+    context "with a postcode that is too short" do
+      let(:postcode) { "N1" }
+      it "raises an error" do
+        expect { subject }.to raise_error Callcredit::InvalidRequestError
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: callcredit
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-19 00:00:00.000000000 Z
+date: 2014-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -66,6 +66,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
+- !ruby/object:Gem::Dependency
+  name: unidecoder
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.1.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.1.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -120,18 +134,20 @@ files:
 - lib/callcredit/request.rb
 - lib/callcredit/response.rb
 - lib/callcredit/util.rb
+- lib/callcredit/validations.rb
 - lib/callcredit/version.rb
 - spec/callcredit_spec.rb
 - spec/checks/id_enhanced_spec.rb
 - spec/client_spec.rb
 - spec/fixtures/access_denied.xml
 - spec/fixtures/bad_request.xml
-- spec/fixtures/request.xml
+- spec/fixtures/request.xsd
 - spec/fixtures/response.xml
 - spec/fixtures/system_call_failure.xml
 - spec/request_spec.rb
 - spec/response_spec.rb
 - spec/spec_helper.rb
+- spec/validations_spec.rb
 homepage: https://github.com/gocardless/callcredit-ruby
 licenses: []
 metadata: {}
@@ -161,9 +177,10 @@ test_files:
 - spec/client_spec.rb
 - spec/fixtures/access_denied.xml
 - spec/fixtures/bad_request.xml
-- spec/fixtures/request.xml
+- spec/fixtures/request.xsd
 - spec/fixtures/response.xml
 - spec/fixtures/system_call_failure.xml
 - spec/request_spec.rb
 - spec/response_spec.rb
 - spec/spec_helper.rb
+- spec/validations_spec.rb

data/spec/fixtures/request.xml

@@ -1,50 +0,0 @@
-<?xml version="1.0"?>
-<callvalidate>
-  <authentication>
-    <company/>
-    <username/>
-    <password/>
-  </authentication>
-  <sessions>
-    <session>
-      <data>
-        <ChecksRequired>
-          <BankStandard>no</BankStandard>
-          <BankEnhanced>no</BankEnhanced>
-          <CardLive>no</CardLive>
-          <CardEnhanced>no</CardEnhanced>
-          <IDEnhanced>yes</IDEnhanced>
-          <NCOAAlert>no</NCOAAlert>
-          <CallValidate3D>no</CallValidate3D>
-          <TheAffordabilityReport>no</TheAffordabilityReport>
-          <DeliveryFraud>no</DeliveryFraud>
-          <EmailValidate>no</EmailValidate>
-          <CreditScore>no</CreditScore>
-          <Zodiac>no</Zodiac>
-          <IPAddress>no</IPAddress>
-          <BankAccountPlus>no</BankAccountPlus>
-          <BankOFA>no</BankOFA>
-          <CardOFA>no</CardOFA>
-        </ChecksRequired>
-        <Personal>
-          <Individual>
-            <Dateofbirth>01/01/2000</Dateofbirth>
-            <Title>Unknown</Title>
-            <Firstname/>
-            <Othernames/>
-            <Surname/>
-            <Phonenumber/>
-            <Drivinglicensenumber/>
-          </Individual>
-          <Address>
-            <Buildingnumber/>
-            <Buildingname/>
-            <Address1/>
-            <Postcode/>
-          </Address>
-        </Personal>
-      </data>
-    </session>
-  </sessions>
-  <application/>
-</callvalidate>