callcredit 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d41d5aaa1a9fdb9f23a7b104f235102e2d93bbde
-  data.tar.gz: ea69cb9394e2c66e77b25ba6034ddec764c99974
+  metadata.gz: c6fd66f12894e3525ef98fd4192476f407c8b163
+  data.tar.gz: f82113873639cb39ed16a22b8aeeaa7623ff7a07
 SHA512:
-  metadata.gz: d3feaa1b7f4d7e3ba4837a8a36a6e300338ad6a79334bf2f2b0272878b4798f01154c392c2781710cefd53d0258f250899fbd2e3607b9e7ef3f5640b54642844
-  data.tar.gz: 4fb33f55e7429dd3a541f6b8d58eb33824dc9481c5d8867b1c2ad520362761ac12bba866fc4a6749cb41db9df5a3e97323506efd221fd032b88ea913b0c1d666
+  metadata.gz: 5b67b4c59f4de25e394bd99a378f756b2896d51e98d676376a5cdfc1a1b251f45dfa828c9af8b1b1bbac1cc8769439c6cd6187c2a2ab8a43e0d05cbb38a1f994
+  data.tar.gz: 78e6accb62801e823ad54f27819142ad75c26215bad8104b4cc202b52c92d865ebca50a1531236993473a4d6f00c54bf7e449ab334c1a9426ca642c31652c9f0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.3 - February 19, 2014
+
+- Handle errors from Callcredit that aren't name-spaced to a module
+
 ## 0.3.2 - February 11, 2014
 
 - Allow a title to be passed as personal data. Specify "Unknown" if not

data/lib/callcredit/middleware/check_response.rb

@@ -9,8 +9,8 @@ module Callcredit
 
           if results["Errors"]
             errors = results["Errors"].values.flatten
-            message = errors.map { |e| e["__content__"] }.join(" | ")
-            raise APIError.new(message, env[:status], env)
+            messages = errors.map { |e| e.is_a?(Hash) ? e["__content__"] : e }
+            raise APIError.new(messages.join(" | "), env[:status], env)
           end
           response_values(env)
         end

data/lib/callcredit/response.rb

@@ -1,3 +1,5 @@
+require 'ostruct'
+
 module Callcredit
   class Response
     def initialize(response_data)

data/lib/callcredit/version.rb

@@ -1,3 +1,3 @@
 module Callcredit
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.3.3'.freeze
 end

data/spec/checks/id_enhanced_spec.rb

@@ -7,17 +7,8 @@ describe Callcredit::Checks::IDEnhanced do
 
   let(:response_hash) { { status: status, body: body } }
   let(:status) { 200 }
-  let(:body) do
-    "<Results>
-      <Result>
-        <Displays>
-          <InputData/>
-          <IdentityCheck/>
-        </Displays>
-      </Result>
-      <Errors/>
-    </Results>"
-  end
+  let(:body) { response_xml }
+  let(:response_xml) { load_fixture('response.xml') }
   before { stub_request(:get, config[:api_endpoint]).to_return(response_hash) }
 
   describe "#perform" do

data/spec/fixtures/request.xml

@@ -29,7 +29,7 @@
         <Personal>
           <Individual>
             <Dateofbirth>01/01/2000</Dateofbirth>
-            <Title>Mr</Title>
+            <Title>Unknown</Title>
             <Firstname/>
             <Othernames/>
             <Surname/>

data/spec/fixtures/response.xml

@@ -0,0 +1,98 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Results xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="C:/tac/Customer-Output-V4-5-3.xsd" APIVERSION="4.5.3 - 20131119">
+  <Result RID="" PID="LTJ-CT2-1606-13927-46399" DateTime="18-02-2014 18:00">
+    <Displays>
+      <ChecksCompleted>
+        <BankStandard>no</BankStandard>
+        <BankEnhanced>no</BankEnhanced>
+        <CardLive>no</CardLive>
+        <CardEnhanced>no</CardEnhanced>
+        <IDEnhanced>yes</IDEnhanced>
+        <NCOAAlert>no</NCOAAlert>
+        <CallValidate3D>no</CallValidate3D>
+        <TheAffordabilityReport>no</TheAffordabilityReport>
+        <DeliveryFraud>no</DeliveryFraud>
+        <EmailValidate>no</EmailValidate>
+        <CreditScore>no</CreditScore>
+        <Zodiac>no</Zodiac>
+        <IPAddress>no</IPAddress>
+        <BankAccountPlus>no</BankAccountPlus>
+        <BankOFA>no</BankOFA>
+        <CardOFA>no</CardOFA>
+      </ChecksCompleted>
+      <InputData>
+        <Individual>
+          <Dateofbirth>01/01/1901</Dateofbirth>
+          <Title>Mr</Title>
+          <Firstname>Grey</Firstname>
+          <Surname>Baker</Surname>
+        </Individual>
+        <Address>
+          <Buildingnumber>1</Buildingnumber>
+          <Postcode>EX8M PLE</Postcode>
+        </Address>
+      </InputData>
+      <IdentityCheck>
+        <appverified>Yes</appverified>
+        <matchlevel>IndividualReport</matchlevel>
+        <ervalid>4</ervalid>
+        <levelofconfidenceer>-4</levelofconfidenceer>
+        <levelofconfidencedob>3</levelofconfidencedob>
+        <levelofconfidenceshare>3</levelofconfidenceshare>
+        <levelofconfidenceccjs>0</levelofconfidenceccjs>
+        <levelofconfidencebai>0</levelofconfidencebai>
+        <levelofconfidenceinvestors>0</levelofconfidenceinvestors>
+        <confirmatorydobs>2</confirmatorydobs>
+        <totaldobs>3</totaldobs>
+        <numprimarychecks>4</numprimarychecks>
+        <numcorroborativechecks>1</numcorroborativechecks>
+        <numprimaryotheridsconfirmed>0</numprimaryotheridsconfirmed>
+        <numccjs>0</numccjs>
+        <numbais>0</numbais>
+        <numinvestors>0</numinvestors>
+        <numaddresslinks>0</numaddresslinks>
+        <numsharerecords>3</numsharerecords>
+        <halomatch>false</halomatch>
+        <readmatch>false</readmatch>
+        <grodeceased>false</grodeceased>
+        <dvlawarning>false</dvlawarning>
+        <passportwarning>false</passportwarning>
+        <namepicklistfound>false</namepicklistfound>
+        <addresspicklistfound>false</addresspicklistfound>
+        <IDBasic/>
+      </IdentityCheck>
+      <AgeVerify>
+        <Age>113</Age>
+        <DateOfBirth>1901-01-01</DateOfBirth>
+        <Over18>yes</Over18>
+      </AgeVerify>
+      <OtherChecks>
+        <IdentityResult>Fail</IdentityResult>
+        <IdentityScore>40</IdentityScore>
+      </OtherChecks>
+      <VelocityChecks>
+        <card/>
+        <bank/>
+        <individual/>
+        <email/>
+      </VelocityChecks>
+      <Warnings>
+        <NonGBRCardWarning>false</NonGBRCardWarning>
+        <NamePicklistWarning>false</NamePicklistWarning>
+        <AddressPicklistWarning>false</AddressPicklistWarning>
+        <PAFNonValidWarning>false</PAFNonValidWarning>
+        <CardAccountClosedWarning>false</CardAccountClosedWarning>
+        <BankAccountClosedWarning>false</BankAccountClosedWarning>
+      </Warnings>
+      <InternalUse>
+        <CESValue>40</CESValue>
+        <BESValue>40</BESValue>
+        <CESCARD_DIAG>WVRveE9udHBPakE3Y3pveE1qZzZJalBMSW43aktyRmRLWWdINnI3aER3ZVIvN3hkRjNqUm11ZzRwTnV6UjE4bGJkZUdlcTRPVkJ6b1BYWXNIRE8wMU1wRDhpS1ZUek50U250V0oxNkJRYys3MmxNbE0vVXlWVzgwRHlyKzZFSjF2M29PbXIzOE53VUY4cVE0NTVObTVhN04rNGFIMENlRlQ0ZlpsOTh2VzYrQzNvSzNhNHUwcG5hSmFYd1RiRlNpSWp0OSNLRVlTI7uQIxTC60UH5vu/HJ4ZevjOtRN5tnNeDSh971BnCn1rjP0hyhzgvVkH7Vd+GYNfrMDQDgjc4QOaFGr+q2BynE5P58rjjFxi6f0nNvkcToZBb+r3ahzjBhBCmEcVJT8Uva2ACFpTtM1eDtTEF/PAFpT2qTjngpUUNMpHRZ9t/67M+xNy+VyG1C32xxMb53HeTkbkON2UIUPXWvJ2sKbU9I1IGUMZFI8BNLwHegpSD9BIHB0U91aSWOjuv3Ci+sQkyk9x2nA5zuQVaVo3g531MhVD9Rve30KqKvw0wRbRve0v6hDbMgZ1XpQHK9XmS6EqJ1/ayyBUoEfpRwjDWJCPQe4/i2w/FTLvVK8lbqPQc13XMyGDsncoPkp4Ua4YOziqIpT3weRVMZmhK1HawBgamFnY9Aiid137ZIErr2ew8WraEadz7yemK1K+ymHTCCnJA6X1T1zKUCRHvqrEpxtmcHR70XpBgP+vyVcAe3kAnsAuUZVpHCiXKRs0m4qFCGh321nyNVc6+VdPbo0hFOxuK9dvBOiP38WzoT4ELHZMVvRpCFOfAd578kNxcto+AF9w7xWNJ84A0iAoF/toKvPnIIUUrEFaq+eQKqph6vuF7cObkprFzXN6P9dhngNN5kO2q189T7JdM6muk6CQGTFJjFwWfK/yQ8uJouPJw/10bOqjeXiSWB3l7UKvfw==</CESCARD_DIAG>
+        <BESCARD_DIAG>WVRveE9udHBPakE3Y3pveE1qZzZJdHF1UnhLL09TcktGdnd2UEZQc1dOV3p2R0s2eFk0b29ITWdDdGVMU3JaRWdlSWdwRmdpTWZHdFpPNDJ4c25PZGFVYU4xVHpmRFJDSUdDNjc4ZzM4a3d6TURzR2s1RHZJTmhjaFhQdHhiaGtqZm1OdXNZNFVqc1ZwQmtlK0tKTWw5UGZEQVBTNzd6bHFEaXVIYmhaM0U0TkJEdVlVeFZ6TS9hTmo3dEN4dUs2SWp0OSNLRVlTI7Z64Uhikd23HTXpfURK8jnYzpdROA836z/JLON6bPpoq+vZKhUgyhF7WfVCk/ZRiWE53O12uTSDmeTqrH1qRZwxocjTeIPbZ+w88s+PVGY5PYdqNMNXKaKfMW46ZqVxw+ZNQiTq3V77Yy53bM0peoeXzOdMr+pSYwtGKJVG97W86/JJA5D0peLzzHY+kodYk7TE5E+wraROcPfWZhmML2teNf3oyVeIOtnYqvRg1Ixocjo7HDMIhjWZ3oOnsuulYqOJ8djAHHBE1I1zyonrmcYyVxU/0ZBUeTpJ2ato/Wd+1GyoxQtyYndY7p6rp6rss07yXjG1Aay0U4/kZ3yf/c8W9jzg26tQ4gsMa/y5Bo5jBs7o2kBy8r/DJS+r+bWhRqqRcPjifC5bS42EU8s4sOWIoi90lZvExfjTKBJGYvDjAw4coBcK5oSz8OvPushs7Knd2ZyHsX/n9g4+w7xiViFzGyZ+0U7BlU6VQxqP1w+trNjkXd5F5gmZscXxudU/iI9q9EOI+ejkPpC7x9hwr0bzjLsQ9wK/apLyqG9jQ5vutIROzxpOr+dj</BESCARD_DIAG>
+        <CVSVER/>
+        <CAST>.02.7.1.4.1.0.16202370.0</CAST>
+      </InternalUse>
+    </Displays>
+  </Result>
+  <Errors/>
+</Results>

data/spec/fixtures/system_call_failure.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Results xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="C:/tac/Customer-Output-V4-5-3.xsd" APIVERSION="4.5.3 - 20131119">
+  <Errors>
+    <Error>Error 1</Error>
+    <FatalError>Error 2</FatalError>
+  </Errors>
+</Results>

data/spec/request_spec.rb

@@ -17,10 +17,7 @@ describe Callcredit::Request do
     subject(:build_request_xml) do
       request.build_request_xml(:id_enhanced, check_data).to_s
     end
-    let(:request_xml) do
-      path = File.join(File.dirname(__FILE__), 'fixtures', 'request.xml')
-      File.open(path.to_s).read
-    end
+    let(:request_xml) { load_fixture('request.xml') }
 
     it { should == request_xml }
 
@@ -66,11 +63,7 @@ describe Callcredit::Request do
         end
 
         context "200 with a single error from Callcredit" do
-          let(:body) do
-            path = File.join(File.dirname(__FILE__),
-                             'fixtures', 'bad_request.xml')
-            File.open(path.to_s).read
-          end
+          let(:body) { load_fixture('bad_request.xml') }
 
           it "wraps the error" do
             expect { perform_check }.
@@ -79,11 +72,7 @@ describe Callcredit::Request do
         end
 
         context "200 with multiple errors from Callcredit" do
-          let(:body) do
-            path = File.join(File.dirname(__FILE__),
-                             'fixtures', 'access_denied.xml')
-            File.open(path.to_s).read
-          end
+          let(:body) { load_fixture('access_denied.xml') }
 
           it "wraps the error" do
             expect { perform_check }.
@@ -91,6 +80,15 @@ describe Callcredit::Request do
           end
         end
 
+        context "200 with errors from Callcredit that aren't in a module" do
+          let(:body) { load_fixture('system_call_failure.xml') }
+
+          it "wraps the error" do
+            expect { perform_check }.
+              to raise_error(Callcredit::APIError, "Error 1 | Error 2")
+          end
+        end
+
         context "200 with unexpected XML" do
           let(:body) { "<TopLevel></TopLevel>" }
 

data/spec/response_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+require 'multi_xml'
+
+describe Callcredit::Response do
+  let(:result_hash) { MultiXml.parse(load_fixture('response.xml')) }
+  subject(:response) { Callcredit::Response.new(result_hash) }
+
+  it "makes some helper methods available" do
+    response.pid.should == "LTJ-CT2-1606-13927-46399"
+  end
+end

data/spec/spec_helper.rb

@@ -6,6 +6,10 @@ def configure_callcredit
   Callcredit.configure { |config| config[:first_name] = "Grey" }
 end
 
+def load_fixture(*filename)
+  File.open(File.join('spec', 'fixtures', *filename)).read
+end
+
 shared_examples "it validates presence" do |property|
   context "with a missing #{property}" do
     before { check_data.delete(property) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: callcredit
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-11 00:00:00.000000000 Z
+date: 2014-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -127,7 +127,10 @@ files:
 - spec/fixtures/access_denied.xml
 - spec/fixtures/bad_request.xml
 - spec/fixtures/request.xml
+- spec/fixtures/response.xml
+- spec/fixtures/system_call_failure.xml
 - spec/request_spec.rb
+- spec/response_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/gocardless/callcredit-ruby
 licenses: []
@@ -159,5 +162,8 @@ test_files:
 - spec/fixtures/access_denied.xml
 - spec/fixtures/bad_request.xml
 - spec/fixtures/request.xml
+- spec/fixtures/response.xml
+- spec/fixtures/system_call_failure.xml
 - spec/request_spec.rb
+- spec/response_spec.rb
 - spec/spec_helper.rb