calendly 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa6443944ba1a41d6f868879ddd4aac837f09ce9285eb210d7b61acd5c644615
-  data.tar.gz: efccf9e1c02314b14447e2d99ee9b67cb599f7eff3f9cd37d2b1396dd96d5bbd
+  metadata.gz: f21bb676098bf2f9d6f6e3ea600f7c4017d48207834646b185dbd459a6a8a531
+  data.tar.gz: e5e2accd3cc7145d99b3457f7ed87d79223b3b9fc18e0d49abdeb3a6b75b094f
 SHA512:
-  metadata.gz: be6f91ef55bc88c7a7b925d80de73028f3390b6077765ad91648a486992845db1137778ddbe048cc08e861f025a2fcb653699289f0698a6fd6706144e00638e2
-  data.tar.gz: 490abe0dc221919393b84d23c1eab5dfc776779df1b8f1c52206fd3251e36e09a8d8e8d6324cfad622540ea91d0a433283ca2cbff6f38fbd07ff49801a4851de
+  metadata.gz: ad14b69a614f2f3d39ff993f58b2b5c6f2e5c3a3d74a41b24ac5b17a9a6e915a84f0b99a7282695827d73009019d7ab9c6209a60c1ce8063609f5ab4a1cf5ba1
+  data.tar.gz: 5c5418b39536db9b1d88247e963e9277ae0964eaa64fdd7aabaef9edc29024aa6afed84e4df9b542fd93bf65fd0f311bdc467365bb7ac3097cc2a1a371dd5774

data/{.rubocom.yml → .rubocop.yml}

@@ -23,12 +23,11 @@ Metrics/BlockNesting:
   Max: 2
 
 Layout/LineLength:
- AllowURI: true
- Enabled: false
+  Max: 120
 
 Metrics/MethodLength:
   CountComments: false
-  Max: 15
+  Max: 20
 
 Metrics/ParameterLists:
   Max: 4
@@ -39,10 +38,10 @@ Metrics/AbcSize:
 
 Style/CollectionMethods:
   PreferredMethods:
-    map:      'collect'
-    reduce:   'inject'
-    find:     'detect'
-    find_all: 'select'
+    map: "collect"
+    reduce: "inject"
+    find: "detect"
+    find_all: "select"
 
 Style/Documentation:
   Enabled: false
@@ -60,10 +59,13 @@ Style/ExpandPathArguments:
   Enabled: false
 
 Style/HashSyntax:
-  EnforcedStyle: hash_rockets
+  EnforcedStyle: ruby19
 
 Style/Lambda:
   Enabled: false
 
 Style/RaiseArgs:
-  EnforcedStyle: compact
+  EnforcedStyle: compact
+
+Style/AsciiComments:
+  Enabled: false

data/CHANGELOG.md

@@ -1,27 +1,33 @@
-# 0.1.1
+# CHANGELOG
+
+## 0.1.2
+
+- fix rubocop warnings.
+
+## 0.1.1
 
 - add tests to make coverage 100%.
 
-# 0.1.0
+## 0.1.0
 
 - define methods to access associated resources with each model.
 - rename methods:
   - `Calendly::Client#events` to `Calendly::Client#scheduled_events`
 
-# 0.0.7.alpha
+## 0.0.7.alpha
 
 - support APIs
   - `POST /organizations/{uuid}/invitations`
   - `DELETE /organizations/{org_uuid}/invitations/{invitation_uuid}`
   - `DELETE /organization_memberships/{uuid}`
 
-# 0.0.6.alpha
+## 0.0.6.alpha
 
 - support APIs
   - `GET /organizations/{uuid}/invitations`
   - `GET /organizations/{organization_uuid}/invitations/{invitation_uuid}`
 
-# 0.0.5.alpha
+## 0.0.5.alpha
 
 - support APIs
   - `GET /organization_memberships`
@@ -30,24 +36,24 @@
   - Invitee#event to Invitee#event_uri
   - Event#event_type to Event#event_type_uri
 
-# 0.0.4.alpha
+## 0.0.4.alpha
 
 - support APIs
   - `GET /scheduled_events/{event_uuid}/invitees`
   - `GET /scheduled_events/{event_uuid}/invitees/{invitee_uuid}`
 
-# 0.0.3.alpha
+## 0.0.3.alpha
 
 - support APIs
   - `GET /scheduled_events`
   - `GET /scheduled_events/{uuid}`
 
-# 0.0.2.alpha
+## 0.0.2.alpha
 
 - support APIs
   - `GET /event_types`
 
-# 0.0.1.alpha
+## 0.0.1.alpha
 
 - Initial release
 - support APIs

data/Rakefile

@@ -1,10 +1,12 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/**/*_test.rb"]
+  t.libs << 'test'
+  t.libs << 'lib'
+  t.test_files = FileList['test/**/*_test.rb']
 end
 
-task :default => :test
+task default: :test

data/lib/calendly/api_error.rb

@@ -25,9 +25,9 @@ module Calendly
       "\#<#{self.class}:#{object_id} title:#{title}, status:#{status}>"
     end
 
-    private
+  private
 
-    def set_attributes_from_response
+    def set_attributes_from_response # rubocop:disable Metrics/CyclomaticComplexity
       return unless response
       return unless response.respond_to? :body
 

data/lib/calendly/client.rb

@@ -4,14 +4,15 @@ require 'oauth2'
 
 module Calendly
   # Calendly apis client.
-  class Client
+  class Client # rubocop:disable Metrics/ClassLength
+    include Loggable
     API_HOST = 'https://api.calendly.com'
     AUTH_API_HOST = 'https://auth.calendly.com'
 
     # @param [String] token a Calendly's access token.
+    # @raise [Calendly::Error] if the token is empty.
     def initialize(token = nil)
       @config = Calendly.configuration
-      @logger = @config.logger
       @token = token || Calendly.configuration.token
 
       check_not_empty @token, 'token'
@@ -95,7 +96,7 @@ module Calendly
       check_not_empty user_uri, 'user_uri'
 
       opts_keys = %i[count page_token sort]
-      params = { user: user_uri }
+      params = {user: user_uri}
       params = merge_options opts, opts_keys, params
       body = request :get, 'event_types', params: params
 
@@ -140,7 +141,7 @@ module Calendly
       check_not_empty user_uri, 'user_uri'
 
       opts_keys = %i[count invitee_email max_start_time min_start_time page_token sort status]
-      params = { user: user_uri }
+      params = {user: user_uri}
       params = merge_options opts, opts_keys, params
       body = request :get, 'scheduled_events', params: params
 
@@ -227,7 +228,7 @@ module Calendly
       check_not_empty org_uri, 'org_uri'
 
       opts_keys = %i[count email page_token]
-      params = { organization: org_uri }
+      params = {organization: org_uri}
       params = merge_options opts, opts_keys, params
       body = request :get, 'organization_memberships', params: params
 
@@ -254,7 +255,7 @@ module Calendly
       check_not_empty user_uri, 'user_uri'
 
       opts_keys = %i[count email page_token]
-      params = { user: user_uri }
+      params = {user: user_uri}
       params = merge_options opts, opts_keys, params
       body = request :get, 'organization_memberships', params: params
 
@@ -339,7 +340,7 @@ module Calendly
       body = request(
         :post,
         "organizations/#{uuid}/invitations",
-        body: { email: email }
+        body: {email: email}
       )
       OrganizationInvitation.new body[:resource], self
     end
@@ -361,13 +362,7 @@ module Calendly
       true
     end
 
-    private
-
-    def debug_log(msg)
-      return unless @logger
-
-      @logger.debug msg
-    end
+  private
 
     def request(method, path, params: nil, body: nil)
       debug_log "Request #{method.to_s.upcase} #{API_HOST}/#{path} params:#{params}, body:#{body}"
@@ -388,7 +383,7 @@ module Calendly
     end
 
     def check_not_empty(value, name)
-      raise Calendly::Error, "#{name} is required." if blank? value
+      raise Calendly::Error.new("#{name} is required.") if blank? value
     end
 
     def blank?(value)

data/lib/calendly/error.rb

@@ -3,21 +3,15 @@
 module Calendly
   # calendly module's base error object
   class Error < StandardError
+    include Loggable
+
     def initialize(message = nil)
       @logger = Calendly.configuration.logger
       msg = "#{self.class} occured."
       msg += " status:#{status}" if respond_to?(:status)
       msg += " message:#{message}"
-      log msg
+      warn_log msg
       super message
     end
-
-    private
-
-    def log(msg, level = :warn)
-      return if @logger.nil?
-
-      @logger.send level, msg
-    end
   end
 end

data/lib/calendly/loggable.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module Calendly
+  # Calendly logger utility module.
+  module Loggable
+    def error_log(msg)
+      log msg, :error
+    end
+
+    def warn_log(msg)
+      log msg, :warn
+    end
+
+    def info_log(msg)
+      log msg, :info
+    end
+
+    def debug_log(msg)
+      log msg, :debug
+    end
+
+    private
+
+    def log(msg, level = :info)
+      logger = Calendly.configuration.logger
+      return unless logger
+      return unless logger.respond_to? level
+
+      logger.send level, msg
+    end
+  end
+end

data/lib/calendly/models/event.rb

@@ -7,7 +7,7 @@ module Calendly
     include ModelUtils
     UUID_RE = %r{\A#{Client::API_HOST}/scheduled_events/(\w+)\z}.freeze
     TIME_FIELDS = %i[start_time end_time created_at updated_at].freeze
-    ASSOCIATION = { event_type: EventType }.freeze
+    ASSOCIATION = {event_type: EventType}.freeze
 
     # @return [String]
     # unique id of the Event object.
@@ -69,8 +69,10 @@ module Calendly
     # @param [Hash] opts the optional request parameters.
     # @option opts [Integer] :count Number of rows to return.
     # @option opts [String] :email Filter by email.
-    # @option opts [String] :page_token Pass this to get the next portion of collection.
-    # @option opts [String] :sort Order results by the specified field and directin. Accepts comma-separated list of {field}:{direction} values.
+    # @option opts [String] :page_token
+    # Pass this to get the next portion of collection.
+    # @option opts [String] :sort Order results by the specified field and directin.
+    # Accepts comma-separated list of {field}:{direction} values.
     # @option opts [String] :status Whether the scheduled event is active or canceled.
     # @return [Array<Calendly::Invitee>]
     # @raise [Calendly::Error] if the uuid is empty.
@@ -81,7 +83,7 @@ module Calendly
       auto_pagination request_proc, opts
     end
 
-    private
+  private
 
     def after_set_attributes(attrs)
       super attrs
@@ -89,11 +91,12 @@ module Calendly
       @location = Location.new loc_params if loc_params&.is_a? Hash
 
       inv_cnt_attrs = attrs[:invitees_counter]
-      if inv_cnt_attrs&.is_a? Hash
-        @invitees_counter_total = inv_cnt_attrs[:total]
-        @invitees_counter_active = inv_cnt_attrs[:active]
-        @invitees_counter_limit = inv_cnt_attrs[:limit]
-      end
+      return unless inv_cnt_attrs
+      return unless inv_cnt_attrs.is_a? Hash
+
+      @invitees_counter_total = inv_cnt_attrs[:total]
+      @invitees_counter_active = inv_cnt_attrs[:active]
+      @invitees_counter_limit = inv_cnt_attrs[:limit]
     end
   end
 end

data/lib/calendly/models/event_type.rb

@@ -72,17 +72,16 @@ module Calendly
     # Whether the profile belongs to a “User” or a “Team”.
     attr_accessor :owner_type
 
-    private
+  private
 
     def after_set_attributes(attrs)
       super attrs
-      if attrs[:profile]
+      return unless attrs[:profile]
 
-        @owner_uri = attrs[:profile][:owner]
-        @owner_uuid = User.extract_uuid owner_uri
-        @owner_name = attrs[:profile][:name]
-        @owner_type = attrs[:profile][:type]
-      end
+      @owner_uri = attrs[:profile][:owner]
+      @owner_uuid = User.extract_uuid owner_uri
+      @owner_name = attrs[:profile][:name]
+      @owner_type = attrs[:profile][:type]
     end
   end
 end

data/lib/calendly/models/invitee.rb

@@ -7,7 +7,7 @@ module Calendly
     include ModelUtils
     UUID_RE = %r{\A#{Client::API_HOST}/scheduled_events/\w+/invitees/(\w+)\z}.freeze
     TIME_FIELDS = %i[created_at updated_at].freeze
-    ASSOCIATION = { event: Event }.freeze
+    ASSOCIATION = {event: Event}.freeze
 
     # @return [String]
     # unique id of the Invitee object.
@@ -61,14 +61,12 @@ module Calendly
       client.event_invitee ev_uuid, uuid
     end
 
-    private
+  private
 
     def after_set_attributes(attrs)
       super attrs
       answers = attrs[:questions_and_answers]
-      if answers&.is_a? Array
-        @questions_and_answers = answers.map { |ans| InviteeQuestionAndAnswer.new ans }
-      end
+      @questions_and_answers = answers.map { |ans| InviteeQuestionAndAnswer.new ans } if answers&.is_a? Array
 
       trac_attrs = attrs[:tracking]
       @tracking = InviteeTracking.new trac_attrs if trac_attrs&.is_a? Hash

data/lib/calendly/models/model_utils.rb

@@ -19,7 +19,7 @@ module Calendly
     # @raise [Calendly::Error] if the client is nil.
     # @since 0.1.0
     def client
-      raise Error, '@client is not ready.' if !@client || !@client.is_a?(Client)
+      raise Error.new('@client is not ready.') if !@client || !@client.is_a?(Client)
 
       @client
     end
@@ -31,7 +31,7 @@ module Calendly
     # @raise [Calendly::Error] if uuid is not defined.
     # @since 0.1.0
     def id
-      raise Error, 'uuid is not defined.' unless defined? uuid
+      raise Error.new('uuid is not defined.') unless defined? uuid
 
       uuid
     end
@@ -58,9 +58,9 @@ module Calendly
       base.extend ClassMethods
     end
 
-    private
+  private
 
-    def set_attributes(attrs)
+    def set_attributes(attrs) # rubocop:disable all
       return if attrs.nil?
       return unless attrs.is_a? Hash
       return if attrs.empty?
@@ -69,7 +69,7 @@ module Calendly
         next unless respond_to? "#{key}=".to_sym
 
         if defined?(self.class::ASSOCIATION) && self.class::ASSOCIATION.key?(key)
-          associated_attrs = value.is_a?(Hash) ? value : { uri: value }
+          associated_attrs = value.is_a?(Hash) ? value : {uri: value}
           value = self.class::ASSOCIATION[key].new associated_attrs, @client
         elsif defined?(self.class::TIME_FIELDS) && self.class::TIME_FIELDS.include?(key)
           value = Time.parse value

data/lib/calendly/models/organization.rb

@@ -36,7 +36,8 @@ module Calendly
     # @option opts [Integer] :count Number of rows to return.
     # @option opts [String] :email Filter by email.
     # @option opts [String] :page_token Pass this to get the next portion of collection.
-    # @option opts [String] :sort Order results by the specified field and directin. Accepts comma-separated list of {field}:{direction} values.
+    # @option opts [String] :sort Order results by the specified field and directin.
+    # Accepts comma-separated list of {field}:{direction} values.
     # @option opts [String] :status Filter by status.
     # @return [Array<Calendly::OrganizationInvitation>]
     # @raise [Calendly::Error] if the uuid is empty.

data/lib/calendly/models/organization_invitation.rb

@@ -6,7 +6,7 @@ module Calendly
     include ModelUtils
     UUID_RE = %r{\A#{Client::API_HOST}/organizations/\w+/invitations/(\w+)\z}.freeze
     TIME_FIELDS = %i[created_at updated_at last_sent_at].freeze
-    ASSOCIATION = { user: User, organization: Organization }.freeze
+    ASSOCIATION = {user: User, organization: Organization}.freeze
 
     # @return [String]
     # unique id of the OrganizationInvitation object.

data/lib/calendly/models/organization_membership.rb

@@ -6,7 +6,7 @@ module Calendly
     include ModelUtils
     UUID_RE = %r{\A#{Client::API_HOST}/organization_memberships/(\w+)\z}.freeze
     TIME_FIELDS = %i[created_at updated_at].freeze
-    ASSOCIATION = { user: User, organization: Organization }.freeze
+    ASSOCIATION = {user: User, organization: Organization}.freeze
 
     # @return [String]
     # unique id of the OrganizationMembership object.

data/lib/calendly/models/user.rb

@@ -67,7 +67,8 @@ module Calendly
     # @param [Hash] opts the optional request parameters.
     # @option opts [Integer] :count Number of rows to return.
     # @option opts [String] :page_token Pass this to get the next portion of collection.
-    # @option opts [String] :sort Order results by the specified field and direction. Accepts comma-separated list of {field}:{direction} values.
+    # @option opts [String] :sort Order results by the specified field and direction.
+    # Accepts comma-separated list of {field}:{direction} values.
     # @return [Array<Calendly::EventType>]
     # @raise [Calendly::Error] if the uri is empty.
     # @raise [Calendly::ApiError] if the api returns error code.
@@ -83,10 +84,11 @@ module Calendly
     # @param [Hash] opts the optional request parameters.
     # @option opts [Integer] :count Number of rows to return.
     # @option opts [String] :invitee_email Return events scheduled with the specified invitee email
-    # @option opts [String] :max_start_time Upper bound (inclusive) for an event's start time to filter by.
+    # @option opts [String] :max_start_timeUpper bound (inclusive) for an event's start time to filter by.
     # @option opts [String] :min_start_time Lower bound (inclusive) for an event's start time to filter by.
     # @option opts [String] :page_token Pass this to get the next portion of collection.
-    # @option opts [String] :sort Order results by the specified field and directin. Accepts comma-separated list of {field}:{direction} values.
+    # @option opts [String] :sort Order results by the specified field and directin.
+    # Accepts comma-separated list of {field}:{direction} values.
     # @option opts [String] :status Whether the scheduled event is active or canceled
     # @return [Array<Calendly::Event>]
     # @raise [Calendly::Error] if the uri is empty.

data/lib/calendly/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Calendly
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: calendly
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Kenji Koshikawa
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-27 00:00:00.000000000 Z
+date: 2020-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oauth2
@@ -132,7 +132,7 @@ files:
 - ".github/workflows/gem-push.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
-- ".rubocom.yml"
+- ".rubocop.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -147,6 +147,7 @@ files:
 - lib/calendly/client.rb
 - lib/calendly/configuration.rb
 - lib/calendly/error.rb
+- lib/calendly/loggable.rb
 - lib/calendly/models/event.rb
 - lib/calendly/models/event_type.rb
 - lib/calendly/models/invitee.rb
@@ -166,7 +167,7 @@ metadata:
   homepage_uri: https://github.com/koshilife/calendly-api-ruby-client
   source_code_uri: https://github.com/koshilife/calendly-api-ruby-client
   changelog_uri: https://github.com/koshilife/calendly-api-ruby-client/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/calendly/0.1.1
+  documentation_uri: https://www.rubydoc.info/gems/calendly/0.1.2
 post_install_message: 
 rdoc_options: []
 require_paths: