calendarium-romanum 0.4.0 → 0.5.0

data/spec/readme_spec.rb

@@ -36,6 +36,10 @@ end
 
 %w(README.md data/README.md).each do |path|
   describe path do
+    before :each do
+      STDERR.stub(:puts)
+    end
+
     readme_path = File.expand_path('../../' + path, __FILE__)
     readme = File.read readme_path
     doc = MarkdownDocument.new readme

data/spec/sanctorale_spec.rb

@@ -12,7 +12,7 @@ describe CR::Sanctorale do
   describe '#get' do
     describe 'for an empty day' do
       it 'returns an Array' do
-        expect(s.get(1,3)).to be_an Array
+        expect(s.get(1, 3)).to be_an Array
       end
     end
 
@@ -31,8 +31,8 @@ describe CR::Sanctorale do
 
       it 'may have more CR::Celebrations for a day' do
         [
-         'S. Fabiani, papae et martyris',
-         'S. Sebastiani, martyris'
+          'S. Fabiani, papae et martyris',
+          'S. Sebastiani, martyris'
         ].each {|t| s.add 1, 20, CR::Celebration.new(t, CR::Ranks::MEMORIAL_OPTIONAL) }
         expect(s.get(1, 20).size).to eq 2
       end

data/spec/sanctoraleloader_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe CR::SanctoraleLoader do
-
   before :each do
     @s = CR::Sanctorale.new
     @l = CR::SanctoraleLoader.new
@@ -43,7 +42,7 @@ describe CR::SanctoraleLoader do
 
     describe '#load_from_file' do
       it 'loads something from file' do
-        @l.load_from_file(File.join(%w{data universal-la.txt}), @s)
+        @l.load_from_file(File.join(%w(data universal-la.txt)), @s)
         expect(@s.size).to be > 190
       end
     end
@@ -77,7 +76,6 @@ describe CR::SanctoraleLoader do
       # say we specify a proper calendar of a church dedicated to St. George
 
       it 'sets rank if specified' do
-
         str = '4/23 s R : S. Georgii, martyris'
         @l.load_from_string str, @s
         celeb = @s.get(4, 23).first
@@ -113,58 +111,65 @@ describe CR::SanctoraleLoader do
         str = 'line without standard beginning'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /Syntax error/
+        end.to raise_exception(CR::InvalidDataError, /Syntax error/)
       end
     end
 
     describe 'syntactically correct data making no sense' do
+      it 'invalid month heading' do
+        str = '= 13'
+        expect do
+          @l.load_from_string str, @s
+        end.to raise_exception(CR::InvalidDataError, /Invalid month/)
+      end
+
       it 'invalid month' do
         str = '100/25 f : In conversione S. Pauli, apostoli'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /Invalid month/
+        end.to raise_exception(CR::InvalidDataError, /Invalid month/)
       end
 
       it 'line with day only, without preceding month heading' do
         str = '25 f : In conversione S. Pauli, apostoli'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /Invalid month/
+        end.to raise_exception(CR::InvalidDataError, /Invalid month/)
       end
 
       it 'invalid day' do
         str = '1/250 f : In conversione S. Pauli, apostoli'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /Invalid day/
+        end.to raise_exception(CR::InvalidDataError, /Invalid day/)
       end
 
       it 'invalid month heading' do
         str = '= 0'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /Invalid month/
+        end.to raise_exception(CR::InvalidDataError, /Invalid month/)
       end
 
       it 'invalid rank' do
         str = '1/25 X : In conversione S. Pauli, apostoli'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /Syntax error/
+        end.to raise_exception(CR::InvalidDataError, /Syntax error/)
       end
 
       it 'invalid numeric rank' do
         str = '4/23 s8.4 R : S. Georgii, martyris'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /rank/
+        end.to raise_exception(CR::InvalidDataError, /rank/)
       end
 
       it 'invalid combination of rank latter and number' do
         str = '4/23 m2.5 R : S. Georgii, martyris'
         expect do
           @l.load_from_string str, @s
-        end.to raise_exception /rank/
+        end.to raise_exception(CR::InvalidDataError, /rank/)
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,3 +1,10 @@
+require 'simplecov'
+SimpleCov.start do
+  add_filter 'lib/calendarium-romanum/cli.rb'
+end
+
+require 'aruba/rspec'
+
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # Require this file using `require "spec_helper"` to ensure that it is only
@@ -33,3 +40,7 @@ CR = CalendariumRomanum
 
 I18n.enforce_available_locales = true
 I18n.locale = ENV['LOCALE'] || :en
+
+# make the gem's executable(s) easily available for aruba
+gem_bin = File.expand_path('../../bin', __FILE__)
+ENV['PATH'] = "#{gem_bin}:#{ENV['PATH']}"

data/spec/temporale_spec.rb

@@ -2,7 +2,6 @@
 require_relative 'spec_helper'
 
 describe CR::Temporale do
-
   before :all do
     @t = @t12 = described_class.new 2012
     @t13 = described_class.new 2013
@@ -84,6 +83,39 @@ describe CR::Temporale do
     end
   end
 
+  describe '#season_beginning' do
+    let(:year) { 2016 }
+    let(:options) { {} }
+    let(:t) { described_class.new(year, **options) }
+
+    describe 'unsupported season' do
+      it 'fails' do
+        season = CR::Season.new(:strawberry_season, CR::Colours::RED)
+        expect do
+          t.season_beginning season
+        end.to raise_exception(ArgumentError, /unsupported season/)
+      end
+    end
+
+    describe 'Ordinary Time' do
+      describe 'Epiphany not transferred' do
+        it do
+          expect(t.season_beginning(CR::Seasons::ORDINARY))
+            .to eq Date.new(2017, 1, 9)
+        end
+      end
+
+      describe 'Epiphany transferred' do
+        let(:t) { described_class.new(year, transfer_to_sunday: [:epiphany]) }
+
+        it do
+          expect(t.season_beginning(CR::Seasons::ORDINARY))
+            .to eq Date.new(2017, 1, 10)
+        end
+      end
+    end
+  end
+
   describe '#get' do
     it 'returns a Celebration' do
       expect(@t13.get(8, 12)).to be_a CR::Celebration
@@ -172,6 +204,7 @@ describe CR::Temporale do
           expect(c.rank).to eq CR::Ranks::PRIMARY
           expect(c.title).to have_translation 'The Nativity of the Lord'
           expect(c.colour).to eq CR::Colours::WHITE
+          expect(c.symbol).to eq :nativity
         end
 
         it 'day in the octave of Nativity' do
@@ -242,6 +275,7 @@ describe CR::Temporale do
           expect(c.rank).to eq CR::Ranks::TRIDUUM
           expect(c.title).to have_translation 'Easter Sunday of the Resurrection of the Lord'
           expect(c.colour).to eq CR::Colours::WHITE
+          expect(c.symbol).to eq :easter_sunday
         end
 
         it 'Ascension' do
@@ -256,6 +290,7 @@ describe CR::Temporale do
           expect(c.rank).to eq CR::Ranks::PRIMARY
           expect(c.title).to have_translation 'Pentecost Sunday'
           expect(c.colour).to eq CR::Colours::RED
+          expect(c.symbol).to eq :pentecost
         end
 
         it 'Trinity' do
@@ -343,6 +378,10 @@ describe CR::Temporale do
         it 'ferial' do
           expect(title_for(12, 2)).to have_translation 'Monday, 1st week of Advent'
         end
+
+        it 'ferial before Christmas' do
+          expect(title_for(12, 17)).to have_translation '17th December'
+        end
       end
 
       describe 'Christmas time' do
@@ -434,7 +473,7 @@ describe CR::Temporale do
 
         it 'French' do
           I18n.with_locale(:fr) do
-            expect(title_for(5, 5)).to eq 'Lundi, 3 semaine de Pâques'
+            expect(title_for(5, 5)).to eq 'Lundi, 3ème semaine de Pâques'
           end
         end
 
@@ -463,8 +502,10 @@ describe CR::Temporale do
   end
 
   describe 'Solemnities transferred to a Sunday' do
+    let(:year) { 2016 }
     let(:transferred) { [:epiphany, :ascension, :corpus_christi] }
-    let(:t) { described_class.new(2016, transfer_to_sunday: transferred) }
+    let(:t) { described_class.new(year, transfer_to_sunday: transferred) }
+    let(:t_notransfer) { described_class.new(year) }
 
     it 'Epiphany' do
       date = Date.new(2017, 1, 8)
@@ -488,6 +529,18 @@ describe CR::Temporale do
       expect(c.title).to have_translation 'The Baptism of the Lord'
     end
 
+    describe 'Ordinary Time numbering after transferred Epiphany' do
+      it 'ferials correct' do
+        first_ot_tuesday = Date.new(2017, 1, 10)
+        expect(t.get(first_ot_tuesday)).to eq t_notransfer.get(first_ot_tuesday)
+      end
+
+      it 'Sundays correct' do
+        second_ot_sunday = Date.new(2017, 1, 15)
+        expect(t.get(second_ot_sunday)).to eq t_notransfer.get(second_ot_sunday)
+      end
+    end
+
     it 'Ascension' do
       date = Date.new(2017, 5, 28)
       expect(date).to be_sunday # make sure

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: calendarium-romanum
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Jakub Pavlík
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-26 00:00:00.000000000 Z
+date: 2017-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -118,6 +118,7 @@ files:
 - lib/calendarium-romanum/day.rb
 - lib/calendarium-romanum/enum.rb
 - lib/calendarium-romanum/enums.rb
+- lib/calendarium-romanum/errors.rb
 - lib/calendarium-romanum/i18n_setup.rb
 - lib/calendarium-romanum/ordinalizer.rb
 - lib/calendarium-romanum/perpetual_calendar.rb
@@ -126,6 +127,7 @@ files:
 - lib/calendarium-romanum/sanctorale_factory.rb
 - lib/calendarium-romanum/sanctoraleloader.rb
 - lib/calendarium-romanum/temporale.rb
+- lib/calendarium-romanum/temporale/celebration_factory.rb
 - lib/calendarium-romanum/temporale/dates.rb
 - lib/calendarium-romanum/temporale/extensions/christ_eternal_priest.rb
 - lib/calendarium-romanum/transfers.rb
@@ -133,10 +135,12 @@ files:
 - lib/calendarium-romanum/version.rb
 - spec/abstract_date_spec.rb
 - spec/calendar_spec.rb
+- spec/celebration_factory_spec.rb
 - spec/celebration_spec.rb
 - spec/cli_spec.rb
 - spec/colour_spec.rb
 - spec/data_spec.rb
+- spec/date_parser_spec.rb
 - spec/date_spec.rb
 - spec/dates_spec.rb
 - spec/day_spec.rb