calagator 0.0.1.pre1

data/spec/controllers/calagator/venues_controller_spec.rb

@@ -0,0 +1,319 @@
+require 'spec_helper'
+require './spec/controllers/squash_many_duplicates_examples'
+
+module Calagator
+
+describe VenuesController, :type => :controller do
+  routes { Calagator::Engine.routes }
+
+  render_views
+
+  it "should redirect duplicate venues to their master" do
+    venue_master = FactoryGirl.create(:venue)
+    venue_duplicate = FactoryGirl.create(:venue)
+
+    # No redirect when they're unique
+    get 'show', :id => venue_duplicate.id
+    expect(response).not_to be_redirect
+    expect(assigns(:venue).id).to eq venue_duplicate.id
+
+    # Mark as duplicate
+    venue_duplicate.duplicate_of = venue_master
+    venue_duplicate.save!
+
+    # Now check that redirection happens
+    get 'show', :id => venue_duplicate.id
+    expect(response).to be_redirect
+    expect(response).to redirect_to(venue_url(venue_master.id))
+  end
+
+  context "with admin auth for duplicates" do
+    before do
+      credentials = ActionController::HttpAuthentication::Basic.encode_credentials SECRETS.admin_username, SECRETS.admin_password
+      request.env['HTTP_AUTHORIZATION'] = credentials
+    end
+
+    it "should display an error message if given invalid arguments" do
+      get 'duplicates', :type => 'omgwtfbbq'
+
+      expect(response).to be_success
+      expect(response.body).to have_selector('.failure', text: 'omgwtfbbq')
+    end
+
+    context do
+      include_examples "#squash_many_duplicates", :venue
+    end
+  end
+
+  describe "when creating venues" do
+    it "should redirect to the newly created venue" do
+      post :create, venue: FactoryGirl.attributes_for(:venue)
+      expect(response).to redirect_to(assigns(:venue))
+    end
+
+    it "should stop evil robots" do
+      post :create, :trap_field => "I AM AN EVIL ROBOT, I EAT OLD PEOPLE'S MEDICINE FOR FOOD!"
+      expect(response).to render_template :new
+    end
+  end
+
+  describe "when updating venues" do
+    before do
+      @venue = FactoryGirl.create(:venue)
+    end
+
+    it "should redirect to the updated venue" do
+      put :update, id: @venue.id, venue: FactoryGirl.attributes_for(:venue)
+      expect(response).to redirect_to(@venue)
+    end
+
+    it "should redirect to any associated event" do
+      @event = FactoryGirl.create(:event, venue: @venue)
+      put :update, id: @venue.id, from_event: @event.id, venue: FactoryGirl.attributes_for(:venue)
+      expect(response).to redirect_to(@event)
+    end
+
+    it "should stop evil robots" do
+      put :update, id: @venue.id, trap_field: "I AM AN EVIL ROBOT, I EAT OLD PEOPLE'S MEDICINE FOR FOOD!"
+      expect(response).to render_template :edit
+    end
+  end
+
+  describe "when rendering the new venue page" do
+    it "passes the template a new venue" do
+      get :new
+      expect(assigns[:venue]).to be_a Venue
+      expect(assigns[:venue]).to be_new_record
+    end
+  end
+
+  describe "when rendering the edit venue page" do
+    it "passes the template the specified venue" do
+      @venue = FactoryGirl.create(:venue)
+      get :edit, id: @venue.id
+      expect(assigns[:venue]).to eq(@venue)
+    end
+  end
+
+  describe "when rendering the map page" do
+    before do
+      @open_venue = FactoryGirl.create(:venue)
+      @closed_venue = FactoryGirl.create(:venue, closed: true)
+      @duplicate_venue = FactoryGirl.create(:venue, duplicate_of: @open_venue)
+    end
+
+    it "only shows open non-duplicate venues" do
+      get :map
+      expect(assigns[:venues]).to eq([@open_venue])
+    end
+  end
+
+  describe "when rendering the venues index" do
+    before do
+      @venues = [FactoryGirl.create(:venue), FactoryGirl.create(:venue)]
+    end
+
+    it "should assign the search object to @search" do
+      get :index
+      expect(assigns[:search]).to be_a Venue::Search
+    end
+
+    it "should assign search results to @venues" do
+      get :index
+      expect(assigns[:venues]).to eq(@venues)
+    end
+
+    describe "in JSON format" do
+      it "should produce JSON" do
+        get :index, :format => "json"
+
+        struct = ActiveSupport::JSON.decode(response.body)
+        expect(struct).to be_a_kind_of Array
+      end
+
+      it "should accept a JSONP callback" do
+        get :index, :format => "json", :callback => "some_function"
+
+        expect(response.body.split("\n").join).to match /^\s*some_function\(.*\);?\s*$/
+      end
+    end
+
+  end
+
+  describe "when showing venues" do
+    it "redirects to all venues if venue doesn't exist" do
+      get :show, id: "garbage"
+      expect(response).to redirect_to("/venues")
+    end
+
+    describe "in JSON format" do
+      describe "with events" do
+        before do
+          @venue = FactoryGirl.build(:venue, :id => 123)
+          allow(Venue).to receive(:find).and_return(@venue)
+        end
+
+        it "should produce JSON" do
+          get :show, :id => @venue.to_param, :format => "json"
+
+          struct = ActiveSupport::JSON.decode(response.body)
+          expect(struct).to be_a_kind_of Hash
+          %w[id title description address].each do |field|
+            expect(struct[field]).to eq @venue.send(field)
+          end
+        end
+
+        it "should accept a JSONP callback" do
+          get :show, :id => @venue.to_param, :format => "json", :callback => "some_function"
+
+          expect(response.body.split("\n").join).to match /^\s*some_function\(.*\);?\s*$/
+        end
+      end
+    end
+
+    describe "in HTML format" do
+      describe "venue with future and past events" do
+        before do
+          @venue = FactoryGirl.create(:venue)
+          @future_event = FactoryGirl.create(:event, :venue => @venue)
+          @past_event = FactoryGirl.create(:event, :venue => @venue,
+            :start_time => Time.now - 1.week + 1.hour,
+            :end_time => Time.now - 1.week + 2.hours)
+
+          get :show, :id => @venue.to_param, :format => "html"
+          expect(response).to be_success
+        end
+
+        it "should have a venue" do
+          expect(response.body).to have_selector(".location .fn", text: @venue.title)
+        end
+
+        it "should have a future event" do
+          expect(response.body).to have_selector("#events #future_events .summary", text: @future_event.title)
+        end
+
+        it "should have a past event" do
+          expect(response.body).to have_selector("#events #past_events .summary", text: @past_event.title)
+        end
+      end
+    end
+
+    describe "as an iCalendar" do
+      before do
+        @venue = FactoryGirl.create(:venue)
+        @future_event = FactoryGirl.create(:event, :venue => @venue, :start_time => today + 1.hour)
+        @past_event = FactoryGirl.create(:event, :venue => @venue, :start_time => today - 1.hour)
+
+        get :show, :id => @venue.to_param, :format => "ics"
+      end
+
+      it "should have a calendar" do
+        expect(response.body).to match /BEGIN:VCALENDAR/
+      end
+
+      it "should have events" do
+        expect(response.body).to match /BEGIN:VEVENT/
+      end
+
+      it "should render all future events" do
+        expect(response.body).to match /SUMMARY:#{@future_event.title}/
+      end
+
+      it "should render all past events" do
+        expect(response.body).to match /SUMMARY:#{@past_event.title}/
+      end
+    end
+
+  end
+
+  describe "DELETE" do
+    describe "when deleting a venue without events" do
+      before do
+        @venue = FactoryGirl.create(:venue)
+      end
+
+      shared_examples_for "destroying a Venue record without events" do
+        it "should destroy the Venue record" do
+          expect { Venue.find(@venue.id) }.to raise_error ActiveRecord::RecordNotFound
+        end
+      end
+
+      describe "and rendering HTML" do
+        before do
+          delete :destroy, :id => @venue.id
+        end
+
+        it_should_behave_like "destroying a Venue record without events"
+
+        it "should display a success message" do
+          expect(flash[:success]).to be_present
+        end
+
+        it "should redirect to the venues listing" do
+          expect(response).to redirect_to(venues_path)
+        end
+      end
+
+      describe "and rendering XML" do
+        render_views
+
+        before do
+          delete :destroy, :id => @venue.id, :format => "xml"
+        end
+
+        it_should_behave_like "destroying a Venue record without events"
+
+        it "should return a success status" do
+          expect(response).to be_success
+        end
+      end
+    end
+
+    describe "when deleting a venue with events" do
+      before do
+        @event = FactoryGirl.create(:event, :with_venue)
+        @venue = @event.venue
+      end
+
+      shared_examples_for "destroying a Venue record with events" do
+        it "should not destroy the Venue record" do
+          expect(Venue.find(@venue.id)).to be_present
+        end
+      end
+
+      describe "and rendering HTML" do
+        before do
+          delete :destroy, :id => @venue.id
+        end
+
+        it_should_behave_like "destroying a Venue record with events"
+
+        it "should display a failure message" do
+          expect(flash[:failure]).to be_present
+        end
+
+        it "should redirect to the venue page" do
+          expect(response).to redirect_to(venue_path(@venue))
+        end
+      end
+
+      describe "and rendering XML" do
+        before do
+          delete :destroy, :id => @venue.id, :format => "xml"
+        end
+
+        it_should_behave_like "destroying a Venue record with events"
+
+        it "should return unprocessable entity status" do
+          expect(response.code.to_i).to eq 422
+        end
+
+        it "should describing the problem" do
+          expect(response.body).to match /cannot/i
+        end
+      end
+    end
+  end
+end
+
+end

data/spec/controllers/calagator/versions_controller_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+module Calagator
+
+describe VersionsController, :type => :controller do
+  routes { Calagator::Engine.routes }
+
+  describe "without versions" do
+    it "should raise RecordNotFound if not given an id" do
+      expect do
+        get :edit, :id => ''
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    it "should raise RecordNotFound if given invalid id" do
+      expect do
+        get :edit, :id => '-1'
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    it "should raise RecordNotFound if given id that doesn't exist" do
+      expect do
+        get :edit, :id => '1234'
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+  end
+
+  describe "with versions" do
+    before do
+      @create_title = "myevent"
+      @update_title = "myevent v2"
+      @final_title = "myevent v3"
+
+      @event = FactoryGirl.create(:event, :title => @create_title)
+
+      @event.title = @update_title
+      @event.save!
+
+      @event.title = @final_title
+      @event.save!
+
+      @event.destroy
+    end
+
+    # Returns the versioned record's title for the event (e.g. :update).
+    def title_for(event)
+      version_id = @event.versions.where(event: event).pluck(:id).first
+
+      get :edit, :id => version_id
+
+      return assigns[:event].title
+    end
+
+    it "should render the initial content for a 'create'" do
+      expect(title_for(:create)).to eq @create_title
+    end
+
+    it "should render the updated content for an 'update'" do
+      expect(title_for(:update)).to eq @update_title
+    end
+
+    it "should render the final content for a 'destroy'" do
+      expect(title_for(:destroy)).to eq @final_title
+    end
+
+    it "should render html" do
+      version_id = @event.versions.first.id
+      get :edit, id: version_id
+      expect(response).to be_success
+      expect(response).to render_template "events/edit"
+    end
+
+    it "should render html via xhr" do
+      version_id = @event.versions.first.id
+      xhr :get, :edit, id: version_id
+      expect(response).to be_success
+      expect(response).to render_template "events/_form"
+    end
+  end
+end
+
+end

data/spec/controllers/squash_many_duplicates_examples.rb

@@ -0,0 +1,49 @@
+shared_examples "#squash_many_duplicates" do |model|
+  before do
+    @master = FactoryGirl.create(model, title: "master")
+    @dup1 = FactoryGirl.create(model, title: "dup1")
+    @dup2 = FactoryGirl.create(model, title: "dup2")
+  end
+
+  context "happy path" do
+    before do
+      post :squash_many_duplicates, master_id: @master.id, duplicate_id_1: @dup1.id, duplicate_id_2: @dup2.id
+    end
+
+    it "squashes the duplicates into the master" do
+      expect(@master.duplicate_ids).to match_array([@dup1.id, @dup2.id])
+    end
+
+    it "redirects to duplicates page for more duplicate squashing" do
+      expect(response).to redirect_to("/#{model}s/duplicates")
+    end
+
+    it "sets the flash success message" do
+      expect(flash[:success]).to eq(%(Squashed duplicate #{model}s ["dup1", "dup2"] into master #{@master.id}.))
+    end
+  end
+
+  context "with no master" do
+    it "redirects with a failure message" do
+      post :squash_many_duplicates, duplicate_id_1: @dup1.id, duplicate_id_2: @dup2.id
+      expect(flash[:failure]).to eq("A master #{model} must be selected.")
+      expect(response).to redirect_to("/#{model}s/duplicates")
+    end
+  end
+
+  context "with no duplicates" do
+    it "redirects with a failure message" do
+      post :squash_many_duplicates, master_id: @master.id
+      expect(flash[:failure]).to eq("At least one duplicate #{model} must be selected.")
+      expect(response).to redirect_to("/#{model}s/duplicates")
+    end
+  end
+
+  context "with duplicates containing master" do
+    it "redirects with a failure message" do
+      post :squash_many_duplicates, master_id: @master.id, duplicate_id_1: @master.id
+      expect(flash[:failure]).to eq("The master #{model} could not be squashed into itself.")
+      expect(response).to redirect_to("/#{model}s/duplicates")
+    end
+  end
+end