cacheable_delegator 1.2.0 → 1.2.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Yjc0MjE1Y2JmODg4NDYyYTkxOGZkMjQ0MTQxYmZkOGE3MGY4MDUwNA==
+    MjRjYTRkYjIwNmIzYmQ1NTY4OTFlNzIzNDc5ZDJkYWZlYjg5MGJkNA==
   data.tar.gz: !binary |-
-    NWI1NTlhMDBmNTY4NDAyNGM4M2VjZmEwMzQyOTI5OGFkYjhlYjcwYw==
+    NDVjODg0N2EwYzQzZjliMmU1MmVjYWY3MmVkMGMwYjFkY2E1YzIzNA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    M2ZmOWQyNDQ3Yjg4MjE4YjYyNzFiOGU5ZmI4N2VkOTIzMDk4NjhlOGQ3YzEz
-    Mjg4M2NlNDZiZmFjZmRhZmMzMGZkOTE2OTllMTAyNjcwMzY5MmVjZTc4MWMw
-    OWQ3NGY2MGZiYWNjNTAwMDc2MGNmNGYzNTY4NWZiZTQ2ODdjNmQ=
+    N2U0MThmYjY5ZGQ5ZmZkYTEyNjJlNWJiZmIxYjc4OTEwZmIxODRhODhhNDBi
+    ZGQ2OWU0Y2ZjYTEwNTk4ZGEyNmZkZDdkZjAyZDJjNzU4ZWFiODRkNmQyMTA0
+    NjBhMzI3NTc5MzcxZGZhZDU1NzIwNTExZmY0OWM0YTliNjkyYWU=
   data.tar.gz: !binary |-
-    MWE1ODZlNjEzMzdiYWRjNWQ4YzcyMzhlM2NjYjMyYmJhNzIwZjY5N2ZlZjBj
-    ZWM2NTc1NTFjZDUxMTc2Njk3OTE1MDE2ZmVmNTFhYzdmMTJiYjc0MmIzODY5
-    Mjk2NjFkMTIwODJmNjIzNDQxYzU3YzM4OTcwYjg3NThlMzQ1ZTc=
+    ZjZkYzAxZjgyN2RlNjhmOTczNmRlNzI0MTUwMWVkNDAwYThlOTJhYjY2ZjZk
+    Mzc0ODIyZjA1YWMzZmFlYmZmMDdlNjU3ODRjMTY5NThlMGZjMTAyZmQxMmI1
+    MzEzMzBkOGU2NWQ1OTQxZjZjZmZhMTE0OWRiMDQ2MmY2NWE2MWU=

data/VERSION

@@ -1 +1 @@
-1.2.0
+1.2.1

data/cacheable_delegator.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "cacheable_delegator"
-  s.version = "1.2.0"
+  s.version = "1.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Dan Nguyen"]

data/lib/cacheable_delegator.rb

@@ -120,7 +120,7 @@ module CacheableDelegator
       col_str = col_name.to_s
       is_bespoke = opts.delete :bespoke     
       if !(self.source_class.method_defined?(col_str) || self.source_class.new.respond_to?(col_str)) && is_bespoke != true
-        raise ArgumentError, "Since :bespoke != true, instance of #{self.source_class} was expected to respond_to? :#{col_str}"
+        raise NonExistentInstanceMethod, "Since :bespoke != true, instance of #{self.source_class} was expected to respond_to? :#{col_str}"
       end
 
       custom_columns[col_name.to_s] = opts
@@ -206,3 +206,5 @@ module CacheableDelegator
 
 end
 
+
+class NonExistentInstanceMethod < ArgumentError; end

data/spec/mixin_active_record_inline_schema_spec.rb

@@ -47,7 +47,7 @@ describe CacheableDelegator do
         end
 
         it 'by default, should raise error if source_class does not respond_to custom column name' do 
-          expect{ MyCachedRecord.add_custom_column :not_foo_of_record }.to raise_error ArgumentError
+          expect{ MyCachedRecord.add_custom_column :not_foo_of_record }.to raise_error NonExistentInstanceMethod
         end
 
 
@@ -81,6 +81,38 @@ describe CacheableDelegator do
 
         end
 
+        context 'enforcement of responds_to' do 
+          it 'should allow adding of columns based on defined instance method' do 
+            MyCachedRecord.add_custom_column :superfluous_instance_method
+            MyCachedRecord.upgrade_schema!
+
+            expect(MyCachedRecord.column_names.include?('superfluous_instance_method')).to be_true
+          end
+
+          context 'respond_to_missing? works' do 
+            it 'should allow reference to dynamically defined methods' do 
+              MyCachedRecord.add_custom_column :dynamic_foo
+              MyCachedRecord.upgrade_schema!
+
+              expect(MyCachedRecord.column_names.include?('dynamic_foo')).to be_true 
+            end
+
+          end
+
+          context 'non-existent' do 
+            it 'should raise error of undefined instance methods' do 
+              expect{ MyCachedRecord.add_custom_column :non_existent_method }.to raise_error NonExistentInstanceMethod
+            end
+
+            it 'should not raise error if bespoke is true' do 
+              MyCachedRecord.add_custom_column :non_existent_method, bespoke: true 
+              MyCachedRecord.upgrade_schema!
+              expect(MyCachedRecord.column_names.include?('non_existent_method')).to be_true
+            end            
+          end
+        end
+
+
         it 'should allow exclusion of specified columns'
 
 

data/spec/spec_records.rb

@@ -49,11 +49,35 @@ class MyRecord < ActiveRecord::Base
     'special foo'
   end
 
+  def superfluous_instance_method
+    'hello'
+  end
 
   def foo_array
     [awesome_value, 'foo!', awesome_value]
   end
 
+
+
+  DELEGATING_REGEX ||= /^dynamic_(\w+)/
+
+  def method_missing(foo, *args, &block)
+    if foomatch = foo.to_s.match(DELEGATING_REGEX)
+      foo = foomatch[1].to_s
+      self.send(foo, *args, &block)
+    else
+      super
+    end
+  end
+
+  def respond_to?(method, f=false)
+    method =~ DELEGATING_REGEX || super
+  end
+
+
+  def respond_to_missing?(method, *)
+    method =~ DELEGATING_REGEX || super
+  end
 end
 
 class MyCover < ActiveRecord::Base

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cacheable_delegator
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Dan Nguyen