cache_rules 0.1.15 → 0.1.16
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- data/CHANGELOG.md +4 -0
- data/cache_rules.gemspec +1 -1
- data/lib/formatting.rb +1 -1
- data/test/test_regressions.rb +9 -0
- metadata +1 -1
data/CHANGELOG.md
CHANGED
data/cache_rules.gemspec
CHANGED
data/lib/formatting.rb
CHANGED
|
@@ -30,7 +30,7 @@ module CacheRules
|
|
|
30
30
|
def clean
|
|
31
31
|
->(headers) {
|
|
32
32
|
Array(headers).reject {|key, value|
|
|
33
|
-
HEADERS_NO_CACHE.include?(key) || helper_is_if_modified_error?(key, value)
|
|
33
|
+
HEADERS_NO_CACHE.include?(key) || helper_is_if_modified_error?(key, value) || value.nil? || value.empty?
|
|
34
34
|
}
|
|
35
35
|
}
|
|
36
36
|
end
|
data/test/test_regressions.rb
CHANGED
|
@@ -35,4 +35,13 @@ class TestRegressions < MiniTest::Test
|
|
|
35
35
|
|
|
36
36
|
assert_kind_of TrueClass, no_max_stale
|
|
37
37
|
end
|
|
38
|
+
|
|
39
|
+
# https://github.com/aw/CacheRules/issues/8
|
|
40
|
+
def test_bugfix_8_errors_caused_by_empty_http_headers
|
|
41
|
+
isnil = CacheRules.clean.call({'Content-Type'=>nil})
|
|
42
|
+
isempty = CacheRules.clean.call({'Content-Type'=>''})
|
|
43
|
+
|
|
44
|
+
assert_equal isnil, []
|
|
45
|
+
assert_equal isempty, []
|
|
46
|
+
end
|
|
38
47
|
end
|