cable_room 0.7.0.beta3 → 0.8.0.beta1

data/cable_room.gemspec

@@ -18,17 +18,14 @@ Gem::Specification.new do |spec|
   spec.summary       = "Build live Rooms on top of ActionCable"
   spec.homepage      = "https://instructure.com"
 
-  spec.files = Dir["{app,config,db,exe,lib}/**/*", "README.md", "CHANGELOG.md", "*.gemspec"]
-  spec.bindir = "exe"
-  spec.executables = ["cable_room"]
+  spec.files = Dir["{app,config,db,lib}/**/*", "README.md", "*.gemspec"]
   spec.require_paths = ['lib']
 
   spec.add_dependency "rails", ">= 7.2", "< 9.0"
   spec.add_dependency "rufus-scheduler", "~> 3.6"
   spec.add_dependency "redlock", "~> 2.0"
   spec.add_dependency "rediconn", "~> 0.1.2"
-  # rediconn builds pools of redis-rb clients but doesn't declare the gem; the Bus needs it too
-  spec.add_dependency "redis", ">= 5.0"
 
+  spec.add_development_dependency "redis"
   spec.add_development_dependency 'rspec', '~> 3'
 end

data/lib/cable_room/host/action_cable_inbound.rb

@@ -0,0 +1,35 @@
+module CableRoom
+  class Host
+    # How rooms receive messages: straight off ActionCable's pubsub adapter, on the same stream
+    # names members publish to (Room::Base.room_port_key). This is the only place the room side
+    # touches ActionCable for inbound traffic; anything with the same two methods can be handed to
+    # `Host.new(inbound:)`.
+    #
+    # `subscribe` returns a handle that `unsubscribe` needs back. Handlers receive the payload
+    # exactly as published (a JSON string, for ActionCable) on the adapter's own thread, so they
+    # must be quick and hand the real work off. Host::Runner does that by queueing it on the room.
+    # `on_live` runs on that same thread once the adapter confirms the subscription.
+    class ActionCableInbound
+      # Subscribes from the calling thread. ActionCable's own stream_from posts the subscribe to
+      # the event loop first, but the adapter registers asynchronously either way, so that extra
+      # hop only widens the window in which the room can't hear anything.
+      #
+      # The adapter calls `on_live` while holding its own subscriber-map lock, so it must never
+      # wait on anything that might be waiting on the adapter (a room's mutex, say).
+      def subscribe(stream, on_live: nil, &on_message)
+        server.pubsub.subscribe(stream, on_message, on_live)
+        on_message
+      end
+
+      def unsubscribe(stream, handle)
+        server.pubsub.unsubscribe(stream, handle)
+      end
+
+      private
+
+      def server
+        ActionCable.server
+      end
+    end
+  end
+end