bypass 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 718e8ae5c353526d782ccaa70459e5f5dc70b84f
-  data.tar.gz: 870eadce1dfe1ba0fe41625d12527fe3fa09c03b
+  metadata.gz: 241540206797fc2ee8bb927912833a4ee8146acc
+  data.tar.gz: 3d107907b49d2a7ff4bfc1852212fef76f05dbbe
 SHA512:
-  metadata.gz: 6a11749670fe237ebe686e126a9620ed2463c9855284290850c9ca81cf85d14f7c5e679b70543006986ec668d18538ced58ec7e21b889dad8ec79bf43aa02a55
-  data.tar.gz: a2d4dfcd1fc1ff96b30452dc251bfff9a1826fd6de7e860016a2ff00cc1584ba43d6ad33232b23d867f4850fd6b9f2eef6200bae7b6d16af3ddfdadfef42f66e
+  metadata.gz: c34514af9628da625ad96c9d20b070fa890b0bdf252105f1b2c62c88ee7ddc81c79b1abfe0ea26c6e2277dc89ffbafad984dec87368f4166eb2aa1528da59797
+  data.tar.gz: 30a6d0eab06f840b8308c32b28c823a61ff8025acf273c51c4483f21770796dd3c33e50f8d4b7a051b6daff35978d17137f56d8dc3f7e0c57fe198f5df11f44b

data/lib/bypass/uri.rb

@@ -3,7 +3,14 @@ require "addressable/uri"
 module Bypass
   class URI < Addressable::URI
     def append_to_query_values(params = {})
-      self.query_values = (query_values || {}).merge(params)
+      pairs = params.keys.map do |raw_key|
+        key = self.class.encode(raw_key.to_s)
+        val = self.class.encode(params[raw_key])
+        [key, val].join("=")
+      end
+
+      pairs.unshift(query) if query
+      self.query = pairs.join("&")
     end
   end
-end
+end

data/lib/bypass/version.rb

@@ -1,3 +1,3 @@
 module Bypass
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/test/bypass/uri_test.rb

@@ -7,5 +7,41 @@ class Bypass::URITest < MiniTest::Test
       uri.append_to_query_values(:foo => "bar")
       assert_equal "http://www.getdrip.com?foo=bar", uri.to_s
     end
+
+    should "add mulitple values" do
+      uri = Bypass::URI.parse("http://www.getdrip.com")
+      uri.append_to_query_values(:foo => "bar", :name => "Ian")
+      assert_equal "http://www.getdrip.com?foo=bar&name=Ian", uri.to_s
+    end
+
+    should "append to the existing query string" do
+      uri = Bypass::URI.parse("http://www.getdrip.com?foo=bar")
+      uri.append_to_query_values(:name => "Ian")
+      assert_equal "http://www.getdrip.com?foo=bar&name=Ian", uri.to_s
+    end
+
+    should "support array-style keys" do
+      uri = Bypass::URI.parse("http://www.getdrip.com?foo[]=bar1&foo[]=bar2")
+      uri.append_to_query_values(:name => "Ian")
+      assert_equal "http://www.getdrip.com?foo[]=bar1&foo[]=bar2&name=Ian", uri.to_s
+    end
+
+    should "not attempt to merge duplicate keys" do
+      uri = Bypass::URI.parse("http://www.getdrip.com?name=Ian")
+      uri.append_to_query_values(:name => "Derrick")
+      assert_equal "http://www.getdrip.com?name=Ian&name=Derrick", uri.to_s
+    end
+
+    should "encode keys" do
+      uri = Bypass::URI.parse("http://www.getdrip.com")
+      uri.append_to_query_values("first name" => "Ian")
+      assert_equal "http://www.getdrip.com?first%20name=Ian", uri.to_s
+    end
+
+    should "encode values" do
+      uri = Bypass::URI.parse("http://www.getdrip.com")
+      uri.append_to_query_values(:name => "Ian Nance")
+      assert_equal "http://www.getdrip.com?name=Ian%20Nance", uri.to_s
+    end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bypass
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Derrick Reimer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-26 00:00:00.000000000 Z
+date: 2015-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -134,3 +134,4 @@ test_files:
 - test/bypass/text_filter_test.rb
 - test/bypass/uri_test.rb
 - test/test_helper.rb
+has_rdoc: