byebug 3.4.1 → 3.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7001ae9053bb3dff2ca95eee6b105c0b1e75b06b
-  data.tar.gz: f1d8c6f4b00f51f1460f6833bdc28dcf84f28a4d
+  metadata.gz: 51062987a9c4c26728720d8416eb99354576fa00
+  data.tar.gz: 2c85de15d46650690562bc84533ad254890efb18
 SHA512:
-  metadata.gz: 8360f244410378f4b11caae0eabcd6dcc18cacd66562fd7a460d99c5861c03ff5a92a08f027bb9dc5fc25ae3527518e8ac45ed3e5643389fd0cfd9eac2354f75
-  data.tar.gz: f9bba361d8ace23476c667df962e610fe1a054de7224c8ae8cf392fa8ee930656d5d6ac7f3f6ddfceb863cdb3f9926c808f785476c3833123a021bbb7d24889d
+  metadata.gz: c6840103b5586afd62b89c16a28e512e73b4365734e4fc7e3c06f6e93f2563d7d9e255ef9bbe978b4557e9152c576e7800177a464f56ac93d5396a543ea18ba8
+  data.tar.gz: bf2fee35bad9a06b866f6350435ad81b7807f6d7b8e42394de54b22e9f82bdbe2244d2a6b124b300b311b1072426e0587081e523ec4b9e11f16b75780b70110f

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 3.4.2
+* Fix #67, you can debug commands starting with `ruby` now, as in `byebug --
+ruby -Itest test/controllers/posts_controller_test.rb -n test_should_get_index`
+
+
 # 3.4.1
 * Fix #54, you can use threads when "evaling" stuff now.
 * Fix bug in list command where user could not list backwards if current

data/GUIDE.md

@@ -204,7 +204,7 @@ Pathname          fail                  process_options             trap
 Rational          fork                  public                      untrace_var
 String            format                putc                        using      
 __callee__        gem                   puts                        warn       
-__dir__           gem_original_require  raise                       whence_file
+__dir__           gem_original_require  raise                     
 __method__        gets                  rand                      
 `                 global_variables      readline                  
 abort             include               readlines                 

data/README.md

@@ -136,13 +136,10 @@ connected.
 * [sublime_debugger][] provides a plugin for ruby debugging on Sublime Text.
 
 
-## TODO List (by priority)
+## Contribute
 
-* Write tests for remote debugging support.
-* Add printers support.
-* Support rubies other than MRI.
+See [Getting Started with Development](CONTRIBUTING.md).
 
-[Getting Started with Development](CONTRIBUTING.md)
 
 ## Credits
 

data/lib/byebug/helper.rb

@@ -1,4 +1,24 @@
 module Byebug
+  module MiscUtils
+    #
+    # Cross-platform way of finding an executable in the $PATH.
+    # Borrowed from: http://stackoverflow.com/questions/2108727
+    #
+    def which(cmd)
+      return File.expand_path(cmd) if File.exist?(cmd)
+
+      exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
+      ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
+        exts.each do |ext|
+          exe = File.join(path, "#{cmd}#{ext}")
+          return exe if File.executable?(exe) && !File.directory?(exe)
+        end
+      end
+
+      nil
+    end
+  end
+
   #
   # Miscelaneous Utilities
   #

data/lib/byebug/runner.rb

@@ -28,40 +28,25 @@ module Byebug
       Byebug.puts "#{status}\n#{status.backtrace}" if status
     end
 
+    include MiscUtils
     #
-    # Do a shell-like path lookup for prog_script and return the results. If we
-    # can't find anything return prog_script.
-    #
-    def whence_file(prog_script)
-      if prog_script.index(File::SEPARATOR)
-        # Don't search since this name has path separator components
-        return prog_script
-      end
-
-      ENV['PATH'].split(File::PATH_SEPARATOR).each do |dirname|
-        prog_script_try = File.join(dirname, prog_script)
-        return prog_script_try if File.exist?(prog_script_try)
-      end
-
-      # Failure
-      prog_script
-    end
-
-    #
-    # Save path to program to be debugged
+    # Extracts path to program to be debugged from ARGV
     #
     # Used for restarts.
     #
-    def save_debugged_program
+    def debugged_program_from_argv
       if ARGV.empty?
         Byebug.puts 'You must specify a program to debug...'
         abort
       end
 
-      prog_script = ARGV.first
-      prog_script = whence_file(prog_script) unless File.exist?(prog_script)
+      prog_script_try = which(ARGV.first)
+      if prog_script_try == which('ruby')
+        ARGV.shift
+        return which(ARGV.first)
+      end
 
-      Byebug.debugged_program = File.expand_path(prog_script)
+      prog_script_try
     end
 
     #
@@ -80,7 +65,7 @@ module Byebug
         return
       end
 
-      save_debugged_program
+      Byebug.debugged_program = debugged_program_from_argv
 
       # Set up trace hook for byebug
       Byebug.start

data/lib/byebug/version.rb

@@ -1,3 +1,3 @@
 module Byebug
-  VERSION = '3.4.1'
+  VERSION = '3.4.2'
 end

data/test/runner_test.rb

@@ -1,11 +1,11 @@
 require 'byebug/runner'
 
 module Byebug
-
   class RunnerTest < TestCase
     def setup
       super
       @old_argv = ARGV
+      @runner = Byebug::Runner.new
     end
 
     def after
@@ -14,14 +14,14 @@ module Byebug
 
     def test_run_with_version_flag
       ARGV.replace(%w(--version))
-      Byebug::Runner.new.run
+      @runner.run
 
       check_output_includes(/#{Byebug::VERSION}/)
     end
 
     def test_run_with_help_flag
       ARGV.replace(%w(--help))
-      Byebug::Runner.new.run
+      @runner.run
 
       check_output_includes(/-d.*-I.*-q.*-s.*-x.*-m.*-r.*-R.*-t.*-v.*-h/m)
     end
@@ -29,7 +29,7 @@ module Byebug
     def test_run_with_remote_option_only_with_a_port_number
       ARGV.replace(%w(--remote 9999))
       Byebug.expects(:start_client)
-      Byebug::Runner.new.run
+      @runner.run
 
       check_output_includes(/Connecting to byebug server localhost:9999/)
     end
@@ -37,7 +37,7 @@ module Byebug
     def test_run_with_remote_option_with_host_and_port_specification
       ARGV.replace(%w(--remote myhost:9999))
       Byebug.expects(:start_client)
-      Byebug::Runner.new.run
+      @runner.run
 
       check_output_includes(/Connecting to byebug server myhost:9999/)
     end
@@ -45,7 +45,7 @@ module Byebug
     def test_run_without_a_script_to_debug
       ARGV.replace([])
 
-      assert_raises(SystemExit) { Byebug::Runner.new.run }
+      assert_raises(SystemExit) { @runner.run }
 
       check_output_includes(/You must specify a program to debug.../)
     end
@@ -60,14 +60,23 @@ module Byebug
       ARGV.replace(%w(my_script))
       expect_it_debugs_script
 
-      Byebug::Runner.new.run
+      @runner.run
+    end
+
+    def test_run_with_a_script_and_params_does_not_consume_script_params
+      ARGV.replace(%w(-- my_script -opt value))
+      expect_it_debugs_script
+
+      @runner.run
+      assert_equal %w(my_script -opt value), ARGV
     end
 
-    def test_saved_debugged_program
-      ARGV.replace(%w(my_script -opt value))
+    def test_run_with_ruby_script_ruby_is_ignored_and_script_passed_instead
+      ARGV.replace(%w(-- ruby ruby_script))
+      expect_it_debugs_script
 
-      Byebug::Runner.new.save_debugged_program
-      assert_match 'my_script', Byebug.debugged_program
+      @runner.run
+      assert_equal %w(ruby_script), ARGV
     end
 
     def test_run_with_no_rc_option
@@ -76,14 +85,14 @@ module Byebug
       Byebug::Runner.any_instance.expects(:debug_program)
       Byebug.expects(:run_init_script).never
 
-      Byebug::Runner.new.run
+      @runner.run
     end
 
     def test_run_with_post_mortem_mode_flag
       ARGV.replace(%w(-m my_script))
       expect_it_debugs_script
+      @runner.run
 
-      Byebug::Runner.new.run
       assert_equal true, Byebug.post_mortem?
       Byebug::Setting[:post_mortem] = false
     end
@@ -91,8 +100,8 @@ module Byebug
     def test_run_with_linetracing_flag
       ARGV.replace(%w(-t my_script))
       expect_it_debugs_script
+      @runner.run
 
-      Byebug::Runner.new.run
       assert_equal true, Byebug.tracing?
       Byebug::Setting[:linetrace] = false
     end
@@ -100,16 +109,16 @@ module Byebug
     def test_run_with_no_quit_flag
       skip 'for now'
       ARGV.replace(%w(--no-quit my_script))
+      @runner.run
 
-      Byebug::Runner.new.run
       check_output_includes('(byebug:ctrl)')
     end
 
     def test_run_with_require_flag
       ARGV.replace(%w(-r abbrev my_script))
       expect_it_debugs_script
+      @runner.run
 
-      Byebug::Runner.new.run
       hsh = { 'can' => 'can', 'cat' => 'cat' }
       assert_equal hsh, %w(can cat).abbrev
     end
@@ -117,16 +126,16 @@ module Byebug
     def test_run_with_include_flag
       ARGV.replace(%w(-I custom_dir my_script))
       expect_it_debugs_script
+      @runner.run
 
-      Byebug::Runner.new.run
       assert_includes $LOAD_PATH, 'custom_dir'
     end
 
     def test_run_with_debug_flag
       ARGV.replace(%w(-d my_script))
       expect_it_debugs_script
+      @runner.run
 
-      Byebug::Runner.new.run
       assert_equal $DEBUG, true
       $DEBUG = false
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: byebug
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 3.4.2
 platform: ruby
 authors:
 - David Rodriguez
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-25 00:00:00.000000000 Z
+date: 2014-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: columnize