byebug 2.7.0 → 3.0.0

data/test/quit_test.rb

@@ -27,9 +27,9 @@ class TestQuit < TestDsl::TestCase
     check_output_doesnt_include 'Really quit? (y/n)', interface.confirm_queue
   end
 
-  it 'must finalize interface before quitting' do
+  it 'must close interface before quitting' do
     Byebug::QuitCommand.any_instance.stubs(:exit!)
-    interface.expects(:finalize)
+    interface.expects(:close)
     enter 'quit!'
     debug_file 'quit'
   end

data/test/restart_test.rb

@@ -60,47 +60,26 @@ class TestRestart < TestDsl::TestCase
     describe 'no script specified' do
       temporary_change_const Byebug, 'PROG_SCRIPT', :__undefined__
 
-      describe 'and no $0 used' do
-        temporary_change_const Byebug, 'DEFAULT_START_SETTINGS',
-          { init: false, post_mortem: false, tracing: nil }
-
-        it 'must not restart and show error messages instead' do
-          must_restart.never
-          debug_file 'restart'
-          check_output_includes 'Don\'t know name of debugged program',
-                                interface.error_queue
-        end
-      end
-
-      describe 'but initialized from $0' do
-        it 'must use prog_script from $0' do
-          old_prog_name = $0
-          $0 = 'prog-0'
-          debug_file 'restart'
-          check_output_includes 'Ruby program prog-0 doesn\'t exist',
+      it 'must not restart and show error messages instead' do
+        must_restart.never
+        debug_file 'restart'
+        check_output_includes 'Don\'t know name of debugged program',
                                 interface.error_queue
-          $0 = old_prog_name
-        end
       end
     end
 
     describe 'no script at the specified path' do
       temporary_change_const Byebug, 'PROG_SCRIPT', 'blabla'
 
-      describe 'and no restart params set' do
-        temporary_change_const Byebug, 'DEFAULT_START_SETTINGS',
-          init: false, post_mortem: false, tracing: nil
-
-        it 'must not restart' do
-          must_restart.never
-          debug_file 'restart'
-        end
+      it 'must not restart' do
+        must_restart.never
+        debug_file 'restart'
+      end
 
-        it 'must show an error message' do
-          debug_file 'restart'
-          check_output_includes 'Ruby program blabla doesn\'t exist',
-                                interface.error_queue
-        end
+      it 'must show an error message' do
+        debug_file 'restart'
+        check_output_includes 'Ruby program blabla doesn\'t exist',
+                              interface.error_queue
       end
     end
 

data/test/set_test.rb

@@ -1,58 +1,64 @@
 class TestSet < TestDsl::TestCase
 
-  describe 'setting to on' do
-    temporary_change_hash Byebug.settings, :autolist, 0
+  [:autoeval, :autoreload, :autosave, :basename, :forcestep, :fullpath,
+   :linetrace_plus, :stack_on_error].each do |setting|
 
-    it 'must set a setting to on' do
-      enter 'set autolist on'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 1
-    end
+    describe "setting #{setting} to on" do
+      temporary_change_hash Byebug.settings, setting, false
 
-    it 'must set a setting to on by 1' do
-      enter 'set autolist 1'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 1
-    end
+      it "must set #{setting} to on using on" do
+        enter "set #{setting} on"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal true
+      end
 
-    it 'must set a setting to on by default' do
-      enter 'set autolist'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 1
-    end
+      it "must set #{setting} to on using 1" do
+        enter "set #{setting} 1"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal true
+      end
 
-    it 'must set a setting using shortcut' do
-      enter 'set autol'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 1
+      it "must set #{setting} to on by default" do
+        enter "set #{setting}"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal true
+      end
+
+      it "must set #{setting} using shortcut" do
+        skip 'it for now until I make it work'
+        enter "set autol"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal 1
+      end
     end
-  end
 
-  describe 'setting to off' do
-    temporary_change_hash Byebug.settings, :autolist, 1
+    describe "setting #{setting} to off" do
+      temporary_change_hash Byebug.settings, setting, true
 
-    it 'must set a setting to off' do
-      enter 'set autolist off'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 0
-    end
+      it "must set #{setting} to off using off" do
+        enter "set #{setting} off"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal false
+      end
 
-    it 'must set a setting to off by 0' do
-      enter 'set autolist 0'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 0
-    end
+      it "must set #{setting} to on using 0" do
+        enter "set #{setting} 0"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal false
+      end
 
-    it 'must set a setting to off by "no" prefix' do
-      enter 'set noautolist'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 0
-    end
+      it "must set #{setting} to off using 'no' prefix" do
+        enter "set no#{setting}"
+        debug_file 'set'
+        Byebug.settings[setting].must_equal false
+      end
 
-    it 'must set a setting to off by "no" prefix and shortcut' do
-      enter 'set noautol'
-      debug_file 'set'
-      Byebug.settings[:autolist].must_equal 0
+      it "must set #{setting} off using 'no' prefix and shortcut" do
+        skip 'it for now until I make it work'
+        enter 'set noautol'
+        debug_file 'set'
+        Byebug.settings[setting].must_equal 0
+      end
     end
   end
 
@@ -89,82 +95,49 @@ class TestSet < TestDsl::TestCase
     end
   end
 
-  describe 'history' do
-    describe 'save' do
-      it 'must set history save to on' do
-        enter 'set history save on'
-        debug_file 'set'
-        interface.history_save.must_equal true
-      end
-
-      it 'must set history save to on when no param' do
-        enter 'set history save'
-        debug_file 'set'
-        interface.history_save.must_equal true
-      end
-
-      it 'must show a message' do
-        enter 'set history save on'
-        debug_file 'set'
-        check_output_includes 'Saving of history save is on.'
-      end
+  describe 'histsize' do
+    after { Byebug::History.max_size = Byebug::History::DEFAULT_MAX_SIZE }
 
-      it 'must set history save to off' do
-        enter 'set history save off'
-        debug_file 'set'
-        interface.history_save.must_equal false
-      end
+    it 'must set maximum history size' do
+      enter 'set histsize 250'
+      debug_file 'set'
+      Byebug::History.max_size.must_equal 250
     end
 
-    describe 'size' do
-      it 'must set history size' do
-        enter 'set history size 250'
-        debug_file 'set'
-        interface.history_length.must_equal 250
-      end
-
-      it 'must show a message' do
-        enter 'set history size 250'
-        debug_file 'set'
-        check_output_includes 'Byebug history size is 250'
-      end
-
-      it 'must show an error message if no size provided' do
-        enter 'set history size'
-        debug_file 'set'
-        check_output_includes 'You need to specify the history size'
-      end
+    it 'must show a message' do
+      enter 'set histsize 250'
+      debug_file 'set'
+      check_output_includes "Byebug history's maximum size is 250"
     end
 
-    describe 'filename' do
-      let(:filename) {
-        File.join(ENV['HOME']||ENV['HOMEPATH']||'.', '.byebug-hist') }
+    it 'must show an error message if no size provided' do
+      enter 'set histsize'
+      debug_file 'set'
+      check_output_includes 'You need to specify the history size'
+    end
+  end
 
-      it 'must set history filename' do
-        enter 'set history filename .byebug-hist'
-        debug_file 'set'
-        interface.histfile.must_equal filename
-      end
+  describe 'histfile' do
+    let(:filename) { File.expand_path('./.custom-byebug-hist') }
 
-      it 'must show a message' do
-        enter 'set history filename .byebug-hist'
-        debug_file 'set'
-        check_output_includes "The command history file is \"#{filename}\""
-      end
+    after { Byebug::History.file = Byebug::History::DEFAULT_FILE }
 
-      it 'must show an error message if no filenmae provided' do
-        enter 'set history filename'
-        debug_file 'set'
-        check_output_includes 'You need to specify a filename'
-      end
+    it 'must set history filename' do
+      enter "set histfile #{filename}"
+      debug_file 'set'
+      Byebug::History.file.must_equal filename
+    end
 
+    it 'must show a message' do
+      enter "set histfile #{filename}"
+      debug_file 'set'
+      check_output_includes "The command history file is \"#{filename}\""
     end
 
-    it 'must show an error message if used wrong subcommand' do
-      enter 'set history bla 2'
+    it 'must show an error message if no filename provided' do
+      enter 'set histfile'
       debug_file 'set'
-      check_output_includes \
-        'Invalid history parameter bla. Should be "filename", "save" or "size"'
+      check_output_includes 'You need to specify a filename'
     end
   end
 

data/test/show_test.rb

@@ -48,7 +48,7 @@ class TestShow < TestDsl::TestCase
   end
 
   describe 'autoirb' do
-    before { Byebug::IRBCommand.any_instance.stubs(:execute) }
+    before { Byebug::IrbCommand.any_instance.stubs(:execute) }
 
     it 'must show default value' do
       enter 'show autoirb'
@@ -135,7 +135,7 @@ class TestShow < TestDsl::TestCase
     it 'must show default width' do
       enter 'show width'
       debug_file 'show'
-      check_output_includes "width is #{cols}."
+      check_output_includes "Width is #{cols}."
     end
   end
 
@@ -147,109 +147,74 @@ class TestShow < TestDsl::TestCase
     end
   end
 
-  describe 'history' do
-    describe 'without arguments' do
-      before do
-        interface.histfile = 'hist_file.txt'
-        interface.history_save = true
-        interface.history_length = 25
-        enter 'show history'
-        debug_file 'show'
-      end
-
-      it 'must show history file' do
-        check_output_includes(
-          /filename: The command history file is "hist_file\.txt"/)
-      end
+  describe 'autosave' do
+    it 'must show default value' do
+      enter 'show autosave'
+      debug_file 'show'
+      check_output_includes 'Saving history is on.'
+    end
+  end
 
-      it 'must show history save setting' do
-        check_output_includes(/save: Saving of history save is on\./)
-      end
+  describe 'histfile' do
+    before { @filename = Byebug::History::DEFAULT_FILE }
 
-      it 'must show history length' do
-        check_output_includes(/size: Byebug history size is 25/)
-      end
+    it 'must show history filename' do
+      enter 'show histfile'
+      debug_file 'show'
+      check_output_includes "The command history file is \"#{@filename}\""
     end
+  end
 
-    describe 'with "filename" argument' do
-      it 'must show history filename' do
-        interface.histfile = 'hist_file.txt'
-        enter 'show history filename'
-        debug_file 'show'
-        check_output_includes 'The command history file is "hist_file.txt"'
-      end
-
-      it 'must show history save setting' do
-        interface.history_save = true
-        enter 'show history save'
-        debug_file 'show'
-        check_output_includes 'Saving of history save is on.'
-      end
+  describe 'histsize' do
+    before { @max_size = Byebug::History::DEFAULT_MAX_SIZE }
 
-      it 'must show history length' do
-        interface.history_length = 30
-        enter 'show history size'
-        debug_file 'show'
-        check_output_includes 'Byebug history size is 30'
-      end
+    it "must show history's max size" do
+      enter 'show histsize'
+      debug_file 'show'
+      check_output_includes "Byebug history's maximum size is #{@max_size}"
     end
   end
 
   describe 'commands' do
-    describe 'no readline support' do
-      before { interface.readline_support = false }
+    temporary_change_const Readline, 'HISTORY', %w(aaa bbb ccc ddd)
+
+    describe 'with history disabled' do
+      temporary_change_hash Byebug.settings, :autosave, false
 
       it 'must not show records from readline' do
         enter 'show commands'
         debug_file 'show'
-        check_output_includes 'No readline support'
+        check_output_includes "Not currently saving history. " \
+                              'Enable it with "set autosave"'
       end
     end
 
-    describe 'readline support' do
-      before { interface.readline_support = true }
+    describe 'with history enabled' do
+      temporary_change_hash Byebug.settings, :autosave, true
 
       describe 'show records' do
-        temporary_change_const Readline, 'HISTORY', %w{aaa bbb ccc ddd eee fff}
-
-        it 'must show records from readline history' do
-          enter 'show commands'
+        it 'displays last max_size records from readline history' do
+          enter 'set histsize 3', 'show commands'
           debug_file 'show'
-          check_output_includes(/1  aaa/)
-          check_output_includes(/6  fff/)
+          check_output_includes(/2  bbb\n    3  ccc\n    4  ddd/)
+          check_output_doesnt_include(/1  aaa/)
         end
       end
 
       describe 'max records' do
-        temporary_change_const Readline, 'HISTORY', %w{aaa bbb ccc ddd eee fff ggg hhh iii jjj kkk lll mmm nnn}
-
-        it 'must show last 10 records from readline history' do
-          enter 'show commands'
+        it 'displays whole history if max_size is bigger than Readline::HISTORY' do
+          enter 'set histsize 7', 'show commands'
           debug_file 'show'
-          check_output_doesnt_include(/3  ddd/)
-          check_output_includes(/4  eee/)
-          check_output_includes(/13  nnn/)
+          check_output_includes(/1  aaa\n    2  bbb\n    3  ccc\n    4  ddd/)
         end
       end
 
-      describe 'with specified positions' do
-        temporary_change_const Readline, 'HISTORY', %w{aaa bbb ccc ddd eee fff ggg hhh iii jjj kkk lll mmm nnn}
-
-        it 'must show records within boundaries' do
-          # Really don't know why it substracts 4, and shows starting from position 6
-          enter 'show commands 10'
-          debug_file 'show'
-          check_output_doesnt_include(/5  fff/)
-          check_output_includes(/6  ggg/)
-          check_output_includes(/13  nnn/)
-        end
-
-        it 'must adjust first line if it is < 0' do
-          enter 'show commands 3'
+      describe 'with specified size' do
+        it 'displays the specified number of entries most recent first' do
+          enter 'show commands 2'
           debug_file 'show'
-          check_output_includes(/1  bbb/)
-          check_output_includes(/8  iii/)
-          check_output_doesnt_include(/9  jjj/)
+          check_output_includes(/3  ccc\n    4  ddd/)
+          check_output_doesnt_include(/1  aaa\n    2  bbb/)
         end
       end
     end