byebug 1.8.2 → 2.0.0

data/test/conditions_test.rb

@@ -69,13 +69,4 @@ class TestConditions < TestDsl::TestCase
       debug_file('conditions') { $state.line.must_equal 3 }
     end
   end
-
-  describe 'Post Mortem' do
-    it 'must be able to set conditions in post-mortem mode' do
-      enter 'cont', 'break 12', ->{ "cond #{Byebug.breakpoints.first.id} true" },
-            'cont'
-      debug_file('post_mortem') { $state.line.must_equal 12 }
-    end
-  end
-
 end

data/test/continue_test.rb

@@ -28,8 +28,8 @@ class TestContinue < TestDsl::TestCase
     it "must show error if specified line is not valid" do
       enter 'cont 123'
       debug_file 'continue'
-      check_output_includes "Line 123 is not a stopping point in file " \
-                            "\"#{fullpath('continue')}\"", interface.error_queue
+      check_error_includes \
+        "Line 123 is not a stopping point in file \"#{fullpath('continue')}\""
     end
   end
 end

data/test/display_test.rb

@@ -24,7 +24,7 @@ class TestDisplay < TestDsl::TestCase
       Byebug.handler.display.concat([[true, 'abc'], [true, 'd']]); 'display'
     end
     debug_file 'display'
-    check_output_includes '1: ', 'abc = ', '2: ', 'd = 4'
+    check_output_includes '1: ', 'abc = nil', '2: ', 'd = 4'
   end
 
   describe 'undisplay' do
@@ -52,7 +52,7 @@ class TestDisplay < TestDsl::TestCase
 
         it 'must not show any output' do
           debug_file 'display'
-          check_output_doesnt_include '1: ', 'abc = ', '2: ', 'd = 4'
+          check_output_doesnt_include '1: ', 'abc = nil', '2: ', 'd = 4'
         end
       end
 
@@ -66,7 +66,7 @@ class TestDisplay < TestDsl::TestCase
 
         it 'must not show any output' do
           debug_file 'display'
-          check_output_includes '1: ', 'abc = ', '2: ', 'd = 4'
+          check_output_includes '1: ', 'abc = nil', '2: ', 'd = 4'
         end
       end
     end
@@ -113,7 +113,7 @@ class TestDisplay < TestDsl::TestCase
       enter 'display d', 'disable display 4'
       debug_file 'display'
       check_output_includes \
-        'Disable display argument "4" needs to be at most 1.'
+        '"disable display" argument "4" needs to be at most 1.'
     end
   end
 
@@ -123,23 +123,4 @@ class TestDisplay < TestDsl::TestCase
       debug_file('display') { $state.display.must_equal [[true, 'd']] }
     end
   end
-
-  describe 'annotate' do
-    after  { Byebug.annotate = 0 }
-
-    it 'must show display expression in annotation' do
-      enter 'display 2 + 2', 'set annotate 3', 'next', 'next'
-      debug_file 'display'
-      check_output_includes "\u001A\u001Adisplay", '1:', '2 + 2 = 4'
-    end
-  end
-
-  describe 'Post Mortem' do
-    it 'must be able to set display expressions in post-mortem mode' do
-      enter 'cont', 'display 2 + 2'
-      debug_file 'post_mortem'
-      check_output_includes '1:', '2 + 2 = 4'
-    end
-  end
-
 end

data/test/edit_test.rb

@@ -38,26 +38,12 @@ class TestEdit < TestDsl::TestCase
   it 'must show an error if there is no such line' do
     enter "edit #{fullpath('edit3')}:6"
     debug_file 'edit'
-    check_output_includes \
-      "File \"#{fullpath('edit3')}\" is not readable.", interface.error_queue
+    check_error_includes "File \"#{fullpath('edit3')}\" is not readable."
   end
 
   it 'must show an error if there is incorrect syntax' do
     enter 'edit blabla'
     debug_file 'edit'
-    check_output_includes \
-      'Invalid file/line number specification: blabla', interface.error_queue
+    check_error_includes 'Invalid file/line number specification: blabla'
   end
-
-  describe 'Post Mortem' do
-    temporary_change_hash ENV, 'EDITOR', 'editr'
-
-    it 'must work in post-mortem mode' do
-      Byebug::Edit.any_instance.expects(:system).
-                                with("editr +2 #{fullpath('edit')}")
-      enter 'cont', "edit #{fullpath('edit')}:2", 'cont'
-      debug_file 'post_mortem'
-    end
-  end
-
 end

data/test/eval_test.rb

@@ -38,7 +38,7 @@ class TestEval < TestDsl::TestCase
 
   describe 'stack trace on error' do
     describe 'when enabled' do
-      temporary_change_hash Byebug::Command.settings, :stack_trace_on_error, true
+      temporary_change_hash Byebug.settings, :stack_trace_on_error, true
 
       it 'must show a stack trace' do
         enter 'eval 2 / 0'
@@ -49,7 +49,7 @@ class TestEval < TestDsl::TestCase
     end
 
     describe 'when disabled' do
-      temporary_change_hash Byebug::Command.settings, :stack_trace_on_error, false
+      temporary_change_hash Byebug.settings, :stack_trace_on_error, false
 
       it 'must only show exception' do
         enter 'eval 2 / 0'
@@ -69,7 +69,7 @@ class TestEval < TestDsl::TestCase
   end
 
   describe 'putl' do
-    temporary_change_hash Byebug::Command.settings, :width, 20
+    temporary_change_hash Byebug.settings, :width, 20
 
     it 'must print expression and columnize the result' do
       enter 'putl [1, 2, 3, 4, 5, 9, 8, 7, 6]'
@@ -79,7 +79,7 @@ class TestEval < TestDsl::TestCase
   end
 
   describe 'ps' do
-    temporary_change_hash Byebug::Command.settings, :width, 20
+    temporary_change_hash Byebug.settings, :width, 20
 
     it 'must print expression and sort and columnize the result' do
       enter 'ps [1, 2, 3, 4, 5, 9, 8, 7, 6]'
@@ -87,13 +87,4 @@ class TestEval < TestDsl::TestCase
       check_output_includes "1  3  5  7  9\n2  4  6  8"
     end
   end
-
-  describe 'Post Mortem' do
-    it 'must work in post-mortem mode' do
-      enter 'cont', 'eval 2 + 2'
-      debug_file 'post_mortem'
-      check_output_includes '4'
-    end
-  end
-
 end

data/test/examples/thread.rb

@@ -0,0 +1,32 @@
+byebug
+class ThreadExample
+  def initialize
+    Thread.main[:should_break] = false
+  end
+
+  def launch
+    @t1 = Thread.new do
+      while true
+        break if Thread.main[:should_break]
+        sleep 0.02
+      end
+    end
+
+    @t2 = Thread.new do
+      while true
+        sleep 0.02
+      end
+    end
+
+    @t1.join
+    Thread.main[:should_break]
+  end
+
+  def kill
+    @t2.kill
+  end
+end
+
+t = ThreadExample.new
+t.launch
+t.kill

data/test/finish_test.rb

@@ -27,23 +27,11 @@ class TestFinish < TestDsl::TestCase
 
     it 'must show an error' do
       debug_file('finish')
-      check_output_includes 'Finish argument "foo" needs to be a number.'
+      check_output_includes '"finish" argument "foo" needs to be a number.'
     end
 
     it 'must be on the same line' do
       debug_file('finish') { $state.line.must_equal 16 }
     end
   end
-
-  describe 'Post Mortem' do
-    temporary_change_hash Byebug::Command.settings, :autoeval, false
-
-    it 'must not work in post-mortem mode' do
-      enter 'cont', 'finish'
-      debug_file 'post_mortem'
-      check_output_includes \
-        'Unknown command: "finish".  Try "help".', interface.error_queue
-    end
-  end
-
 end

data/test/frame_test.rb

@@ -44,9 +44,8 @@ class TestFrame < TestDsl::TestCase
     end
 
     it 'must set frame to the last one' do
-      enter 'bt', 'frame -1'
+      enter 'frame -1'
       debug_file('frame') { $state.file.must_match /minitest\/unit.rb/ }
-      check_output_doesnt_include "at #{@tst_file}:"
     end
 
     it 'must not set frame if the frame number is too low' do
@@ -70,7 +69,7 @@ class TestFrame < TestDsl::TestCase
       end
 
       describe 'when set' do
-        temporary_change_hash Byebug::Command.settings, :frame_fullpath, true
+        temporary_change_hash Byebug.settings, :fullpath, true
 
         it 'must display current backtrace with fullpaths' do
           enter 'where'
@@ -83,7 +82,7 @@ class TestFrame < TestDsl::TestCase
       end
 
       describe 'when unset' do
-        temporary_change_hash Byebug::Command.settings, :frame_fullpath, false
+        temporary_change_hash Byebug.settings, :fullpath, false
 
         it 'must display current backtrace with shortpaths' do
           enter 'where'
@@ -99,7 +98,7 @@ class TestFrame < TestDsl::TestCase
 
     describe 'callstyle' do
       describe 'long' do
-        temporary_change_hash Byebug::Command.settings, :callstyle, :long
+        temporary_change_hash Byebug.settings, :callstyle, :long
 
         it 'displays current backtrace with callstyle "long"' do
           enter 'where'
@@ -113,7 +112,7 @@ class TestFrame < TestDsl::TestCase
       end
 
       describe 'short' do
-        temporary_change_hash Byebug::Command.settings, :callstyle, :short
+        temporary_change_hash Byebug.settings, :callstyle, :short
 
         it 'displays current backtrace with callstyle "short"' do
             enter 'where'
@@ -195,10 +194,4 @@ class TestFrame < TestDsl::TestCase
     end
   end
 
-  describe 'Post Mortem' do
-    it 'must work in post-mortem mode' do
-      enter 'cont', 'frame'
-      debug_file('post_mortem') { $state.line.must_equal 8 }
-    end
-  end
 end

data/test/help_test.rb

@@ -7,7 +7,7 @@ class TestHelp < TestDsl::TestCase
     Byebug::Command.commands.select(&:event).map(&:names).flatten.uniq.sort }
 
   describe 'when typed alone' do
-    temporary_change_hash Byebug::Command.settings, :width, 50
+    temporary_change_hash Byebug.settings, :width, 50
 
     it 'must show self help when typed alone' do
       enter 'help'
@@ -29,8 +29,7 @@ class TestHelp < TestDsl::TestCase
     it 'must show an error if an undefined command is specified' do
       enter 'help foobar'
       debug_file 'help'
-      check_output_includes \
-        'Undefined command: "foobar".  Try "help".', interface.error_queue
+      check_error_includes 'Undefined command: "foobar".  Try "help".'
     end
 
     it "must show a command's help" do
@@ -53,13 +52,4 @@ class TestHelp < TestDsl::TestCase
         "With an integer argument, list info on that breakpoint."
     end
   end
-
-  describe 'Post Mortem' do
-    it 'must work in post-mortem mode' do
-      enter 'cont', 'help'
-      debug_file 'post_mortem'
-      check_output_includes 'Available commands:'
-    end
-  end
-
 end

data/test/info_test.rb

@@ -4,7 +4,7 @@ class TestInfo < TestDsl::TestCase
   include Columnize
 
   describe 'Args info' do
-    temporary_change_hash Byebug::Command.settings, :width, 15
+    temporary_change_hash Byebug.settings, :width, 15
 
     it 'must show info about all args' do
       enter 'break 3', 'cont', 'info args'
@@ -39,8 +39,7 @@ class TestInfo < TestDsl::TestCase
     it 'must show an error if no breakpoints are found' do
       enter 'break 7', 'info breakpoints 123'
       debug_file 'info'
-      check_output_includes \
-        'No breakpoints found among list given.', interface.error_queue
+      check_error_includes 'No breakpoints found among list given.'
     end
 
     it 'must show hit count' do
@@ -99,7 +98,7 @@ class TestInfo < TestDsl::TestCase
     let(:sha1)     { LineCache.sha1(file) }
     let(:breakpoint_line_numbers) {
       columnize(LineCache.trace_line_numbers(file).to_a.sort,
-                Byebug::Command.settings[:width]) }
+                Byebug.settings[:width]) }
 
     it 'must show basic info about the file' do
       enter "info file #{file} basic"
@@ -155,7 +154,7 @@ class TestInfo < TestDsl::TestCase
     it 'must not show any info if the parameter is invalid' do
       enter "info file #{file} blabla"
       debug_file 'info'
-      check_output_includes 'Invalid parameter blabla', interface.error_queue
+      check_error_includes 'Invalid parameter blabla'
     end
   end
 
@@ -176,18 +175,18 @@ class TestInfo < TestDsl::TestCase
   end
 
   describe 'Locals info' do
-    temporary_change_hash Byebug::Command.settings, :width, 21
+    temporary_change_hash Byebug.settings, :width, 28
 
     it 'must show the current local variables' do
       enter 'break 21', 'cont', 'info locals'
       debug_file 'info'
-      check_output_includes 'a = "1111111111111...', 'b = 2'
+      check_output_includes 'a = "11111111111111111111...', 'b = 2'
     end
 
     it 'must fail if local variable doesn\'t respond to #to_s or to #inspect' do
       enter 'break 26', 'cont', 'info locals'
       debug_file 'info'
-      check_output_includes '*Error in evaluation*'
+      check_output_includes 'a = *Error in evaluation*'
     end
   end
 
@@ -248,7 +247,7 @@ class TestInfo < TestDsl::TestCase
   end
 
   describe 'Variables info' do
-    temporary_change_hash Byebug::Command.settings, :width, 30
+    temporary_change_hash Byebug.settings, :width, 30
 
     it 'must show all variables' do
       enter 'break 21', 'cont', 'info variables'
@@ -283,13 +282,4 @@ class TestInfo < TestDsl::TestCase
       check_output_includes /List of "info" subcommands:/
     end
   end
-
-  describe 'Post Mortem' do
-    it 'must work in post-mortem mode' do
-      enter 'cont', 'info line'
-      debug_file 'post_mortem'
-      check_output_includes "Line 8 of \"#{fullpath('post_mortem')}\""
-    end
-  end
-
 end

data/test/kill_test.rb

@@ -32,16 +32,7 @@ class TestKill < TestDsl::TestCase
     it 'must show an error' do
       enter 'kill BLA'
       debug_file('kill')
-      check_output_includes \
-        'signal name BLA is not a signal I know about', interface.error_queue
-    end
-  end
-
-  describe 'Post Mortem' do
-    it 'must work in post-mortem mode' do
-      Process.expects(:kill).with('USR1', Process.pid)
-      enter 'cont', 'kill USR1'
-      debug_file 'post_mortem'
+      check_error_includes 'signal name BLA is not a signal I know about'
     end
   end
 end

data/test/list_test.rb

@@ -28,7 +28,7 @@ class TestList < TestDsl::TestCase
     end
 
     describe 'very large' do
-      temporary_change_hash Byebug::Command.settings, :listsize, 50
+      temporary_change_hash Byebug.settings, :listsize, 50
 
       it 'must list whole file if number of lines is smaller than listsize' do
         enter 'break 3', 'cont'
@@ -57,7 +57,7 @@ class TestList < TestDsl::TestCase
   end
 
   describe 'list backwards' do
-    temporary_change_hash Byebug::Command.settings, :autolist, 0
+    temporary_change_hash Byebug.settings, :autolist, 0
 
     it 'must show surrounding lines with the first call' do
       enter 'break 15', 'cont', 'list -'
@@ -77,7 +77,7 @@ class TestList < TestDsl::TestCase
   end
 
   describe 'list surrounding' do
-    temporary_change_hash Byebug::Command.settings, :autolist, 0
+    temporary_change_hash Byebug.settings, :autolist, 0
 
     it 'must show the surrounding lines with =' do
       enter 'break 5', 'cont', 'list ='
@@ -140,7 +140,7 @@ class TestList < TestDsl::TestCase
     after  { change_line_in_file(fullpath('list'), 4, 'a = 4')   }
 
     describe 'when autoreload is false' do
-      temporary_change_hash Byebug::Command.settings, :autoreload, false
+      temporary_change_hash Byebug.settings, :autoreload, false
 
       it 'must not reload listing with file changes' do
         enter -> { change_line_in_file fullpath('list'), 4, 'a = 100' ;
@@ -163,8 +163,7 @@ class TestList < TestDsl::TestCase
   it 'must show an error when there is no such file' do
     enter -> { $state.file = 'blabla'; 'list 4-4' }
     debug_file 'list'
-    check_output_includes 'No sourcefile available for blabla',
-                          interface.error_queue
+    check_error_includes 'No sourcefile available for blabla'
   end
 
   it 'must correctly print lines containing % sign' do
@@ -172,12 +171,4 @@ class TestList < TestDsl::TestCase
     debug_file 'list'
     check_output_includes "23: a = '%23'"
   end
-
-  describe 'Post Mortem' do
-    it 'must work in post-mortem mode' do
-      enter 'cont'
-      debug_file 'post_mortem'
-      check_output_includes "[3, 12] in #{fullpath('post_mortem')}"
-    end
-  end
 end