byebug 1.1.1 → 1.2.0

data/test/info_test.rb

@@ -5,8 +5,10 @@ describe 'Info Command' do
   include Columnize
 
    describe 'Args info' do
+     temporary_change_hash Byebug::Command.settings, :width, 15
+
      it 'must show info about all args' do
-       enter 'set width 15', 'break 3', 'cont', 'info args'
+       enter 'break 3', 'cont', 'info args'
        debug_file 'info'
        check_output_includes 'a = "aaaaaaa...', 'b = "b"'
      end
@@ -91,14 +93,14 @@ describe 'Info Command' do
   end
 
   describe 'File info' do
-    let(:file) { fullpath('info') }
+    let(:file)     { fullpath('info') }
     let(:filename) { "File #{file}" }
-    let(:lines) { "#{LineCache.size(file)} lines" }
-    let(:mtime) { LineCache.stat(file).mtime.to_s }
-    let(:sha1) { LineCache.sha1(file) }
+    let(:lines)    { "#{LineCache.size(file)} lines" }
+    let(:mtime)    { LineCache.stat(file).mtime.to_s }
+    let(:sha1)     { LineCache.sha1(file) }
     let(:breakpoint_line_numbers) {
       columnize(LineCache.trace_line_numbers(file).to_a.sort,
-                Byebug::InfoCommand.settings[:width]) }
+                Byebug::Command.settings[:width]) }
 
     it 'must show basic info about the file' do
       enter "info file #{file} basic"
@@ -175,14 +177,16 @@ describe 'Info Command' do
   end
 
   describe 'Locals info' do
+    temporary_change_hash Byebug::Command.settings, :width, 21
+
     it 'must show the current local variables' do
-      enter 'set width 12', 'break 21', 'cont', 'info locals'
+      enter 'break 21', 'cont', 'info locals'
       debug_file 'info'
-      check_output_includes 'a = "1111...', 'b = 2'
+      check_output_includes 'a = "1111111111111...', 'b = 2'
     end
 
     it 'must fail if local variable doesn\'t respond to #to_s or to #inspect' do
-      enter 'set width 21', 'break 26', 'cont', 'info locals'
+      enter 'break 26', 'cont', 'info locals'
       debug_file 'info'
       check_output_includes '*Error in evaluation*'
     end
@@ -227,11 +231,12 @@ describe 'Info Command' do
   end
 
   describe 'Stack info' do
-    let(:width) { "    #2  <main> at #{fullpath('info')}:36".size }
+    # XXX: Calculate magic number dinamically, like
+    # "longest_string_in_test_output".size
+    temporary_change_hash Byebug::Command.settings, :width, 87
 
     it 'must show stack info' do
-      enter 'set fullpath', ->{ "set width #{width}"}, 'break 20', 'cont',
-            'info stack'
+      enter 'set fullpath', 'break 20', 'cont', 'info stack'
       debug_file 'info'
       check_output_includes "--> #0  A.a at #{fullpath('info')}:20",
                             "    #1  A.b at #{fullpath('info')}:30",
@@ -248,7 +253,7 @@ describe 'Info Command' do
   end
 
   describe 'Variables info' do
-    before { Byebug::Command.settings[:width] = 30 }
+    temporary_change_hash Byebug::Command.settings, :width, 30
 
     it 'must show all variables' do
       enter 'break 21', 'cont', 'info variables'

data/test/list_test.rb

@@ -3,123 +3,105 @@ require_relative 'test_helper'
 describe 'List Command' do
   include TestDsl
 
-  def after_setup
-    LineCache.clear_file_cache
-    Byebug::Command.settings[:listsize] = 3
-    Byebug::Command.settings[:autolist] = 0
-  end
-
   describe 'listsize' do
     it 'must show lines according to :listsize setting' do
-      enter 'set listsize 4', 'break 5', 'cont', 'list'
+      enter 'break 5', 'cont'
       debug_file 'list'
-      check_output_includes "[3, 6] in #{fullpath('list')}"
+      check_output_includes "[1, 10] in #{fullpath('list')}"
     end
 
     it 'must not set it if the param is not an integer' do
-      enter 'set listsize 4.0', 'break 5', 'cont', 'list'
+      enter 'set listsize 4.0', 'break 5', 'cont'
       debug_file 'list'
-      check_output_includes "[4, 6] in #{fullpath('list')}"
+      check_output_includes "[1, 10] in #{fullpath('list')}"
     end
 
     it 'must move range up when it goes before begining of file' do
-      enter 'set listsize 10', 'break 3', 'cont', 'list'
+      enter 'break 3', 'cont'
       debug_file 'list'
       check_output_includes "[1, 10] in #{fullpath('list')}"
     end
 
     it 'must move range down when it goes after end of file' do
-      enter 'set listsize 10', 'break 10', 'cont', 'list'
+      enter 'break 10', 'cont'
       debug_file 'list'
-      check_output_includes "[3, 12] in #{fullpath('list')}"
+      check_output_includes "[5, 14] in #{fullpath('list')}"
     end
 
-    it 'must list whole file if number of lines is smaller than listsize' do
-      enter 'set listsize 13', 'list'
-      debug_file 'list'
-      check_output_includes "[1, 12] in #{fullpath('list')}"
-    end
+    describe 'very large' do
+      temporary_change_hash Byebug::Command.settings, :listsize, 50
 
+      it 'must list whole file if number of lines is smaller than listsize' do
+        enter 'break 3', 'cont'
+        debug_file 'list'
+        check_output_includes "[1, 23] in #{fullpath('list')}"
+      end
+   end
   end
 
   describe 'without arguments' do
     it 'must show surrounding lines with the first call' do
-      enter 'break 5', 'cont', 'list'
+      enter 'break 5', 'cont'
       debug_file 'list'
-      check_output_includes \
-        "[4, 6] in #{fullpath('list')}", '4  4', '=> 5  5', '6  6'
+      check_output_includes "[1, 10] in #{fullpath('list')}", '1: byebug',
+        '2: 2', '3: 3', '4: 4', '=>  5: 5', '6: 6', '7: 7', '8: 8', '9: 9',
+        '10: 10'
     end
 
     it 'must list forward after second call' do
-      enter 'break 5', 'cont', 'list', 'list'
+      enter 'break 5', 'cont', 'list'
       debug_file 'list'
-      check_output_includes \
-        "[7, 9] in #{fullpath('list')}", '7  7', '8  8', '9  9'
+      check_output_includes "[11, 20] in #{fullpath('list')}", '11: 11',
+        '12: 12', '13: 13', '14: 14', '15: 15', '16: 16', '17: 17', '18: 18',
+        '19: 19', '20: 20'
     end
   end
 
   describe 'list backward' do
+    temporary_change_hash Byebug::Command.settings, :autolist, 0
+
     it 'must show surrounding lines with the first call' do
-      enter 'break 5', 'cont', 'list -'
+      enter 'break 15', 'cont', 'list -'
       debug_file 'list'
-      check_output_includes \
-        "[4, 6] in #{fullpath('list')}", '4  4', '=> 5  5', '6  6'
+      check_output_includes "[10, 19] in #{fullpath('list')}", '10: 10',
+        '11: 11', '12: 12', '13: 13', '14: 14', '=> 15: 15', '16: 16', '17: 17',
+        '18: 18', '19: 19'
     end
 
     it 'must list backward after second call' do
-      enter 'break 5', 'cont', 'list -', 'list -'
+      enter 'break 15', 'cont', 'list -', 'list -'
       debug_file 'list'
-      check_output_includes \
-        "[1, 3] in #{fullpath('list')}", '1  byebug', '2  2', '3  3'
+      check_output_includes "[1, 10] in #{fullpath('list')}", '1: byebug',
+        '2: 2', '3: 3', '4: 4', '5: 5', '6: 6', '7: 7', '8: 8', '9: 9',
+        '10: 10'
     end
   end
 
-
   describe 'list surrounding' do
+    temporary_change_hash Byebug::Command.settings, :autolist, 0
+
     it 'must show the surrounding lines with =' do
       enter 'break 5', 'cont', 'list ='
       debug_file 'list'
-      check_output_includes \
-        "[4, 6] in #{fullpath('list')}", '4  4', '=> 5  5', '6  6'
+      check_output_includes "[1, 10] in #{fullpath('list')}", '1: byebug',
+        '2: 2', '3: 3', '4: 4', '=>  5: 5', '6: 6', '7: 7', '8: 8', '9: 9',
+        '10: 10'
     end
   end
 
-  describe 'autolist' do
-    it 'must show the surronding lines after stop if autolist is enabled' do
-      enter 'set autolist', 'break 5', 'cont'
-      debug_file 'list'
-      check_output_includes \
-        "[4, 6] in #{fullpath('list')}", '4  4', '=> 5  5', '6  6'
-    end
-  end
-
-  describe 'specified lines' do
+  describe 'specific range' do
     it 'must show with mm-nn' do
       enter 'list 4-6'
       debug_file 'list'
       check_output_includes \
-        "[4, 6] in #{fullpath('list')}", '4  4', '5  5', '6  6'
+        "[4, 6] in #{fullpath('list')}", '4: 4', '5: 5', '6: 6'
     end
 
     it 'must show with mm,nn' do
       enter 'list 4,6'
       debug_file 'list'
       check_output_includes \
-        "[4, 6] in #{fullpath('list')}", '4  4', '5  5', '6  6'
-    end
-
-    it 'must show surroundings with mm-' do
-      enter 'list 4-'
-      debug_file 'list'
-      check_output_includes \
-        "[3, 5] in #{fullpath('list')}", '3  3', '4  4', '5  5'
-    end
-
-    it 'must show surroundings with mm,' do
-      enter 'list 4,'
-      debug_file 'list'
-      check_output_includes \
-        "[3, 5] in #{fullpath('list')}", '3  3', '4  4', '5  5'
+        "[4, 6] in #{fullpath('list')}", '4: 4', '5: 5', '6: 6'
     end
 
     it 'must show nothing if there is no such lines' do
@@ -134,33 +116,46 @@ describe 'List Command' do
       enter 'list 5,4'
       debug_file 'list'
       check_output_includes "[5, 4] in #{fullpath('list')}"
-      check_output_doesnt_include '5  5'
-      check_output_doesnt_include '4  4'
     end
   end
 
-  describe 'reload source' do
-    after do
-      change_line_in_file(fullpath('list'), 4, '4')
-      Byebug::Command.settings[:reload_source_on_change] = true
+  describe 'arround specific line' do
+    it 'must show surroundings with mm-' do
+      enter 'list 14-'
+      debug_file 'list'
+      check_output_includes "[9, 18] in #{fullpath('list')}", '9: 9', '10: 10',
+        '11: 11', '12: 12', '13: 13', '14: 14', '15: 15', '16: 16', '17: 17',
+        '18: 18'
     end
 
-    it 'must not reload if setting is false' do
-      enter 'set noautoreload', -> do
-        change_line_in_file(fullpath('list'), 4, '100')
-        'list 4-4'
-      end
+    it 'must show surroundings with mm,' do
+      enter 'list 14,'
       debug_file 'list'
-      check_output_includes '4  4'
+      check_output_includes "[9, 18] in #{fullpath('list')}", '9: 9', '10: 10',
+        '11: 11', '12: 12', '13: 13', '14: 14', '15: 15', '16: 16', '17: 17',
+        '18: 18'
     end
+  end
+
+  describe 'reload source' do
+    after  { change_line_in_file(fullpath('list'), 4, '4')   }
+
+    describe 'when autoreload is false' do
+      temporary_change_hash Byebug::Command.settings, :autoreload, false
 
-    it 'must reload if setting is true' do
-      enter 'set autoreload', -> do
-        change_line_in_file(fullpath('list'), 4, '100')
-        'list 4-4'
+      it 'must not reload listing with file changes' do
+        enter -> { change_line_in_file fullpath('list'), 4, '100' ; 'list 4-4' }
+        debug_file 'list'
+        check_output_includes '4: 4'
+      end
+    end
+
+    describe 'when autoreload is true' do
+      it 'must reload listing with file changes' do
+        enter -> { change_line_in_file fullpath('list'), 4, '100' ; 'list 4-4' }
+        debug_file 'list'
+        check_output_includes '4: 100'
       end
-      debug_file 'list'
-      check_output_includes '4  100'
     end
   end
 
@@ -173,10 +168,9 @@ describe 'List Command' do
 
   describe 'Post Mortem' do
     it 'must work in post-mortem mode' do
-      enter 'cont', 'list'
+      enter 'cont'
       debug_file 'post_mortem'
-      check_output_includes "[7, 9] in #{fullpath('post_mortem')}"
+      check_output_includes "[3, 12] in #{fullpath('post_mortem')}"
     end
   end
-
 end

data/test/method_test.rb

@@ -3,9 +3,7 @@ require_relative 'test_helper'
 describe 'Method Command' do
   include TestDsl
 
-  def after_setup
-    Byebug::Command.settings[:autolist] = 0
-  end
+  temporary_change_hash Byebug::Command.settings, :autolist, 0
 
   describe 'show instance method of a class' do
     it 'must show using full command name' do

data/test/reload_test.rb

@@ -4,7 +4,7 @@ describe 'Reload Command' do
   include TestDsl
 
   describe 'autoreloading' do
-    after { Byebug::Command.settings[:reload_source_on_change] = true }
+    after { Byebug::Command.settings[:autoreload] = true }
 
     it 'must notify that automatic reloading is on by default' do
       enter 'reload'
@@ -29,7 +29,7 @@ describe 'Reload Command' do
         'reload'
       end, 'l 4-4'
       debug_file 'reload'
-      check_output_includes '4  100'
+      check_output_includes '4: 100'
     end
   end
 
@@ -42,7 +42,7 @@ describe 'Reload Command' do
         'reload'
       end, 'l 7-7'
       debug_file 'post_mortem'
-      check_output_includes '7  z = 100'
+      check_output_includes '7: z = 100'
     end
   end
 

data/test/repl_test.rb

@@ -0,0 +1,112 @@
+require_relative 'test_helper'
+
+describe 'Repl commands' do
+  include TestDsl
+
+  describe 'Irb Command' do
+    before do
+      interface.stubs(:kind_of?).with(Byebug::LocalInterface).returns(true)
+      IRB::Irb.stubs(:new).returns(irb)
+    end
+
+    let(:irb) { stub(context: ->{}) }
+
+    it 'must support next command' do
+      irb.stubs(:eval_input).throws(:IRB_EXIT, :next)
+      enter 'irb'
+      debug_file('irb') { state.line.must_equal 3 }
+    end
+
+    it 'must support step command' do
+      irb.stubs(:eval_input).throws(:IRB_EXIT, :step)
+      enter 'irb'
+      debug_file('irb') { state.line.must_equal 3 }
+    end
+
+    it 'must support cont command' do
+      irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
+      enter 'break 4', 'irb'
+      debug_file('irb') { state.line.must_equal 4 }
+    end
+
+    describe 'autoirb' do
+      it 'must call irb automatically after breakpoint' do
+        irb.expects(:eval_input)
+        enter 'set autoirb', 'break 4', 'cont', 'set noautoirb'
+        debug_file 'irb'
+      end
+    end
+
+    describe 'setting context to $byebug_state' do
+      temporary_change_hash Byebug::Command.settings, :testing, false
+
+      it 'must set $byebug_state if irb is in the debug mode' do
+        byebug_state = nil
+        irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
+        enter 'irb -d'
+        debug_file 'irb'
+        byebug_state.must_be_kind_of Byebug::CommandProcessor::State
+      end
+
+      it 'must not set $byebug_state if irb is not in the debug mode' do
+        byebug_state = nil
+        irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
+        enter 'irb'
+        debug_file 'irb'
+        byebug_state.must_be_nil
+      end
+    end
+
+    describe 'Post Mortem' do
+      it 'must work in post-mortem mode' do
+        irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
+        enter 'cont', 'break 12', 'irb'
+        debug_file('post_mortem') { state.line.must_equal 12 }
+      end
+    end
+  end
+
+  @has_pry = false
+  describe 'Pry command' do
+    before do
+      interface.stubs(:kind_of?).with(Byebug::LocalInterface).returns(true)
+      Byebug::PryCommand.any_instance.expects(:pry)
+    end
+
+    it 'must support step command' do
+      skip 'TODO'
+    end
+
+    it 'must support cont command' do
+      skip 'TODO'
+    end
+
+    describe 'autopry' do
+      it 'must call pry automatically after breakpoint' do
+        skip 'TODO'
+      end
+    end
+
+    describe 'setting context to $byebug_state' do
+      temporary_change_hash Byebug::Command.settings, :testing, false
+
+      it 'must set $byebug_state if irb is in the debug mode' do
+        enter 'pry -d'
+        debug_file 'irb'
+        $byebug_state.must_be_kind_of Byebug::CommandProcessor::State
+      end
+
+      it 'must not set $byebug_state if irb is not in the debug mode' do
+        enter 'pry'
+        debug_file 'pry'
+        $byebug_state.must_be_nil
+      end
+    end
+
+    describe 'Post Mortem' do
+      it 'must work in post-mortem mode' do
+        skip 'TODO'
+      end
+    end
+  end if @has_pry
+end