byebug 1.0.2 → 1.0.3

data/test/display_test.rb

@@ -1,140 +1,146 @@
 require_relative 'test_helper'
 
-describe "Display Command" do
+describe 'Display Command' do
   include TestDsl
 
-  it "must show expressions" do
+  it 'must show expressions' do
     enter 'break 3', 'cont', 'display d + 1'
     debug_file('display')
-    check_output_includes "1: ", "d + 1 = 5"
+    check_output_includes '1: ', 'd + 1 = 5'
   end
 
-  it "must work with shortcut" do
+  it 'must work with shortcut' do
     enter 'break 3', 'cont', 'disp d + 1'
     debug_file('display')
-    check_output_includes "1: ", "d + 1 = 5"
+    check_output_includes '1: ', 'd + 1 = 5'
   end
 
-  it "must save displayed expressions" do
+  it 'must save displayed expressions' do
     enter 'display d + 1'
-    debug_file('display') { state.display.must_equal [[true, "d + 1"]] }
+    debug_file('display') { state.display.must_equal [[true, 'd + 1']] }
   end
 
-  it "displays all expressions available" do
+  it 'displays all expressions available' do
     enter 'break 3', 'cont', -> do
-      Byebug.handler.display.concat([[true, "abc"], [true, "d"]]); 'display'
+      Byebug.handler.display.concat([[true, 'abc'], [true, 'd']]); 'display'
     end
     debug_file('display')
-    check_output_includes "1: ", "abc = ", "2: ", "d = 4"
+    check_output_includes '1: ', 'abc = ', '2: ', 'd = 4'
   end
 
-  describe "undisplay" do
-    describe "undisplay all" do
+  describe 'undisplay' do
+    describe 'undisplay all' do
       before do
         enter 'break 3', 'cont', -> do
-          Byebug.handler.display.concat([[true, "abc"], [true, "d"]])
+          Byebug.handler.display.concat([[true, 'abc'], [true, 'd']])
           'undisplay'
         end, confirm_response, 'display'
       end
 
-      describe "confirmation is successful" do
+      describe 'confirmation is successful' do
         let(:confirm_response) { 'y' }
 
-        it "must ask about confirmation" do
+        it 'must ask about confirmation' do
           debug_file('display')
-          check_output_includes "Clear all expressions? (y/n)", interface.confirm_queue
+          check_output_includes \
+            'Clear all expressions? (y/n)', interface.confirm_queue
         end
 
-        it "must set all expressions saved to 'false'" do
-          debug_file('display') { state.display.must_equal [[false, "abc"], [false, "d"]] }
+        it 'must set all expressions saved to "false"' do
+          debug_file('display') {
+            state.display.must_equal [[false, 'abc'], [false, 'd']] }
         end
 
-        it "must not show any output" do
+        it 'must not show any output' do
           debug_file('display')
-          check_output_doesnt_include "1: ", "abc = ", "2: ", "d = 4"
+          check_output_doesnt_include '1: ', 'abc = ', '2: ', 'd = 4'
         end
       end
 
-      describe "confirmation is unsuccessful" do
+      describe 'confirmation is unsuccessful' do
         let(:confirm_response) { 'n' }
 
-        it "must set all expressions saved to 'false'" do
-          debug_file('display') { state.display.must_equal [[true, "abc"], [true, "d"]] }
+        it 'must set all expressions saved to "false"' do
+          debug_file('display') {
+            state.display.must_equal [[true, 'abc'], [true, 'd']] }
         end
 
-        it "must not show any output" do
+        it 'must not show any output' do
           debug_file('display')
-          check_output_includes "1: ", "abc = ", "2: ", "d = 4"
+          check_output_includes '1: ', 'abc = ', '2: ', 'd = 4'
         end
       end
     end
 
-    describe "undisplay specific position" do
+    describe 'undisplay specific position' do
       before do
         enter 'break 3', 'cont', -> do
-          Byebug.handler.display.concat([[true, "abc"], [true, "d"]])
+          Byebug.handler.display.concat([[true, 'abc'], [true, 'd']])
           'undisplay 1'
         end, 'display'
       end
 
-      it "must set inactive positions" do
-        debug_file('display') { state.display.must_equal [[nil, "abc"], [true, "d"]] }
+      it 'must set inactive positions' do
+        debug_file('display') {
+          state.display.must_equal [[nil, 'abc'], [true, 'd']] }
       end
 
-      it "must display only the active position" do
+      it 'must display only the active position' do
         debug_file('display')
-        check_output_includes "2: ", "d = 4"
+        check_output_includes '2: ', 'd = 4'
       end
 
-      it "must not display the disabled position" do
+      it 'must not display the disabled position' do
         debug_file('display')
-        check_output_doesnt_include "1: ", "abc"
+        check_output_doesnt_include '1: ', 'abc'
       end
     end
   end
 
-  describe "disable" do
-    it "must disable a position" do
+  describe 'disable' do
+    it 'must disable a position' do
       enter 'display d', 'disable display 1'
-      debug_file('display') { state.display.must_equal [[false, "d"]] }
+      debug_file('display') { state.display.must_equal [[false, 'd']] }
     end
 
-    it "must show an error if no displays are set" do
+    it 'must show an error if no displays are set' do
       enter 'disable display 1'
       debug_file('display')
-      check_output_includes "No display expressions have been set.", interface.error_queue
+      check_output_includes \
+        'No display expressions have been set.', interface.error_queue
     end
 
-    it "must show an error if there is no such display position" do
+    it 'must show an error if there is no such display position' do
       enter 'display d', 'disable display 4'
       debug_file('display')
-      check_output_includes "Disable display argument '4' needs to at most 1."
+      check_output_includes \
+        'Disable display argument "4" needs to be at most 1.'
     end
   end
 
-  describe "enable" do
-    it "must enable a position" do
+  describe 'enable' do
+    it 'must enable a position' do
       enter 'display d', 'disable display 1', 'enable display 1'
-      debug_file('display') { state.display.must_equal [[true, "d"]] }
+      debug_file('display') { state.display.must_equal [[true, 'd']] }
     end
   end
 
-  describe "annotate" do
-    temporary_change_method_value(Byebug, :annotate, 0)
+  describe 'annotate' do
+    after  { Byebug.annotate = 0 }
 
-    it "must show display expression in annotation" do
+    it 'must show display expression in annotation' do
       enter 'display 2 + 2', 'set annotate 3', 'next', 'next'
       debug_file 'display'
-      check_output_includes "\x1A\x1Adisplay", "1:", "2 + 2 = 4"
+      check_output_includes "\u001A\u001Adisplay", '1:', '2 + 2 = 4'
     end
   end
 
-  describe "Post Mortem" do
-    it "must be able to set display expressions in post-mortem mode" do
-      skip("No post morten mode for now")
-      #  enter 'cont', 'display 2 + 2', 'cont'
-      #  debug_file("post_mortem")
-      #  check_output_includes "1:", "2 + 2 = 4"
+  describe 'Post Mortem' do
+    it 'must be able to set display expressions in post-mortem mode' do
+      skip('No post morten mode for now')
+      enter 'cont', 'display 2 + 2', 'cont'
+      debug_file('post_mortem')
+      check_output_includes '1:', '2 + 2 = 4'
     end
   end
 

data/test/eval_test.rb

@@ -38,8 +38,6 @@ describe 'Eval Command' do
   end
 
   describe 'stack trace on error' do
-    temporary_change_hash_value(Byebug::Command.settings, :stack_trace_on_error, false)
-
     it 'must show a stack trace if showing trace on error is enabled' do
       enter 'set notrace', 'eval 2 / 0'
       debug_file 'eval'

data/test/examples/info.rb

@@ -2,11 +2,11 @@ byebug
 def bla(a, b)
   a + b
 end
-va = 2
-vb = 3
-vc = 4
-vd = 5
-ve = 6
+2
+3
+4
+5
+6
 bla("a" * 30, "b")
 
 class A

data/test/examples/info_threads.rb

@@ -43,6 +43,6 @@ end
 
 A.new.b
 A.new.a
-A.new.c
 @break = true
 t1.join
+A.new.c

data/test/finish_test.rb

@@ -1,47 +1,48 @@
 require_relative 'test_helper'
 
-describe "Finish Command" do
+describe 'Finish Command' do
   include TestDsl
 
-  it "must stop at the next frame by default" do
+  it 'must stop at the next frame by default' do
     enter 'break 16', 'cont', 'finish'
     debug_file('finish') { state.line.must_equal 13 }
   end
 
-  it "must stop at the #0 frame by default" do
+  it 'must stop at the #0 frame by default' do
     enter 'break 16', 'cont', 'finish 0'
     debug_file('finish') { state.line.must_equal 13 }
   end
 
-  it "must stop at the specified frame" do
+  it 'must stop at the specified frame' do
     enter 'break 16', 'cont', 'finish 1'
     debug_file('finish') { state.line.must_equal 9 }
   end
 
-  it "must stop at the next frame if the current frame was changed" do
+  it 'must stop at the next frame if the current frame was changed' do
     enter 'break 16', 'cont', 'up', 'finish'
     debug_file('finish') { state.line.must_equal 9 }
   end
 
-  describe "not a number is specified for frame" do
+  describe 'not a number is specified for frame' do
     before { enter 'break 16', 'cont', 'finish foo' }
 
-    it "must show an error" do
+    it 'must show an error' do
       debug_file('finish')
-      check_output_includes "Finish argument 'foo' needs to be a number."
+      check_output_includes 'Finish argument "foo" needs to be a number.'
     end
 
-    it "must be on the same line" do
+    it 'must be on the same line' do
       debug_file('finish') { state.line.must_equal 16 }
     end
   end
 
-  describe "Post Mortem" do
-    it "must not work in post-mortem mode" do
-      skip("No post morten mode for now")
-      #enter 'cont', 'finish'
-      #debug_file "post_mortem"
-      #check_output_includes 'Unknown command: "finish".  Try "help".', interface.error_queue
+  describe 'Post Mortem' do
+    it 'must not work in post-mortem mode' do
+      skip('No post morten mode for now')
+      enter 'cont', 'finish'
+      debug_file 'post_mortem'
+      check_output_includes 'Unknown command: "finish".  Try "help".',
+                            interface.error_queue
     end
   end
 

data/test/info_test.rb

@@ -19,16 +19,16 @@ describe "Info Command" do
       enter 'break 7', 'break 9 if a == b', 'info breakpoints'
       debug_file 'info'
       check_output_includes "Num Enb What",
-                            /\d+ y   at #{fullpath('info')}:7/,
-                            /\d+ y   at #{fullpath('info')}:9 if a == b/
+                            /\d+ +y   at #{fullpath('info')}:7/,
+                            /\d+ +y   at #{fullpath('info')}:9 if a == b/
     end
 
     it "must show info about specific breakpoint" do
       enter 'break 7', 'break 9',
             ->{"info breakpoints #{Byebug.breakpoints.first.id}"}
       debug_file 'info'
-      check_output_includes "Num Enb What", /\d+ y   at #{fullpath('info')}:7/
-      check_output_doesnt_include  /\d+ y   at #{fullpath('info')}:9/
+      check_output_includes "Num Enb What", /\d+ +y   at #{fullpath('info')}:7/
+      check_output_doesnt_include  /\d+ +y   at #{fullpath('info')}:9/
     end
 
     it "must show an error if no breakpoints are found" do
@@ -47,8 +47,8 @@ describe "Info Command" do
     it "must show hit count" do
       enter 'break 9', 'cont', 'info breakpoints'
       debug_file 'info'
-      check_output_includes /\d+ y   at #{fullpath('info')}:9/
-      check_output_includes /\d+ y   at #{fullpath('info')}:9/,
+      check_output_includes /\d+ +y   at #{fullpath('info')}:9/
+      check_output_includes /\d+ +y   at #{fullpath('info')}:9/,
                             "breakpoint already hit 1 time"
     end
   end
@@ -243,14 +243,13 @@ describe "Info Command" do
 
    describe "Thread info" do
      it "must show threads info when without args" do
-       skip("XXX: Unreliable due to race conditions, needs fix to be reliable")
        enter 'break 48', 'cont', 'info threads'
-       debug_file 'info'
-       check_output_includes /#<Thread:\S+ run>/, /#<Thread:\S+ run>/
+       debug_file 'info_threads'
+       check_output_includes /#<Thread:\S+ run>/
      end
 
      it "must show thread info" do
-       skip("No thread support")
+       skip("XXX: Unreliable due to race conditions, needs fix to be reliable")
        thread_number = nil
        enter ->{thread_number = context.thnum; "info thread #{context.thnum}"}
        debug_file 'info'

data/test/irb_test.rb

@@ -3,84 +3,83 @@ require_relative 'test_helper'
 describe "Irb Command" do
   include TestDsl
 
-  describe "Irb Command Setup" do
-    before do
-      interface.stubs(:kind_of?).with(Byebug::LocalInterface).returns(true)
-      IRB::Irb.stubs(:new).returns(irb)
-      Signal.trap("SIGINT", "IGNORE")
-    end
-    after do
-      Signal.trap("SIGINT", "DEFAULT")
-    end
-    let(:irb) { stub(context: ->{}) }
+  def after_setup
+    interface.stubs(:kind_of?).with(Byebug::LocalInterface).returns(true)
+    IRB::Irb.stubs(:new).returns(irb)
+    Signal.trap("SIGINT", "IGNORE")
+  end
 
-    it "must support next command" do
-      irb.stubs(:eval_input).throws(:IRB_EXIT, :next)
-      enter 'irb'
-      debug_file('irb') { state.line.must_equal 3 }
-    end
+  def after_teardown
+    Signal.trap("SIGINT", "DEFAULT")
+  end
 
-    it "must support step command" do
-      irb.stubs(:eval_input).throws(:IRB_EXIT, :step)
-      enter 'irb'
-      debug_file('irb') { state.line.must_equal 3 }
-    end
+  let(:irb) { stub(context: ->{}) }
 
-    it "must support cont command" do
-      irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
-      enter 'break 4', 'irb'
-      debug_file('irb') { state.line.must_equal 4 }
-    end
+  it "must support next command" do
+    irb.stubs(:eval_input).throws(:IRB_EXIT, :next)
+    enter 'irb'
+    debug_file('irb') { state.line.must_equal 3 }
+  end
 
-    describe "autoirb" do
-      temporary_change_hash_value(Byebug::Command.settings, :autoirb, 0)
+  it "must support step command" do
+    irb.stubs(:eval_input).throws(:IRB_EXIT, :step)
+    enter 'irb'
+    debug_file('irb') { state.line.must_equal 3 }
+  end
 
-      it "must call irb automatically after breakpoint" do
-        irb.expects(:eval_input)
-        enter 'set autoirb', 'break 4', 'cont'
-        debug_file 'irb'
-      end
-    end
+  it "must support cont command" do
+    irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
+    enter 'break 4', 'irb'
+    debug_file('irb') { state.line.must_equal 4 }
+  end
 
-    # TODO: Can't reliably test the signal, from time to time Signal.trap, which
-    # is defined in IRBCommand, misses the SIGINT signal, which makes the test
-    # suite exit. Not sure how to fix that...
-    it "must translate SIGINT into 'cont' command" do
-      irb.stubs(:eval_input).calls { Process.kill("SIGINT", Process.pid) }
-      enter 'break 4', 'irb'
-      debug_file('irb') { state.line.must_equal 4 }
-    end
+  #describe "autoirb" do
+  #  it "must call irb automatically after breakpoint" do
+  #    irb.expects(:eval_input)
+  #    enter 'set autoirb', 'break 4', 'cont'
+  #    debug_file 'irb'
+  #  end
+  #end
 
-    describe "setting context to $byebug_state" do
-      before { $byebug_state = nil }
-      temporary_change_hash_value(Byebug::Command.settings, :byebugtesting, false)
+  # TODO: Can't reliably test the signal, from time to time Signal.trap, which
+  # is defined in IRBCommand, misses the SIGINT signal, which makes the test
+  # suite exit. Not sure how to fix that...
+  it "must translate SIGINT into 'cont' command" do
+    irb.stubs(:eval_input).calls { Process.kill("SIGINT", Process.pid) }
+    enter 'break 4', 'irb'
+    debug_file('irb') { state.line.must_equal 4 }
+  end
 
-      it "must set $byebug_state if irb is in the debug mode" do
-        byebug_state = nil
-        irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
-        enter 'irb -d'
-        debug_file('irb')
-        byebug_state.must_be_kind_of Byebug::CommandProcessor::State
-      end
+  describe "setting context to $byebug_state" do
+    before do
+      $byebug_state = nil
+      Byebug::Command.settings[:byebugtesting] = false
+    end
 
-      it "must not set $byebug_state if irb is not in the debug mode" do
-        byebug_state = nil
-        irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
-        enter 'irb'
-        debug_file('irb')
-        byebug_state.must_be_nil
-      end
+    it "must set $byebug_state if irb is in the debug mode" do
+      byebug_state = nil
+      irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
+      enter 'irb -d'
+      debug_file('irb')
+      byebug_state.must_be_kind_of Byebug::CommandProcessor::State
     end
 
-    describe "Post Mortem" do
-      it "must work in post-mortem mode" do
-        skip("No post morten mode for now")
-        irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
-        enter 'cont', 'break 12', 'irb'
-        debug_file("post_mortem") { state.line.must_equal 12 }
-      end
+    it "must not set $byebug_state if irb is not in the debug mode" do
+      byebug_state = nil
+      irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
+      enter 'irb'
+      debug_file('irb')
+      byebug_state.must_be_nil
     end
+  end
 
+  describe "Post Mortem" do
+    it "must work in post-mortem mode" do
+      skip("No post morten mode for now")
+      irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
+      enter 'cont', 'break 12', 'irb'
+      debug_file("post_mortem") { state.line.must_equal 12 }
+    end
   end
 
 end