byebug 1.0.1 → 1.0.2

data/test/eval_test.rb

@@ -1,62 +1,68 @@
 require_relative 'test_helper'
 
-describe "Eval Command" do
+describe 'Eval Command' do
   include TestDsl
 
-  it "must evaluate an expression" do
+  it 'must evaluate an expression' do
     enter 'eval 3 + 2'
     debug_file 'eval'
-    check_output_includes "5"
+    check_output_includes '5'
   end
 
-  it "must work with shortcut" do
+  it 'must work with shortcut' do
     enter 'e 3 + 2'
     debug_file 'eval'
-    check_output_includes "5"
+    check_output_includes '5'
   end
 
-  it "must work with another syntax" do
+  it 'must work with another syntax' do
     enter 'p 3 + 2'
     debug_file 'eval'
-    check_output_includes "5"
+    check_output_includes '5'
   end
 
-  describe "autoeval" do
-    temporary_change_hash_value(Byebug::Command.settings, :autoeval, false)
+  describe 'autoeval' do
+    it 'must be set by default' do
+      enter '[5,6,7].inject(&:+)'
+      debug_file 'eval'
+      check_output_includes '18'
+    end
 
-    it "must eval the expression if no matching command is found" do
-      enter 'set autoeval', '[5,6,7].inject(&:+)'
+    it 'can be turned off and back on' do
+      enter 'set noautoeval', '[5,6,7].inject(&:+)',
+            'set autoeval',   '[1,2,3].inject(&:+)'
       debug_file 'eval'
-      check_output_includes "18"
+      check_output_doesnt_include '18'
+      check_output_includes '6'
     end
   end
 
-  describe "stack trace on error" do
+  describe 'stack trace on error' do
     temporary_change_hash_value(Byebug::Command.settings, :stack_trace_on_error, false)
 
-    it "must show a stack trace if showing trace on error is enabled" do
+    it 'must show a stack trace if showing trace on error is enabled' do
       enter 'set notrace', 'eval 2 / 0'
       debug_file 'eval'
-      check_output_includes "ZeroDivisionError Exception: divided by 0"
+      check_output_includes 'ZeroDivisionError Exception: divided by 0'
       check_output_doesnt_include /\S+:\d+:in `eval':divided by 0/
     end
 
-    it "must show a stack trace if showing trace on error is enabled" do
+    it 'must show a stack trace if showing trace on error is enabled' do
       enter 'set trace', 'eval 2 / 0'
       debug_file 'eval'
       check_output_includes /\S+:\d+:in `eval':divided by 0/
-      check_output_doesnt_include "ZeroDivisionError Exception: divided by 0"
+      check_output_doesnt_include 'ZeroDivisionError Exception: divided by 0'
     end
   end
 
 
-  it "must pretty print the expression result" do
-    enter 'pp {a: "3" * 40, b: "4" * 30}'
+  it 'must pretty print the expression result' do
+    enter 'pp {a: \'3\' * 40, b: \'4\' * 30}'
     debug_file 'eval'
-    check_output_includes "{:a=>\"#{"3" * 40}\",\n :b=>\"#{"4" * 30}\"}"
+    check_output_includes "{:a=>\"#{'3' * 40}\",\n :b=>\"#{'4' * 30}\"}"
   end
 
-  it "must print expression and columnize the result" do
+  it 'must print expression and columnize the result' do
     temporary_change_hash_value(Byebug::PutLCommand.settings, :width, 20) do
       enter 'putl [1, 2, 3, 4, 5, 9, 8, 7, 6]'
       debug_file 'eval'
@@ -64,7 +70,7 @@ describe "Eval Command" do
     end
   end
 
-  it "must print expression and sort and columnize the result" do
+  it 'must print expression and sort and columnize the result' do
     temporary_change_hash_value(Byebug::PSCommand.settings, :width, 20) do
       enter 'ps [1, 2, 3, 4, 5, 9, 8, 7, 6]'
       debug_file 'eval'
@@ -72,7 +78,7 @@ describe "Eval Command" do
     end
   end
 
-  it "must set width by the 'set' command" do
+  it 'must set width by the "set" command' do
     temporary_change_hash_value(Byebug::PSCommand.settings, :width, 20) do
       enter 'set width 10', 'ps [1, 2, 3, 4, 5, 9, 8, 7, 6]'
       debug_file 'eval'
@@ -80,12 +86,12 @@ describe "Eval Command" do
     end
   end
 
-  describe "Post Mortem" do
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
-      #enter 'cont', 'eval 2 + 2'
-      #debug_file "post_mortem"
-      #check_output_includes "4"
+  describe 'Post Mortem' do
+    it 'must work in post-mortem mode' do
+      skip('No post morten mode for now')
+      enter 'cont', 'eval 2 + 2'
+      debug_file 'post_mortem'
+      check_output_includes '4'
     end
   end
 

data/test/frame_test.rb

@@ -1,70 +1,71 @@
 require_relative 'test_helper'
 
-describe "Frame Command" do
+describe 'Frame Command' do
   include TestDsl
 
-  it "must go up" do
+  it 'must go up' do
     enter 'break 16', 'cont', 'up'
     debug_file('frame') { state.line.must_equal 12 }
   end
 
-  it "must go up by specific number of frames" do
+  it 'must go up by specific number of frames' do
     enter 'break 16', 'cont', 'up 2'
     debug_file('frame') { state.line.must_equal 8 }
   end
 
-  it "must go down" do
+  it 'must go down' do
     enter 'break 16', 'cont', 'up', 'down'
     debug_file('frame') { state.line.must_equal 16 }
   end
 
-  it "must go down by specific number of frames" do
+  it 'must go down by specific number of frames' do
     enter 'break 16', 'cont', 'up 3', 'down 2'
     debug_file('frame') { state.line.must_equal 12 }
   end
 
-  it "must set frame" do
+  it 'must set frame' do
     enter 'break 16', 'cont', 'frame 2'
     debug_file('frame') { state.line.must_equal 8 }
   end
 
-  it "must set frame to the first one by default" do
+  it 'must set frame to the first one by default' do
     enter 'break 16', 'cont', 'up', 'frame'
     debug_file('frame') { state.line.must_equal 16 }
   end
 
-  it "must print current stack frame when without arguments" do
+  it 'must print current stack frame when without arguments' do
     enter 'break A.d', 'cont', 'up', 'frame'
-    debug_file('frame') { check_output_includes "#0", "A.d(e#String)" }
+    debug_file('frame') { check_output_includes '#0', 'A.d(e#String)' }
   end
 
-  it "must set frame to the first one" do
+  it 'must set frame to the first one' do
     enter 'break 16', 'cont', 'up', 'frame 0'
     debug_file('frame') { state.line.must_equal 16 }
   end
 
-  it "must set frame to the last one" do
+  it 'must set frame to the last one' do
     enter 'break 16', 'cont', 'frame -1'
-    debug_file('frame') { state.line.must_equal 20 }
+    debug_file('frame') { state.file.must_match /test_dsl.rb/ }
+    check_output_doesnt_include "at #{fullpath('frame')}:"
   end
 
-  it "must not set frame if the frame number is too low" do
+  it 'must not set frame if the frame number is too low' do
     enter 'break 16', 'cont', 'down'
     debug_file('frame') { state.line.must_equal 16 }
     check_output_includes \
-      "Adjusting would put us beyond the newest (innermost) frame.",
+      'Adjusting would put us beyond the newest (innermost) frame.',
       interface.error_queue
   end
 
-  it "must not set frame if the frame number is too high" do
+  it 'must not set frame if the frame number is too high' do
     enter 'break 16', 'cont', 'up 100'
     debug_file('frame') { state.line.must_equal 16 }
     check_output_includes \
-      "Adjusting would put us beyond the oldest (initial) frame.",
+      'Adjusting would put us beyond the oldest (initial) frame.',
       interface.error_queue
   end
 
-  describe "full path settings" do
+  describe 'full path settings' do
     def short_path(fullpath)
       separator = File::ALT_SEPARATOR || File::SEPARATOR
       "...#{separator}" + fullpath.split(separator)[-3..-1].join(separator)
@@ -74,70 +75,70 @@ describe "Frame Command" do
       Byebug::Command.settings[:callstyle] = :last
     end
 
-    it "must display current backtrace with full path = true" do
+    it 'must display current backtrace with full path = true' do
       enter 'set fullpath', 'break 16', 'cont', 'where'
       debug_file 'frame'
       check_output_includes \
-        "-->", "#0", "A.d(e#String)", "at line #{fullpath('frame')}:16",
-               "#1", "A.c", "at line #{fullpath('frame')}:12"
+        '-->', '#0', 'A.d(e#String)', "at #{fullpath('frame')}:16",
+               '#1', 'A.c'          , "at #{fullpath('frame')}:12"
     end
 
-    it "must display current backtrace with full path = false" do
+    it 'must display current backtrace with full path = false' do
       enter 'set nofullpath', 'break 16', 'cont', 'where'
       debug_file 'frame'
       check_output_includes \
-        "-->", "#0", "A.d(e#String)", "at line #{short_path(fullpath('frame'))}:16",
-               "#1", "A.c", "at line #{short_path(fullpath('frame'))}:12"
+        '-->', '#0', 'A.d(e#String)', "at #{short_path(fullpath('frame'))}:16",
+               '#1', 'A.c'          , "at #{short_path(fullpath('frame'))}:12"
     end
   end
 
-  describe "callstyles" do
-    it "displays current backtrace with callstyle 'last'" do
+  describe 'callstyles' do
+    it 'displays current backtrace with callstyle "last"' do
       enter 'set callstyle last', 'break 16', 'cont', 'where'
       debug_file 'frame'
       check_output_includes \
-        "-->", "#0", "A.d(e#String)", "at line #{fullpath('frame')}:16",
-               "#1", "A.c", "at line #{fullpath('frame')}:12",
-               "#2", "A.b", "at line #{fullpath('frame')}:8",
-               "#3", "A.a", "at line #{fullpath('frame')}:5"
+        '-->', '#0', 'A.d(e#String)', "at #{fullpath('frame')}:16",
+               '#1', 'A.c'          , "at #{fullpath('frame')}:12",
+               '#2', 'A.b'          , "at #{fullpath('frame')}:8" ,
+               '#3', 'A.a'          , "at #{fullpath('frame')}:5"
     end
 
-    it "displays current backtrace with callstyle 'short'" do
+    it 'displays current backtrace with callstyle "short"' do
       enter 'set callstyle short', 'break 16', 'cont', 'where'
       debug_file 'frame'
       check_output_includes \
-        "-->", "#0", "d(e)", "at line #{fullpath('frame')}:16",
-               "#1", "c", "at line #{fullpath('frame')}:12",
-               "#2", "b", "at line #{fullpath('frame')}:8",
-               "#3", "a", "at line #{fullpath('frame')}:5"
+        '-->', '#0', 'd(e)', "at #{fullpath('frame')}:16",
+               '#1', 'c'   , "at #{fullpath('frame')}:12",
+               '#2', 'b'   , "at #{fullpath('frame')}:8" ,
+               '#3', 'a'   , "at #{fullpath('frame')}:5"
     end
 
-    it "displays current backtrace with callstyle 'tracked'" do
-      skip("XXX: Style supported but not working....")
+    it 'displays current backtrace with callstyle "tracked"' do
+      skip('XXX: Style supported but not working....')
       enter 'set callstyle tracked'
       debug_file 'frame'
       check_output_includes \
-        "Invalid call style tracked. Should be one of: 'shast'."
+        'Invalid call style tracked. Should be one of: "last".'
       Byebug::Command.settings[:callstyle].must_equal :last
     end
   end
 
-  it "must change to frame in another thread" do
-    skip("No threads supported")
+  it 'must change to frame in another thread' do
+    skip('No threads supported')
   end
 
-  it "must not change to frame in another thread if thread doesn't exist" do
-    skip("No threads supported")
+  it 'must not change to frame in another thread if thread doesn\'t exist' do
+    skip('No threads supported')
   end
 
-  describe "Post Mortem" do
-    # TODO: This test fails with "Segmentation fault". Probably need to fix it
+  describe 'Post Mortem' do
+    # TODO: This test fails with 'Segmentation fault'. Probably need to fix it
     # somehow, or forbid this command in the post mortem mode. Seems like
     # state.context.frame_file and state.context.frame_line cause that.
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
-      enter 'cont', "frame"
-      debug_file "post_mortem"
+    it 'must work in post-mortem mode' do
+      skip('No post morten mode for now')
+      enter 'cont', 'frame'
+      debug_file 'post_mortem'
     end
   end
 

data/test/info_test.rb

@@ -235,9 +235,9 @@ describe "Info Command" do
       enter 'break 20', 'cont', 'info stack'
       debug_file 'info'
       check_output_includes \
-        "-->", "#0", "A.a", "at line #{fullpath('info')}:20",
-               "#1", "A.b", "at line #{fullpath('info')}:30",
-               "#2",        "at line #{fullpath('info')}:36"
+        "-->", "#0", "A.a", "at #{fullpath('info')}:20",
+               "#1", "A.b", "at #{fullpath('info')}:30",
+               "#2",        "at #{fullpath('info')}:36"
     end
   end
 
@@ -262,7 +262,7 @@ describe "Info Command" do
        enter 'break 20', 'cont', ->{"info thread #{context.thnum} verbose"}
        debug_file 'info'
        check_output_includes /#<Thread:\S+ run>/, "#0", "A.a",
-                             "at line #{fullpath('info')}:20"
+                             "at #{fullpath('info')}:20"
      end
 
      it "must show error when unknown parameter is used" do

data/test/list_test.rb

@@ -72,10 +72,7 @@ describe "List Command" do
     end
 
     describe "autolist" do
-      before do
-        Byebug::Command.settings[:listsize] = 3
-        Byebug::Command.settings[:autolist] = 0
-      end
+      before { Byebug::Command.settings[:listsize] = 3 }
 
       it "must show the surronding lines even without 'list' command if autolist is enabled" do
         enter 'set autolist', 'break 5', 'cont'

data/test/reload_test.rb

@@ -2,43 +2,48 @@ require_relative 'test_helper'
 
 describe "Reload Command" do
   include TestDsl
-  temporary_change_hash_value(Byebug::Command.settings, :reload_source_on_change, false)
 
-  it "must notify that automatic reloading is off" do
-    enter 'reload'
-    debug_file 'reload'
-    check_output_includes "Source code is reloaded. Automatic reloading is off."
-  end
+  describe "Reload Command (Setup)" do
 
-  it "must notify that automatic reloading is on" do
-    enter 'set autoreload', 'reload'
-    debug_file 'reload'
-    check_output_includes "Source code is reloaded. Automatic reloading is on."
-  end
+    before { Byebug::Command.settings[:reload_source_on_change] = false }
 
-  describe "reloading" do
-    after { change_line_in_file(fullpath('reload'), 4, '4') }
-    it "must reload the code" do
-      enter 'break 3', 'cont', 'l 4-4', -> do
-        change_line_in_file(fullpath('reload'), 4, '100')
-        'reload'
-      end, 'l 4-4'
+    it "must notify that automatic reloading is off" do
+      enter 'reload'
       debug_file 'reload'
-      check_output_includes "4  100"
+      check_output_includes "Source code is reloaded. Automatic reloading is off."
     end
-  end
 
-  describe "Post Mortem" do
-    #after { change_line_in_file(fullpath('post_mortem'), 7, '        z = 4') }
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
-      #enter 'cont', -> do
-      #  change_line_in_file(fullpath('post_mortem'), 7, 'z = 100')
-      #  'reload'
-      #end, 'l 7-7'
-      #debug_file 'post_mortem'
-      #check_output_includes "7  z = 100"
+    it "must notify that automatic reloading is on" do
+      enter 'set autoreload', 'reload'
+      debug_file 'reload'
+      check_output_includes "Source code is reloaded. Automatic reloading is on."
     end
+
+    describe "reloading" do
+      after { change_line_in_file(fullpath('reload'), 4, '4') }
+      it "must reload the code" do
+        enter 'break 3', 'cont', 'l 4-4', -> do
+          change_line_in_file(fullpath('reload'), 4, '100')
+          'reload'
+        end, 'l 4-4'
+        debug_file 'reload'
+        check_output_includes "4  100"
+      end
+    end
+
+    describe "Post Mortem" do
+       after { change_line_in_file(fullpath('post_mortem'), 7, '        z = 4') }
+      it "must work in post-mortem mode" do
+        skip("No post morten mode for now")
+        enter 'cont', -> do
+          change_line_in_file(fullpath('post_mortem'), 7, 'z = 100')
+          'reload'
+        end, 'l 7-7'
+        debug_file 'post_mortem'
+        check_output_includes "7  z = 100"
+      end
+    end
+
   end
 
 end

data/test/show_test.rb

@@ -19,7 +19,6 @@ describe "Show Command" do
     end
   end
 
-
   describe "args" do
     temporary_change_hash_value(Byebug::Command.settings, :argv, %w{foo bar})
 
@@ -106,12 +105,11 @@ describe "Show Command" do
   end
 
   it "must show linetrace" do
-    enter 'trace on', 'show linetrace'
+    enter 'trace on', 'show linetrace', 'trace off'
     debug_file 'show'
     check_output_includes "line tracing is on."
   end
 
-
   describe "linetrace+" do
     it "must show a message when linetrace+ is on" do
       temporary_change_hash_value(Byebug::Command.settings, :tracing_plus, true) do
@@ -282,9 +280,9 @@ describe "Show Command" do
 
     it "must work in post-mortem mode" do
       skip("No post morten mode for now")
-      #enter 'cont', "show autolist"
-      #debug_file 'post_mortem'
-      #check_output_includes "autolist is off."
+      enter 'cont', "show autolist"
+      debug_file 'post_mortem'
+      check_output_includes "autolist is off."
     end
   end