byebug-dap 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3396f670f640d236adac1e58a6dd95af568925af57e9215262a0c10cd870d8df
-  data.tar.gz: 516cc5caca246d9a2764c1cc7ec72b5e1ed2ce27bfcca04a9c7ce1413ce720c3
+  metadata.gz: 9695c31c89057519d92567d4b14faf182a108aeaad4994d92104733c966f1e32
+  data.tar.gz: d030b0a78edd8010d05f3a8af5e6adbc88ab553671f429babdc1f14390a222c1
 SHA512:
-  metadata.gz: cc4611e07bc8c7738335c1a27340849ddb59a0728ce880926e99753d5168cd1f03f8e6197ba375fe074d852eaa502fb824e2555f39c76195ca301e9b4100926b
-  data.tar.gz: c6af798756bb6d6ab71089f365b5cc869dd1c0fde932960f1b450c198439c4bb7be0ff385a22ebc9bcc486ff5465ee937bba9836ef367857c88dd9d8f0660d15
+  metadata.gz: e37dd536e602234f326c4d86b179046f1896fc8913979bbe193646a0387a829975abe6f4e7cad1d42d1615fff02436242d7caeaff030e34ec1472c82547e9cdc
+  data.tar.gz: f9efa4e3ca7cec53cd8c2b9dc89212640006ac1ffd841b753a72bbb3540a842fa7622ae010c55d6fee005d631e6bd4d15b36108517a22a0935465ed564a629cf

data/README.md

@@ -0,0 +1,4 @@
+# Byebug Debug Adapter Protocol
+
+This gem adds [Debug Adapter
+Protocol](https://microsoft.github.io/debug-adapter-protocol) support to Byebug.

data/lib/byebug/dap/controller.rb

@@ -11,34 +11,26 @@ module Byebug
       end
 
       def run
-        @trace.enable
-
         loop do
           @request = @interface.receive
           process_command @request
-
-        rescue InvalidRequestArgumentError => e
-          handle_error e
-
-        rescue CommandProcessor::TimeoutError => e
-          respond! success: false, message: "Debugger on thread ##{e.context.thnum} is not responding"
         end
 
       rescue IOError, Errno::EPIPE, Errno::ECONNRESET, Errno::ECONNABORTED, DisconnectError
         STDERR.puts "\nClient disconnected"
 
-      rescue StandardError => e
-        STDERR.puts "\n! #{e.message} (#{e.class})", *e.backtrace
-
       ensure
         Byebug.mode = :off
         Byebug.stop
         @interface.socket.close
+        @trace.disable
       end
 
       private
 
       def process_trace(trace)
+        return unless Byebug.started?
+
         ctx = Byebug.contexts.find { |c| c.thread == Thread.current }
 
         case trace.event
@@ -47,10 +39,9 @@ module Byebug
         when :thread_end
           @interface.event! 'thread', reason: 'exited', threadId: ctx.thnum
         end
-      end
 
-      def running!
-        raise InvalidRequestArgumentError.new(:not_running, nil) unless Byebug.started?
+      rescue IOError, Errno::EPIPE, Errno::ECONNRESET, Errno::ECONNABORTED
+        # client disconnected, ignore error
       end
 
       def process_command(request)
@@ -83,6 +74,7 @@ module Byebug
 
           Byebug.mode = :attached
           Byebug.start
+          @trace.enable
 
           @signal_start.call(:attach) if @signal_start
 
@@ -95,6 +87,7 @@ module Byebug
           unless request.arguments.noDebug
             Byebug.mode = :launched
             Byebug.start
+            @trace.enable
           end
 
           @signal_start.call(:launch) if @signal_start
@@ -109,7 +102,10 @@ module Byebug
           return
         end
 
-        running!
+        unless Byebug.started?
+          respond! success: false, message: "Debugger is not running"
+          return
+        end
 
         case request.command
         when 'pause', 'next', 'stepIn', 'stepOut', 'continue'
@@ -179,6 +175,12 @@ module Byebug
           # "To clear all breakpoint for a source, specify an empty array.
           # "When a breakpoint is hit, a ‘stopped’ event (with reason ‘breakpoint’) is generated.
 
+          unless File.exist?(request.arguments.source.path)
+            # file doesn't exist, no breakpoints set
+            respond! body: ::DAP::SetBreakpointsResponseBody.new(breakpoints: [])
+            return
+          end
+
           path = File.realpath(request.arguments.source.path)
           ::Byebug.breakpoints.each { |bp| ::Byebug::Breakpoint.remove(bp.id) if bp.source == path }
 
@@ -199,42 +201,46 @@ module Byebug
         else
           respond! success: false, message: 'Invalid command'
         end
-      end
-
-      def respond!(body = {}, success: true, message: 'Success', **values)
-        # TODO make body default to nil?
-        @interface << ::DAP::Response.new(
-          request_seq: @request.seq,
-          command: @request.command,
-          success: success,
-          message: message,
-          body: body,
-          **values)
-      end
-
-      def handle_error(ex)
-        case ex.error
-        when :not_running
-          respond! success: false, message: "Debugger is not running"
 
+      rescue InvalidRequestArgumentError => e
+        case e.error
         when :missing_argument
-          respond! success: false, message: "Missing #{ex.scope}"
+          respond! success: false, message: "Missing #{e.scope}"
 
         when :missing_entry
-          respond! success: false, message: "Invalid #{ex.scope} #{ex.value}"
+          respond! success: false, message: "Invalid #{e.scope} #{e.value}"
 
         when :missing_thread
-          respond! success: false, message: "Cannot locate thread ##{ex.value}"
+          respond! success: false, message: "Cannot locate thread ##{e.value}"
 
         when :missing_frame
-          respond! success: false, message: "Cannot locate frame ##{ex.value}"
+          respond! success: false, message: "Cannot locate frame ##{e.value}"
 
         when :invalid_entry
-          respond! success: false, message: "Error resolving #{ex.scope}: #{ex.value}"
+          respond! success: false, message: "Error resolving #{e.scope}: #{e.value}"
 
         else
-          raise "Unknown internal error: #{err}"
+          respond! success: false, message: "An internal error occured"
+          STDERR.puts "#{e.message} (#{e.class})", *e.backtrace
         end
+
+      rescue CommandProcessor::TimeoutError => e
+        respond! success: false, message: "Debugger on thread ##{e.context.thnum} is not responding"
+
+      rescue StandardError => e
+        respond! success: false, message: "An internal error occured"
+        STDERR.puts "#{e.message} (#{e.class})", *e.backtrace
+      end
+
+      def respond!(body = {}, success: true, message: 'Success', **values)
+        # TODO make body default to nil?
+        @interface << ::DAP::Response.new(
+          request_seq: @request.seq,
+          command: @request.command,
+          success: success,
+          message: message,
+          body: body,
+          **values)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: byebug-dap
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Ethan Reesor
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-07 00:00:00.000000000 Z
+date: 2020-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug
@@ -47,6 +47,7 @@ extra_rdoc_files: []
 files:
 - AUTHORS
 - LICENSE
+- README.md
 - bin/byebug-dap
 - lib/byebug/dap.rb
 - lib/byebug/dap/channel.rb