by_star 2.2.0 → 4.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MTIzYTk4N2IwY2ExNjIwNGNhNGRmODNiNjA3NGQ5YmQyYWI1ODkyZQ==
-  data.tar.gz: !binary |-
-    Zjg5MDgwZDMzMTcyOThlZGE4N2M4OTg5MmMzNDMxNzE0MGUyYjhlMg==
+SHA256:
+  metadata.gz: ae1bb4b3e4e148196c9a1164b3b0b70022fd84843eb4d5adc0cb9dfd41b0ff5a
+  data.tar.gz: ec16b5bb712e19cae620110b979774fe472c430d5485565bd62d8bb30595858a
 SHA512:
-  metadata.gz: !binary |-
-    MmU1OTgwYWY3YTBmMjQwMzgyYmI0YWNkMTkxM2I5NGMxZTQzYTI2MmEyYTIw
-    OTZjMmJiZmNkZjk4YTUyMmNkOTcxN2IyYjZjZjc4ZGFkMjE5YmNmNjUwNzhj
-    MzEyYTdlZTcyN2QwMjE1YzFjODIyYTA4ZTFkOTQ2ODVjMjJkZTI=
-  data.tar.gz: !binary |-
-    YzVhM2U3YzRlZTE5ZWY4ZTdjZDc2MDc3MDI4YTVlMWU4OWY4MjNiM2Q3Y2Fk
-    N2JmNTdmN2M2YmNjYjY1MjJkZGUxMGVmNTdlNzA0OTBiNjJlZWRjN2RhOTcy
-    YWVhMzIwZmUxMjdjNWEwNmI2NjdiYWNiNGE4NjZhMjdjMmE1NDM=
+  metadata.gz: 4749e66ea10dddf1c32c87d0e598b6f852708dcc195dec7f96f3cf83580ff6d50ffcc0f2b286d1cd5b0332d7579634dc23c48aac0b4a97d7e8935d0c89300dc3
+  data.tar.gz: 2efd2cab53a2844e1a1ad28fc01557ca3c5e84ddb1e5b0e719f00130c41348c137c121b793cf73ca6d5c7cc88f5d714c075de00785e34afffc6175199f25aafe

data/.github/workflows/mysql.yml

@@ -0,0 +1,92 @@
+name: MySQL tests
+
+on:
+  # Trigger the workflow on push or pull request,
+  # but only for the master branch
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  mysql:
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby_version: [3.0, 2.7, 2.6, 2.5, jruby]
+        gemfile:
+          [
+            spec/gemfiles/Gemfile.rails50,
+            spec/gemfiles/Gemfile.rails51,
+            spec/gemfiles/Gemfile.rails52,
+            spec/gemfiles/Gemfile.rails60,
+            spec/gemfiles/Gemfile.rails61,
+            spec/gemfiles/Gemfile.rails,
+          ]
+        exclude:
+          # Ruby 3.x is not supported by Rails 5.2.x
+          - ruby_version: 3.0
+            gemfile: spec/gemfiles/Gemfile.rails52
+          # Ruby 3.x is not supported by Rails 5.1.x
+          - ruby_version: 3.0
+            gemfile: spec/gemfiles/Gemfile.rails51
+          # Ruby 3.x is not supported by Rails 5.0.x
+          - ruby_version: 3.0
+            gemfile: spec/gemfiles/Gemfile.rails50
+
+          - ruby_version: 2.6
+            gemfile: spec/gemfiles/Gemfile.rails32
+
+          # Ruby 2.6.x is not supported by Rails main
+          - ruby_version: 2.6
+            gemfile: spec/gemfiles/Gemfile.rails
+
+          # Ruby 2.5.x is not supported by Rails main
+          - ruby_version: 2.5
+            gemfile: spec/gemfiles/Gemfile.rails
+
+          # Ruby 2.4.x is not supported by Rails main
+          - ruby_version: 2.4
+            gemfile: spec/gemfiles/Gemfile.rails
+          # Ruby 2.4.x is not supported by Rails 6.1.x
+          - ruby_version: 2.4
+            gemfile: spec/gemfiles/Gemfile.rails61
+          # Ruby 2.4.x is not supported by Rails 6.0.x
+          - ruby_version: 2.4
+            gemfile: spec/gemfiles/Gemfile.rails60
+          # Ruby 2.3.x is not supported by Rails 6.1.x
+          - ruby_version: 2.3
+            gemfile: spec/gemfiles/Gemfile.rails61
+          # Ruby 2.3.x is not supported by Rails main
+          - ruby_version: 2.3
+            gemfile: spec/gemfiles/Gemfile.rails
+          # Ruby 2.3.x is not supported by Rails 6.0.x
+          - ruby_version: 2.3
+            gemfile: spec/gemfiles/Gemfile.rails60
+          # JRuby is not supported by Rails main
+          - ruby_version: jruby
+            gemfile: spec/gemfiles/Gemfile.rails
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@master
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+
+      - name: Start MySQL
+      - run: sudo /etc/init.d/mysql start
+
+      - name: Build and test with Rake
+        env:
+          BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+          DB: "postgres"
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3
+          bundle exec rake

data/.github/workflows/postgresql.yml

@@ -0,0 +1,99 @@
+name: PostgreSQL tests
+
+on:
+  # Trigger the workflow on push or pull request,
+  # but only for the master branch
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  postgresql:
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby_version: [3.0, 2.7, 2.6, 2.5, jruby]
+        gemfile:
+          [
+            spec/gemfiles/Gemfile.rails50,
+            spec/gemfiles/Gemfile.rails51,
+            spec/gemfiles/Gemfile.rails52,
+            spec/gemfiles/Gemfile.rails60,
+            spec/gemfiles/Gemfile.rails61,
+            spec/gemfiles/Gemfile.rails,
+          ]
+        exclude:
+          # Ruby 3.x is not supported by Rails 5.2.x
+          - ruby_version: 3.0
+            gemfile: spec/gemfiles/Gemfile.rails52
+          # Ruby 3.x is not supported by Rails 5.1.x
+          - ruby_version: 3.0
+            gemfile: spec/gemfiles/Gemfile.rails51
+          # Ruby 3.x is not supported by Rails 5.0.x
+          - ruby_version: 3.0
+            gemfile: spec/gemfiles/Gemfile.rails50
+
+          - ruby_version: 2.6
+            gemfile: spec/gemfiles/Gemfile.rails32
+
+          # Ruby 2.6.x is not supported by Rails main
+          - ruby_version: 2.6
+            gemfile: spec/gemfiles/Gemfile.rails
+
+          # Ruby 2.5.x is not supported by Rails main
+          - ruby_version: 2.5
+            gemfile: spec/gemfiles/Gemfile.rails
+
+          # Ruby 2.4.x is not supported by Rails main
+          - ruby_version: 2.4
+            gemfile: spec/gemfiles/Gemfile.rails
+          # Ruby 2.4.x is not supported by Rails 6.1.x
+          - ruby_version: 2.4
+            gemfile: spec/gemfiles/Gemfile.rails61
+          # Ruby 2.4.x is not supported by Rails 6.0.x
+          - ruby_version: 2.4
+            gemfile: spec/gemfiles/Gemfile.rails60
+          # Ruby 2.3.x is not supported by Rails 6.1.x
+          - ruby_version: 2.3
+            gemfile: spec/gemfiles/Gemfile.rails61
+          # Ruby 2.3.x is not supported by Rails main
+          - ruby_version: 2.3
+            gemfile: spec/gemfiles/Gemfile.rails
+          # Ruby 2.3.x is not supported by Rails 6.0.x
+          - ruby_version: 2.3
+            gemfile: spec/gemfiles/Gemfile.rails60
+          # JRuby is not supported by Rails main
+          - ruby_version: jruby
+            gemfile: spec/gemfiles/Gemfile.rails
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@master
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+
+      - uses: harmon758/postgresql-action@v1
+        with:
+          postgresql version: '11'
+
+      - name: Start PostgreSQL
+        run: |
+          sudo service postgresql start
+          sudo -u postgres createuser --superuser "$USER"
+          createdb by_star_test
+
+      - name: Build and test with Rake
+        env:
+          BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+          DB: "postgres"
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3
+          bundle exec rake

data/.gitignore

@@ -1,5 +1,6 @@
-tmp
-spec/fixtures/database.yml
-pkg
-by_star.sqlite3
-Gemfile.lock
+.idea
+tmp
+spec/fixtures/database.yml
+pkg
+by_star.sqlite3
+Gemfile.lock

data/.travis.yml

@@ -1,35 +1,92 @@
-before_script:
-  - "mysql -e 'create database by_star_test;'"
-  - "psql -c 'create database by_star_test;' -U postgres"
-
-env:
-  - DB=sqlite
-  - DB=mysql
-  - DB=postgres
-  - DB=mongodb
-  - ACTIVE_RECORD_VERSION=4.0.0 MONGOID_VERSION=master DB=sqlite
-  - ACTIVE_RECORD_VERSION=4.0.0 MONGOID_VERSION=master DB=mysql
-  - ACTIVE_RECORD_VERSION=4.0.0 MONGOID_VERSION=master DB=postgres
-  - ACTIVE_RECORD_VERSION=4.0.0 MONGOID_VERSION=master DB=mongodb
-
-notifications:
-  email:
-    - radarlistener@gmail.com
-
-branches:
-  only:
-    - master
-
-rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
-  - rbx
-  - jruby
-
-matrix:
-  allow_failures:
-    - rvm: rbx
-    - rvm: jruby
-
-services: mongodb
+services: mongodb
+
+before_script:
+  - "mysql -e 'create database by_star_test;'"
+  - "psql -c 'create database by_star_test;' -U postgres"
+
+env:
+  - DB=sqlite
+  - DB=mysql
+  - DB=postgres
+  - DB=mongodb
+
+gemfile:
+  - spec/gemfiles/Gemfile.rails32
+  - spec/gemfiles/Gemfile.rails40
+  - spec/gemfiles/Gemfile.rails41
+  - spec/gemfiles/Gemfile.rails42
+  - spec/gemfiles/Gemfile.rails50
+  - spec/gemfiles/Gemfile.rails51
+  - spec/gemfiles/Gemfile.rails52
+  - spec/gemfiles/Gemfile.master
+
+rvm:
+  - 2.0.0
+  - 2.1.10
+  - 2.2.10
+  - 2.3.8
+  - 2.4.6
+  - 2.5.5
+  - 2.6.3
+
+matrix:
+  fast_finish: true
+
+  exclude:
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      rvm: 2.2.10
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      rvm: 2.3.8
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      rvm: 2.4.6
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      rvm: 2.5.5
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      rvm: 2.6.3
+    - gemfile: 'spec/gemfiles/Gemfile.rails40'
+      rvm: 2.4.6
+    - gemfile: 'spec/gemfiles/Gemfile.rails40'
+      rvm: 2.5.5
+    - gemfile: 'spec/gemfiles/Gemfile.rails40'
+      rvm: 2.6.3
+    - gemfile: 'spec/gemfiles/Gemfile.rails41'
+      rvm: 2.4.6
+    - gemfile: 'spec/gemfiles/Gemfile.rails41'
+      rvm: 2.5.5
+    - gemfile: 'spec/gemfiles/Gemfile.rails41'
+      rvm: 2.6.3
+    - gemfile: 'spec/gemfiles/Gemfile.rails50'
+      rvm: 2.0.0
+    - gemfile: 'spec/gemfiles/Gemfile.rails50'
+      rvm: 2.1.10
+    - gemfile: 'spec/gemfiles/Gemfile.rails50'
+      rvm: 2.6.3
+    - gemfile: 'spec/gemfiles/Gemfile.rails51'
+      rvm: 2.0.0
+    - gemfile: 'spec/gemfiles/Gemfile.rails51'
+      rvm: 2.1.10
+    - gemfile: 'spec/gemfiles/Gemfile.rails51'
+      rvm: 2.6.3
+    - gemfile: 'spec/gemfiles/Gemfile.rails52'
+      rvm: 2.0.0
+    - gemfile: 'spec/gemfiles/Gemfile.rails52'
+      rvm: 2.1.10
+
+  allow_failures:
+    - gemfile: 'spec/gemfiles/Gemfile.master'
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      env: 'DB=sqlite'
+    - gemfile: 'spec/gemfiles/Gemfile.rails32'
+      env: 'DB=mysql'
+    - gemfile: 'spec/gemfiles/Gemfile.rails40'
+      env: 'DB=sqlite'
+    - gemfile: 'spec/gemfiles/Gemfile.rails40'
+      env: 'DB=mysql'
+    - gemfile: 'spec/gemfiles/Gemfile.rails41'
+      env: 'DB=sqlite'
+    - gemfile: 'spec/gemfiles/Gemfile.rails41'
+      env: 'DB=mysql'
+    - gemfile: 'spec/gemfiles/Gemfile.rails42'
+      env: 'DB=sqlite'
+    - gemfile: 'spec/gemfiles/Gemfile.rails50'
+      env: 'DB=sqlite'

data/CHANGELOG.md

@@ -1,29 +1,59 @@
-# CHANGELOG
-
-## v2.2.0 - 2014-04-01
-
-* Add `:scope` parameter support on all finders - @pnomolos / @johnnyshields
-* Feature: Add `past_*` and `next_*` finders - @davegudge
-* Bug Fix: `:field`, `:start_field`, and `:end_field` options were being ignored on finder - @johnnyshields / @gamov
-* Bug Fix: `by_star_field` should accept options without start/end_time args - @johnnyshields
-* Improve readme documentation - @johnnyshields
-
-## v2.2.0.rc1 - 2014-01-14
-
-* Begin tracking CHANGELOG
-* Drop official support for Ruby <= 1.9.2
-* Add Ruby 2.1.0, Rubinius, and JRuby to Travis
-* Decouple gem from ActiveRecord, and put ActiveRecord and Mongoid specific methods in ORM modules.
-* Consolidate all normalization/parsing functions into new Normalization module
-* Remove meta-programming methods, e.g. `send("by_week_#{time_klass}")`
-* Support matching timespan-type objects with distinct start and end times (previously only point-in-time matching was supported)
-* Make Chronic gem optional; use it only if user has included it externally
-* `by_week` always returns a calendar week (i.e. beginning Monday or as specified by Rails setting), regardless of whether Date or Fixnum is given as a parameter.
-* `by_week` and `by_calendar_month` now supports optional `:start_day` option (:monday, :tuesday, etc)
-* Separate `by_calendar_month` into it's own class
-* Rename `between` method to `between_times` internally, as Mongoid already defines `between`. ActiveRecord has an alias of `between` so interface stays consistent.
-* Add `:offset` option to all query methods, in order to offset the time the day begins/ends (for example supposing business cycle begins at 8:00 each day until 7:59:59 the next day)
-* `by_weekend` can now take a fixnum (parsing logic is same as by_week)
-* Two-digit year now considers 70 to be 1970, and 69 to be 2069 (was previously 40 -> 1940)
-* Add Time kernel extensions for fortnight and calendar_month
-* Add Johnny Shields as a gem co-author
+# CHANGELOG
+
+## v4.0.0 - Unreleased
+
+* BREAKING CHANGE - `#between` method has been removed (was deprecated in 2.2.0)
+* BREAKING CHANGE - `:order` arg for `#between_times` has been removed.
+* BREAKING CHANGE - Drop support for option `:year` used as a standalone. Use `by_year` instead.
+* BREAKING CHANGE - `#between_times` now queries on records until end of day on `end_time`, if it is a date.
+* `#between_times` now accepts one-sided arguments, e.g. `Time, nil` or `nil, Time`.
+* `#between_times` now accepts `Range` or `Array` as an argument, while continuing to support existing `Time, Time` interface.
+* Add `#at_time` method for point-in-time query.
+* Timespan "strict" query now sets double-sided constraints on both fields to ensure database indexes are used properly.
+* Add optional `:index_scope` option for timespan "non-strict" queries to improve database performance.
+* Fixes `offset` option to set hour, min, and sec of day for queries on dates for better DST support.
+* More consistent application of `Time.zone`.
+* Re-add test coverage for Rails 3.2. This will be removed when we upgrade to Ruby 2.2+ as minimum version.
+
+## v3.0.0
+
+* Upgrade Travis for broader coverage of Ruby, ActiveRecord, and Mongoid versions - @johnnyshields
+* Removed support for Ruby < 2.0 and Rails < 4.0. They are over 5 years old, and so it's time to upgrade. - @radar
+* Removed references to deprecated Fixnum constant - @rgioia - #78
+* Mongoid `newest`, `oldest`, `previous`, and `next` now use `reorder` to ignore any default scope, consistent with ActiveRecord - @johnnyshields
+* Mongoid 3.x: Add support for `Criteria#reorder` method from version 4+ - @johnnyshields
+* Upgrade Rspec tests to version 3.1 - @nhocki
+
+## v2.2.1 - 2014-04-21
+
+* Allow `previous` and `next` to take the current record in their scope - @pnomolos / @johnnyshields
+* Alias `Date#in_time_zone` to `#to_time_in_current_zone` if not already defined (e.g. for Rails <= 3) - @jcypret / @johnnyshields
+* Add `oldest` and `newest` methods
+
+## v2.2.0 - 2014-04-01
+
+* Add `:scope` parameter support on all finders - @pnomolos / @johnnyshields
+* Feature: Add `past_*` and `next_*` finders - @davegudge
+* Bug Fix: `:field`, `:start_field`, and `:end_field` options were being ignored on finder - @johnnyshields / @gamov
+* Bug Fix: `by_star_field` should accept options without start/end_time args - @johnnyshields
+* Improve readme documentation - @johnnyshields
+
+## v2.2.0.rc1 - 2014-01-14
+
+* Begin tracking CHANGELOG
+* Drop official support for Ruby <= 1.9.2
+* Add Ruby 2.1.0, Rubinius, and JRuby to Travis
+* Decouple gem from ActiveRecord, and put ActiveRecord and Mongoid specific methods in ORM modules.
+* Consolidate all normalization/parsing functions into new Normalization module
+* Remove meta-programming methods, e.g. `send("by_week_#{time_klass}")`
+* Support matching timespan-type objects with distinct start and end times (previously only point-in-time matching was supported)
+* Make Chronic gem optional; use it only if user has included it externally
+* `by_week` always returns a calendar week (i.e. beginning Monday or as specified by Rails setting), regardless of whether Date or Fixnum is given as a parameter.
+* `by_week` and `by_calendar_month` now supports optional `:start_day` option (:monday, :tuesday, etc)
+* Separate `by_calendar_month` into it's own class
+* Rename `between` method to `between_times` internally, as Mongoid already defines `between`. ActiveRecord has an alias of `between` so interface stays consistent.
+* Add `:offset` option to all query methods, in order to offset the time the day begins/ends (for example supposing business cycle begins at 8:00 each day until 7:59:59 the next day)
+* `by_weekend` can now take a fixnum (parsing logic is same as by_week)
+* Two-digit year now considers 70 to be 1970, and 69 to be 2069 (was previously 40 -> 1940)
+* Add Time kernel extensions for fortnight and calendar_month
+* Add Johnny Shields as a gem co-author

data/Gemfile

@@ -1,25 +1,18 @@
-source 'http://rubygems.org'
-
-# Specify your gem's dependencies in by_star.gemspec
-gemspec
-
-active_record_version = ENV['ACTIVE_RECORD_VERSION'] || 'default'
-
-active_record_opts =
-  case active_record_version
-  when 'master'  then {github: 'rails/rails'}
-  when 'default' then '~> 3.0'
-  else "~> #{active_record_version}"
-  end
-
-mongoid_version = ENV['MONGOID_VERSION'] || 'default'
-
-mongoid_opts =
-  case mongoid_version
-  when 'master'  then {github: 'mongoid/mongoid'}
-  when 'default' then '~> 3.0'
-  else "~> #{mongoid_version}"
-  end
-
-gem 'activerecord', active_record_opts
-gem 'mongoid', mongoid_opts
+source 'http://rubygems.org'
+
+gemspec
+
+ar_version = ENV['ACTIVE_RECORD_VERSION']
+ar_version = case ar_version
+               when 'master' then {github: 'rails'}
+               when String   then "~> #{ar_version}"
+             end
+
+mo_version = ENV['MONGOID_VERSION']
+mo_version = case mo_version
+               when 'master' then {github: 'mongoid'}
+               when String   then "~> #{mo_version}"
+             end
+
+gem 'activerecord', ar_version if ar_version
+gem 'mongoid',      mo_version if mo_version

data/MIT-LICENSE

@@ -1,20 +1,20 @@
-Copyright (c) 2008 Ryan Bigg
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+Copyright (c) 2008 Ryan Bigg
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.