butterfly 0.0.1 → 0.0.2

data/lib/butterfly/provider/base.rb

@@ -1,4 +1,5 @@
 require "httparty"
+require "active_support/core_ext/class/inheritable_attributes"
 
 module Butterfly
   module Provider
@@ -6,6 +7,25 @@ module Butterfly
 
       include ::HTTParty
 
+      class_inheritable_array :required_parameters
+
+      def initialize(parameters = {})
+        self.class.required_parameters.each do |parameter|
+          self.send("#{parameter}=", parameters[parameter])
+        end
+      end
+
+      private
+
+        def self.required_parameter(*parameters)
+          self.required_parameters ||= []
+          self.required_parameters += parameters
+
+          parameters.each do |parameter|
+            self.send(:attr_accessor, parameter)
+          end
+        end
+
     end
   end
 end

data/lib/butterfly/provider/dribbble.rb

@@ -4,11 +4,7 @@ module Butterfly
 
       base_uri "http://api.dribbble.com"
 
-      attr_reader :username
-
-      def initialize(username)
-        @username = username
-      end
+      required_parameter :username
 
       def raw
         @raw ||= self.class.get("/players/#{username}/shots/likes", :format => :json)

data/lib/butterfly/provider/flickr.rb

@@ -6,11 +6,7 @@ module Butterfly
 
       base_uri "http://api.flickr.com/services/rest"
 
-      attr_reader :user_id, :api_key
-
-      def initialize(user_id, api_key)
-        @user_id, @api_key = user_id, api_key
-      end
+      required_parameter :user_id, :api_key
 
       def raw
         @raw ||= self.class.get("/", :format => :json, :query => { :method => "flickr.favorites.getPublicList", :api_key => api_key, :user_id => user_id, :format => "json", :nojsoncallback => "1", :extras => EXTRAS.join(",") })

data/lib/butterfly/provider/tumblr.rb

@@ -4,11 +4,7 @@ module Butterfly
 
       base_uri "http://www.tumblr.com/api"
 
-      attr_reader :email, :password
-
-      def initialize(email, password)
-        @email, @password = email, password
-      end
+      required_parameter :email, :password
 
       def raw
         @raw ||= self.class.get("/likes", :format => :xml, :query => { :email => email, :password => password })

data/lib/butterfly/provider/twitter.rb

@@ -4,11 +4,7 @@ module Butterfly
 
       base_uri "http://api.twitter.com/1"
 
-      attr_reader :username
-
-      def initialize(username)
-        @username = username
-      end
+      required_parameter :username
 
       def raw
         @raw ||= self.class.get("/favorites/#{username}.json", :format => :json, :query => { :include_entities => 1 })

data/lib/butterfly/version.rb

@@ -1,3 +1,3 @@
 module Butterfly
-  VERSION = "0.0.1"
-end
+  VERSION = "0.0.2"
+end

data/spec/provider/dribbble_spec.rb

@@ -7,7 +7,7 @@ describe Butterfly::Provider::Dribbble do
   it "should retrieve dribbble likes" do
     FakeWeb.register_uri(:get, "http://api.dribbble.com/players/testusername/shots/likes", :body => valid_response)
 
-    dribbble = Butterfly::Provider::Dribbble.new("testusername")
+    dribbble = Butterfly::Provider::Dribbble.new(:username => "testusername")
 
     dribbble.likes.first.as_json.should == {
       "service" => "dribbble",

data/spec/provider/flickr_spec.rb

@@ -7,7 +7,7 @@ describe Butterfly::Provider::Flickr do
   it "should retrieve flickr likes" do
     FakeWeb.register_uri(:get, "http://api.flickr.com/services/rest/?method=flickr.favorites.getPublicList&api_key=testapikey&user_id=testuserid&format=json&nojsoncallback=1&extras=description%2Clicense%2Cdate_upload%2Cdate_taken%2Cowner_name%2Cicon_server%2Coriginal_format%2Clast_update%2Cgeo%2Ctags%2Cmachine_tags%2Co_dims%2Cviews%2Cmedia%2Cpath_alias%2Curl_sq%2Curl_t%2Curl_s%2Curl_m%2Curl_z%2Curl_l%2Curl_o", :body => valid_response)
 
-    flickr = Butterfly::Provider::Flickr.new("testuserid", "testapikey")
+    flickr = Butterfly::Provider::Flickr.new(:user_id => "testuserid", :api_key => "testapikey")
 
     flickr.likes.first.as_json.should == {
       "service" => "flickr",

data/spec/provider/tumblr_spec.rb

@@ -7,7 +7,7 @@ describe Butterfly::Provider::Tumblr do
   it "should retrieve tumblr likes" do
     FakeWeb.register_uri(:get, "http://www.tumblr.com/api/likes?email=testemail&password=testpassword", :body => valid_response)
 
-    tumblr = Butterfly::Provider::Tumblr.new("testemail", "testpassword")
+    tumblr = Butterfly::Provider::Tumblr.new(:email => "testemail", :password => "testpassword")
 
     tumblr.likes.first.as_json.should == {
       "service" => "tumblr",

data/spec/provider/twitter_spec.rb

@@ -7,7 +7,7 @@ describe Butterfly::Provider::Twitter do
   it "should retrieve twitter likes" do
     FakeWeb.register_uri(:get, "http://api.twitter.com/1/favorites/testusername.json?include_entities=1", :body => valid_response)
 
-    twitter = Butterfly::Provider::Twitter.new("testusername")
+    twitter = Butterfly::Provider::Twitter.new(:username => "testusername")
 
     twitter.likes.first.as_json.should == {
       "service" => "twitter",

metadata

@@ -2,7 +2,7 @@
 name: butterfly
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - Steve Hoeksema