busser 0.8.0 → 0.9.1

data/spec/busser/ui_spec.rb

@@ -42,13 +42,19 @@ class SneakyUI
   end
 end
 
-# Stub that mimicks a Process::Status object
+# Stub that mimics a Process::Status object
 class FakeStatus
 
-  attr_reader :exitstatus
+  attr_reader :exitstatus, :termsig
 
-  def initialize(success = true, exitstatus = 0)
-    @success, @exitstatus = success, exitstatus
+  # A process stopped by a signal reports success? as nil rather than false,
+  # carries no exitstatus, and sets termsig instead.
+  def self.signalled(termsig)
+    new(nil, nil, termsig)
+  end
+
+  def initialize(success = true, exitstatus = 0, termsig = nil)
+    @success, @exitstatus, @termsig = success, exitstatus, termsig
   end
 
   def success?
@@ -65,35 +71,35 @@ describe Busser::UI do
   end
 
   it "#banner should display a formatted message" do
-    ui.invoke_banner("coffee").must_equal "-----> coffee"
+    _(ui.invoke_banner("coffee")).must_equal "-----> coffee"
   end
 
   it "#info should display a formatted message" do
-    ui.invoke_info("beans").must_equal "       beans"
+    _(ui.invoke_info("beans")).must_equal "       beans"
   end
 
   it "#warn should display a formatted message" do
-    ui.invoke_warn("grinder").must_equal ">>>>>> grinder"
+    _(ui.invoke_warn("grinder")).must_equal ">>>>>> grinder"
   end
 
   it "#fatal should display a formatted message on stderr" do
-    capture_stderr { ui.invoke_fatal("grinder") }.must_equal "!!!!!! grinder\n"
+    _(capture_stderr { ui.invoke_fatal("grinder") }).must_equal "!!!!!! grinder\n"
   end
 
   describe "#die" do
     it "prints a message to stderr" do
-      capture_stderr { ui.invoke_die("noes") }.must_equal "!!!!!! noes\n"
+      _(capture_stderr { ui.invoke_die("noes") }).must_equal "!!!!!! noes\n"
     end
 
     it "calls exit with 1 by default" do
       capture_stderr do
-        ui.invoke_die("fail").must_equal 1
+        _(ui.invoke_die("fail")).must_equal 1
       end
     end
 
     it "exits with a custom exit status" do
       capture_stderr do
-        ui.invoke_die("fail", 16).must_equal 16
+        _(ui.invoke_die("fail", 16)).must_equal 16
       end
     end
   end
@@ -103,45 +109,68 @@ describe Busser::UI do
     it "calls #run with correct options" do
       ui.invoke_run!("doitpls")
 
-      ui.run_args.must_equal([
+      _(ui.run_args).must_equal([
         "doitpls",
         { :capture => false, :verbose => false}
       ])
     end
 
     it "returns true if command succeeded" do
-      ui.invoke_run!("great-stuff").must_equal true
+      _(ui.invoke_run!("great-stuff")).must_equal true
     end
 
     it "re-raises any exceptions from the underlying fork/exec" do
       ui.stubs(:run).raises(Errno::ENOMEM)
 
-      capture_stderr {
-        proc { ui.invoke_run!("failwhale") }.must_raise Errno::ENOMEM
-      }.must_match /raised an exception/
+      output = capture_stderr do
+        _ { ui.invoke_run!("failwhale") }.must_raise Errno::ENOMEM
+      end
+
+      _(output).must_match(/raised an exception/)
     end
 
     it "terminates the program if the command failed" do
       ui.status = FakeStatus.new(false)
       capture_stderr { ui.invoke_run!("failwhale") }
 
-      ui.died?.must_equal true
+      _(ui.died?).must_equal true
     end
 
     it "terminates with the exit code of the failed command" do
       ui.status = FakeStatus.new(false, 24)
 
       capture_stderr do
-        ui.invoke_run!("failwhale").must_equal 24
+        _(ui.invoke_run!("failwhale")).must_equal 24
+      end
+    end
+
+    # The out of memory killer stops a run with SIGKILL. exitstatus is nil
+    # there, and reporting it as an exit code used to raise a TypeError from
+    # Kernel#exit, so Busser died with a stack trace instead of saying what
+    # happened.
+    it "reports the signal when the command was killed" do
+      ui.status = FakeStatus.signalled(9)
+      output = capture_stderr { ui.invoke_run!("failwhale") }
+
+      _(output).must_match(/terminated by signal 9/)
+      _(ui.died?).must_equal true
+    end
+
+    it "terminates with 128 plus the signal when the command was killed" do
+      ui.status = FakeStatus.signalled(9)
+
+      capture_stderr do
+        _(ui.invoke_run!("failwhale")).must_equal 137
       end
     end
 
     it "terminates the program if status is nil" do
       ui.status = nil
-      capture_stderr { ui.invoke_run!("failwhale") }.
-        must_match /did not return a valid status/
+      output = capture_stderr { ui.invoke_run!("failwhale") }
 
-      ui.died?.must_equal true
+      _(output).must_match(/did not return a valid status/)
+
+      _(ui.died?).must_equal true
     end
   end
 
@@ -150,7 +179,7 @@ describe Busser::UI do
     it "calls #run_ruby_script with correct default options" do
       ui.invoke_run_ruby_script!("theworks.rb")
 
-      ui.run_ruby_script_args.must_equal([
+      _(ui.run_ruby_script_args).must_equal([
         "theworks.rb",
         { :capture => false, :verbose => false }
       ])
@@ -159,45 +188,68 @@ describe Busser::UI do
     it "calls #run_ruby_script with correct default options" do
       ui.invoke_run_ruby_script!("theworks.rb", :verbose => true)
 
-      ui.run_ruby_script_args.must_equal([
+      _(ui.run_ruby_script_args).must_equal([
         "theworks.rb",
         { :capture => false, :verbose => true }
       ])
     end
 
     it "returns true if command succeeded" do
-      ui.invoke_run_ruby_script!("thewin.rb").must_equal true
+      _(ui.invoke_run_ruby_script!("thewin.rb")).must_equal true
     end
 
     it "re-raises any exceptions from the underlying fork/exec" do
       ui.stubs(:run_ruby_script).raises(Errno::ENOMEM)
 
-      capture_stderr {
-        proc { ui.invoke_run_ruby_script!("nope.rb") }.must_raise Errno::ENOMEM
-      }.must_match /raised an exception/
+      output = capture_stderr do
+        _ { ui.invoke_run_ruby_script!("nope.rb") }.must_raise Errno::ENOMEM
+      end
+
+      _(output).must_match(/raised an exception/)
     end
 
     it "terminates the program if the script failed" do
       ui.status = FakeStatus.new(false)
       capture_stderr { ui.invoke_run_ruby_script!("nope.rb") }
 
-      ui.died?.must_equal true
+      _(ui.died?).must_equal true
     end
 
     it "terminates with the exit code of the failed script" do
       ui.status = FakeStatus.new(false, 97)
 
       capture_stderr do
-        ui.invoke_run_ruby_script!("nadda.rb").must_equal 97
+        _(ui.invoke_run_ruby_script!("nadda.rb")).must_equal 97
+      end
+    end
+
+    # The out of memory killer stops a run with SIGKILL. exitstatus is nil
+    # there, and reporting it as an exit code used to raise a TypeError from
+    # Kernel#exit, so Busser died with a stack trace instead of saying what
+    # happened.
+    it "reports the signal when the command was killed" do
+      ui.status = FakeStatus.signalled(9)
+      output = capture_stderr { ui.invoke_run_ruby_script!("nope.rb") }
+
+      _(output).must_match(/terminated by signal 9/)
+      _(ui.died?).must_equal true
+    end
+
+    it "terminates with 128 plus the signal when the command was killed" do
+      ui.status = FakeStatus.signalled(9)
+
+      capture_stderr do
+        _(ui.invoke_run_ruby_script!("nope.rb")).must_equal 137
       end
     end
 
     it "terminates the program if status is nil" do
       ui.status = nil
-      capture_stderr { ui.invoke_run_ruby_script!("nope.rb") }.
-        must_match /did not return a valid status/
+      output = capture_stderr { ui.invoke_run_ruby_script!("nope.rb") }
+
+      _(output).must_match(/did not return a valid status/)
 
-      ui.died?.must_equal true
+      _(ui.died?).must_equal true
     end
   end
 

data/spec/spec_helper.rb

@@ -16,11 +16,5 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require 'fakefs/safe'
 require 'minitest/autorun'
-require 'mocha/setup'
-
-if ENV["COVERAGE"]
-  require 'simplecov'
-  SimpleCov.command_name "unit"
-end
+require 'mocha/minitest'

data/templates/plugin/Rakefile.erb

@@ -1,31 +1,11 @@
 require "bundler/gem_tasks"
-require 'cucumber/rake/task'
-require 'cane/rake_task'
-require 'tailor/rake_task'
+require "cucumber/rake/task"
 
 Cucumber::Rake::Task.new(:features) do |t|
-  t.cucumber_opts = ['features', '-x', '--format progress']
+  t.cucumber_opts = ["features", "-x", "--format progress", "--no-color"]
 end
 
 desc "Run all test suites"
-task :test => [:features]
+task test: [:features]
 
-desc "Run cane to check quality metrics"
-Cane::RakeTask.new do |cane|
-  cane.canefile = './.cane'
-end
-
-Tailor::RakeTask.new
-
-desc "Display LOC stats"
-task :stats do
-  puts "\n## Production Code Stats"
-  sh "countloc -r lib"
-  puts "\n## Test Code Stats"
-  sh "countloc -r features"
-end
-
-desc "Run all quality tasks"
-task :quality => [:cane, :tailor, :stats]
-
-task :default => [:test, :quality]
+task default: [:test]

data/templates/plugin/features_env.rb.erb

@@ -1,8 +1,8 @@
-require 'aruba/cucumber'
-require 'busser/cucumber'
+require "aruba/cucumber"
+require "busser/cucumber"
 
-Before do
-  @aruba_timeout_seconds = 10
+Aruba.configure do |config|
+  config.exit_timeout = 20
 end
 
 After do |s|

data/templates/plugin/gemspec.erb

@@ -11,20 +11,19 @@ Gem::Specification.new do |spec|
   spec.description   = %q{A Busser <%= config[:type] %> plugin for <%= config[:klass_name] %>}
   spec.summary       = spec.description
   spec.homepage      = ''
-  spec.license       = '<%= config[:license_string] %>'
+<% if config[:license_spdx] -%>
+  spec.license       = '<%= config[:license_spdx] %>'
+<% end -%>
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = []
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = '>= 3.2'
+
   spec.add_dependency 'busser'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'aruba'
-
-  spec.add_development_dependency 'cane'
-  spec.add_development_dependency 'tailor'
-  spec.add_development_dependency 'countloc'
+  spec.add_development_dependency 'aruba', '>= 2.0'
+  spec.add_development_dependency 'cucumber', '>= 9.0'
 end

data/templates/plugin/github_workflow.yml.erb

@@ -0,0 +1,26 @@
+---
+name: "Test"
+
+"on":
+  push:
+    branches: [main]
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    name: "Ruby ${{ matrix.ruby }}"
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["3.2", "3.3", "3.4"]
+    steps:
+      - uses: actions/checkout@v5
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rake test

metadata

@@ -1,79 +1,37 @@
 --- !ruby/object:Gem::Specification
 name: busser
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Fletcher Nichol
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-20 00:00:00.000000000 Z
+date: 2026-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "<="
-      - !ruby/object:Gem::Version
-        version: 0.19.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "<="
-      - !ruby/object:Gem::Version
-        version: 0.19.0
-- !ruby/object:Gem::Dependency
-  name: aruba
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.7.4
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.7.4
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: cane
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '1.1'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: countloc
+  name: base64
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -81,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: fakefs
+  name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -136,20 +94,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Busser - Runs tests for projects in Test Kitchen
 email:
 - fnichol@nichol.ca
@@ -158,17 +102,20 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".cane"
+- ".github/workflows/ci.yml"
+- ".github/workflows/pr-title.yml"
+- ".github/workflows/publish.yml"
 - ".gitignore"
-- ".simplecov"
-- ".travis.yml"
+- ".markdownlint.yaml"
+- ".release-please-manifest.json"
+- ".rubocop.yml"
+- ".yamllint"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
-- Guardfile
 - LICENSE
 - README.md
 - Rakefile
-- appveyor.yml
 - bin/busser
 - busser.gemspec
 - features/deserialize_command.feature
@@ -201,7 +148,13 @@ files:
 - lib/busser/thor.rb
 - lib/busser/ui.rb
 - lib/busser/version.rb
+- release-please-config.json
+- renovate.json
+- spec/busser/command/deserialize_spec.rb
+- spec/busser/command/plugin_create_spec.rb
+- spec/busser/command/setup_spec.rb
 - spec/busser/helpers_spec.rb
+- spec/busser/plugin_spec.rb
 - spec/busser/ui_spec.rb
 - spec/spec_helper.rb
 - templates/plugin/CHANGELOG.md.erb
@@ -213,18 +166,17 @@ files:
 - templates/plugin/features_plugin_list_command.feature.erb
 - templates/plugin/features_test_command.feature.erb
 - templates/plugin/gemspec.erb
+- templates/plugin/github_workflow.yml.erb
 - templates/plugin/gitignore.erb
 - templates/plugin/license_apachev2.erb
 - templates/plugin/license_lgplv3.erb
 - templates/plugin/license_mit.erb
 - templates/plugin/license_reserved.erb
 - templates/plugin/runner_plugin.rb.erb
-- templates/plugin/tailor.erb
-- templates/plugin/travis.yml.erb
 - templates/plugin/version.rb.erb
 homepage: https://github.com/test-kitchen/busser
 licenses:
-- Apache 2.0
+- Apache-2.0
 metadata: {}
 post_install_message:
 rdoc_options: []
@@ -234,26 +186,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.1
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Busser - Runs tests for projects in Test Kitchen
-test_files:
-- features/deserialize_command.feature
-- features/files/base64.txt
-- features/plugin_create_command.feature
-- features/plugin_install_command.feature
-- features/setup_command.feature
-- features/suite_cleanup_command.feature
-- features/suite_path_command.feature
-- features/support/env.rb
-- spec/busser/helpers_spec.rb
-- spec/busser/ui_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.simplecov

@@ -1,10 +0,0 @@
-SimpleCov.profiles.define 'gem' do
-  command_name 'Specs'
-
-  add_filter '.gem/'
-  add_filter '/spec/'
-  add_filter '/lib/vendor/'
-
-  add_group 'Libraries', '/lib/'
-end
-SimpleCov.start 'gem'

data/.travis.yml

@@ -1,52 +0,0 @@
-language: ruby
-
-rvm:
-  - 2.2
-  - 2.1
-  - 2.0.0
-  - 1.9.3
-  - ruby-head
-
-env:
-  - RUBYGEMS_VERSION=
-  - RUBYGEMS_VERSION=2.4.5
-  - RUBYGEMS_VERSION=2.2.2
-  - RUBYGEMS_VERSION=2.1.11
-  - RUBYGEMS_VERSION=2.0.14
-  - RUBYGEMS_VERSION=1.8.29
-
-before_install:
-  - if [ -n "$RUBYGEMS_VERSION" ]; then gem update --system $RUBYGEMS_VERSION; fi
-  - gem --version
-
-bundler_args: --without guard
-
-sudo: false
-
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-  exclude:
-    - rvm: 2.2
-      env: RUBYGEMS_VERSION=2.2.2
-    - rvm: 2.2
-      env: RUBYGEMS_VERSION=2.1.11
-    - rvm: 2.2
-      env: RUBYGEMS_VERSION=2.0.14
-    - rvm: 2.2
-      env: RUBYGEMS_VERSION=1.8.29
-    - rvm: 2.1
-      env: RUBYGEMS_VERSION=1.8.29
-    - rvm: 2.0.0
-      env: RUBYGEMS_VERSION=1.8.29
-    - rvm: ruby-head
-      env: RUBYGEMS_VERSION=2.2.2
-    - rvm: ruby-head
-      env: RUBYGEMS_VERSION=2.1.11
-    - rvm: ruby-head
-      env: RUBYGEMS_VERSION=2.0.14
-    - rvm: ruby-head
-      env: RUBYGEMS_VERSION=1.8.29
-
-notifications:
-  irc: "chat.freenode.net#kitchenci"

data/Guardfile

@@ -1,18 +0,0 @@
-guard 'minitest' do
-  watch(%r|^spec/(.*)_spec\.rb|)
-  watch(%r|^lib/(.*)([^/]+)\.rb|)     { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
-  watch(%r|^spec/spec_helper\.rb|)    { "spec" }
-end
-
-guard 'cucumber' do
-  watch(%r{^features/.+\.feature$})
-  watch(%r{^features/support/.+$}) { 'features' }
-  watch(%r{^features/step_definitions/(.+)_steps\.rb$}) do |m|
-    Dir[File.join("**/#{m[1]}.feature")][0] || 'features'
-  end
-end
-
-guard 'cane' do
-  watch(%r|.*\.rb|)
-  watch('.cane')
-end