business_flow 0.19.5 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82c431371d59045db43a3e6a53b1f5be3169396eb684cd3dd57360c13e66de93
-  data.tar.gz: 7af7df17705aba80a4c27099a72a122413029bf95f73490d87de2ae66336dd4d
+  metadata.gz: 629b01be7c90cd6bd0d11524bda269fc640863487e2a45a59d739497938d0ac9
+  data.tar.gz: 7e3b3799817d2e8d451da79b266ebb9329f6db311c707ae1608471813f5ecb9f
 SHA512:
-  metadata.gz: 27e674b0357b3312991ad8d65c91b95e0fed8481259512bdee9e3e2a262e9841af6a1d2b30de250781de36e4aa7544a5d17482ee75013067c9f59c837603958d
-  data.tar.gz: 8c3fe93115e9ac88c71812c1392e9a88702a410ce904f12b2982640a115066a93b1b676fc671be99ef9675073f5e90454d231409e2c13c67ded91f595aa588ae
+  metadata.gz: 1b9affb629f4994fe84655c081d429ef056e221c59739d926ee87205d2febb7ab314beda318f0f7f94b38f215ddcd3588b4f813be38918d43496ad6ce0fa066c
+  data.tar.gz: 2fa9f60dd2d93f674ccf0473ebeb44ac8545d3a2f34cf2a815111a8bc934311bb0b07a205d6d5bd3ef7b84830859c2daa3e4bc07c7ad9819650127050e1c8124

data/.circleci/config.yml

@@ -0,0 +1,95 @@
+version: 2.1
+
+setup: true
+
+orbs:
+  ruby: circleci/ruby@2.5.3
+
+executors:
+  docker: # Docker using the Base Convenience Image
+    docker:
+      - image: cimg/base:stable
+  # linux: # a Linux VM running Ubuntu 20.04
+  #   machine:
+  #     image: ubuntu-2004:202107-02
+  # macos: # macos executor running Xcode
+  #   macos:
+  #     xcode: 14.2.0
+
+references:
+  RUBY_IMAGE: &RUBY_IMAGE
+    cimg/ruby:3.3.7
+  RUBY_DEPS: &RUBY_DEPS
+    include-branch-in-cache-key: false
+    clean-bundle: true
+    key: gems-v2
+
+jobs:
+  refresh_ruby_deps:
+    docker:
+      - image: *RUBY_IMAGE
+    environment:
+      BUNDLE_JOBS: '2'
+      MALLOC_ARENA_MAX: '2'
+      BUNDLE_RETRY: '3'
+    steps:
+      - checkout
+      - run: 'rm .ruby-*'
+      - ruby/install-deps:
+          <<: *RUBY_DEPS
+  rubocop:
+    docker:
+      - image: *RUBY_IMAGE
+    steps:
+      - checkout
+      - run: 'rm .ruby-*'
+      - ruby/install-deps:
+          <<: *RUBY_DEPS
+      - run: bundle exec rubocop
+  reek:
+    docker:
+      - image: *RUBY_IMAGE
+    steps:
+      - checkout
+      - run: 'rm .ruby-*'
+      - ruby/install-deps:
+          <<: *RUBY_DEPS
+      - run: bundle exec reek
+  rspec:
+    parameters:
+      os:
+        type: executor
+      ruby-version:
+        type: string
+    executor: << parameters.os >>
+    steps:
+      - checkout
+      - run: 'rm .ruby-*'
+      - ruby/install:
+          version: << parameters.ruby-version >>
+      - run: bundle
+      - run: appraisal install
+      - run: appraisal rspec --format p
+
+workflows:
+  full:
+    jobs:
+      - refresh_ruby_deps
+      - rubocop:
+          requires:
+            - refresh_ruby_deps
+      - reek:
+          requires:
+            - refresh_ruby_deps
+      - rspec:
+          matrix:
+            parameters:
+              os:
+                - docker
+                # - linux
+                # - macos # Disabled because macOS testing isn't worth sorting out why GPG isn't present.
+              ruby-version:
+                - "3.1.7"
+                - "3.2.8"
+                - "3.3.8"
+                - "3.4.3"

data/.reek.yml

@@ -1,6 +1,9 @@
 # Auto generated by Reeks --todo flag
 ---
 detectors:
+  ControlParameter:
+    exclude:
+    - BusinessFlow::ClusterLock#read_attribute_for_validation
   FeatureEnvy:
     exclude:
     - BusinessFlow::ClusterLock::ClassMethods::LockFailure#add_to
@@ -11,3 +14,5 @@ detectors:
     # N.B. If we want to enable this, we need to tweak the RuboCop config.  In particular, RuboCop
     # prefers `e` for exceptions.
     enabled: false
+exclude_paths:
+  - vendor # For CircleCI.

data/.rubocop.yml

@@ -1,11 +1,15 @@
-require:
+plugins:
 - rubocop-rspec
+- rubocop-rspec_rails
+- rubocop-rake
 
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.1
   NewCops: enable
   Exclude:
     - coverage/**/*
+    - gemfiles/**/*
+    - vendor/bundle/**/* # For CircleCI.  Siiiiigh.
 
 # Excluding specs here because of RSpec's tendency to look at the line-number info on a backtrace to
 # decide what to show you when a matcher fails.  I.E. a very long line may be needed to ensure you
@@ -18,6 +22,9 @@ Layout/LineLength:
 RSpec/MultipleMemoizedHelpers:
   Enabled: false
 
+RSpec/IncludeExamples:
+  Enabled: false
+
 RSpec/IndexedLet:
   # We have specs that are describing process steps, so... numbers are kinda the best way to describe that.
   Enabled: false
@@ -48,10 +55,6 @@ Style/RescueModifier:
 Style/DocumentDynamicEvalDefinition:
   Enabled: false
 
-# Explicit is bettr than implicit.
-FactoryBot/SyntaxMethods:
-  Enabled: false
-
 # For `match(hash_including(...))`, in specs, this rule would make things pretty unreadable.
 Layout/ClosingParenthesisIndentation:
   Exclude:

data/.ruby-version

@@ -1 +1 @@
-ruby-2.7.4
+ruby-3.1.6

data/Appraisals

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+if RUBY_ENGINE == 'ruby' && Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3.4.0')
+  appraise 'activemodel-4.2' do
+    source 'https://teak_io_199:6YKvtYgoo5R8_zxD@gems.railslts.com' do
+      gem 'activemodel', '~> 4.2.11'
+      gem 'activesupport', '~> 4.2.11'
+    end
+  end
+
+  appraise 'activemodel-5.2' do
+    source 'https://teak_io_199:6YKvtYgoo5R8_zxD@gems.railslts.com' do
+      gem 'activemodel', '~> 5.2.8'
+      gem 'activesupport', '~> 5.2.8'
+    end
+  end
+end
+
+appraise 'activemodel-6.1' do
+  source 'https://teak_io_199:6YKvtYgoo5R8_zxD@gems.railslts.com' do
+    gem 'activemodel', '~> 6.1.7'
+    gem 'activesupport', '~> 6.1.7'
+  end
+end
+
+if RUBY_ENGINE == 'ruby' && Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3.4.0')
+  appraise 'activemodel-7.0' do
+    gem 'activemodel', '~> 7.0.8'
+    gem 'activesupport', '~> 7.0.8'
+  end
+end
+
+appraise 'activemodel-7.1' do
+  gem 'activemodel', '~> 7.1.3'
+  gem 'activesupport', '~> 7.1.3'
+end
+
+appraise 'activemodel-7.2' do
+  gem 'activemodel', '~> 7.2.1'
+  gem 'activesupport', '~> 7.2.1'
+end
+
+if RUBY_ENGINE == 'ruby' && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.2.0')
+  appraise 'activemodel-8.0' do
+    gem 'activemodel', '~> 8.0.0'
+    gem 'activesupport', '~> 8.0.0'
+  end
+end

data/Gemfile

@@ -7,12 +7,19 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in business_flow.gemspec
 gemspec
 
-gem 'pry', '~> 0.14.2'
+gem 'pry', '~> 0.15.2'
 gem 'rake', '~> 13.0'
 gem 'reek', '~> 6.1'
 gem 'retryable', '~> 3.0.4'
 gem 'rspec', '~> 3.0'
-gem 'rubocop', '~> 1.59.0'
-gem 'rubocop-rspec', '~> 2.29.1'
+gem 'rubocop', '~> 1.59'
+gem 'rubocop-factory_bot', '~> 2.27'
+gem 'rubocop-rspec', '~> 3.0'
+gem 'rubocop-rspec_rails', '~> 2.31'
+gem 'rubocop-rake', '~> 0.7.0'
 gem 'simplecov', '~> 0.22.0'
 gem 'timecop', '~> 0.9.1'
+
+gem 'ruby3-backward-compatibility'
+
+gem 'appraisal', '~> 2.5.0'

data/Gemfile.lock

@@ -1,122 +1,175 @@
 PATH
   remote: .
   specs:
-    business_flow (0.19.5)
-      activemodel (>= 4.2, < 8)
-      activesupport (>= 4.2, < 8)
+    business_flow (0.20.0)
+      activemodel (>= 4.2, < 8.1)
+      activesupport (>= 4.2, < 8.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (7.1.3.2)
-      activesupport (= 7.1.3.2)
-    activesupport (7.1.3.2)
+    activemodel (7.1.5.1)
+      activesupport (= 7.1.5.1)
+    activesupport (7.1.5.1)
       base64
+      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
       mutex_m
+      securerandom (>= 0.3)
       tzinfo (~> 2.0)
-    ast (2.4.2)
-    base64 (0.2.0)
-    bigdecimal (3.1.7)
+    appraisal (2.5.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
     coderay (1.1.3)
-    concurrent-ruby (1.2.3)
-    connection_pool (2.4.1)
-    diff-lcs (1.5.1)
-    docile (1.4.0)
-    drb (2.2.1)
-    i18n (1.14.4)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
+    diff-lcs (1.6.2)
+    docile (1.4.1)
+    drb (2.2.3)
+    dry-configurable (1.3.0)
+      dry-core (~> 1.1)
+      zeitwerk (~> 2.6)
+    dry-core (1.1.0)
       concurrent-ruby (~> 1.0)
-    json (2.7.2)
-    kwalify (0.7.2)
-    language_server-protocol (3.17.0.3)
+      logger
+      zeitwerk (~> 2.6)
+    dry-inflector (1.2.0)
+    dry-initializer (3.2.0)
+    dry-logic (1.6.0)
+      bigdecimal
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 1.1)
+      zeitwerk (~> 2.6)
+    dry-schema (1.14.1)
+      concurrent-ruby (~> 1.0)
+      dry-configurable (~> 1.0, >= 1.0.1)
+      dry-core (~> 1.1)
+      dry-initializer (~> 3.2)
+      dry-logic (~> 1.5)
+      dry-types (~> 1.8)
+      zeitwerk (~> 2.6)
+    dry-types (1.8.3)
+      bigdecimal (~> 3.0)
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 1.0)
+      dry-inflector (~> 1.0)
+      dry-logic (~> 1.4)
+      zeitwerk (~> 2.6)
+    i18n (1.14.7)
+      concurrent-ruby (~> 1.0)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    logger (1.7.0)
     method_source (1.1.0)
-    minitest (5.22.3)
-    mutex_m (0.2.0)
-    parallel (1.24.0)
-    parser (3.2.2.4)
+    minitest (5.25.5)
+    mutex_m (0.3.0)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
-    pry (0.14.2)
+    prism (1.4.0)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    racc (1.7.3)
+    racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.2.1)
-    reek (6.1.4)
-      kwalify (~> 0.7.0)
-      parser (~> 3.2.0)
+    rake (13.3.0)
+    reek (6.5.0)
+      dry-schema (~> 1.13)
+      logger (~> 1.6)
+      parser (~> 3.3.0)
       rainbow (>= 2.0, < 4.0)
-    regexp_parser (2.9.0)
+      rexml (~> 3.1)
+    regexp_parser (2.10.0)
     retryable (3.0.5)
-    rexml (3.2.6)
-    rspec (3.13.0)
+    rexml (3.4.1)
+    rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.0)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.0)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.1)
-    rubocop (1.59.0)
+    rspec-support (3.13.4)
+    rubocop (1.78.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.4)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.45.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.30.0)
-      parser (>= 3.2.1.0)
-    rubocop-capybara (2.20.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.25.1)
-      rubocop (~> 1.41)
-    rubocop-rspec (2.29.2)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.28.3)
-      rubocop (~> 1.40)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.45.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rspec_rails (2.31.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-rspec (~> 3.5)
     ruby-progressbar (1.13.0)
+    ruby3-backward-compatibility (1.5.0)
+    securerandom (0.3.2)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.12.3)
+    simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    timecop (0.9.8)
+    thor (1.3.2)
+    timecop (0.9.10)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (2.6.0)
+    zeitwerk (2.6.18)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  appraisal (~> 2.5.0)
   business_flow!
-  pry (~> 0.14.2)
+  pry (~> 0.15.2)
   rake (~> 13.0)
   reek (~> 6.1)
   retryable (~> 3.0.4)
   rspec (~> 3.0)
-  rubocop (~> 1.59.0)
-  rubocop-rspec (~> 2.29.1)
+  rubocop (~> 1.59)
+  rubocop-factory_bot (~> 2.27)
+  rubocop-rake (~> 0.7.0)
+  rubocop-rspec (~> 3.0)
+  rubocop-rspec_rails (~> 2.31)
+  ruby3-backward-compatibility
   simplecov (~> 0.22.0)
   timecop (~> 0.9.1)
 
 BUNDLED WITH
-   2.3.6
+   2.6.9

data/README.md

@@ -30,9 +30,23 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+### Running Tests
+
+```bash
+# To test against all supported ActiveModel versions:
+appraisal rspec
+
+# To test against a specific ActiveModel version:
+appraisal activemodel-5.2 rspec
+
+# Validate code quality:
+rubocop
+reek # N.B. RSpec runs _some_ reek tests, but not _all_!
+```
+
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/business_flow.
+Bug reports and pull requests are welcome on GitHub at <https://github.com/GoCarrot/business_flow>.
 
 ## License
 

data/bin/setup

@@ -5,4 +5,10 @@ set -vx
 
 bundle install
 
+if which rbenv >/dev/null; then
+  rbenv rehash
+fi
+
+appraisal install
+
 # Do any other automated setup that you need to do here

data/business_flow.gemspec

@@ -21,10 +21,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activemodel', '>= 4.2', '< 8'
-  spec.add_dependency 'activesupport', '>= 4.2', '< 8'
+  spec.add_dependency 'activemodel', '>= 4.2', '< 8.1'
+  spec.add_dependency 'activesupport', '>= 4.2', '< 8.1'
 
   spec.metadata['rubygems_mfa_required'] = 'true'
 
-  spec.required_ruby_version = '>= 2.7.0'
+  spec.required_ruby_version = '>= 3.1.0'
 end

data/gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

data/gemfiles/activemodel_4.2.gemfile

@@ -0,0 +1,24 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pry", "~> 0.15.2"
+gem "rake", "~> 13.0"
+gem "reek", "~> 6.1.0"
+gem "retryable", "~> 3.0.4"
+gem "rspec", "~> 3.0"
+gem "rubocop", "~> 1.59"
+gem "rubocop-factory_bot", "~> 2.24"
+gem "rubocop-rspec", "~> 2.29"
+gem "rubocop-rspec_rails", "~> 2.28"
+gem "simplecov", "~> 0.22.0"
+gem "timecop", "~> 0.9.1"
+gem "appraisal", "~> 2.5.0"
+gem "ruby3-backward-compatibility"
+
+source 'https://teak_io_199:6YKvtYgoo5R8_zxD@gems.railslts.com' do
+  gem "activemodel", "~> 4.2.11"
+  gem "activesupport", "~> 4.2.11"
+end
+
+gemspec path: "../"