business_flow 0.19.2 → 0.19.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 594752766329fcaa20e52b6b17f3a0b864fb893453055d24dd8596e0a3f5dac5
-  data.tar.gz: c4c8a27b23c2bfdd63378d9a3da1f47e3f9c9f1e0b95eb7344575c30ef2651d0
+  metadata.gz: 307a7eda1932f6d130f00e092df7a21cb2a33b011e83673558fdcf0fcbddb197
+  data.tar.gz: 6397d9e3d64e63892323e1d17489aab5d8c65a81dd38723cb7160278c2cbb41b
 SHA512:
-  metadata.gz: 0ac739ddbf16363e5d6397be8720205187a9ccaa043a11b26e67ccc33f72f83d354c713d2359ffec27bb8a2c9cd93422922aee25aefcec424cc4bc3c5f76226c
-  data.tar.gz: be38502bd0d953729bb48b723540dbc2288f5cd7eb56c5ef54e60854de6c2a4d185604f3d84c681c36906658058863d18ff86eb7a20144ee4a8d1d86fb033f40
+  metadata.gz: 73d2958f6aabc69cb04f442a317c1b4cf561f305cbc2641e88a623d003d46dd496d69d62b240fba1d9e0567f4297ed6fa80ef935ea832629563ce31205b419c3
+  data.tar.gz: 15db0becd4c584ef9dd926eb02d4ffe34b30b184ffdbd484fc44b8264e25c1a856b8ea41049ba3f005a342d438dd16e1a75a32842c5e9e1c4d00a8c668eeec88

data/Gemfile.lock

@@ -1,29 +1,40 @@
 PATH
   remote: .
   specs:
-    business_flow (0.19.2)
+    business_flow (0.19.4)
       activemodel (>= 4.2, < 8)
       activesupport (>= 4.2, < 8)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (7.0.4)
-      activesupport (= 7.0.4)
-    activesupport (7.0.4)
+    activemodel (7.1.3)
+      activesupport (= 7.1.3)
+    activesupport (7.1.3)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
     ast (2.4.2)
-    concurrent-ruby (1.1.10)
+    base64 (0.2.0)
+    bigdecimal (3.1.6)
+    concurrent-ruby (1.2.3)
+    connection_pool (2.4.1)
     diff-lcs (1.5.0)
     docile (1.4.0)
-    i18n (1.12.0)
+    drb (2.2.0)
+      ruby2_keywords
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     jaro_winkler (1.5.4)
     kwalify (0.7.2)
-    minitest (5.16.3)
+    minitest (5.21.2)
+    mutex_m (0.2.0)
     parallel (1.22.1)
     parser (3.2.2.1)
       ast (~> 2.4.1)
@@ -57,6 +68,7 @@ GEM
     rubocop-rspec (1.24.0)
       rubocop (>= 0.53.0)
     ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.5)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -64,7 +76,7 @@ GEM
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
     timecop (0.9.6)
-    tzinfo (2.0.5)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (1.5.0)
 

data/lib/business_flow/cluster_lock.rb

@@ -177,22 +177,38 @@ module BusinessFlow
       end
 
       def self.cleanup(lock, zk_connection)
-        lock.unlock if lock
+        begin
+          lock.unlock if lock
+        rescue ZK::Exceptions::OperationTimeOut
+          # Just let the connection close handle this.
+        end
         zk_connection.close! if zk_connection
       end
 
+      # :reek:ControlParameter
+      # I'm using a case statement instead of a hash in a constant to ensure that this
+      # doesn't throw exceptions if this file is required before zookeeper is.
+      def self.exception_to_error_type(exc)
+        case exc
+        when ZK::Exceptions::LockAssertionFailedError
+          :assert_failed
+        when ZK::Exceptions::OperationTimeOut
+          :zookeeper_timeout
+        else
+          :unknown_failure
+        end
+      end
+
       def self.with_lock(flow, lock_info, &blk)
         zk_connection, lock =
           if !BusinessFlow::ClusterLock.disabled?
             instrumented_acquire_lock(flow, lock_info)
           end
         yield lock_info
-      rescue ZK::Exceptions::LockAssertionFailedError => exc
+      rescue ZK::Exceptions::LockAssertionFailedError, ZK::Exceptions::OperationTimeOut => exc
         # This would occur if we asserted a cluster lock while executing the flow.
         # This will have set an error on the flow, so we can carry on.
-        raise LockFailure.new(:assert_failed, exc.message)
-      rescue ZK::Exceptions::OperationTimeOut
-        # Sometimes this happens. Just let the ensure block take care of everything
+        raise LockFailure.new(exception_to_error_type(exc), exc.message)
       ensure
         cleanup(lock, zk_connection)
       end

data/lib/business_flow/dsl.rb

@@ -56,11 +56,12 @@ module BusinessFlow
       # without having to check for whether or not the wants can be executed.
       #
       # :reek:NilCheck This is one of the places where we eliminate nil.
-      def lookup(field, by:, with:)
+      # :reek:LongParameterList Deal with it
+      def lookup(field, by:, with:, inputs: nil, output: nil)
         by = Array.wrap(by)
         optional(*by)
         wants field, with, unless: -> { by.any? { |input| send(input).nil? } },
-                           default_output: field
+                           default_output: field, inputs: inputs, output: output
       end
 
       # Allows a field to be retrieved from the initialiaztion parameters

data/lib/business_flow/step.rb

@@ -160,10 +160,9 @@ module BusinessFlow
 
       def to_unless(cond)
         if_stmt = Callable.new(cond)
-        unless_stmt = proc do |instance, input|
+        proc do |instance, input|
           !if_stmt.call(instance, input)
         end
-        Callable.new(unless_stmt)
       end
     end
 

data/lib/business_flow/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BusinessFlow
-  VERSION = '0.19.2'.freeze
+  VERSION = '0.19.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: business_flow
 version: !ruby/object:Gem::Version
-  version: 0.19.2
+  version: 0.19.4
 platform: ruby
 authors:
 - Alex Scarborough
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-06 00:00:00.000000000 Z
+date: 2024-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel