business_calendar 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 216930bd93cbe52079f053f6bb5f67cfb3efbaa0478bb4474a98e1b4912023b7
-  data.tar.gz: 1b0242038fdbfd28978c7e9551b3f225ad43413bd7b19d19f9e9fe59c409e6e5
+  metadata.gz: 565c792e03739cdb3e5f506afba3f18c45098b204dda20051978333bcb5a5acc
+  data.tar.gz: 39de2f975e53ab66e32408c7591ec620b7596784277eebf1994c7231ecdd27af
 SHA512:
-  metadata.gz: 4744b858e9faa599b605c0912337dff1480ac092644d9b3b3a9666c4657daaa8e98b5e905529246ac8580c793786f8334cdaf2023d62e8a07e2dd094ab124daf
-  data.tar.gz: ef328442115bcbb191992c2279d99accb5a1bd39e3cadc753404a15504549e8943889f0cd6739ad4c265a5465aacb0ee4b5e6127544fe68e688a586466f9b864
+  metadata.gz: 6a671409be0e036f24dd0d15a8125702b37c0218387026a2a609cd1c22a6a8b25523dd4a78a16b2b5dfb688230fe2286bbf3f9f273cbdf26f0bca3a74b3b3d30
+  data.tar.gz: 59d51361f35e15405f208288c9865e1d602fdb4baef607a509e191273c5ba1f38600a6d70a80e76104dc944cdab8539b25c33c8881a811dde5d11aec8a91d00e

data/.github/workflows/ci.yml

@@ -0,0 +1,30 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.experimental }}
+    strategy:
+      matrix:
+        ruby-version: [2.3.1, 2.7.0]
+        experimental: [false]
+        include:
+          - ruby-version: head
+            experimental: true
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rspec

data/.github/workflows/gem-push.yml

@@ -0,0 +1,29 @@
+name: Ruby Gem
+
+on:
+  push:
+    tags:
+      - '*'
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby 2.7
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+
+    - name: Publish to RubyGems
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem
+      env:
+        GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # business_calendar changes by version
 
+2.0.0
+---------
+
+- Remove UK weekend holidays, replace with the actual observed holiday dates [#26]
+
 1.1.0
 ---------
 

data/Gemfile

@@ -1,6 +1,4 @@
 source 'https://rubygems.org'
 
-gem 'coveralls'
-
 # Specify your gem's dependencies in business_calendar.gemspec
 gemspec

data/README.md

@@ -1,8 +1,6 @@
 # BusinessCalendar
 
 [![Gem Version](https://badge.fury.io/rb/business_calendar.svg)](https://rubygems.org/gems/business_calendar)
-[![Build Status](https://travis-ci.org/enova/business_calendar.svg)](https://travis-ci.org/enova/business_calendar)
-[![Coverage Status](https://coveralls.io/repos/github/enova/business_calendar/badge.svg?branch=master)](https://coveralls.io/github/enova/business_calendar?branch=master)
 [![Dependency Status](https://gemnasium.com/enova/business_calendar.svg)](https://gemnasium.com/enova/business_calendar)
 
 Need to know what days you can actually debit a customer on in excruciating detail? Fed up with singleton-based gems 
@@ -32,7 +30,7 @@ Instantiate a calendar object with:
 bc = BusinessCalendar.for(:US)
 ```
 
-This will automatically load holidays based on the US banking holiday schedule, as configured in `data/holidays.yml`. 
+This will automatically load holidays based on the US banking holiday schedule, as configured in `data/US.yml`.
 Currently, this gem supports `:GB` and `:US` regions.
 
 Now, you can use it:

data/business_calendar.gemspec

@@ -18,15 +18,11 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-
   spec.add_dependency "holidays", "~> 1.0"
   spec.add_dependency "faraday"
-  spec.add_dependency "faraday-conductivity"
 
-  spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.2"
   spec.add_development_dependency "webmock"
-  spec.add_development_dependency "simplecov"
   spec.add_development_dependency "pry"
 end

data/data/GB.yml

@@ -26,12 +26,12 @@ GB:
   - '2015-12-26'
   - '2016-12-25'
   - '2017-01-01'
-  - '2020-12-26'
-  - '2021-12-25'
-  - '2021-12-26'
-  - '2022-01-01'
-  - '2022-12-25'
-  - '2023-01-01'
+  - '2020-12-28'
+  - '2021-12-27'
+  - '2021-12-28'
+  - '2022-01-03'
+  - '2022-12-27'
+  - '2023-01-02'
   removals:
   - '2002-05-28'
   - '2007-04-08'
@@ -44,9 +44,9 @@ GB:
   - '2013-03-31'
   - '2014-04-20'
   - '2015-12-28'
-  - '2020-12-28'
-  - '2021-12-27'
-  - '2021-12-28'
-  - '2022-01-03'
-  - '2022-12-27'
-  - '2023-01-02'
+  - '2020-12-26'
+  - '2021-12-25'
+  - '2021-12-26'
+  - '2022-01-01'
+  - '2022-12-25'
+  - '2023-01-01'

data/gemfiles/ruby_1.9.3.gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+gem 'json', '< 2.3.0'
+
+# Specify your gem's dependencies in business_calendar.gemspec
+gemspec :path => '../'

data/lib/business_calendar.rb

@@ -1,5 +1,4 @@
 require 'faraday'
-require 'faraday/conductivity'
 
 module BusinessCalendar
   CountryNotSupported = Class.new(StandardError)
@@ -51,7 +50,7 @@ module BusinessCalendar
 
     def holiday_determiner_for_endpoint(additions_endpoint, removals_endpoint, opts)
       client = Faraday.new do |conn|
-        conn.response :selective_errors
+        conn.response :raise_error
         conn.adapter :net_http
       end
 

data/lib/business_calendar/version.rb

@@ -1,3 +1,3 @@
 module BusinessCalendar
-  VERSION = "1.1.0"
+  VERSION = "2.0.0"
 end

data/spec/acceptance_gb_spec.rb

@@ -20,12 +20,12 @@ describe "GB bank holidays" do
       2015-12-26
       2016-12-25
       2017-01-01
-      2020-12-26
-      2021-12-25
-      2021-12-26
-      2022-01-01
-      2022-12-25
-      2023-01-01
+      2020-12-28
+      2021-12-27
+      2021-12-28
+      2022-01-03
+      2022-12-27
+      2023-01-02
     ).map { |x| Date.parse x }.each do |expected_holiday|
     it "treats #{expected_holiday} as a holiday" do
       expect(BusinessCalendar.for(:GB).is_holiday?(expected_holiday)).to be true
@@ -35,12 +35,12 @@ describe "GB bank holidays" do
   %w(
       2012-05-28
       2015-12-28
-      2020-12-28
-      2021-12-27
-      2021-12-28
-      2022-01-03
-      2022-12-27
-      2023-01-02
+      2020-12-26
+      2021-12-25
+      2021-12-26
+      2022-01-01
+      2022-12-25
+      2023-01-01
     ).map { |x| Date.parse x }.each do |date|
     it "treats #{date} as not a holiday" do
       expect(BusinessCalendar.for(:GB).is_holiday?(date)).to be false

data/spec/business_calendar_spec.rb

@@ -366,7 +366,7 @@ describe BusinessCalendar do
       before { stub_request(:get, additions).to_return(:status => 500) }
 
       it 'raises an error' do
-        expect { subject.is_business_day?('2014-07-04'.to_date) }.to raise_error Faraday::ClientError
+        expect { subject.is_business_day?('2014-07-04'.to_date) }.to raise_error Faraday::Error
       end
     end
 

data/spec/spec_helper.rb

@@ -1,8 +1,6 @@
 require 'bundler/setup'
 Bundler.setup
 
-require 'simplecov'
-
 require 'business_calendar'
 require 'date'
 require 'webmock/rspec'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: business_calendar
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Robert Nubel
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-25 00:00:00.000000000 Z
+date: 2020-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: holidays
@@ -38,34 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: faraday-conductivity
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -144,10 +102,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
+- ".github/workflows/gem-push.yml"
 - ".gitignore"
 - ".rspec"
-- ".simplecov"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -160,6 +118,7 @@ files:
 - data/US.yml
 - data/org/captalys.yml
 - gemfiles/ree.gemfile
+- gemfiles/ruby_1.9.3.gemfile
 - lib/business_calendar.rb
 - lib/business_calendar/calendar.rb
 - lib/business_calendar/holiday_determiner.rb
@@ -177,7 +136,7 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -192,8 +151,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Country-aware business-date logic and handling.
 test_files:

data/.simplecov

@@ -1,8 +0,0 @@
-unless RUBY_VERSION == "1.8.7"
-  require 'coveralls'
-
-  Coveralls.wear! do
-    add_filter "version.rb"
-    add_filter "spec/"
-  end
-end

data/.travis.yml

@@ -1,25 +0,0 @@
-sudo: false
-language: ruby
-cache: bundler
-
-matrix:
-  include:
-    - rmv: ree
-      gemfile: gemfiles/ree.gemfile
-      script: bundle exec rspec
-    - rvm: 1.9.3
-      script: bundle exec rspec
-    - rvm: 2.3.1
-      script: bundle exec rspec
-
-env:
-  global:
-    secure: klQ3BQNdKkGIq3Zfv8Sr6oZqaMg9GHx+LGhynQ5xt7A6SGvxbMuoXJlE9wW4me6u+B9S2D+q+pdKgGPE/+fHsVt/d0zDXRnrjVyo1eexT220AMfpjiFDAtya8sAcuuAICLhw8AmzTjns8yAWInv5U5vC6oejkLA71FXtHU//210=
-
-deploy:
-  provider: rubygems
-  api_key:
-    secure: "c9QcNX+nk0Yzl22ZVknZtv+/G4fUeLph0TH9PS6hQ92zywM61wtXTJExZdBHulvKAaQbKaq20LcFjLw41qwJc6tvIEYXpOinfOaiemTKaGmKscDrIi3wUAxfjmTacXZAaTdEORQVqTOmppqsuKnP7cqmSNxTSI901Sz5Cy6Jpl0="
-  on:
-    tags: true
-    repo: enova/business_calendar