business 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba9a77c99ec8b8d8d62ce8dd67e03cfbcadf3948
-  data.tar.gz: 0e9f3652c8bf6a17ec0200786a0fff9bb99f2a2a
+  metadata.gz: 57d7e4abbcd7ac0f7b1e6852b70b8a79a3ce617b
+  data.tar.gz: 43d1b2553edbcc7871a57aba27f2dd265d310b2c
 SHA512:
-  metadata.gz: c331e4584c468ff1760ef2d5e355355999eba3d5dbda0ce4ce172072be71e28b7dc98a279163b6b25c47b5aee4fc50a0ef3fabb6cbc47ccfc3b3442fdd7a8685
-  data.tar.gz: 625fd8b80ae09a43a4196477560997299f440fa3ddd1f2f6c77ee044c97ea472c8e8dfddba4ecee5ae8e0cea75aaa7f18d025ec51193f9946280f4879c41c3c5
+  metadata.gz: 1483bdaffd374f8cad123855cc1c54a30e589c57fe98f8e7c47891dd74751087f5cee2bb0177d8bb11a66bacc93645ed1d94bf81bb1c1d72837da40c50ad700d
+  data.tar.gz: 815dd1a6e4de78b31fb6820f22348b684b91df7f8ad0f735aadc6634fde3c69624915aeb3b7fc22175ea0cc0d0bef7eaa4c235964fca7cf84bba1526027f2d6d

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - "1.9.3"
+  - "2.0.0"
+  - "2.1.1"
+  - jruby-19mode
+script: bundle exec rspec spec

data/README.md

@@ -1,33 +1,21 @@
 # Business
 
-Date calculations based on business calendars.
-
-
-## But other libraries already do this
-
-Another gem, business_time, also exists for this purpose. We previously used
-business_time, but encountered several issues that prompted us to create
-business.
+[![Gem version](https://badge.fury.io/rb/business.svg)](http://badge.fury.io/rb/business)
+[![Build status](https://travis-ci.org/gocardless/business.svg?branch=master)](https://travis-ci.org/gocardless/business)
 
-Firstly, business_time works by monkey-patching `Date`, `Time`, and `FixNum`.
-While this enables syntax like `Time.now + 1.business_day`, it means that all
-configuration has to be global. GoCardless handles payments across multiple
-geographies, so being able to work with multiple working-day calendars is
-essential for us. Business provides a simple `Calendar` class, that is
-initialized with a configuration that specifies which days of the week are
-considered to be working days, and which dates are holidays.
+Date calculations based on business calendars.
 
-Secondly, business_time supports calculations on times as well as dates. For
-our purposes, date-based calculations are sufficient. Supporting time-based
-calculations as well makes the code significantly more complex. We chose to
-avoid this extra complexity by sticking solely to date-based mathematics.
+## Documentation
 
+To get business, simply:
 
-## Documentation
+```bash
+$ gem install business
+```
 
 ### Getting started
 
-Get stareted with business by creating an instance of the calendar class,
+Get started with business by creating an instance of the calendar class,
 passing in a hash that specifies with days of the week are considered working
 days, and which days are holidays.
 
@@ -38,10 +26,10 @@ calendar = Business::Calendar.new(
 )
 ```
 
-A few calendar configs are bundled with the gem. Load them by calling the
-`load` class method on `Calendar`. The `load_cached` variant of this method
-caches the calendars by name after loading them, to avoid reading and
-parsing the config file multiple times.
+A few calendar configs are bundled with the gem (see lib/business/data for
+details). Load them by calling the `load` class method on `Calendar`. The
+`load_cached` variant of this method caches the calendars by name after loading
+them, to avoid reading and parsing the config file multiple times.
 
 ```ruby
 calendar = Business::Calendar.load("weekdays")
@@ -98,3 +86,25 @@ calendar.business_days_between(date, date + 7)
 # => 5
 ```
 
+
+## But other libraries already do this
+
+Another gem, [business_time](https://github.com/bokmann/business_time), also
+exists for this purpose. We previously used business_time, but encountered
+several issues that prompted us to start business.
+
+Firstly, business_time works by monkey-patching `Date`, `Time`, and `FixNum`.
+While this enables syntax like `Time.now + 1.business_day`, it means that all
+configuration has to be global. GoCardless handles payments across several
+geographies, so being able to work with multiple working-day calendars is
+essential for us. Business provides a simple `Calendar` class, that is
+initialized with a configuration that specifies which days of the week are
+considered to be working days, and which dates are holidays.
+
+Secondly, business_time supports calculations on times as well as dates. For
+our purposes, date-based calculations are sufficient. Supporting time-based
+calculations as well makes the code significantly more complex. We chose to
+avoid this extra complexity by sticking solely to date-based mathematics.
+
+
+![I'm late for business](http://3.bp.blogspot.com/-aq4iOz2OZzs/Ty8xaQwMhtI/AAAAAAAABrM/-vn4tcRA9-4/s1600/daily-morning-awesomeness-243.jpeg)

data/lib/business/calendar.rb

@@ -29,7 +29,7 @@ module Business
       set_holidays(config[:holidays])
     end
 
-    # Return true if the date given is a business day (typically that meanss a
+    # Return true if the date given is a business day (typically that means a
     # non-weekend day) and not a holiday.
     def business_day?(date)
       date = date.to_date
@@ -42,8 +42,7 @@ module Business
     # day, that day will be returned. If the day given is a holiday or
     # non-working day, the next non-holiday working day will be returned.
     def roll_forward(date)
-      interval = date.is_a?(Date) ? 1 : 3600 * 24
-      date += interval until business_day?(date)
+      date += day_interval_for(date) until business_day?(date)
       date
     end
 

data/lib/business/data/bacs.yml

@@ -22,4 +22,11 @@ holidays:
   - August 25th, 2014
   - December 25th, 2014
   - December 26th, 2014
-
+  - January 1st, 2015
+  - April 3rd, 2015
+  - April 6th, 2015
+  - May 4th, 2015
+  - May 25th, 2015
+  - August 31st, 2015
+  - December 25th, 2015
+  - December 28th, 2015

data/lib/business/data/sepa.yml

@@ -33,3 +33,17 @@ holidays:
   - December 25th, 2014
   - December 26th, 2014
   - December 31st, 2014
+  - January 1st, 2015
+  - April 3rd, 2015
+  - April 6th, 2015
+  - May 1st, 2015
+  - May 9th, 2015
+  - May 14th, 2015
+  - May 25th, 2015
+  - June 4th, 2015
+  - October 3rd, 2015
+  - November 1st, 2015
+  - December 24th, 2015
+  - December 25th, 2015
+  - December 26th, 2015
+  - December 31st, 2015

data/lib/business/version.rb

@@ -1,3 +1,3 @@
 module Business
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/spec/calendar_spec.rb

@@ -1,6 +1,11 @@
 require "business/calendar"
 require "time"
 
+RSpec.configure do |config|
+  config.mock_with(:rspec) { |mocks| mocks.verify_partial_doubles = true }
+  config.raise_errors_for_deprecations!
+end
+
 describe Business::Calendar do
   describe ".load" do
     context "when given a valid calendar" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: business
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Harry Marr
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-11 00:00:00.000000000 Z
+date: 2014-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -46,6 +46,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.md