business-central 1.0.2 → 1.0.3

data/lib/business_central/object/customer_sale.rb

@@ -0,0 +1,11 @@
+module BusinessCentral
+  module Object
+    class CustomerSale < Base
+      OBJECT = 'customerSales'.freeze
+
+      OBJECT_METHODS = [
+        :get
+      ].freeze
+    end
+  end
+end

data/lib/business_central/object/default_dimension.rb

@@ -0,0 +1,54 @@
+module BusinessCentral
+  module Object
+    class DefaultDimension < Base
+      OBJECT = 'defaultDimensions'.freeze
+
+      OBJECT_VALIDATION = {
+        parent_id: {
+          required: true
+        },
+        dimension_code: {
+          maximum_length: 20
+        },
+        dimension_value_code: {
+          maximum_length: 20
+        }
+      }.freeze
+
+      OBJECT_METHODS = [
+        :get,
+        :post,
+        :patch,
+        :delete
+      ].freeze
+
+      OBJECT_PARENTS = [
+        'items',
+        'customers',
+        'vendors',
+        'employees'
+      ].freeze
+
+      def initialize(client, company_id:, parent:, parent_id:)
+        raise InvalidArgumentException.new("parents allowed: #{OBJECT_PARENTS.join(', ')}") if !valid_parent?(parent)
+        super(client, company_id: company_id)
+        @parent_path << {
+          path: parent.downcase,
+          id: parent_id
+        }
+        @parent_id = parent_id
+      end
+
+      def create(params = {})
+        params[:parent_id] = @parent_id
+        super(params)
+      end
+
+      private
+
+      def valid_parent?(parent)
+        OBJECT_PARENTS.include?(parent.downcase)
+      end
+    end
+  end
+end

data/lib/business_central/object/helper.rb

@@ -4,10 +4,36 @@ module BusinessCentral
       def object(object_name, *params)
         define_method(object_name) do |argument=nil|
           object = "@#{object_name}_cache".to_sym
-          if !instance_variable_defined?(object)
-            instance_variable_set(object, BusinessCentral::Object.const_get("#{object_name.to_s.to_camel_case(true)}".to_sym).new(self, argument))
+          if argument.nil?
+            if !instance_variable_defined?(object)
+              instance_variable_set(
+                object,
+                BusinessCentral::Object.const_get("#{object_name.to_s.to_camel_case(true)}".to_sym).new(self, argument)
+              )
+            else
+              instance_variable_get(object)
+            end
+          else
+            instance_variable_set(
+              object,
+              BusinessCentral::Object.const_get("#{object_name.to_s.to_camel_case(true)}".to_sym).new(self, argument)
+            )
           end
-          instance_variable_get(object)
+        end
+      end
+
+      def navigation(object_name, *params)
+        define_method(object_name) do |argument=nil|
+          object = "@#{object_name}_cache".to_sym
+          instance_variable_set(
+            object,
+            BusinessCentral::Object.const_get("#{object_name.to_s.to_camel_case(true)}".to_sym).new(
+              self.client,
+              company_id: company_id(argument),
+              parent: self.class.const_get(:OBJECT),
+              parent_id: id(argument)
+            )
+          )
         end
       end
     end

data/lib/business_central/object/item.rb

@@ -35,16 +35,6 @@ module BusinessCentral
         :patch,
         :delete
       ].freeze
-
-      def initialize(client, company_id:)
-        super(client, company_id: company_id)
-        @parent_path = [
-          {
-            path: 'companies',
-            id: company_id
-          }
-        ]
-      end
     end
   end
 end

data/lib/business_central/object/purchase_invoice.rb

@@ -62,16 +62,6 @@ module BusinessCentral
         :patch,
         :delete
       ].freeze
-
-      def initialize(client, company_id:)
-        super(client, company_id: company_id)
-        @parent_path = [
-          {
-            path: 'companies',
-            id: company_id
-          }
-        ]
-      end
     end
   end
 end

data/lib/business_central/object/purchase_invoice_line.rb

@@ -25,16 +25,10 @@ module BusinessCentral
 
       def initialize(client, company_id:, purchase_invoice_id:)
         super(client, company_id: company_id)
-        @parent_path = [
-          {
-            path: 'companies',
-            id: company_id
-          },
-          {
-            path: 'purchaseInvoices',
-            id: purchase_invoice_id
-          }
-        ]
+        @parent_path << {
+          path: 'purchaseInvoices',
+          id: purchase_invoice_id
+        }
       end
     end
   end

data/lib/business_central/object/request.rb

@@ -42,7 +42,7 @@ module BusinessCentral
       def self.convert(request = {})
         result = {}
         request.each do |key, value|
-          result[key.to_s.to_camel_case] = value 
+          result[key.to_s.to_camel_case] = value if key.is_a? Symbol
         end
 
         return result.to_json
@@ -61,7 +61,7 @@ module BusinessCentral
             if Response.unauthorized?(request.code.to_i)
               raise UnauthorizedException.new
             else
-              if !response[:error][:code].blank?
+              if !response.fetch(:error, nil).nil?
                 case response[:error][:code]
                   when  'Internal_CompanyNotFound'
                     raise CompanyNotFoundException.new

data/lib/business_central/object/vendor.rb

@@ -1,6 +1,8 @@
 module BusinessCentral
   module Object
     class Vendor < Base
+      extend BusinessCentral::Object::Helper
+
       OBJECT = 'vendors'.freeze
 
       OBJECT_VALIDATION = {
@@ -31,15 +33,7 @@ module BusinessCentral
         :delete
       ].freeze
 
-      def initialize(client, company_id:)
-        super(client, company_id: company_id)
-        @parent_path = [
-          {
-            path: 'companies',
-            id: company_id
-          }
-        ]
-      end
+      navigation :default_dimension
     end
   end
 end

data/lib/business_central/version.rb

@@ -1,3 +1,3 @@
 module BusinessCentral
-  VERSION = "1.0.2".freeze
+  VERSION = "1.0.3".freeze
 end

data/test/business_central/client_test.rb

@@ -17,7 +17,7 @@ class BusinessCentral::ClientTest < Minitest::Test
     test_redirect_url = 'www.example.com'
     test_access_token = '123'
 
-    stub_request(:post, /login.windows.net/)
+    stub_request(:post, /#{BusinessCentral::Client::DEFAULT_LOGIN_URL}/)
       .to_return(
         status: 200,
         headers: {
@@ -56,7 +56,7 @@ class BusinessCentral::ClientTest < Minitest::Test
       expires_in: 3600
     )
 
-    stub_request(:post, /login.windows.net/)
+    stub_request(:post, /#{BusinessCentral::Client::DEFAULT_LOGIN_URL}/)
       .to_return(
         status: 200,
         headers: {
@@ -74,4 +74,39 @@ class BusinessCentral::ClientTest < Minitest::Test
     assert_equal test_access_token, response.token
   end
 
+  def test_authorize_throws_exception
+    stub_request(:get, BusinessCentral::Client::DEFAULT_LOGIN_URL)
+        .to_return(status: 200, body: "", headers: {})
+
+    mock = MiniTest::Mock.new
+    def mock.authorize_url(arguments)
+      response = Faraday.get(BusinessCentral::Client::DEFAULT_LOGIN_URL)
+      response = OAuth2::Response.new(response)
+      raise OAuth2::Error.new(response)
+    end
+
+    OAuth2::Strategy::AuthCode.stub(:new, mock) do
+      assert_raises(BusinessCentral::ApiException) do
+        @client.authorize
+      end
+    end
+  end
+
+  def test_request_token_throws_exception
+    stub_request(:get, BusinessCentral::Client::DEFAULT_URL)
+        .to_return(status: 200, body: "", headers: {})
+
+    mock = MiniTest::Mock.new
+    def mock.get_token(code, redirect_uri: '')
+      response = Faraday.get(BusinessCentral::Client::DEFAULT_URL)
+      response = OAuth2::Response.new(response)
+      raise OAuth2::Error.new(response)
+    end
+
+    OAuth2::Strategy::AuthCode.stub(:new, mock) do
+      assert_raises(BusinessCentral::ApiException) do
+        @client.request_token
+      end
+    end
+  end
 end

data/test/business_central/object/base_test.rb

@@ -0,0 +1,39 @@
+require "test_helper"
+# rake test TEST=test/business_central/object/base_test.rb
+
+class BusinessCentral::Object::BaseTest < Minitest::Test
+  def setup
+    @company_id = '123456'
+    @client = BusinessCentral::Client.new
+  end
+
+  def test_no_method_supported_for_find_all
+    base = BusinessCentral::Object::Base.new(@client, {})
+    set_object_method(base, [])
+    assert_raises(BusinessCentral::NoSupportedMethod) do
+      base.find_all
+    end
+  end
+
+  def test_no_method_supported_for_find_by_id
+    base = BusinessCentral::Object::Base.new(@client, {})
+    set_object_method(base, [])
+    assert_raises(BusinessCentral::NoSupportedMethod) do
+      base.find_by_id('123')
+    end
+  end
+
+  def test_no_method_supported_for_where_query
+    base = BusinessCentral::Object::Base.new(@client, {})
+    set_object_method(base, [])
+    assert_raises(BusinessCentral::NoSupportedMethod) do
+      base.where("displayName eq '123'")
+    end
+  end
+
+  private
+
+  def set_object_method(base, value)
+    base.class.const_set('OBJECT_METHODS', value) if !base.class.const_defined?('OBJECT_METHODS')
+  end
+end

data/test/business_central/object/customer_financial_detail_test.rb

@@ -0,0 +1,66 @@
+require "test_helper"
+# rake test TEST=test/business_central/object/customer_financial_detail_test.rb
+
+class BusinessCentral::Object::CustomerFinancialDetailTest < Minitest::Test
+  def setup
+    @company_id = '123456'
+    @client = BusinessCentral::Client.new
+    @customer_financial_detail = @client.customer_financial_detail(
+      company_id: @company_id
+    )
+  end
+
+  def test_find_all
+    stub_request(:get, /customerFinancialDetails/)
+      .to_return(
+        status: 200, 
+        body: {
+          'value': [
+            {
+              id: 1,
+              number: 'N1',
+              balance: 0
+            }
+          ]
+        }.to_json,
+      )
+
+    response = @customer_financial_detail.find_all
+    assert_equal response.first[:number], 'N1'
+  end
+
+  def test_find_by_id
+    test_id = '2'
+    stub_request(:get, /customerFinancialDetails\(#{test_id}\)/)
+      .to_return(
+        status: 200, 
+        body: {
+          id: test_id,
+          number: 'N2',
+          balance: 0
+        }.to_json
+      )
+
+    response = @customer_financial_detail.find_by_id(test_id)
+    assert_equal response[:number], 'N2'
+  end
+
+  def test_where
+    test_filter = "number eq 'N3'"
+    stub_request(:get, /customerFinancialDetails\?\$filter=#{test_filter}/)
+      .to_return(
+        status: 200, 
+        body: {
+          'value': [
+            {
+              id: 3,
+              number: 'N3'
+            }
+          ]
+        }.to_json
+      )
+
+    response = @customer_financial_detail.where(test_filter)
+    assert_equal response.first[:number], 'N3'
+  end
+end

data/test/business_central/object/customer_payment_journal_test.rb

@@ -0,0 +1,135 @@
+require "test_helper"
+# rake test TEST=test/business_central/object/customer_payment_journal_test.rb
+
+class BusinessCentral::Object::CustomerPaymentJournalTest < Minitest::Test
+  def setup
+    @company_id = '123456'
+    @client = BusinessCentral::Client.new
+    @customer_payment_journal = @client.customer_payment_journal(company_id: @company_id)
+  end
+
+  def test_find_all
+    stub_request(:get, /customerPaymentJournals/)
+      .to_return(
+        status: 200, 
+        body: {
+          'value': [
+            {
+              id: 1,
+              code: 'GENERAL',
+              displayName: 'GENERAL 1'
+            }
+          ]
+        }.to_json,
+      )
+
+    response = @customer_payment_journal.find_all
+    assert_equal response.first[:display_name], 'GENERAL 1'
+  end
+
+  def test_find_by_id
+    test_id = 2
+    stub_request(:get, /customerPaymentJournals\(#{test_id}\)/)
+      .to_return(
+        status: 200, 
+        body: {
+          id: test_id,
+          code: 'GENERAL',
+          displayName: 'GENERAL 2'
+        }.to_json
+      )
+
+    response = @customer_payment_journal.find_by_id(test_id)
+    assert_equal response[:display_name], 'GENERAL 2'
+  end
+
+  def test_where
+    test_filter = "displayName eq 'GENERAL 3'"
+    stub_request(:get, /customerPaymentJournals\?\$filter=#{test_filter}/)
+      .to_return(
+        status: 200,
+        body: {
+          'value': [
+            {
+              id: 1,
+              code: 'GENERAL',
+              displayName: 'GENERAL 3'
+            }
+          ]
+        }.to_json
+      )
+
+    response = @customer_payment_journal.where(test_filter)
+    assert_equal response.first[:display_name], 'GENERAL 3'
+  end
+
+  def test_create
+    stub_request(:post, /customerPaymentJournals/)
+      .to_return(
+        status: 200, 
+        body: {
+          id: 1,
+          code: 'GENERAL',
+          displayName: 'GENERAL 4'
+        }.to_json
+      )
+
+    response = @customer_payment_journal.create({
+      display_name: 'GENERAL 4'
+    })
+    assert_equal response[:display_name], 'GENERAL 4'
+  end
+
+
+  def test_update
+    test_id = 2
+    stub_request(:get, /customerPaymentJournals\(#{test_id}\)/)
+      .to_return(
+        status: 200, 
+        body: {
+          etag: '3333',
+          id: test_id,
+          code: 'GENERAL',
+          displayName: 'GENERAL 4'
+        }.to_json
+      )
+
+    stub_request(:patch, /customerPaymentJournals\(#{test_id}\)/)
+      .to_return(
+        status: 200, 
+        body: {
+          etag: '4444',
+          id: test_id,
+          code: 'GENERAL',
+          displayName: 'GENERAL 5'
+        }.to_json
+      )
+
+    response = @customer_payment_journal.update(
+      test_id,
+      {
+        display_name: 'GENERAL 5'
+      }
+    )
+    assert_equal response[:display_name], 'GENERAL 5'
+  end
+
+  def test_delete
+    test_id = '33333'
+    stub_request(:get, /customerPaymentJournals\(#{test_id}\)/)
+      .to_return(
+        status: 200, 
+        body: {
+          etag: '5555',
+          id: test_id,
+          code: 'GENERAL',
+          displayName: 'GENERAL 5'
+        }.to_json
+      )
+
+    stub_request(:delete, /customerPaymentJournals\(#{test_id}\)/)
+      .to_return(status: 204)
+
+    assert @customer_payment_journal.destroy(test_id)
+  end
+end