bushpig 0.1.1 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f268254d94c085b2d6f9ce94fdbe41a7f19f258dab8b4bdb8f693539ca2dae2a
-  data.tar.gz: 9e6cd8def3f5098cb61ad97d4890a49d521b8bb0406d1c56502ca262622f0c21
+  metadata.gz: 8d3c78ffe7777e02a7e1a7d4f4e1838ab47c80a5c9d0c1d61e6547c2b956065f
+  data.tar.gz: 64bc3d1e149b54e84a28e9f637b9495b7a6e9d7eec451304e310afd8bb473067
 SHA512:
-  metadata.gz: ad01e0e305262739d92ad507b6ddf69df77273d95a84a35e0d3fc92e6753413ce6c5a273d20cc870ff29beb14fdd4279f91da132ca785666c83ffb9661f1a638
-  data.tar.gz: 9e8e78181b40dc8871e1367b8c7b18990256ab78da5e44c900bdf58d60b5609ed473bdb35c60e44a34879940ca2eeb1f69104b55d97e907a48a6faf4308e976e
+  metadata.gz: 9a1ca507019ef95f735f9b0558d1b4867fccec40a6fac62ced66f69d0ab57168a081af14dd661876221213c92e3c184393dabedefe8f706a1a12aa6354955bdd
+  data.tar.gz: 7148a4dabeff3df6575b455a08306342d9b488938593841882ed025e1f7a6fcbb35d22c5f29554a2269c78f3aa853808c84570d889aca8fadcac55ef5a362ec7

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bushpig (0.1.1)
+    bushpig (0.1.7)
       connection_pool (~> 2.2)
       json (>= 1.8)
       redis (~> 3.3)

data/bin/bushpig

@@ -1,4 +1,10 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
+# don't buffer output (for logging if running as a systemd service)
+$stdout.sync = true
+$stderr.sync = true
+
 require 'bushpig/cli'
 Bushpig::CLI.start(ARGV)

data/gemset.nix

@@ -186,7 +186,7 @@
       path = ./.;
       type = "path";
     };
-    version = "0.1.1";
+    version = "0.1.7";
   };
   coderay = {
     groups = ["default" "development"];

data/lib/bushpig.rb

@@ -43,11 +43,11 @@ module Bushpig
     defined?(Bushpig::CLI)
   end
 
-  def self.set_key(queue)
+  def self.queue_key(queue)
     "set:#{queue}"
   end
 
-  def self.job_key(job_id)
-    "job:#{job_id}"
+  def self.job_key(job_key)
+    "job:#{job_key}"
   end
 end

data/lib/bushpig/client.rb

@@ -4,9 +4,10 @@ module Bushpig
   class Client
     attr_accessor :default_ttl
 
-    def initialize(pool)
+    def initialize(pool, &callback)
       @pool = pool
       @default_ttl = nil
+      @callback = callback
     end
 
     def redis_pool
@@ -18,9 +19,10 @@ module Bushpig
     end
 
     def submit(queue, job, score: default_score, ttl: default_ttl)
+      modified = @callback.call(job)
       redis_pool.with do |conn|
-        conn.set(Bushpig.job_key(job.job_id), job.job_payload, ex: ttl)
-        conn.zadd(Bushpig.set_key(queue), score, job.job_id)
+        conn.set(Bushpig.job_key(modified.job_key), modified.job_payload, ex: ttl)
+        conn.zadd(Bushpig.queue_key(queue), score, modified.job_key)
       end
     end
   end

data/lib/bushpig/job.rb

@@ -16,8 +16,12 @@ module Bushpig
           @job_id = job_id
         end
 
+        def job_key
+          job_id
+        end
+
         def job_payload
-          JSON.generate({ class: self.class.name, args: each.to_a })
+          JSON.generate({ class: self.class.name, id: job_id, args: each.to_a })
         end
       end
     end
@@ -27,24 +31,30 @@ module Bushpig
         @@unique_key = unique_key
 
         def job_id
+          @job_id ||= SecureRandom.hex(32)
+        end
+
+        def job_id=(job_id)
+          @job_id = job_id
+        end
+
+        def job_key
           @@unique_key.inject(Digest::SHA256.new) do |digest, key|
             digest.update(self[key].to_s)
           end.hexdigest
         end
 
-        def job_id=(job_id); end
-
         def job_payload
-          JSON.generate({ class: self.class.name, args: each.to_a })
+          JSON.generate({ class: self.class.name, id: job_id, args: each.to_a })
         end
       end
     end
 
-    def self.hydrate(job_id, job_payload)
+    def self.hydrate(job_payload)
       h = JSON.parse(job_payload, symbolize_names: true)
       klass = const_get(h[:class])
       job = klass.new(*h[:args])
-      job.job_id = job_id
+      job.job_id = h[:id]
       job
     end
   end

data/lib/bushpig/server.rb

@@ -19,10 +19,16 @@ module Bushpig
         puts 'INT received, shutdown flagged'
         @done = true
       end
+      Signal.trap('TERM') do
+        reset_signals
+        puts 'TERM received, shutdown flagged'
+        @done = true
+      end
     end
 
     def reset_signals
       Signal.trap('INT', 'DEFAULT')
+      Signal.trap('TERM', 'DEFAULT')
     end
 
     def serve(queue)
@@ -42,18 +48,29 @@ module Bushpig
     end
 
     def handle(job)
-      puts "Job starting: jid-#{job.job_id} #{job}"
+      puts "Job starting: jid-#{job.job_id} jkey-#{job.job_key} #{job}"
       started = monotonic_time
       @handler.call(job)
       finished = monotonic_time
       elapsed = finished - started
       puts "Job completed: jid-#{job.job_id} #{elapsed} seconds"
     rescue StandardError => e
-      # Job handler raised exception
       finished = monotonic_time
       elapsed = finished - started
       puts "Job raised exception: jid-#{job.job_id} #{elapsed} seconds: #{e}"
-      # TODO: log exception to honeybadger
+      notify_exception(job, e)
+    end
+
+    def honeybadger
+      @honeybadger ||= begin
+        Honeybadger
+      rescue NameError
+        nil
+      end
+    end
+
+    def notify_exception(job, exception)
+      honeybadger&.notify(exception, context: { job_id: job.job_id, job_key: job.job_key, job: job.to_s })
     end
 
     def monotonic_time
@@ -63,7 +80,7 @@ module Bushpig
     def fetch(queue)
       redis_pool.with do |conn|
         begin
-          res = conn.bzpopmin(Bushpig.set_key(queue), @timeout)
+          res = conn.bzpopmin(Bushpig.queue_key(queue), @timeout)
         rescue Redis::TimeoutError
           # TODO: warn user (once) that redis timeout set lower than pop timeout
           conn.close
@@ -71,20 +88,20 @@ module Bushpig
         end
         return nil if res.nil?
 
-        (_set, jid, _score) = res
-        # conn.sadd('running', jid)
+        (_set, key, _score) = res
+        # conn.sadd('running', key)
 
-        payload = conn.get(Bushpig.job_key(jid))
+        payload = conn.get(Bushpig.job_key(key))
         return nil if payload.nil? # most likely job expired
 
-        Bushpig::Job.hydrate(jid, payload)
+        Bushpig::Job.hydrate(payload)
       end
     end
 
     def complete(job)
       redis_pool.with do |conn|
-        # conn.srem('running', job.job_id)
-        conn.del(Bushpig.job_key(job.job_id))
+        # conn.srem('running', job.job_key)
+        conn.del(Bushpig.job_key(job.job_key))
       end
     end
   end

data/lib/bushpig/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bushpig
-  VERSION = '0.1.1'
+  VERSION = '0.1.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bushpig
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.7
 platform: ruby
 authors:
 - Shaun Sharples