bundler_ext 0.3.2 → 0.4.0

data/spec/bundler_ext/gemfile_spec.rb

@@ -0,0 +1,191 @@
+require 'spec_helper'
+require 'bundler_ext/gemfile'
+
+module BundlerExt
+  describe Gemfile do
+    describe "#setup_env" do
+      around(:each) do |spec|
+        orig = ENV['BUNDLE_GEMFILE']
+        spec.run
+        ENV['BUNDLE_GEMFILE'] = orig
+      end
+
+      it "sets BUNDLE_GEMFILE env varialbe" do
+        described_class.setup_env('Gemfile.custom')
+        ENV['BUNDLE_GEMFILE'].should == 'Gemfile.custom'
+      end
+    end
+
+    describe "#parse_env" do
+      around(:each) do |spec|
+        beg1 = ENV['BUNDLER_EXT_GROUPS']
+        beg2 = ENV['BEXT_GROUPS']
+        spec.run
+        ENV['BUNDLER_EXT_GROUPS'] = beg1
+        ENV['BEXT_GROUPS']       = beg2
+      end
+
+      it "converts specified groups to symbols" do
+        described_class.parse_env(['development', 'test'])[:groups].should == [:development, :test]
+      end
+
+      it "retrieves extra groups from BUNDLER_EXT_GROUPS env variable" do
+        ENV['BUNDLER_EXT_GROUPS'] = 'development test'
+        env = described_class.parse_env([])
+        env[:groups].should == [:development, :test]
+        env[:extra_groups].should == 'development test'
+      end
+
+      it "retrieves extra groups from BEXT_GROUPS env variable" do
+        ENV['BEXT_GROUPS'] = 'development test'
+        env = described_class.parse_env([])
+        env[:groups].should == [:development, :test]
+        env[:extra_groups].should == 'development test'
+      end
+
+      context "groups == [:all] and no extra groups specified" do
+        it "sets all_groups true" do
+          described_class.parse_env([:all])[:all_groups].should be_true
+        end
+      end
+
+      context "groups != [:all]" do
+        it "sets all_groups false" do
+          described_class.parse_env([:dev])[:all_groups].should be_false
+        end
+      end
+
+      context "extra groups specified" do
+        it "sets all_groups false" do
+          ENV['BEXT_GROUPS'] = 'development'
+          described_class.parse_env([:all])[:all_groups].should be_false
+        end
+      end
+    end
+
+    describe "#dependency_in_env?" do
+      before(:each) do
+        @dep = Bundler::Dependency.new 'rake', '1.0.0', 'group' => [:test]
+        @env = {:groups => []}
+      end
+
+      context "dep.current_platform? is false" do
+        it "returns false" do
+          @env[:all_groups] = true
+          @dep.should_receive(:current_platform?).and_return(false)
+          described_class.dependency_in_env?(@dep, @env).should be_false
+        end
+      end
+
+      context ":all_groups is false and depenency _not_ in env groups" do
+        it "returns false" do
+          @env[:all_groups] = false
+          @env[:groups] << :dev
+          described_class.dependency_in_env?(@dep, @env).should be_false
+        end
+      end
+
+      context ":all_groups and dep.current_platform? are true" do
+        it "returns true" do
+          @env[:all_groups] = true
+          @dep.should_receive(:current_platform?).and_return(true)
+          described_class.dependency_in_env?(@dep, @env).should be_true
+        end
+      end
+
+      context "dep is in a group and dep.current_platform? is true" do
+        it "returns true" do
+          @env[:groups] << :dev
+          @dep.groups   << :dev
+          @dep.should_receive(:current_platform?).and_return(true)
+          described_class.dependency_in_env?(@dep, @env).should be_true
+        end
+      end
+    end
+
+    describe "#files_for_dependency" do
+      context "dependency in env" do
+        it "returns dependency autorequires" do
+          dep = Bundler::Dependency.new 'rake', '1.0.0', 'require' => [:foo]
+          described_class.should_receive(:dependency_in_env?).and_return(true)
+          described_class.files_for_dependency(dep, {}).should == [:foo]
+        end
+
+        context "autorequires is nil" do
+          it("returns depenency name") do
+            dep = Bundler::Dependency.new 'rake', '1.0.0'
+            described_class.should_receive(:dependency_in_env?).and_return(true)
+            described_class.files_for_dependency(dep, {}).should == ['rake']
+          end
+        end
+      end
+
+      context "dependency not in env" do
+        it "returns empty array" do
+          dep = Bundler::Dependency.new 'rake', '1.0.0'
+          described_class.should_receive(:dependency_in_env?).and_return(false)
+          described_class.files_for_dependency(dep, {}).should == []
+        end
+      end
+    end
+
+    describe "#process" do
+      before(:each) do
+        ENV['BUNDLE_GEMFILE'] = 'spec/fixtures/Gemfile.in'
+        @dep = Bundler::Dependency.new 'rake', '1.0.0'
+        @gemfile = Bundler::Dsl.evaluate 'spec/fixtures/Gemfile.in', nil, true
+        @gemfile.should_receive(:dependencies).and_return([@dep])
+      end
+
+      after(:each) do
+        ENV.delete('BUNDLE_GEMFILE')
+      end
+
+      it "returns gemfile dependencies with files" do
+        described_class.should_receive(:files_for_dependency).and_return([:files])
+        described_class.process(@gemfile, {}).should ==
+          {'rake' => {:dep => @dep, :files => [:files]}}
+      end
+
+      it "does not return gemfile dependencies without files" do
+        described_class.should_receive(:files_for_dependency).and_return([])
+        described_class.process(@gemfile, {}).should == {}
+      end
+    end
+
+    describe "#parse" do
+      before(:each) do
+        @gemfile = 'spec/fixtures/Gemfile.in'
+        ENV['BUNDLE_GEMFILE'] = @gemfile
+      end
+
+      after(:each) do
+        ENV.delete('BUNDLE_GEMFILE')
+      end
+
+      it "sets up env for gemfile" do
+        described_class.should_receive(:setup_env).with(@gemfile)
+        described_class.parse(@gemfile)
+      end
+
+      it "retrieves env configured by gemfile" do
+        described_class.should_receive(:parse_env).with([:test]).and_call_original
+        described_class.parse(@gemfile, :test)
+      end
+
+      it "evaluates gemfile with bundler dsl" do
+        Bundler::Dsl.should_receive(:evaluate).with(@gemfile, nil, true).and_call_original
+        described_class.parse(@gemfile, :test)
+      end
+
+      it "processes gemfile / returns results" do
+        env = Object.new
+        gemfile = Object.new
+        described_class.should_receive(:parse_env).and_return(env)
+        Bundler::Dsl.should_receive(:evaluate).and_return(gemfile)
+        described_class.should_receive(:process).with(gemfile, env)
+        described_class.parse(@gemfile, :test)
+      end
+    end
+  end # describe Gemfile
+end # module BundlerExt

data/spec/bundler_ext/integration_spec.rb

@@ -0,0 +1,146 @@
+require 'spec_helper'
+
+# skip system specs unless we can load linux_admin
+skip_system = false
+begin
+  require 'linux_admin'
+rescue LoadError
+  skip_system = true
+end
+
+  describe BundlerExt do
+    before(:each) do
+      @gemfile = 'spec/fixtures/Gemfile.in'
+    end
+    after(:each) do
+      ENV['BUNDLER_PKG_PREFIX'] = nil
+      ENV['BEXT_ACTIVATE_VERSIONS'] = nil
+      ENV['BEXT_PKG_PREFIX'] = nil
+      ENV['BEXT_NOSTRICT'] = nil
+      ENV['BEXT_GROUPS'] = nil
+    end
+
+    describe "#parse_from_gemfile" do
+      describe "with no group passed in" do
+        it "should return nothing to require" do
+          libs = BundlerExt::Gemfile.parse(@gemfile)
+          libs.should be_an(Hash)
+          libs.keys.should_not include('deltacloud-client')
+          libs.keys.should_not include('vcr')
+        end
+      end
+      describe "with :all passed in" do
+        it "should return the list of system libraries in all groups to require" do
+          libs = BundlerExt::Gemfile.parse(@gemfile, :all)
+          libs.should be_an(Hash)
+          libs.keys.should include('deltacloud-client')
+          libs['deltacloud-client'][:files].should == ['deltacloud']
+          libs.keys.should include('vcr')
+        end
+      end
+      describe "with group passed in" do
+        it "should not return any deps that are not in the 'development' group" do
+          libs = BundlerExt::Gemfile.parse(@gemfile,'development')
+          libs.should be_an(Hash)
+          libs.keys.should_not include('deltacloud-client')
+        end
+        it "should return only deps that are in the :test group" do
+          libs = BundlerExt::Gemfile.parse(@gemfile, :test)
+          libs.should be_an(Hash)
+          libs.keys.should_not include('deltacloud-client')
+          libs.keys.should include('vcr')
+        end
+        it "should return deps from both the :default and :test groups" do
+          libs = BundlerExt::Gemfile.parse(@gemfile, :default, :test)
+          libs.should be_an(Hash)
+          libs.keys.should include('deltacloud-client')
+          libs.keys.should include('vcr')
+        end
+      end
+      it "should only return deps for the current platform" do
+        libs = BundlerExt::Gemfile.parse(@gemfile)
+        libs.should be_an(Hash)
+        if RUBY_VERSION < "1.9"
+          libs.keys.should_not include('cinch')
+        else
+          libs.keys.should_not include('fastercsv')
+        end
+      end
+    end
+    describe "#system_require" do
+      it "strict mode should fail loading non existing gem" do
+        expect { BundlerExt.system_require(@gemfile, :fail) }.to raise_error
+      end
+
+      it "non-strict mode should load the libraries in the gemfile" do
+        ENV['BEXT_NOSTRICT'] = 'true'
+        BundlerExt.system_require(@gemfile)
+        defined?(Gem).should be_true
+      end
+
+      it "non-strict mode should load the libraries in the gemfile" do
+        ENV['BUNDLER_EXT_NOSTRICT'] = 'true'
+        BundlerExt.system_require(@gemfile)
+        defined?(Gem).should be_true
+      end
+
+      it "non-strict mode should load the libraries in the gemfile" do
+        ENV['BEXT_NOSTRICT'] = 'true'
+        BundlerExt.system_require(@gemfile, :fail)
+        defined?(Gem).should be_true
+      end
+
+      it "non-strict mode should load the libraries in the gemfile" do
+        ENV['BUNDLER_EXT_NOSTRICT'] = 'true'
+        BundlerExt.system_require(@gemfile, :fail)
+        defined?(Gem).should be_true
+      end
+      it "non-strict mode should load the libraries using env var list" do
+        ENV['BEXT_GROUPS'] = 'test development blah'
+        ENV['BEXT_NOSTRICT'] = 'true'
+        BundlerExt.system_require(@gemfile)
+        defined?(Gem::Command).should be_true
+      end
+
+      it "non-strict mode should load the libraries using env var list" do
+        ENV['BUNLDER_EXT_GROUPS'] = 'test development blah'
+        ENV['BEXT_NOSTRICT'] = 'true'
+        BundlerExt.system_require(@gemfile)
+        defined?(Gem::Command).should be_true
+      end
+
+      unless skip_system
+        context "ENV['BEXT_ACTIVATE_VERSIONS'] is true" do
+          before(:each) do
+            ENV['BUNDLER_EXT_NOSTRICT'] = 'true'
+            ENV['BEXT_ACTIVATE_VERSIONS'] = 'true'
+          end
+
+          it "activates the version of the system installed package" do
+            gems = BundlerExt::Gemfile.parse(@gemfile, :all)
+            gems.each { |gem,gdep|
+              version = rand(100)
+              BundlerExt::System.should_receive(:system_name_for).with(gem).
+                         and_return(gem)
+              BundlerExt::System.should_receive(:system_version_for).with(gem).
+                         and_return(version)
+              BundlerExt::System.should_receive(:gem).with(gem, "=#{version}")
+            }
+            BundlerExt.system_require(@gemfile, :all)
+          end
+
+          context "ENV['BEXT_PKG_PREFIX'] is specified" do
+            it "prepends bundler pkg prefix onto system package name to load" do
+              ENV['BEXT_PKG_PREFIX'] = 'rubygem-'
+              gems = BundlerExt::Gemfile.parse(@gemfile, :all)
+              gems.each { |gem,gdep|
+                BundlerExt::System.should_receive(:system_version_for).with("rubygem-#{gem}").
+                           and_return('0')
+              }
+              BundlerExt.system_require(@gemfile, :all)
+            end
+          end
+        end
+      end
+    end
+  end

data/spec/bundler_ext/runtime_spec.rb

@@ -0,0 +1,178 @@
+require 'spec_helper'
+require 'bundler_ext/runtime'
+
+module BundlerExt
+  describe Runtime do
+    describe "#gemfile" do
+      it "gets/sets bext_gemfile" do
+        runtime = described_class.new
+        runtime.gemfile('Gemfile.in').should == 'Gemfile.in'
+        runtime.gemfile.should == 'Gemfile.in'
+      end
+
+      it "defaults to Bundler.default_gemfile" do
+        Bundler.should_receive(:default_gemfile).and_return('DefaultGemfile')
+        runtime = described_class.new
+        runtime.gemfile.should == 'DefaultGemfile'
+      end
+    end
+
+    describe "#root" do
+      it "returns directory name of gemfile" do
+        runtime = described_class.new
+        runtime.gemfile(Pathname.new('spec/fixtures/Gemfile.in'))
+        runtime.root.to_s.should == File.expand_path('spec/fixtures')
+      end
+    end
+
+    describe "#bundler" do
+      it "returns handle to bundler runtime" do
+        runtime = described_class.new
+        runtime.gemfile(Pathname.new('spec/fixtures/Gemfile.in'))
+        bundler = runtime.bundler
+        bundler.should be_an_instance_of(Bundler::Runtime)
+        bundler.root.to_s.should == File.expand_path('spec/fixtures')
+        runtime.bundler.should == bundler
+      end
+    end
+
+    describe "#rubygems" do
+      it "returns handle to bundler rubygems integration" do
+        runtime  = described_class.new
+        rubygems = runtime.rubygems
+        rubygems.should be_an_instance_of(Bundler::RubygemsIntegration)
+        runtime.rubygems.should == rubygems
+      end
+    end
+
+    describe "#setup_env" do
+      around(:each) do |spec|
+        orig = ENV
+        spec.run
+        ENV = orig
+      end
+
+      it "assigns env home variable to BEXT_HOME" do
+        ENV['BEXT_HOME'] = '/home/foo'
+        described_class.new.setup_env
+        ENV['HOME'].should == '/home/foo'
+      end
+
+      it "assigns env home variable to BUNDLER_EXT_HOME" do
+        ENV['BUNDLER_EXT_HOME'] = '/home/foo'
+        described_class.new.setup_env
+        ENV['HOME'].should == '/home/foo'
+      end
+    end
+
+    describe "::namespaced_file" do
+      context "file does not include '-'" do
+        it "returns nil" do
+          described_class.namespaced_file('foobar').should be_nil
+        end
+      end
+
+      context "file responds to :name" do
+        it "returns file name in path format" do
+          file = Pathname.new 'foo-bar'
+          file.should_receive(:name).and_return('foo-bar')
+          described_class.namespaced_file(file).should == 'foo/bar'
+        end
+      end
+
+      it "returns file in path format" do
+        described_class.namespaced_file("foo-bar").should == 'foo/bar'
+      end
+    end
+
+    describe "#system_require" do
+      it "requires files" do
+        runtime = described_class.new
+        runtime.should_receive(:require).with('file1')
+        runtime.system_require(['file1'])
+      end
+
+      context "LoadError when requiring file" do
+        it "requires namespaced file" do
+          described_class.should_receive(:namespaced_file).with('file1').
+            and_return('namespaced_file1')
+          runtime = described_class.new
+          runtime.should_receive(:require).with('file1').and_call_original
+          runtime.should_receive(:require).with('namespaced_file1')
+          runtime.system_require(['file1'])
+        end
+
+        context "LoadError when requiring namespaced file" do
+          it "outputs strict error" do
+            expected = 'Gem loading error: cannot load such file -- namespaced_file1'
+            Output.should_receive(:strict_err).with(expected)
+
+            described_class.should_receive(:namespaced_file).with('file1').
+              and_return('namespaced_file1')
+            runtime = described_class.new
+            runtime.should_receive(:require).with('file1').and_call_original
+            runtime.should_receive(:require).with('namespaced_file1').and_call_original
+            runtime.system_require(['file1'])
+          end
+        end
+
+        context "namespaced file is nil" do
+          it "outputs strict error" do
+            expected = 'Gem loading error: cannot load such file -- file1'
+            Output.should_receive(:strict_err).with(expected)
+
+            described_class.should_receive(:namespaced_file).with('file1').
+              and_return(nil)
+            runtime = described_class.new
+            runtime.should_receive(:require).with('file1').and_call_original
+            runtime.system_require(['file1'])
+          end
+        end
+      end
+    end
+
+    describe "clear" do
+      it "cleans bundler load path" do
+        runtime = described_class.new
+        runtime.bundler.should_receive(:clean_load_path)
+        runtime.clear
+      end
+    end
+
+    describe "add_spec" do
+      around(:each) do |spec|
+        orig = $LOAD_PATH
+        spec.run
+
+        # XXX need to restore this way else we'll get an err:
+        #   "$LOAD_PATH is a read-only variable"
+        $LOAD_PATH.clear
+        orig.each { |o| $LOAD_PATH << o }
+      end
+
+      it "marks spec as loaded" do
+        spec = Gem::Specification.new
+        runtime = described_class.new
+        runtime.rubygems.should_receive(:mark_loaded).with(spec)
+        runtime.add_spec(spec)
+      end
+
+      it "adds spec load paths not already on LOAD_PATH to it" do
+        $LOAD_PATH.clear
+        spec = Gem::Specification.new :load_paths => ['foo']
+        runtime = described_class.new
+        runtime.add_spec(spec)
+        $LOAD_PATH.should include(*spec.load_paths)
+      end
+
+      it "skips paths already on the $LOAD_PATH" do
+        spec = Gem::Specification.new :load_paths => ['foo']
+        $LOAD_PATH.clear
+        $LOAD_PATH << spec.load_paths.first
+        runtime = described_class.new
+        runtime.add_spec(spec)
+        $LOAD_PATH.size.should == 1
+      end
+    end
+  end # describe Runtime
+end # module BundlerExt