bundler 2.7.1 → 4.0.0.beta1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (144) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +1001 -902
  3. data/README.md +4 -4
  4. data/bundler.gemspec +3 -3
  5. data/lib/bundler/build_metadata.rb +2 -2
  6. data/lib/bundler/capistrano.rb +1 -19
  7. data/lib/bundler/checksum.rb +6 -0
  8. data/lib/bundler/cli/cache.rb +1 -12
  9. data/lib/bundler/cli/common.rb +21 -4
  10. data/lib/bundler/cli/config.rb +1 -2
  11. data/lib/bundler/cli/console.rb +5 -0
  12. data/lib/bundler/cli/exec.rb +29 -4
  13. data/lib/bundler/cli/gem.rb +19 -33
  14. data/lib/bundler/cli/install.rb +7 -84
  15. data/lib/bundler/cli/issue.rb +2 -2
  16. data/lib/bundler/cli/list.rb +33 -2
  17. data/lib/bundler/cli/lock.rb +5 -5
  18. data/lib/bundler/cli/plugin.rb +5 -1
  19. data/lib/bundler/cli/show.rb +3 -7
  20. data/lib/bundler/cli/update.rb +3 -3
  21. data/lib/bundler/cli.rb +97 -95
  22. data/lib/bundler/compact_index_client.rb +0 -1
  23. data/lib/bundler/current_ruby.rb +3 -15
  24. data/lib/bundler/definition.rb +122 -95
  25. data/lib/bundler/deployment.rb +1 -64
  26. data/lib/bundler/digest.rb +1 -1
  27. data/lib/bundler/dsl.rb +14 -36
  28. data/lib/bundler/endpoint_specification.rb +0 -22
  29. data/lib/bundler/errors.rb +1 -5
  30. data/lib/bundler/feature_flag.rb +0 -33
  31. data/lib/bundler/fetcher/compact_index.rb +1 -1
  32. data/lib/bundler/friendly_errors.rb +2 -2
  33. data/lib/bundler/index.rb +0 -7
  34. data/lib/bundler/inline.rb +1 -1
  35. data/lib/bundler/installer/gem_installer.rb +0 -11
  36. data/lib/bundler/installer.rb +0 -6
  37. data/lib/bundler/lockfile_generator.rb +1 -1
  38. data/lib/bundler/lockfile_parser.rb +2 -12
  39. data/lib/bundler/man/bundle-add.1 +1 -1
  40. data/lib/bundler/man/bundle-binstubs.1 +3 -6
  41. data/lib/bundler/man/bundle-binstubs.1.ronn +4 -6
  42. data/lib/bundler/man/bundle-cache.1 +2 -14
  43. data/lib/bundler/man/bundle-cache.1.ronn +1 -14
  44. data/lib/bundler/man/bundle-check.1 +2 -5
  45. data/lib/bundler/man/bundle-check.1.ronn +0 -5
  46. data/lib/bundler/man/bundle-clean.1 +1 -1
  47. data/lib/bundler/man/bundle-config.1 +36 -46
  48. data/lib/bundler/man/bundle-config.1.ronn +69 -75
  49. data/lib/bundler/man/bundle-console.1 +1 -1
  50. data/lib/bundler/man/bundle-doctor.1 +4 -4
  51. data/lib/bundler/man/bundle-doctor.1.ronn +4 -4
  52. data/lib/bundler/man/bundle-env.1 +1 -1
  53. data/lib/bundler/man/bundle-exec.1 +2 -5
  54. data/lib/bundler/man/bundle-exec.1.ronn +1 -5
  55. data/lib/bundler/man/bundle-fund.1 +1 -1
  56. data/lib/bundler/man/bundle-gem.1 +3 -6
  57. data/lib/bundler/man/bundle-gem.1.ronn +2 -5
  58. data/lib/bundler/man/bundle-help.1 +1 -1
  59. data/lib/bundler/man/bundle-info.1 +1 -1
  60. data/lib/bundler/man/bundle-init.1 +1 -1
  61. data/lib/bundler/man/bundle-install.1 +8 -59
  62. data/lib/bundler/man/bundle-install.1.ronn +12 -107
  63. data/lib/bundler/man/bundle-issue.1 +1 -1
  64. data/lib/bundler/man/bundle-licenses.1 +1 -1
  65. data/lib/bundler/man/bundle-list.1 +6 -1
  66. data/lib/bundler/man/bundle-list.1.ronn +5 -0
  67. data/lib/bundler/man/bundle-lock.1 +1 -1
  68. data/lib/bundler/man/bundle-open.1 +1 -1
  69. data/lib/bundler/man/bundle-outdated.1 +1 -1
  70. data/lib/bundler/man/bundle-platform.1 +1 -1
  71. data/lib/bundler/man/bundle-plugin.1 +33 -15
  72. data/lib/bundler/man/bundle-plugin.1.ronn +36 -15
  73. data/lib/bundler/man/bundle-pristine.1 +1 -1
  74. data/lib/bundler/man/bundle-remove.1 +2 -8
  75. data/lib/bundler/man/bundle-remove.1.ronn +1 -8
  76. data/lib/bundler/man/bundle-show.1 +2 -5
  77. data/lib/bundler/man/bundle-show.1.ronn +0 -4
  78. data/lib/bundler/man/bundle-update.1 +1 -1
  79. data/lib/bundler/man/bundle-version.1 +1 -1
  80. data/lib/bundler/man/bundle.1 +1 -10
  81. data/lib/bundler/man/bundle.1.ronn +0 -9
  82. data/lib/bundler/man/gemfile.5 +1 -1
  83. data/lib/bundler/man/index.txt +0 -2
  84. data/lib/bundler/materialization.rb +1 -1
  85. data/lib/bundler/plugin/installer.rb +0 -10
  86. data/lib/bundler/plugin/source_list.rb +1 -1
  87. data/lib/bundler/plugin.rb +1 -1
  88. data/lib/bundler/resolver/package.rb +1 -0
  89. data/lib/bundler/resolver.rb +1 -1
  90. data/lib/bundler/ruby_dsl.rb +2 -0
  91. data/lib/bundler/ruby_version.rb +1 -3
  92. data/lib/bundler/rubygems_ext.rb +1 -1
  93. data/lib/bundler/rubygems_gem_installer.rb +1 -1
  94. data/lib/bundler/rubygems_integration.rb +1 -5
  95. data/lib/bundler/self_manager.rb +1 -1
  96. data/lib/bundler/settings.rb +8 -27
  97. data/lib/bundler/shared_helpers.rb +8 -20
  98. data/lib/bundler/source/gemspec.rb +4 -0
  99. data/lib/bundler/source/git/git_proxy.rb +3 -11
  100. data/lib/bundler/source/git.rb +2 -3
  101. data/lib/bundler/source/path.rb +5 -7
  102. data/lib/bundler/source/rubygems.rb +11 -17
  103. data/lib/bundler/source.rb +1 -1
  104. data/lib/bundler/source_list.rb +4 -45
  105. data/lib/bundler/source_map.rb +2 -5
  106. data/lib/bundler/spec_set.rb +6 -15
  107. data/lib/bundler/templates/newgem/CODE_OF_CONDUCT.md.tt +7 -129
  108. data/lib/bundler/templates/newgem/circleci/config.yml.tt +12 -0
  109. data/lib/bundler/templates/newgem/ext/newgem/Cargo.toml.tt +1 -1
  110. data/lib/bundler/templates/newgem/ext/newgem/extconf-go.rb.tt +11 -0
  111. data/lib/bundler/templates/newgem/ext/newgem/go.mod.tt +5 -0
  112. data/lib/bundler/templates/newgem/ext/newgem/newgem-go.c.tt +2 -0
  113. data/lib/bundler/templates/newgem/ext/newgem/newgem.go.tt +31 -0
  114. data/lib/bundler/templates/newgem/github/workflows/main.yml.tt +6 -0
  115. data/lib/bundler/templates/newgem/gitlab-ci.yml.tt +9 -0
  116. data/lib/bundler/templates/newgem/newgem.gemspec.tt +7 -4
  117. data/lib/bundler/vendor/connection_pool/lib/connection_pool/timed_stack.rb +26 -23
  118. data/lib/bundler/vendor/connection_pool/lib/connection_pool/version.rb +1 -1
  119. data/lib/bundler/vendor/connection_pool/lib/connection_pool.rb +50 -6
  120. data/lib/bundler/vendor/fileutils/lib/fileutils.rb +57 -52
  121. data/lib/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb +5 -2
  122. data/lib/bundler/vendor/thor/lib/thor/actions/file_manipulation.rb +42 -6
  123. data/lib/bundler/vendor/thor/lib/thor/parser/options.rb +1 -1
  124. data/lib/bundler/vendor/thor/lib/thor/runner.rb +2 -2
  125. data/lib/bundler/vendor/thor/lib/thor/shell/basic.rb +3 -7
  126. data/lib/bundler/vendor/thor/lib/thor/version.rb +1 -1
  127. data/lib/bundler/vendor/uri/lib/uri/common.rb +57 -15
  128. data/lib/bundler/vendor/uri/lib/uri/file.rb +1 -1
  129. data/lib/bundler/vendor/uri/lib/uri/generic.rb +34 -21
  130. data/lib/bundler/vendor/uri/lib/uri/http.rb +12 -0
  131. data/lib/bundler/vendor/uri/lib/uri/rfc2396_parser.rb +9 -8
  132. data/lib/bundler/vendor/uri/lib/uri/version.rb +2 -2
  133. data/lib/bundler/version.rb +1 -1
  134. data/lib/bundler/vlad.rb +1 -14
  135. data/lib/bundler.rb +6 -28
  136. metadata +9 -13
  137. data/lib/bundler/cli/inject.rb +0 -60
  138. data/lib/bundler/cli/viz.rb +0 -31
  139. data/lib/bundler/graph.rb +0 -152
  140. data/lib/bundler/man/bundle-inject.1 +0 -31
  141. data/lib/bundler/man/bundle-inject.1.ronn +0 -32
  142. data/lib/bundler/man/bundle-viz.1 +0 -30
  143. data/lib/bundler/man/bundle-viz.1.ronn +0 -36
  144. data/lib/bundler/similarity_detector.rb +0 -63
@@ -1,132 +1,10 @@
1
- # Contributor Covenant Code of Conduct
1
+ # Code of Conduct
2
2
 
3
- ## Our Pledge
3
+ <%= config[:name].inspect %> follows [The Ruby Community Conduct Guideline](https://www.ruby-lang.org/en/conduct) in all "collaborative space", which is defined as community communications channels (such as mailing lists, submitted patches, commit comments, etc.):
4
4
 
5
- We as members, contributors, and leaders pledge to make participation in our
6
- community a harassment-free experience for everyone, regardless of age, body
7
- size, visible or invisible disability, ethnicity, sex characteristics, gender
8
- identity and expression, level of experience, education, socio-economic status,
9
- nationality, personal appearance, race, caste, color, religion, or sexual
10
- identity and orientation.
5
+ * Participants will be tolerant of opposing views.
6
+ * Participants must ensure that their language and actions are free of personal attacks and disparaging personal remarks.
7
+ * When interpreting the words and actions of others, participants should always assume good intentions.
8
+ * Behaviour which can be reasonably considered harassment will not be tolerated.
11
9
 
12
- We pledge to act and interact in ways that contribute to an open, welcoming,
13
- diverse, inclusive, and healthy community.
14
-
15
- ## Our Standards
16
-
17
- Examples of behavior that contributes to a positive environment for our
18
- community include:
19
-
20
- * Demonstrating empathy and kindness toward other people
21
- * Being respectful of differing opinions, viewpoints, and experiences
22
- * Giving and gracefully accepting constructive feedback
23
- * Accepting responsibility and apologizing to those affected by our mistakes,
24
- and learning from the experience
25
- * Focusing on what is best not just for us as individuals, but for the overall
26
- community
27
-
28
- Examples of unacceptable behavior include:
29
-
30
- * The use of sexualized language or imagery, and sexual attention or advances of
31
- any kind
32
- * Trolling, insulting or derogatory comments, and personal or political attacks
33
- * Public or private harassment
34
- * Publishing others' private information, such as a physical or email address,
35
- without their explicit permission
36
- * Other conduct which could reasonably be considered inappropriate in a
37
- professional setting
38
-
39
- ## Enforcement Responsibilities
40
-
41
- Community leaders are responsible for clarifying and enforcing our standards of
42
- acceptable behavior and will take appropriate and fair corrective action in
43
- response to any behavior that they deem inappropriate, threatening, offensive,
44
- or harmful.
45
-
46
- Community leaders have the right and responsibility to remove, edit, or reject
47
- comments, commits, code, wiki edits, issues, and other contributions that are
48
- not aligned to this Code of Conduct, and will communicate reasons for moderation
49
- decisions when appropriate.
50
-
51
- ## Scope
52
-
53
- This Code of Conduct applies within all community spaces, and also applies when
54
- an individual is officially representing the community in public spaces.
55
- Examples of representing our community include using an official email address,
56
- posting via an official social media account, or acting as an appointed
57
- representative at an online or offline event.
58
-
59
- ## Enforcement
60
-
61
- Instances of abusive, harassing, or otherwise unacceptable behavior may be
62
- reported to the community leaders responsible for enforcement at
63
- [INSERT CONTACT METHOD].
64
- All complaints will be reviewed and investigated promptly and fairly.
65
-
66
- All community leaders are obligated to respect the privacy and security of the
67
- reporter of any incident.
68
-
69
- ## Enforcement Guidelines
70
-
71
- Community leaders will follow these Community Impact Guidelines in determining
72
- the consequences for any action they deem in violation of this Code of Conduct:
73
-
74
- ### 1. Correction
75
-
76
- **Community Impact**: Use of inappropriate language or other behavior deemed
77
- unprofessional or unwelcome in the community.
78
-
79
- **Consequence**: A private, written warning from community leaders, providing
80
- clarity around the nature of the violation and an explanation of why the
81
- behavior was inappropriate. A public apology may be requested.
82
-
83
- ### 2. Warning
84
-
85
- **Community Impact**: A violation through a single incident or series of
86
- actions.
87
-
88
- **Consequence**: A warning with consequences for continued behavior. No
89
- interaction with the people involved, including unsolicited interaction with
90
- those enforcing the Code of Conduct, for a specified period of time. This
91
- includes avoiding interactions in community spaces as well as external channels
92
- like social media. Violating these terms may lead to a temporary or permanent
93
- ban.
94
-
95
- ### 3. Temporary Ban
96
-
97
- **Community Impact**: A serious violation of community standards, including
98
- sustained inappropriate behavior.
99
-
100
- **Consequence**: A temporary ban from any sort of interaction or public
101
- communication with the community for a specified period of time. No public or
102
- private interaction with the people involved, including unsolicited interaction
103
- with those enforcing the Code of Conduct, is allowed during this period.
104
- Violating these terms may lead to a permanent ban.
105
-
106
- ### 4. Permanent Ban
107
-
108
- **Community Impact**: Demonstrating a pattern of violation of community
109
- standards, including sustained inappropriate behavior, harassment of an
110
- individual, or aggression toward or disparagement of classes of individuals.
111
-
112
- **Consequence**: A permanent ban from any sort of public interaction within the
113
- community.
114
-
115
- ## Attribution
116
-
117
- This Code of Conduct is adapted from the [Contributor Covenant][homepage],
118
- version 2.1, available at
119
- [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1].
120
-
121
- Community Impact Guidelines were inspired by
122
- [Mozilla's code of conduct enforcement ladder][Mozilla CoC].
123
-
124
- For answers to common questions about this code of conduct, see the FAQ at
125
- [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at
126
- [https://www.contributor-covenant.org/translations][translations].
127
-
128
- [homepage]: https://www.contributor-covenant.org
129
- [v2.1]: https://www.contributor-covenant.org/version/2/1/code_of_conduct.html
130
- [Mozilla CoC]: https://github.com/mozilla/diversity
131
- [FAQ]: https://www.contributor-covenant.org/faq
132
- [translations]: https://www.contributor-covenant.org/translations
10
+ If you have any concerns about behaviour within this project, please contact us at [<%= config[:email].inspect %>](mailto:<%= config[:email].inspect %>).
@@ -6,6 +6,10 @@ jobs:
6
6
  <%- if config[:ext] == 'rust' -%>
7
7
  environment:
8
8
  RB_SYS_FORCE_INSTALL_RUST_TOOLCHAIN: 'true'
9
+ <%- end -%>
10
+ <%- if config[:ext] == 'go' -%>
11
+ environment:
12
+ GO_VERSION: '1.23.0'
9
13
  <%- end -%>
10
14
  steps:
11
15
  - checkout
@@ -16,6 +20,14 @@ jobs:
16
20
  - run:
17
21
  name: Install a RubyGems version that can compile rust extensions
18
22
  command: gem update --system '<%= ::Gem.rubygems_version %>'
23
+ <%- end -%>
24
+ <%- if config[:ext] == 'go' -%>
25
+ - run:
26
+ name: Install Go
27
+ command: |
28
+ wget https://go.dev/dl/go$GO_VERSION.linux-amd64.tar.gz -O /tmp/go.tar.gz
29
+ tar -C /usr/local -xzf /tmp/go.tar.gz
30
+ echo 'export PATH=/usr/local/go/bin:"$PATH"' >> "$BASH_ENV"
19
31
  <%- end -%>
20
32
  - run:
21
33
  name: Run the default task
@@ -12,4 +12,4 @@ publish = false
12
12
  crate-type = ["cdylib"]
13
13
 
14
14
  [dependencies]
15
- magnus = { version = "0.6.2" }
15
+ magnus = { version = "0.8.2" }
@@ -0,0 +1,11 @@
1
+ # frozen_string_literal: true
2
+
3
+ require "mkmf"
4
+ require "go_gem/mkmf"
5
+
6
+ # Makes all symbols private by default to avoid unintended conflict
7
+ # with other gems. To explicitly export symbols you can use RUBY_FUNC_EXPORTED
8
+ # selectively, or entirely remove this flag.
9
+ append_cflags("-fvisibility=hidden")
10
+
11
+ create_go_makefile(<%= config[:makefile_path].inspect %>)
@@ -0,0 +1,5 @@
1
+ module github.com/<%= config[:go_module_username] %>/<%= config[:underscored_name] %>
2
+
3
+ go 1.23
4
+
5
+ require github.com/ruby-go-gem/go-gem-wrapper latest
@@ -0,0 +1,2 @@
1
+ #include "<%= config[:underscored_name] %>.h"
2
+ #include "_cgo_export.h"
@@ -0,0 +1,31 @@
1
+ package main
2
+
3
+ /*
4
+ #include "<%= config[:underscored_name] %>.h"
5
+
6
+ VALUE rb_<%= config[:underscored_name] %>_sum(VALUE self, VALUE a, VALUE b);
7
+ */
8
+ import "C"
9
+
10
+ import (
11
+ "github.com/ruby-go-gem/go-gem-wrapper/ruby"
12
+ )
13
+
14
+ //export rb_<%= config[:underscored_name] %>_sum
15
+ func rb_<%= config[:underscored_name] %>_sum(_ C.VALUE, a C.VALUE, b C.VALUE) C.VALUE {
16
+ longA := ruby.NUM2LONG(ruby.VALUE(a))
17
+ longB := ruby.NUM2LONG(ruby.VALUE(b))
18
+
19
+ sum := longA + longB
20
+
21
+ return C.VALUE(ruby.LONG2NUM(sum))
22
+ }
23
+
24
+ //export Init_<%= config[:underscored_name] %>
25
+ func Init_<%= config[:underscored_name] %>() {
26
+ rb_m<%= config[:constant_array].join %> := ruby.RbDefineModule(<%= config[:constant_name].inspect %>)
27
+ ruby.RbDefineSingletonMethod(rb_m<%= config[:constant_array].join %>, "sum", C.rb_<%= config[:underscored_name] %>_sum, 2)
28
+ }
29
+
30
+ func main() {
31
+ }
@@ -34,6 +34,12 @@ jobs:
34
34
  with:
35
35
  ruby-version: ${{ matrix.ruby }}
36
36
  bundler-cache: true
37
+ <%- end -%>
38
+ <%- if config[:ext] == 'go' -%>
39
+ - name: Setup Go
40
+ uses: actions/setup-go@v5
41
+ with:
42
+ go-version-file: ext/<%= config[:underscored_name] %>/go.mod
37
43
  <%- end -%>
38
44
  - name: Run the default task
39
45
  run: bundle exec rake
@@ -5,6 +5,11 @@ default:
5
5
  <%- if config[:ext] == 'rust' -%>
6
6
  - apt-get update && apt-get install -y clang
7
7
  - gem update --system '<%= ::Gem.rubygems_version %>'
8
+ <%- end -%>
9
+ <%- if config[:ext] == 'go' -%>
10
+ - wget https://go.dev/dl/go$GO_VERSION.linux-amd64.tar.gz -O /tmp/go.tar.gz
11
+ - tar -C /usr/local -xzf /tmp/go.tar.gz
12
+ - export PATH=/usr/local/go/bin:$PATH
8
13
  <%- end -%>
9
14
  - gem install bundler -v <%= Bundler::VERSION %>
10
15
  - bundle install
@@ -13,6 +18,10 @@ example_job:
13
18
  <%- if config[:ext] == 'rust' -%>
14
19
  variables:
15
20
  RB_SYS_FORCE_INSTALL_RUST_TOOLCHAIN: 'true'
21
+ <%- end -%>
22
+ <%- if config[:ext] == 'go' -%>
23
+ variables:
24
+ GO_VERSION: '1.23.0'
16
25
  <%- end -%>
17
26
  script:
18
27
  - bundle exec rake
@@ -22,9 +22,9 @@ Gem::Specification.new do |spec|
22
22
  spec.metadata["allowed_push_host"] = "TODO: Set to your gem server 'https://example.com'"
23
23
  spec.metadata["homepage_uri"] = spec.homepage
24
24
  spec.metadata["source_code_uri"] = "<%= config[:source_code_uri] %>"
25
- <%- if config[:changelog] -%>
26
- spec.metadata["changelog_uri"] = "<%= config[:changelog_uri] %>"
27
- <%- end -%>
25
+ <%- if config[:changelog] -%>
26
+ spec.metadata["changelog_uri"] = "<%= config[:changelog_uri] %>"
27
+ <%- end -%>
28
28
 
29
29
  # Specify which files should be added to the gem when it is released.
30
30
  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -38,7 +38,7 @@ Gem::Specification.new do |spec|
38
38
  spec.bindir = "exe"
39
39
  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
40
40
  spec.require_paths = ["lib"]
41
- <%- if config[:ext] == 'c' || config[:ext] == 'rust' -%>
41
+ <%- if %w(c rust go).include?(config[:ext]) -%>
42
42
  spec.extensions = ["ext/<%= config[:underscored_name] %>/extconf.rb"]
43
43
  <%- end -%>
44
44
 
@@ -47,6 +47,9 @@ Gem::Specification.new do |spec|
47
47
  <%- if config[:ext] == 'rust' -%>
48
48
  spec.add_dependency "rb_sys", "~> 0.9.91"
49
49
  <%- end -%>
50
+ <%- if config[:ext] == 'go' -%>
51
+ spec.add_dependency "go_gem", "~> 0.2"
52
+ <%- end -%>
50
53
 
51
54
  # For more information and examples about making a new gem, check out our
52
55
  # guide at: https://bundler.io/guides/creating_gem.html
@@ -1,8 +1,8 @@
1
1
  ##
2
2
  # The TimedStack manages a pool of homogeneous connections (or any resource
3
- # you wish to manage). Connections are created lazily up to a given maximum
3
+ # you wish to manage). Connections are created lazily up to a given maximum
4
4
  # number.
5
-
5
+ #
6
6
  # Examples:
7
7
  #
8
8
  # ts = TimedStack.new(1) { MyConnection.new }
@@ -16,14 +16,12 @@
16
16
  # conn = ts.pop
17
17
  # ts.pop timeout: 5
18
18
  # #=> raises Bundler::ConnectionPool::TimeoutError after 5 seconds
19
-
20
19
  class Bundler::ConnectionPool::TimedStack
21
20
  attr_reader :max
22
21
 
23
22
  ##
24
23
  # Creates a new pool with +size+ connections that are created from the given
25
24
  # +block+.
26
-
27
25
  def initialize(size = 0, &block)
28
26
  @create_block = block
29
27
  @created = 0
@@ -35,9 +33,8 @@ class Bundler::ConnectionPool::TimedStack
35
33
  end
36
34
 
37
35
  ##
38
- # Returns +obj+ to the stack. +options+ is ignored in TimedStack but may be
36
+ # Returns +obj+ to the stack. +options+ is ignored in TimedStack but may be
39
37
  # used by subclasses that extend TimedStack.
40
-
41
38
  def push(obj, options = {})
42
39
  @mutex.synchronize do
43
40
  if @shutdown_block
@@ -53,14 +50,13 @@ class Bundler::ConnectionPool::TimedStack
53
50
  alias_method :<<, :push
54
51
 
55
52
  ##
56
- # Retrieves a connection from the stack. If a connection is available it is
57
- # immediately returned. If no connection is available within the given
53
+ # Retrieves a connection from the stack. If a connection is available it is
54
+ # immediately returned. If no connection is available within the given
58
55
  # timeout a Bundler::ConnectionPool::TimeoutError is raised.
59
56
  #
60
57
  # +:timeout+ is the only checked entry in +options+ and is preferred over
61
- # the +timeout+ argument (which will be removed in a future release). Other
58
+ # the +timeout+ argument (which will be removed in a future release). Other
62
59
  # options may be used by subclasses that extend TimedStack.
63
-
64
60
  def pop(timeout = 0.5, options = {})
65
61
  options, timeout = timeout, 0.5 if Hash === timeout
66
62
  timeout = options.fetch :timeout, timeout
@@ -69,7 +65,9 @@ class Bundler::ConnectionPool::TimedStack
69
65
  @mutex.synchronize do
70
66
  loop do
71
67
  raise Bundler::ConnectionPool::PoolShuttingDownError if @shutdown_block
72
- return fetch_connection(options) if connection_stored?(options)
68
+ if (conn = try_fetch_connection(options))
69
+ return conn
70
+ end
73
71
 
74
72
  connection = try_create(options)
75
73
  return connection if connection
@@ -86,7 +84,6 @@ class Bundler::ConnectionPool::TimedStack
86
84
  # removing it from the pool. Attempting to checkout a connection after
87
85
  # shutdown will raise +Bundler::ConnectionPool::PoolShuttingDownError+ unless
88
86
  # +:reload+ is +true+.
89
-
90
87
  def shutdown(reload: false, &block)
91
88
  raise ArgumentError, "shutdown must receive a block" unless block
92
89
 
@@ -121,14 +118,12 @@ class Bundler::ConnectionPool::TimedStack
121
118
 
122
119
  ##
123
120
  # Returns +true+ if there are no available connections.
124
-
125
121
  def empty?
126
122
  (@created - @que.length) >= @max
127
123
  end
128
124
 
129
125
  ##
130
126
  # The number of connections available on the stack.
131
-
132
127
  def length
133
128
  @max - @created + @que.length
134
129
  end
@@ -139,6 +134,12 @@ class Bundler::ConnectionPool::TimedStack
139
134
  @que.length
140
135
  end
141
136
 
137
+ ##
138
+ # Reduce the created count
139
+ def decrement_created
140
+ @created -= 1 unless @created == 0
141
+ end
142
+
142
143
  private
143
144
 
144
145
  def current_time
@@ -148,8 +149,17 @@ class Bundler::ConnectionPool::TimedStack
148
149
  ##
149
150
  # This is an extension point for TimedStack and is called with a mutex.
150
151
  #
151
- # This method must returns true if a connection is available on the stack.
152
+ # This method must returns a connection from the stack if one exists. Allows
153
+ # subclasses with expensive match/search algorithms to avoid double-handling
154
+ # their stack.
155
+ def try_fetch_connection(options = nil)
156
+ connection_stored?(options) && fetch_connection(options)
157
+ end
152
158
 
159
+ ##
160
+ # This is an extension point for TimedStack and is called with a mutex.
161
+ #
162
+ # This method must returns true if a connection is available on the stack.
153
163
  def connection_stored?(options = nil)
154
164
  !@que.empty?
155
165
  end
@@ -158,7 +168,6 @@ class Bundler::ConnectionPool::TimedStack
158
168
  # This is an extension point for TimedStack and is called with a mutex.
159
169
  #
160
170
  # This method must return a connection from the stack.
161
-
162
171
  def fetch_connection(options = nil)
163
172
  @que.pop&.first
164
173
  end
@@ -167,10 +176,8 @@ class Bundler::ConnectionPool::TimedStack
167
176
  # This is an extension point for TimedStack and is called with a mutex.
168
177
  #
169
178
  # This method must shut down all connections on the stack.
170
-
171
179
  def shutdown_connections(options = nil)
172
- while connection_stored?(options)
173
- conn = fetch_connection(options)
180
+ while (conn = try_fetch_connection(options))
174
181
  @created -= 1 unless @created == 0
175
182
  @shutdown_block.call(conn)
176
183
  end
@@ -181,7 +188,6 @@ class Bundler::ConnectionPool::TimedStack
181
188
  #
182
189
  # This method returns the oldest idle connection if it has been idle for more than idle_seconds.
183
190
  # This requires that the stack is kept in order of checked in time (oldest first).
184
-
185
191
  def reserve_idle_connection(idle_seconds)
186
192
  return unless idle_connections?(idle_seconds)
187
193
 
@@ -194,7 +200,6 @@ class Bundler::ConnectionPool::TimedStack
194
200
  # This is an extension point for TimedStack and is called with a mutex.
195
201
  #
196
202
  # Returns true if the first connection in the stack has been idle for more than idle_seconds
197
-
198
203
  def idle_connections?(idle_seconds)
199
204
  connection_stored? && (current_time - @que.first.last > idle_seconds)
200
205
  end
@@ -203,7 +208,6 @@ class Bundler::ConnectionPool::TimedStack
203
208
  # This is an extension point for TimedStack and is called with a mutex.
204
209
  #
205
210
  # This method must return +obj+ to the stack.
206
-
207
211
  def store_connection(obj, options = nil)
208
212
  @que.push [obj, current_time]
209
213
  end
@@ -213,7 +217,6 @@ class Bundler::ConnectionPool::TimedStack
213
217
  #
214
218
  # This method must create a connection if and only if the total number of
215
219
  # connections allowed has not been met.
216
-
217
220
  def try_create(options = nil)
218
221
  unless @created == @max
219
222
  object = @create_block.call
@@ -1,3 +1,3 @@
1
1
  class Bundler::ConnectionPool
2
- VERSION = "2.5.0"
2
+ VERSION = "2.5.4"
3
3
  end
@@ -39,7 +39,7 @@ end
39
39
  # - :auto_reload_after_fork - automatically drop all connections after fork, defaults to true
40
40
  #
41
41
  class Bundler::ConnectionPool
42
- DEFAULTS = {size: 5, timeout: 5, auto_reload_after_fork: true}
42
+ DEFAULTS = {size: 5, timeout: 5, auto_reload_after_fork: true}.freeze
43
43
 
44
44
  def self.wrap(options, &block)
45
45
  Wrapper.new(options, &block)
@@ -99,7 +99,8 @@ class Bundler::ConnectionPool
99
99
  @available = TimedStack.new(@size, &block)
100
100
  @key = :"pool-#{@available.object_id}"
101
101
  @key_count = :"pool-#{@available.object_id}-count"
102
- INSTANCES[self] = self if INSTANCES
102
+ @discard_key = :"pool-#{@available.object_id}-discard"
103
+ INSTANCES[self] = self if @auto_reload_after_fork && INSTANCES
103
104
  end
104
105
 
105
106
  def with(options = {})
@@ -116,20 +117,65 @@ class Bundler::ConnectionPool
116
117
  end
117
118
  alias_method :then, :with
118
119
 
120
+ ##
121
+ # Marks the current thread's checked-out connection for discard.
122
+ #
123
+ # When a connection is marked for discard, it will not be returned to the pool
124
+ # when checked in. Instead, the connection will be discarded.
125
+ # This is useful when a connection has become invalid or corrupted
126
+ # and should not be reused.
127
+ #
128
+ # Takes an optional block that will be called with the connection to be discarded.
129
+ # The block should perform any necessary clean-up on the connection.
130
+ #
131
+ # @yield [conn]
132
+ # @yieldparam conn [Object] The connection to be discarded.
133
+ # @yieldreturn [void]
134
+ #
135
+ #
136
+ # Note: This only affects the connection currently checked out by the calling thread.
137
+ # The connection will be discarded when +checkin+ is called.
138
+ #
139
+ # @return [void]
140
+ #
141
+ # @example
142
+ # pool.with do |conn|
143
+ # begin
144
+ # conn.execute("SELECT 1")
145
+ # rescue SomeConnectionError
146
+ # pool.discard_current_connection # Mark connection as bad
147
+ # raise
148
+ # end
149
+ # end
150
+ def discard_current_connection(&block)
151
+ ::Thread.current[@discard_key] = block || proc { |conn| conn }
152
+ end
153
+
119
154
  def checkout(options = {})
120
155
  if ::Thread.current[@key]
121
156
  ::Thread.current[@key_count] += 1
122
157
  ::Thread.current[@key]
123
158
  else
124
159
  ::Thread.current[@key_count] = 1
125
- ::Thread.current[@key] = @available.pop(options[:timeout] || @timeout)
160
+ ::Thread.current[@key] = @available.pop(options[:timeout] || @timeout, options)
126
161
  end
127
162
  end
128
163
 
129
164
  def checkin(force: false)
130
165
  if ::Thread.current[@key]
131
166
  if ::Thread.current[@key_count] == 1 || force
132
- @available.push(::Thread.current[@key])
167
+ if ::Thread.current[@discard_key]
168
+ begin
169
+ @available.decrement_created
170
+ ::Thread.current[@discard_key].call(::Thread.current[@key])
171
+ rescue
172
+ nil
173
+ ensure
174
+ ::Thread.current[@discard_key] = nil
175
+ end
176
+ else
177
+ @available.push(::Thread.current[@key])
178
+ end
133
179
  ::Thread.current[@key] = nil
134
180
  ::Thread.current[@key_count] = nil
135
181
  else
@@ -146,7 +192,6 @@ class Bundler::ConnectionPool
146
192
  # Shuts down the Bundler::ConnectionPool by passing each connection to +block+ and
147
193
  # then removing it from the pool. Attempting to checkout a connection after
148
194
  # shutdown will raise +Bundler::ConnectionPool::PoolShuttingDownError+.
149
-
150
195
  def shutdown(&block)
151
196
  @available.shutdown(&block)
152
197
  end
@@ -155,7 +200,6 @@ class Bundler::ConnectionPool
155
200
  # Reloads the Bundler::ConnectionPool by passing each connection to +block+ and then
156
201
  # removing it the pool. Subsequent checkouts will create new connections as
157
202
  # needed.
158
-
159
203
  def reload(&block)
160
204
  @available.shutdown(reload: true, &block)
161
205
  end