bundler 2.1.4 → 2.2.33

Sign up to get free protection for your applications and to get access to all the features.
Files changed (251) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +2017 -1430
  3. data/README.md +7 -9
  4. data/bundler.gemspec +5 -6
  5. data/exe/bundle +3 -0
  6. data/lib/bundler/build_metadata.rb +3 -11
  7. data/lib/bundler/cli/add.rb +1 -1
  8. data/lib/bundler/cli/binstubs.rb +6 -2
  9. data/lib/bundler/cli/cache.rb +3 -8
  10. data/lib/bundler/cli/check.rb +4 -2
  11. data/lib/bundler/cli/clean.rb +1 -1
  12. data/lib/bundler/cli/common.rb +29 -2
  13. data/lib/bundler/cli/console.rb +1 -1
  14. data/lib/bundler/cli/doctor.rb +16 -5
  15. data/lib/bundler/cli/exec.rb +5 -10
  16. data/lib/bundler/cli/fund.rb +36 -0
  17. data/lib/bundler/cli/gem.rb +209 -28
  18. data/lib/bundler/cli/info.rb +28 -5
  19. data/lib/bundler/cli/init.rb +2 -2
  20. data/lib/bundler/cli/inject.rb +1 -1
  21. data/lib/bundler/cli/install.rb +22 -34
  22. data/lib/bundler/cli/issue.rb +5 -4
  23. data/lib/bundler/cli/list.rb +19 -11
  24. data/lib/bundler/cli/lock.rb +5 -1
  25. data/lib/bundler/cli/open.rb +1 -2
  26. data/lib/bundler/cli/outdated.rb +95 -75
  27. data/lib/bundler/cli/plugin.rb +10 -0
  28. data/lib/bundler/cli/pristine.rb +5 -0
  29. data/lib/bundler/cli/remove.rb +1 -2
  30. data/lib/bundler/cli/show.rb +1 -1
  31. data/lib/bundler/cli/update.rb +14 -7
  32. data/lib/bundler/cli.rb +89 -66
  33. data/lib/bundler/compact_index_client/cache.rb +6 -14
  34. data/lib/bundler/compact_index_client/gem_parser.rb +28 -0
  35. data/lib/bundler/compact_index_client/updater.rb +13 -22
  36. data/lib/bundler/compact_index_client.rb +3 -3
  37. data/lib/bundler/current_ruby.rb +5 -4
  38. data/lib/bundler/definition.rb +193 -363
  39. data/lib/bundler/dep_proxy.rb +16 -9
  40. data/lib/bundler/dependency.rb +3 -10
  41. data/lib/bundler/digest.rb +71 -0
  42. data/lib/bundler/dsl.rb +71 -47
  43. data/lib/bundler/endpoint_specification.rb +1 -1
  44. data/lib/bundler/env.rb +1 -1
  45. data/lib/bundler/environment_preserver.rb +29 -2
  46. data/lib/bundler/errors.rb +20 -3
  47. data/lib/bundler/feature_flag.rb +0 -8
  48. data/lib/bundler/fetcher/base.rb +1 -1
  49. data/lib/bundler/fetcher/compact_index.rb +2 -2
  50. data/lib/bundler/fetcher/downloader.rb +10 -7
  51. data/lib/bundler/fetcher/index.rb +3 -5
  52. data/lib/bundler/fetcher.rb +7 -5
  53. data/lib/bundler/friendly_errors.rb +25 -43
  54. data/lib/bundler/gem_helper.rb +53 -31
  55. data/lib/bundler/gem_helpers.rb +36 -25
  56. data/lib/bundler/gem_version_promoter.rb +4 -4
  57. data/lib/bundler/graph.rb +1 -1
  58. data/lib/bundler/index.rb +9 -9
  59. data/lib/bundler/injector.rb +23 -5
  60. data/lib/bundler/inline.rb +3 -2
  61. data/lib/bundler/installer/gem_installer.rb +6 -19
  62. data/lib/bundler/installer/parallel_installer.rb +46 -25
  63. data/lib/bundler/installer/standalone.rb +30 -10
  64. data/lib/bundler/installer.rb +36 -56
  65. data/lib/bundler/lazy_specification.rb +62 -26
  66. data/lib/bundler/lockfile_generator.rb +1 -1
  67. data/lib/bundler/lockfile_parser.rb +8 -34
  68. data/lib/bundler/man/.document +1 -0
  69. data/{man → lib/bundler/man}/bundle-add.1 +1 -1
  70. data/{man/bundle-add.ronn → lib/bundler/man/bundle-add.1.ronn} +0 -0
  71. data/{man → lib/bundler/man}/bundle-binstubs.1 +5 -3
  72. data/{man/bundle-binstubs.ronn → lib/bundler/man/bundle-binstubs.1.ronn} +2 -4
  73. data/{man → lib/bundler/man}/bundle-cache.1 +1 -1
  74. data/{man/bundle-cache.ronn → lib/bundler/man/bundle-cache.1.ronn} +0 -0
  75. data/{man → lib/bundler/man}/bundle-check.1 +1 -1
  76. data/{man/bundle-check.ronn → lib/bundler/man/bundle-check.1.ronn} +0 -0
  77. data/{man → lib/bundler/man}/bundle-clean.1 +1 -1
  78. data/{man/bundle-clean.ronn → lib/bundler/man/bundle-clean.1.ronn} +0 -0
  79. data/{man → lib/bundler/man}/bundle-config.1 +40 -41
  80. data/{man/bundle-config.ronn → lib/bundler/man/bundle-config.1.ronn} +50 -53
  81. data/{man → lib/bundler/man}/bundle-doctor.1 +1 -1
  82. data/{man/bundle-doctor.ronn → lib/bundler/man/bundle-doctor.1.ronn} +0 -0
  83. data/{man → lib/bundler/man}/bundle-exec.1 +1 -1
  84. data/{man/bundle-exec.ronn → lib/bundler/man/bundle-exec.1.ronn} +0 -0
  85. data/{man → lib/bundler/man}/bundle-gem.1 +38 -3
  86. data/{man/bundle-gem.ronn → lib/bundler/man/bundle-gem.1.ronn} +46 -7
  87. data/{man → lib/bundler/man}/bundle-info.1 +1 -1
  88. data/{man/bundle-info.ronn → lib/bundler/man/bundle-info.1.ronn} +0 -0
  89. data/{man → lib/bundler/man}/bundle-init.1 +1 -1
  90. data/{man/bundle-init.ronn → lib/bundler/man/bundle-init.1.ronn} +0 -0
  91. data/{man → lib/bundler/man}/bundle-inject.1 +1 -1
  92. data/{man/bundle-inject.ronn → lib/bundler/man/bundle-inject.1.ronn} +0 -0
  93. data/{man → lib/bundler/man}/bundle-install.1 +30 -3
  94. data/{man/bundle-install.ronn → lib/bundler/man/bundle-install.1.ronn} +25 -3
  95. data/{man → lib/bundler/man}/bundle-list.1 +7 -7
  96. data/{man/bundle-list.ronn → lib/bundler/man/bundle-list.1.ronn} +6 -6
  97. data/{man → lib/bundler/man}/bundle-lock.1 +1 -1
  98. data/{man/bundle-lock.ronn → lib/bundler/man/bundle-lock.1.ronn} +0 -0
  99. data/{man → lib/bundler/man}/bundle-open.1 +1 -1
  100. data/{man/bundle-open.ronn → lib/bundler/man/bundle-open.1.ronn} +0 -0
  101. data/{man → lib/bundler/man}/bundle-outdated.1 +1 -1
  102. data/{man/bundle-outdated.ronn → lib/bundler/man/bundle-outdated.1.ronn} +0 -0
  103. data/{man → lib/bundler/man}/bundle-platform.1 +1 -1
  104. data/{man/bundle-platform.ronn → lib/bundler/man/bundle-platform.1.ronn} +0 -0
  105. data/{man → lib/bundler/man}/bundle-pristine.1 +1 -1
  106. data/{man/bundle-pristine.ronn → lib/bundler/man/bundle-pristine.1.ronn} +0 -0
  107. data/{man → lib/bundler/man}/bundle-remove.1 +1 -1
  108. data/{man/bundle-remove.ronn → lib/bundler/man/bundle-remove.1.ronn} +0 -0
  109. data/{man → lib/bundler/man}/bundle-show.1 +1 -1
  110. data/{man/bundle-show.ronn → lib/bundler/man/bundle-show.1.ronn} +0 -0
  111. data/{man → lib/bundler/man}/bundle-update.1 +4 -4
  112. data/{man/bundle-update.ronn → lib/bundler/man/bundle-update.1.ronn} +3 -3
  113. data/{man → lib/bundler/man}/bundle-viz.1 +1 -1
  114. data/{man/bundle-viz.ronn → lib/bundler/man/bundle-viz.1.ronn} +0 -0
  115. data/{man → lib/bundler/man}/bundle.1 +1 -1
  116. data/{man/bundle.ronn → lib/bundler/man/bundle.1.ronn} +0 -0
  117. data/{man → lib/bundler/man}/gemfile.5 +30 -4
  118. data/{man → lib/bundler/man}/gemfile.5.ronn +12 -4
  119. data/{man → lib/bundler/man}/index.txt +0 -0
  120. data/lib/bundler/mirror.rb +2 -2
  121. data/lib/bundler/plugin/api/source.rb +23 -1
  122. data/lib/bundler/plugin/dsl.rb +1 -1
  123. data/lib/bundler/plugin/index.rb +13 -1
  124. data/lib/bundler/plugin/installer/rubygems.rb +1 -1
  125. data/lib/bundler/plugin/installer.rb +11 -11
  126. data/lib/bundler/plugin/source_list.rb +5 -1
  127. data/lib/bundler/plugin.rb +56 -11
  128. data/lib/bundler/psyched_yaml.rb +0 -15
  129. data/lib/bundler/remote_specification.rb +5 -2
  130. data/lib/bundler/resolver/spec_group.rb +56 -53
  131. data/lib/bundler/resolver.rb +94 -128
  132. data/lib/bundler/retry.rb +2 -2
  133. data/lib/bundler/ruby_version.rb +1 -1
  134. data/lib/bundler/rubygems_ext.rb +96 -16
  135. data/lib/bundler/rubygems_gem_installer.rb +69 -8
  136. data/lib/bundler/rubygems_integration.rb +57 -72
  137. data/lib/bundler/runtime.rb +22 -25
  138. data/lib/bundler/settings.rb +142 -64
  139. data/lib/bundler/setup.rb +2 -2
  140. data/lib/bundler/shared_helpers.rb +5 -13
  141. data/lib/bundler/similarity_detector.rb +1 -1
  142. data/lib/bundler/source/git/git_proxy.rb +88 -84
  143. data/lib/bundler/source/git.rb +43 -23
  144. data/lib/bundler/source/metadata.rb +0 -4
  145. data/lib/bundler/source/path/installer.rb +10 -10
  146. data/lib/bundler/source/path.rb +10 -4
  147. data/lib/bundler/source/rubygems/remote.rb +1 -1
  148. data/lib/bundler/source/rubygems.rb +126 -116
  149. data/lib/bundler/source/rubygems_aggregate.rb +68 -0
  150. data/lib/bundler/source.rb +22 -1
  151. data/lib/bundler/source_list.rb +101 -63
  152. data/lib/bundler/source_map.rb +58 -0
  153. data/lib/bundler/spec_set.rb +26 -41
  154. data/lib/bundler/stub_specification.rb +25 -7
  155. data/lib/bundler/templates/Executable.bundler +6 -6
  156. data/lib/bundler/templates/Gemfile +1 -1
  157. data/lib/bundler/templates/gems.rb +1 -1
  158. data/lib/bundler/templates/newgem/CHANGELOG.md.tt +5 -0
  159. data/lib/bundler/templates/newgem/CODE_OF_CONDUCT.md.tt +57 -47
  160. data/lib/bundler/templates/newgem/Gemfile.tt +12 -1
  161. data/lib/bundler/templates/newgem/README.md.tt +6 -5
  162. data/lib/bundler/templates/newgem/Rakefile.tt +23 -5
  163. data/lib/bundler/templates/newgem/bin/console.tt +1 -0
  164. data/lib/bundler/templates/newgem/circleci/config.yml.tt +13 -0
  165. data/lib/bundler/templates/newgem/ext/newgem/extconf.rb.tt +2 -0
  166. data/lib/bundler/templates/newgem/github/workflows/main.yml.tt +27 -0
  167. data/lib/bundler/templates/newgem/gitlab-ci.yml.tt +9 -0
  168. data/lib/bundler/templates/newgem/lib/newgem/version.rb.tt +2 -0
  169. data/lib/bundler/templates/newgem/lib/newgem.rb.tt +4 -2
  170. data/lib/bundler/templates/newgem/newgem.gemspec.tt +27 -17
  171. data/lib/bundler/templates/newgem/rubocop.yml.tt +13 -0
  172. data/lib/bundler/templates/newgem/sig/newgem.rbs.tt +8 -0
  173. data/lib/bundler/templates/newgem/spec/newgem_spec.rb.tt +2 -0
  174. data/lib/bundler/templates/newgem/spec/spec_helper.rb.tt +2 -1
  175. data/lib/bundler/templates/newgem/standard.yml.tt +2 -0
  176. data/lib/bundler/templates/newgem/test/{newgem_test.rb.tt → minitest/newgem_test.rb.tt} +2 -0
  177. data/lib/bundler/templates/newgem/test/{test_helper.rb.tt → minitest/test_helper.rb.tt} +2 -0
  178. data/lib/bundler/templates/newgem/test/test-unit/newgem_test.rb.tt +15 -0
  179. data/lib/bundler/templates/newgem/test/test-unit/test_helper.rb.tt +6 -0
  180. data/lib/bundler/ui/shell.rb +5 -5
  181. data/lib/bundler/uri_credentials_filter.rb +3 -1
  182. data/lib/bundler/vendor/.document +1 -0
  183. data/lib/bundler/vendor/connection_pool/LICENSE +20 -0
  184. data/lib/bundler/vendor/connection_pool/lib/connection_pool/timed_stack.rb +19 -21
  185. data/lib/bundler/vendor/connection_pool/lib/connection_pool/version.rb +1 -1
  186. data/lib/bundler/vendor/connection_pool/lib/connection_pool/wrapper.rb +57 -0
  187. data/lib/bundler/vendor/connection_pool/lib/connection_pool.rb +39 -74
  188. data/lib/bundler/vendor/fileutils/LICENSE.txt +22 -0
  189. data/lib/bundler/vendor/molinillo/LICENSE +9 -0
  190. data/lib/bundler/vendor/molinillo/lib/molinillo/delegates/specification_provider.rb +7 -0
  191. data/lib/bundler/vendor/molinillo/lib/molinillo/dependency_graph/tag.rb +2 -2
  192. data/lib/bundler/vendor/molinillo/lib/molinillo/dependency_graph/vertex.rb +11 -5
  193. data/lib/bundler/vendor/molinillo/lib/molinillo/dependency_graph.rb +36 -4
  194. data/lib/bundler/vendor/molinillo/lib/molinillo/errors.rb +3 -3
  195. data/lib/bundler/vendor/molinillo/lib/molinillo/gem_metadata.rb +1 -1
  196. data/lib/bundler/vendor/molinillo/lib/molinillo/modules/specification_provider.rb +12 -1
  197. data/lib/bundler/vendor/molinillo/lib/molinillo/resolution.rb +49 -47
  198. data/lib/bundler/vendor/molinillo/lib/molinillo.rb +0 -1
  199. data/lib/bundler/vendor/net-http-persistent/README.rdoc +82 -0
  200. data/lib/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb +82 -189
  201. data/lib/bundler/vendor/thor/LICENSE.md +20 -0
  202. data/lib/bundler/vendor/thor/lib/thor/actions/create_link.rb +2 -1
  203. data/lib/bundler/vendor/thor/lib/thor/actions/file_manipulation.rb +4 -2
  204. data/lib/bundler/vendor/thor/lib/thor/actions.rb +1 -1
  205. data/lib/bundler/vendor/thor/lib/thor/base.rb +9 -0
  206. data/lib/bundler/vendor/thor/lib/thor/error.rb +1 -1
  207. data/lib/bundler/vendor/thor/lib/thor/parser/arguments.rb +5 -1
  208. data/lib/bundler/vendor/thor/lib/thor/parser/options.rb +9 -8
  209. data/lib/bundler/vendor/thor/lib/thor/shell/basic.rb +5 -2
  210. data/lib/bundler/vendor/thor/lib/thor/shell/color.rb +5 -1
  211. data/lib/bundler/vendor/thor/lib/thor/version.rb +1 -1
  212. data/lib/bundler/vendor/thor/lib/thor.rb +5 -13
  213. data/lib/bundler/vendor/tmpdir/lib/tmpdir.rb +154 -0
  214. data/lib/bundler/vendor/tsort/LICENSE.txt +22 -0
  215. data/lib/bundler/vendor/tsort/lib/tsort.rb +453 -0
  216. data/lib/bundler/vendor/uri/LICENSE.txt +22 -0
  217. data/lib/bundler/vendored_persistent.rb +0 -7
  218. data/lib/bundler/vendored_tmpdir.rb +4 -0
  219. data/lib/bundler/vendored_tsort.rb +4 -0
  220. data/lib/bundler/version.rb +1 -1
  221. data/lib/bundler/worker.rb +20 -5
  222. data/lib/bundler/yaml_serializer.rb +1 -1
  223. data/lib/bundler.rb +52 -37
  224. metadata +90 -89
  225. data/lib/bundler/vendor/connection_pool/lib/connection_pool/monotonic_time.rb +0 -66
  226. data/lib/bundler/vendor/molinillo/lib/molinillo/compatibility.rb +0 -26
  227. data/man/bundle-add.1.txt +0 -58
  228. data/man/bundle-binstubs.1.txt +0 -48
  229. data/man/bundle-cache.1.txt +0 -78
  230. data/man/bundle-check.1.txt +0 -33
  231. data/man/bundle-clean.1.txt +0 -26
  232. data/man/bundle-config.1.txt +0 -528
  233. data/man/bundle-doctor.1.txt +0 -44
  234. data/man/bundle-exec.1.txt +0 -178
  235. data/man/bundle-gem.1.txt +0 -91
  236. data/man/bundle-info.1.txt +0 -21
  237. data/man/bundle-init.1.txt +0 -34
  238. data/man/bundle-inject.1.txt +0 -32
  239. data/man/bundle-install.1.txt +0 -401
  240. data/man/bundle-list.1.txt +0 -43
  241. data/man/bundle-lock.1.txt +0 -93
  242. data/man/bundle-open.1.txt +0 -29
  243. data/man/bundle-outdated.1.txt +0 -131
  244. data/man/bundle-platform.1.txt +0 -57
  245. data/man/bundle-pristine.1.txt +0 -44
  246. data/man/bundle-remove.1.txt +0 -34
  247. data/man/bundle-show.1.txt +0 -27
  248. data/man/bundle-update.1.txt +0 -390
  249. data/man/bundle-viz.1.txt +0 -39
  250. data/man/bundle.1.txt +0 -116
  251. data/man/gemfile.5.txt +0 -649
@@ -5,6 +5,8 @@ module Bundler
5
5
  require_relative "vendored_molinillo"
6
6
  require_relative "resolver/spec_group"
7
7
 
8
+ include GemHelpers
9
+
8
10
  # Figures out the best possible configuration of gems that satisfies
9
11
  # the list of passed dependencies and any child dependencies without
10
12
  # causing any gem activation errors.
@@ -15,16 +17,14 @@ module Bundler
15
17
  # ==== Returns
16
18
  # <GemBundle>,nil:: If the list of dependencies can be resolved, a
17
19
  # collection of gemspecs is returned. Otherwise, nil is returned.
18
- def self.resolve(requirements, index, source_requirements = {}, base = [], gem_version_promoter = GemVersionPromoter.new, additional_base_requirements = [], platforms = nil)
19
- platforms = Set.new(platforms) if platforms
20
+ def self.resolve(requirements, source_requirements = {}, base = [], gem_version_promoter = GemVersionPromoter.new, additional_base_requirements = [], platforms = nil)
20
21
  base = SpecSet.new(base) unless base.is_a?(SpecSet)
21
- resolver = new(index, source_requirements, base, gem_version_promoter, additional_base_requirements, platforms)
22
+ resolver = new(source_requirements, base, gem_version_promoter, additional_base_requirements, platforms)
22
23
  result = resolver.start(requirements)
23
- SpecSet.new(result)
24
+ SpecSet.new(SpecSet.new(result).for(requirements.reject{|dep| dep.name.end_with?("\0") }))
24
25
  end
25
26
 
26
- def initialize(index, source_requirements, base, gem_version_promoter, additional_base_requirements, platforms)
27
- @index = index
27
+ def initialize(source_requirements, base, gem_version_promoter, additional_base_requirements, platforms)
28
28
  @source_requirements = source_requirements
29
29
  @base = base
30
30
  @resolver = Molinillo::Resolver.new(self, self)
@@ -32,14 +32,13 @@ module Bundler
32
32
  @base_dg = Molinillo::DependencyGraph.new
33
33
  @base.each do |ls|
34
34
  dep = Dependency.new(ls.name, ls.version)
35
- @base_dg.add_vertex(ls.name, DepProxy.new(dep, ls.platform), true)
35
+ @base_dg.add_vertex(ls.name, DepProxy.get_proxy(dep, ls.platform), true)
36
36
  end
37
37
  additional_base_requirements.each {|d| @base_dg.add_vertex(d.name, d) }
38
- @platforms = platforms
38
+ @platforms = platforms.reject {|p| p != Gem::Platform::RUBY && (platforms - [p]).any? {|pl| generic(pl) == p } }
39
+ @resolving_only_for_ruby = platforms == [Gem::Platform::RUBY]
39
40
  @gem_version_promoter = gem_version_promoter
40
- @allow_bundler_dependency_conflicts = Bundler.feature_flag.allow_bundler_dependency_conflicts?
41
41
  @use_gvp = Bundler.feature_flag.use_gem_version_promoter_for_major_updates? || !@gem_version_promoter.major?
42
- @lockfile_uses_separate_rubygems_sources = Bundler.feature_flag.disable_multisource?
43
42
  end
44
43
 
45
44
  def start(requirements)
@@ -49,7 +48,6 @@ module Bundler
49
48
  verify_gemfile_dependencies_are_found!(requirements)
50
49
  dg = @resolver.resolve(requirements, @base_dg)
51
50
  dg.
52
- tap {|resolved| validate_resolved_specs!(resolved) }.
53
51
  map(&:payload).
54
52
  reject {|sg| sg.name.end_with?("\0") }.
55
53
  map(&:to_specs).
@@ -75,12 +73,17 @@ module Bundler
75
73
  return unless debug?
76
74
  debug_info = yield
77
75
  debug_info = debug_info.inspect unless debug_info.is_a?(String)
78
- warn debug_info.split("\n").map {|s| " " * depth + s }
76
+ puts debug_info.split("\n").map {|s| depth == 0 ? "BUNDLER: #{s}" : "BUNDLER(#{depth}): #{s}" }
79
77
  end
80
78
 
81
79
  def debug?
82
80
  return @debug_mode if defined?(@debug_mode)
83
- @debug_mode = ENV["DEBUG_RESOLVER"] || ENV["DEBUG_RESOLVER_TREE"] || false
81
+ @debug_mode =
82
+ ENV["BUNDLER_DEBUG_RESOLVER"] ||
83
+ ENV["BUNDLER_DEBUG_RESOLVER_TREE"] ||
84
+ ENV["DEBUG_RESOLVER"] ||
85
+ ENV["DEBUG_RESOLVER_TREE"] ||
86
+ false
84
87
  end
85
88
 
86
89
  def before_resolution
@@ -101,18 +104,18 @@ module Bundler
101
104
  specification.dependencies_for_activated_platforms
102
105
  end
103
106
 
104
- def search_for(dependency)
105
- platform = dependency.__platform
106
- dependency = dependency.dep unless dependency.is_a? Gem::Dependency
107
- search = @search_for[dependency] ||= begin
108
- index = index_for(dependency)
109
- results = index.search(dependency, @base[dependency.name])
107
+ def search_for(dependency_proxy)
108
+ platform = dependency_proxy.__platform
109
+ dependency = dependency_proxy.dep
110
+ name = dependency.name
111
+ @search_for[dependency_proxy] ||= begin
112
+ results = results_for(dependency, @base[name])
110
113
 
111
- if vertex = @base_dg.vertex_named(dependency.name)
114
+ if vertex = @base_dg.vertex_named(name)
112
115
  locked_requirement = vertex.payload.requirement
113
116
  end
114
117
 
115
- if !@prerelease_specified[dependency.name] && (!@use_gvp || locked_requirement.nil?)
118
+ if !@prerelease_specified[name] && (!@use_gvp || locked_requirement.nil?)
116
119
  # Move prereleases to the beginning of the list, so they're considered
117
120
  # last during resolution.
118
121
  pre, results = results.partition {|spec| spec.version.prerelease? }
@@ -131,9 +134,20 @@ module Bundler
131
134
  end
132
135
  nested.reduce([]) do |groups, (version, specs)|
133
136
  next groups if locked_requirement && !locked_requirement.satisfied_by?(version)
134
- spec_group = SpecGroup.new(specs)
135
- spec_group.ignores_bundler_dependencies = @allow_bundler_dependency_conflicts
136
- groups << spec_group
137
+
138
+ specs_by_platform = Hash.new do |current_specs, current_platform|
139
+ current_specs[current_platform] = select_best_platform_match(specs, current_platform)
140
+ end
141
+
142
+ spec_group_ruby = SpecGroup.create_for(specs_by_platform, [Gem::Platform::RUBY], Gem::Platform::RUBY)
143
+ groups << spec_group_ruby if spec_group_ruby
144
+
145
+ next groups if @resolving_only_for_ruby
146
+
147
+ spec_group = SpecGroup.create_for(specs_by_platform, @platforms, platform)
148
+ groups << spec_group if spec_group
149
+
150
+ groups
137
151
  end
138
152
  else
139
153
  []
@@ -146,24 +160,18 @@ module Bundler
146
160
  @gem_version_promoter.sort_versions(dependency, spec_groups)
147
161
  end
148
162
  end
149
- search.select {|sg| sg.for?(platform) }.each {|sg| sg.activate_platform!(platform) }
150
163
  end
151
164
 
152
165
  def index_for(dependency)
153
- source = @source_requirements[dependency.name]
154
- if source
155
- source.specs
156
- elsif @lockfile_uses_separate_rubygems_sources
157
- Index.build do |idx|
158
- if dependency.all_sources
159
- dependency.all_sources.each {|s| idx.add_source(s.specs) if s }
160
- else
161
- idx.add_source @source_requirements[:default].specs
162
- end
163
- end
164
- else
165
- @index
166
- end
166
+ source_for(dependency.name).specs
167
+ end
168
+
169
+ def source_for(name)
170
+ @source_requirements[name] || @source_requirements[:default]
171
+ end
172
+
173
+ def results_for(dependency, base)
174
+ index_for(dependency).search(dependency, base)
167
175
  end
168
176
 
169
177
  def name_for(dependency)
@@ -183,24 +191,15 @@ module Bundler
183
191
  end
184
192
 
185
193
  def requirement_satisfied_by?(requirement, activated, spec)
186
- return false unless requirement.matches_spec?(spec) || spec.source.is_a?(Source::Gemspec)
187
- spec.activate_platform!(requirement.__platform) if !@platforms || @platforms.include?(requirement.__platform)
188
- true
194
+ requirement.matches_spec?(spec) || spec.source.is_a?(Source::Gemspec)
189
195
  end
190
196
 
191
- def relevant_sources_for_vertex(vertex)
192
- if vertex.root?
193
- [@source_requirements[vertex.name]]
194
- elsif @lockfile_uses_separate_rubygems_sources
195
- vertex.recursive_predecessors.map do |v|
196
- @source_requirements[v.name]
197
- end << @source_requirements[:default]
198
- end
197
+ def dependencies_equal?(dependencies, other_dependencies)
198
+ dependencies.map(&:dep) == other_dependencies.map(&:dep)
199
199
  end
200
200
 
201
201
  def sort_dependencies(dependencies, activated, conflicts)
202
202
  dependencies.sort_by do |dependency|
203
- dependency.all_sources = relevant_sources_for_vertex(activated.vertex_named(dependency.name))
204
203
  name = name_for(dependency)
205
204
  vertex = activated.vertex_named(name)
206
205
  [
@@ -215,19 +214,13 @@ module Bundler
215
214
  end
216
215
  end
217
216
 
218
- # Sort platforms from most general to most specific
219
- def self.sort_platforms(platforms)
220
- platforms.sort_by do |platform|
221
- platform_sort_key(platform)
222
- end
223
- end
224
-
225
217
  def self.platform_sort_key(platform)
226
- return ["", "", ""] if Gem::Platform::RUBY == platform
227
- platform.to_a.map {|part| part || "" }
218
+ # Prefer specific platform to not specific platform
219
+ return ["99-LAST", "", "", ""] if Gem::Platform::RUBY == platform
220
+ ["00", *platform.to_a.map {|part| part || "" }]
228
221
  end
229
222
 
230
- private
223
+ private
231
224
 
232
225
  # returns an integer \in (-\infty, 0]
233
226
  # a number closer to 0 means the dependency is less constraining
@@ -260,12 +253,6 @@ module Bundler
260
253
  next if name == "bundler"
261
254
  next unless search_for(requirement).empty?
262
255
 
263
- cache_message = begin
264
- " or in gems cached in #{Bundler.settings.app_cache_path}" if Bundler.app_cache.exist?
265
- rescue GemfileNotFound
266
- nil
267
- end
268
-
269
256
  if (base = @base[name]) && !base.empty?
270
257
  version = base.first.version
271
258
  message = "You have requested:\n" \
@@ -274,18 +261,17 @@ module Bundler
274
261
  "Try running `bundle update #{name}`\n\n" \
275
262
  "If you are updating multiple gems in your Gemfile at once,\n" \
276
263
  "try passing them all to `bundle update`"
277
- elsif source = @source_requirements[name]
278
- specs = source.specs[name]
264
+ else
265
+ source = source_for(name)
266
+ specs = source.specs.search(name)
279
267
  versions_with_platforms = specs.map {|s| [s.version, s.platform] }
268
+ cache_message = begin
269
+ " or in gems cached in #{Bundler.settings.app_cache_path}" if Bundler.app_cache.exist?
270
+ rescue GemfileNotFound
271
+ nil
272
+ end
280
273
  message = String.new("Could not find gem '#{SharedHelpers.pretty_dependency(requirement)}' in #{source}#{cache_message}.\n")
281
- message << if versions_with_platforms.any?
282
- "The source contains '#{name}' at: #{formatted_versions_with_platforms(versions_with_platforms)}"
283
- else
284
- "The source does not contain any versions of '#{name}'"
285
- end
286
- else
287
- message = "Could not find gem '#{requirement}' in any of the gem sources " \
288
- "listed in your Gemfile#{cache_message}."
274
+ message << "The source contains the following versions of '#{name}': #{formatted_versions_with_platforms(versions_with_platforms)}" if versions_with_platforms.any?
289
275
  end
290
276
  raise GemNotFound, message
291
277
  end
@@ -305,10 +291,16 @@ module Bundler
305
291
  def version_conflict_message(e)
306
292
  # only show essential conflicts, if possible
307
293
  conflicts = e.conflicts.dup
308
- conflicts.delete_if do |_name, conflict|
309
- deps = conflict.requirement_trees.map(&:last).flatten(1)
310
- !Bundler::VersionRanges.empty?(*Bundler::VersionRanges.for_many(deps.map(&:requirement)))
294
+
295
+ if conflicts["bundler"]
296
+ conflicts.replace("bundler" => conflicts["bundler"])
297
+ else
298
+ conflicts.delete_if do |_name, conflict|
299
+ deps = conflict.requirement_trees.map(&:last).flatten(1)
300
+ !Bundler::VersionRanges.empty?(*Bundler::VersionRanges.for_many(deps.map(&:requirement)))
301
+ end
311
302
  end
303
+
312
304
  e = Molinillo::VersionConflict.new(conflicts, e.specification_provider) unless conflicts.empty?
313
305
 
314
306
  solver_name = "Bundler"
@@ -336,32 +328,32 @@ module Bundler
336
328
  :additional_message_for_conflict => lambda do |o, name, conflict|
337
329
  if name == "bundler"
338
330
  o << %(\n Current Bundler version:\n bundler (#{Bundler::VERSION}))
339
- other_bundler_required = !conflict.requirement.requirement.satisfied_by?(Gem::Version.new(Bundler::VERSION))
340
- end
341
331
 
342
- if name == "bundler" && other_bundler_required
343
- o << "\n"
344
- o << "This Gemfile requires a different version of Bundler.\n"
345
- o << "Perhaps you need to update Bundler by running `gem install bundler`?\n"
346
- end
347
- if conflict.locked_requirement
332
+ conflict_dependency = conflict.requirement
333
+ conflict_requirement = conflict_dependency.requirement
334
+ other_bundler_required = !conflict_requirement.satisfied_by?(Gem::Version.new(Bundler::VERSION))
335
+
336
+ if other_bundler_required
337
+ o << "\n\n"
338
+
339
+ candidate_specs = source_for(:default_bundler).specs.search(conflict_dependency)
340
+ if candidate_specs.any?
341
+ target_version = candidate_specs.last.version
342
+ new_command = [File.basename($PROGRAM_NAME), "_#{target_version}_", *ARGV].join(" ")
343
+ o << "Your bundle requires a different version of Bundler than the one you're running.\n"
344
+ o << "Install the necessary version with `gem install bundler:#{target_version}` and rerun bundler using `#{new_command}`\n"
345
+ else
346
+ o << "Your bundle requires a different version of Bundler than the one you're running, and that version could not be found.\n"
347
+ end
348
+ end
349
+ elsif conflict.locked_requirement
348
350
  o << "\n"
349
351
  o << %(Running `bundle update` will rebuild your snapshot from scratch, using only\n)
350
352
  o << %(the gems in your Gemfile, which may resolve the conflict.\n)
351
353
  elsif !conflict.existing
352
354
  o << "\n"
353
355
 
354
- relevant_sources = if conflict.requirement.source
355
- [conflict.requirement.source]
356
- elsif conflict.requirement.all_sources
357
- conflict.requirement.all_sources
358
- elsif @lockfile_uses_separate_rubygems_sources
359
- # every conflict should have an explicit group of sources when we
360
- # enforce strict pinning
361
- raise "no source set for #{conflict}"
362
- else
363
- []
364
- end.compact.map(&:to_s).uniq.sort
356
+ relevant_source = conflict.requirement.source || source_for(name)
365
357
 
366
358
  metadata_requirement = name.end_with?("\0")
367
359
 
@@ -374,12 +366,10 @@ module Bundler
374
366
  end
375
367
  o << " "
376
368
 
377
- o << if relevant_sources.empty?
378
- "in any of the sources.\n"
379
- elsif metadata_requirement
380
- "is not available in #{relevant_sources.join(" or ")}"
369
+ o << if metadata_requirement
370
+ "is not available in #{relevant_source}"
381
371
  else
382
- "in any of the relevant sources:\n #{relevant_sources * "\n "}\n"
372
+ "in #{relevant_source}.\n"
383
373
  end
384
374
  end
385
375
  end,
@@ -393,29 +383,5 @@ module Bundler
393
383
  end
394
384
  )
395
385
  end
396
-
397
- def validate_resolved_specs!(resolved_specs)
398
- resolved_specs.each do |v|
399
- name = v.name
400
- next unless sources = relevant_sources_for_vertex(v)
401
- sources.compact!
402
- if default_index = sources.index(@source_requirements[:default])
403
- sources.delete_at(default_index)
404
- end
405
- sources.reject! {|s| s.specs[name].empty? }
406
- sources.uniq!
407
- next if sources.size <= 1
408
-
409
- multisource_disabled = Bundler.feature_flag.disable_multisource?
410
-
411
- msg = ["The gem '#{name}' was found in multiple relevant sources."]
412
- msg.concat sources.map {|s| " * #{s}" }.sort
413
- msg << "You #{multisource_disabled ? :must : :should} add this gem to the source block for the source you wish it to be installed from."
414
- msg = msg.join("\n")
415
-
416
- raise SecurityError, msg if multisource_disabled
417
- Bundler.ui.warn "Warning: #{msg}"
418
- end
419
- end
420
386
  end
421
387
  end
data/lib/bundler/retry.rb CHANGED
@@ -32,7 +32,7 @@ module Bundler
32
32
  end
33
33
  alias_method :attempts, :attempt
34
34
 
35
- private
35
+ private
36
36
 
37
37
  def run(&block)
38
38
  @failed = false
@@ -49,7 +49,7 @@ module Bundler
49
49
  raise e
50
50
  end
51
51
  return true unless name
52
- Bundler.ui.info "" unless Bundler.ui.debug? # Add new line incase dots preceded this
52
+ Bundler.ui.info "" unless Bundler.ui.debug? # Add new line in case dots preceded this
53
53
  Bundler.ui.warn "Retrying #{name} due to error (#{current_run.next}/#{total_runs}): #{e.class} #{e.message}", Bundler.ui.debug?
54
54
  end
55
55
 
@@ -123,7 +123,7 @@ module Bundler
123
123
  @exact = versions.all? {|v| Gem::Requirement.create(v).exact? }
124
124
  end
125
125
 
126
- private
126
+ private
127
127
 
128
128
  def matches?(requirements, version)
129
129
  # Handles RUBY_PATCHLEVEL of -1 for instances like ruby-head
@@ -47,14 +47,13 @@ module Gem
47
47
  full_require_paths
48
48
  end
49
49
 
50
- if method_defined?(:extension_dir)
51
- alias_method :rg_extension_dir, :extension_dir
52
- def extension_dir
53
- @bundler_extension_dir ||= if source.respond_to?(:extension_dir_name)
54
- File.expand_path(File.join(extensions_dir, source.extension_dir_name))
55
- else
56
- rg_extension_dir
57
- end
50
+ alias_method :rg_extension_dir, :extension_dir
51
+ def extension_dir
52
+ @bundler_extension_dir ||= if source.respond_to?(:extension_dir_name)
53
+ unique_extension_dir = [source.extension_dir_name, File.basename(full_gem_path)].uniq.join("-")
54
+ File.expand_path(File.join(extensions_dir, unique_extension_dir))
55
+ else
56
+ rg_extension_dir
58
57
  end
59
58
  end
60
59
 
@@ -86,7 +85,11 @@ module Gem
86
85
  dependencies - development_dependencies
87
86
  end
88
87
 
89
- private
88
+ def deleted_gem?
89
+ !default_gem? && !File.directory?(full_gem_path)
90
+ end
91
+
92
+ private
90
93
 
91
94
  def dependencies_to_gemfile(dependencies, group = nil)
92
95
  gemfile = String.new
@@ -106,7 +109,7 @@ module Gem
106
109
  end
107
110
 
108
111
  class Dependency
109
- attr_accessor :source, :groups, :all_sources
112
+ attr_accessor :source, :groups
110
113
 
111
114
  alias_method :eql?, :==
112
115
 
@@ -117,7 +120,7 @@ module Gem
117
120
  end
118
121
 
119
122
  def to_yaml_properties
120
- instance_variables.reject {|p| ["@source", "@groups", "@all_sources"].include?(p.to_s) }
123
+ instance_variables.reject {|p| ["@source", "@groups"].include?(p.to_s) }
121
124
  end
122
125
 
123
126
  def to_lock
@@ -130,20 +133,97 @@ module Gem
130
133
  end
131
134
  end
132
135
 
136
+ # comparison is done order independently since rubygems 3.2.0.rc.2
137
+ unless Gem::Requirement.new("> 1", "< 2") == Gem::Requirement.new("< 2", "> 1")
138
+ class Requirement
139
+ module OrderIndependentComparison
140
+ def ==(other)
141
+ if _requirements_sorted? && other._requirements_sorted?
142
+ super
143
+ else
144
+ _with_sorted_requirements == other._with_sorted_requirements
145
+ end
146
+ end
147
+
148
+ protected
149
+
150
+ def _requirements_sorted?
151
+ return @_are_requirements_sorted if defined?(@_are_requirements_sorted)
152
+ strings = as_list
153
+ @_are_requirements_sorted = strings == strings.sort
154
+ end
155
+
156
+ def _with_sorted_requirements
157
+ @_with_sorted_requirements ||= _requirements_sorted? ? self : self.class.new(as_list.sort)
158
+ end
159
+ end
160
+
161
+ prepend OrderIndependentComparison
162
+ end
163
+ end
164
+
165
+ if Gem::Requirement.new("~> 2.0").hash == Gem::Requirement.new("~> 2.0.0").hash
166
+ class Requirement
167
+ module CorrectHashForLambdaOperator
168
+ def hash
169
+ if requirements.any? {|r| r.first == "~>" }
170
+ requirements.map {|r| r.first == "~>" ? [r[0], r[1].to_s] : r }.sort.hash
171
+ else
172
+ super
173
+ end
174
+ end
175
+ end
176
+
177
+ prepend CorrectHashForLambdaOperator
178
+ end
179
+ end
180
+
181
+ require "rubygems/platform"
182
+
133
183
  class Platform
134
184
  JAVA = Gem::Platform.new("java") unless defined?(JAVA)
135
185
  MSWIN = Gem::Platform.new("mswin32") unless defined?(MSWIN)
136
186
  MSWIN64 = Gem::Platform.new("mswin64") unless defined?(MSWIN64)
137
187
  MINGW = Gem::Platform.new("x86-mingw32") unless defined?(MINGW)
138
188
  X64_MINGW = Gem::Platform.new("x64-mingw32") unless defined?(X64_MINGW)
189
+ end
190
+
191
+ Platform.singleton_class.module_eval do
192
+ unless Platform.singleton_methods.include?(:match_spec?)
193
+ def match_spec?(spec)
194
+ match_gem?(spec.platform, spec.name)
195
+ end
196
+
197
+ def match_gem?(platform, gem_name)
198
+ match_platforms?(platform, Gem.platforms)
199
+ end
139
200
 
140
- undef_method :hash if method_defined? :hash
141
- def hash
142
- @cpu.hash ^ @os.hash ^ @version.hash
201
+ private
202
+
203
+ def match_platforms?(platform, platforms)
204
+ platforms.any? do |local_platform|
205
+ platform.nil? ||
206
+ local_platform == platform ||
207
+ (local_platform != Gem::Platform::RUBY && local_platform =~ platform)
208
+ end
209
+ end
143
210
  end
211
+ end
144
212
 
145
- undef_method :eql? if method_defined? :eql?
146
- alias_method :eql?, :==
213
+ require "rubygems/util"
214
+
215
+ Util.singleton_class.module_eval do
216
+ if Util.singleton_methods.include?(:glob_files_in_dir) # since 3.0.0.beta.2
217
+ remove_method :glob_files_in_dir
218
+ end
219
+
220
+ def glob_files_in_dir(glob, base_path)
221
+ if RUBY_VERSION >= "2.5"
222
+ Dir.glob(glob, :base => base_path).map! {|f| File.expand_path(f, base_path) }
223
+ else
224
+ Dir.glob(File.join(base_path.to_s.gsub(/[\[\]]/, '\\\\\\&'), glob)).map! {|f| File.expand_path(f) }
225
+ end
226
+ end
147
227
  end
148
228
  end
149
229
 
@@ -4,14 +4,60 @@ require "rubygems/installer"
4
4
 
5
5
  module Bundler
6
6
  class RubyGemsGemInstaller < Gem::Installer
7
- unless respond_to?(:at)
8
- def self.at(*args)
9
- new(*args)
7
+ def check_executable_overwrite(filename)
8
+ # Bundler needs to install gems regardless of binstub overwriting
9
+ end
10
+
11
+ def install
12
+ pre_install_checks
13
+
14
+ run_pre_install_hooks
15
+
16
+ spec.loaded_from = spec_file
17
+
18
+ # Completely remove any previous gem files
19
+ strict_rm_rf gem_dir
20
+ strict_rm_rf spec.extension_dir
21
+
22
+ SharedHelpers.filesystem_access(gem_dir, :create) do
23
+ FileUtils.mkdir_p gem_dir, :mode => 0o755
24
+ end
25
+
26
+ extract_files
27
+
28
+ build_extensions
29
+ write_build_info_file
30
+ run_post_build_hooks
31
+
32
+ generate_bin
33
+ generate_plugins
34
+
35
+ write_spec
36
+
37
+ SharedHelpers.filesystem_access("#{gem_home}/cache", :write) do
38
+ write_cache_file
10
39
  end
40
+
41
+ say spec.post_install_message unless spec.post_install_message.nil?
42
+
43
+ run_post_install_hooks
44
+
45
+ spec
11
46
  end
12
47
 
13
- def check_executable_overwrite(filename)
14
- # Bundler needs to install gems regardless of binstub overwriting
48
+ def generate_plugins
49
+ return unless Gem::Installer.instance_methods(false).include?(:generate_plugins)
50
+
51
+ latest = Gem::Specification.stubs_for(spec.name).first
52
+ return if latest && latest.version > spec.version
53
+
54
+ ensure_writable_dir @plugins_dir
55
+
56
+ if spec.plugins.empty?
57
+ remove_plugins_for(spec, @plugins_dir)
58
+ else
59
+ regenerate_plugins_for(spec, @plugins_dir)
60
+ end
15
61
  end
16
62
 
17
63
  def pre_install_checks
@@ -20,7 +66,10 @@ module Bundler
20
66
 
21
67
  def build_extensions
22
68
  extension_cache_path = options[:bundler_extension_cache_path]
23
- return super unless extension_cache_path && extension_dir = Bundler.rubygems.spec_extension_dir(spec)
69
+ unless extension_cache_path && extension_dir = spec.extension_dir
70
+ require "shellwords" # compensate missing require in rubygems before version 3.2.25
71
+ return super
72
+ end
24
73
 
25
74
  extension_dir = Pathname.new(extension_dir)
26
75
  build_complete = SharedHelpers.filesystem_access(extension_cache_path.join("gem.build_complete"), :read, &:file?)
@@ -30,6 +79,7 @@ module Bundler
30
79
  FileUtils.cp_r extension_cache_path, spec.extension_dir
31
80
  end
32
81
  else
82
+ require "shellwords" # compensate missing require in rubygems before version 3.2.25
33
83
  super
34
84
  if extension_dir.directory? # not made for gems without extensions
35
85
  SharedHelpers.filesystem_access(extension_cache_path.parent, &:mkpath)
@@ -40,7 +90,18 @@ module Bundler
40
90
  end
41
91
  end
42
92
 
43
- private
93
+ private
94
+
95
+ def strict_rm_rf(dir)
96
+ # FileUtils.rm_rf should probably rise in case of permission issues like
97
+ # `rm -rf` does. However, it fails to delete the folder silently due to
98
+ # https://github.com/ruby/fileutils/issues/57. It should probably be fixed
99
+ # inside `fileutils` but for now I`m checking whether the folder was
100
+ # removed after it completes, and raising otherwise.
101
+ FileUtils.rm_rf dir
102
+
103
+ raise PermissionError.new(dir, :delete) if File.directory?(dir)
104
+ end
44
105
 
45
106
  def validate_bundler_checksum(checksum)
46
107
  return true if Bundler.settings[:disable_checksum_validation]
@@ -66,7 +127,7 @@ module Bundler
66
127
 
67
128
  If you wish to continue installing the downloaded gem, and are certain it does not pose a \
68
129
  security issue despite the mismatching checksum, do the following:
69
- 1. run `bundle config set disable_checksum_validation true` to turn off checksum verification
130
+ 1. run `bundle config set --local disable_checksum_validation true` to turn off checksum verification
70
131
  2. run `bundle install`
71
132
 
72
133
  (More info: The expected SHA256 checksum was #{checksum.inspect}, but the \