bundler 1.4.0.rc.1 → 1.5.0.rc.1

data/spec/install/gemspecs_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe "bundle install" do
+
+  describe "when a gem has a YAML gemspec" do
+    before :each do
+      build_repo2 do
+        build_gem "yaml_spec", :gemspec => :yaml
+      end
+    end
+
+    it "still installs correctly" do
+      gemfile <<-G
+        source "file://#{gem_repo2}"
+        gem "yaml_spec"
+      G
+      bundle :install
+      expect(err).to be_empty
+    end
+
+    it "still installs correctly when using path" do
+      build_lib 'yaml_spec', :gemspec => :yaml
+
+      install_gemfile <<-G
+        gem 'yaml_spec', :path => "#{lib_path('yaml_spec-1.0')}"
+      G
+      expect(err).to eq("")
+    end
+  end
+
+  it "should use gemspecs in the system cache when available" do
+    gemfile <<-G
+      source "http://localtestserver.gem"
+      gem 'rack'
+    G
+
+    FileUtils.mkdir_p "#{tmp}/gems/system/specifications"
+    File.open("#{tmp}/gems/system/specifications/rack-1.0.0.gemspec", 'w+') do |f|
+      spec = Gem::Specification.new do |s|
+        s.name = 'rack'
+        s.version = '1.0.0'
+        s.add_runtime_dependency 'activesupport', '2.3.2'
+      end
+      f.write spec.to_ruby
+    end
+    bundle :install, :artifice => 'endpoint_marshal_fail' # force gemspec load
+    should_be_installed "activesupport 2.3.2"
+  end
+
+end

data/spec/install/path_spec.rb

@@ -1,468 +1,150 @@
 require "spec_helper"
 
-describe "bundle install with explicit source paths" do
-  it "fetches gems" do
-    build_lib "foo"
+describe "bundle install" do
 
-    install_gemfile <<-G
-      path "#{lib_path('foo-1.0')}"
-      gem 'foo'
-    G
-
-    should_be_installed("foo 1.0")
-  end
-
-  it "supports pinned paths" do
-    build_lib "foo"
-
-    install_gemfile <<-G
-      gem 'foo', :path => "#{lib_path('foo-1.0')}"
-    G
-
-    should_be_installed("foo 1.0")
-  end
-
-  it "supports relative paths" do
-    build_lib "foo"
-
-    relative_path = lib_path('foo-1.0').relative_path_from(Pathname.new(Dir.pwd))
-
-    install_gemfile <<-G
-      gem 'foo', :path => "#{relative_path}"
-    G
-
-    should_be_installed("foo 1.0")
-  end
-
-  it "expands paths" do
-    build_lib "foo"
-
-    relative_path = lib_path('foo-1.0').relative_path_from(Pathname.new('~').expand_path)
-
-    install_gemfile <<-G
-      gem 'foo', :path => "~/#{relative_path}"
-    G
-
-    should_be_installed("foo 1.0")
-  end
-
-  it "expands paths relative to Bundler.root" do
-    build_lib "foo", :path => bundled_app("foo-1.0")
-
-    install_gemfile <<-G
-      gem 'foo', :path => "./foo-1.0"
-    G
-
-    bundled_app("subdir").mkpath
-    Dir.chdir(bundled_app("subdir")) do
-      should_be_installed("foo 1.0")
-    end
-  end
-
-  it "expands paths when comparing locked paths to Gemfile paths" do
-    build_lib "foo", :path => bundled_app("foo-1.0")
-
-    install_gemfile <<-G
-      gem 'foo', :path => File.expand_path("../foo-1.0", __FILE__)
-    G
-
-    bundle "install --frozen", :exitstatus => true
-    expect(exitstatus).to eq(0)
-  end
-
-  it "installs dependencies from the path even if a newer gem is available elsewhere" do
-    system_gems "rack-1.0.0"
+  describe "with --path" do
+    before :each do
+      build_gem "rack", "1.0.0", :to_system => true do |s|
+        s.write "lib/rack.rb", "puts 'FAIL'"
+      end
 
-    build_lib "rack", "1.0", :path => lib_path('nested/bar') do |s|
-      s.write "lib/rack.rb", "puts 'WIN OVERRIDE'"
+      gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "rack"
+      G
     end
 
-    build_lib "foo", :path => lib_path('nested') do |s|
-      s.add_dependency "rack", "= 1.0"
+    it "does not use available system gems with bundle --path vendor/bundle" do
+      bundle "install --path vendor/bundle"
+      should_be_installed "rack 1.0.0"
     end
 
-    install_gemfile <<-G
-      source "file://#{gem_repo1}"
-      gem "foo", :path => "#{lib_path('nested')}"
-    G
+    it "handles paths with regex characters in them" do
+      dir = bundled_app("bun++dle")
+      dir.mkpath
 
-    run "require 'rack'"
-    expect(out).to eq('WIN OVERRIDE')
-  end
+      Dir.chdir(dir) do
+        bundle "install --path vendor/bundle"
+        expect(out).to include("installed into ./vendor/bundle")
+      end
 
-  it "works" do
-    build_gem "foo", "1.0.0", :to_system => true do |s|
-      s.write "lib/foo.rb", "puts 'FAIL'"
+      dir.rmtree
     end
 
-    build_lib "omg", "1.0", :path => lib_path("omg") do |s|
-      s.add_dependency "foo"
+    it "prints a warning to let the user know what has happened with bundle --path vendor/bundle" do
+      bundle "install --path vendor/bundle"
+      expect(out).to include("It was installed into ./vendor")
     end
 
-    build_lib "foo", "1.0.0", :path => lib_path("omg/foo")
-
-    install_gemfile <<-G
-      gem "omg", :path => "#{lib_path('omg')}"
-    G
-
-    should_be_installed "foo 1.0"
-  end
-
-  it "supports gemspec syntax" do
-    build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-      s.add_dependency "rack", "1.0"
+    it "disallows --path vendor/bundle --system" do
+      bundle "install --path vendor/bundle --system"
+      expect(out).to include("Please choose.")
     end
 
-    gemfile = <<-G
-      source "file://#{gem_repo1}"
-      gemspec
-    G
-
-    File.open(lib_path("foo/Gemfile"), "w") {|f| f.puts gemfile }
-
-    Dir.chdir(lib_path("foo")) do
+    it "remembers to disable system gems after the first time with bundle --path vendor/bundle" do
+      bundle "install --path vendor/bundle"
+      FileUtils.rm_rf bundled_app('vendor')
       bundle "install"
-      should_be_installed "foo 1.0"
-      should_be_installed "rack 1.0"
-    end
-  end
-
-  it "supports gemspec syntax with an alternative path" do
-    build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-      s.add_dependency "rack", "1.0"
-    end
-
-    install_gemfile <<-G
-      source "file://#{gem_repo1}"
-      gemspec :path => "#{lib_path("foo")}"
-    G
-
-    should_be_installed "foo 1.0"
-    should_be_installed "rack 1.0"
-  end
-
-  it "doesn't automatically unlock dependencies when using the gemspec syntax" do
-    build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-      s.add_dependency "rack", ">= 1.0"
-    end
-
-    Dir.chdir lib_path("foo")
-
-    install_gemfile lib_path("foo/Gemfile"), <<-G
-      source "file://#{gem_repo1}"
-      gemspec
-    G
-
-    build_gem "rack", "1.0.1", :to_system => true
-
-    bundle "install"
-
-    should_be_installed "foo 1.0"
-    should_be_installed "rack 1.0"
-  end
-
-  it "doesn't automatically unlock dependencies when using the gemspec syntax and the gem has development dependencies" do
-    build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-      s.add_dependency "rack", ">= 1.0"
-      s.add_development_dependency "activesupport"
-    end
-
-    Dir.chdir lib_path("foo")
-
-    install_gemfile lib_path("foo/Gemfile"), <<-G
-      source "file://#{gem_repo1}"
-      gemspec
-    G
-
-    build_gem "rack", "1.0.1", :to_system => true
-
-    bundle "install"
-
-    should_be_installed "foo 1.0"
-    should_be_installed "rack 1.0"
-  end
-
-  it "raises if there are multiple gemspecs" do
-    build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-      s.write "bar.gemspec"
-    end
-
-    install_gemfile <<-G, :exitstatus => true
-      gemspec :path => "#{lib_path("foo")}"
-    G
-
-    expect(exitstatus).to eq(15)
-    expect(out).to match(/There are multiple gemspecs/)
-  end
-
-  it "allows :name to be specified to resolve ambiguity" do
-    build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-      s.write "bar.gemspec"
-    end
-
-    install_gemfile <<-G, :exitstatus => true
-      gemspec :path => "#{lib_path("foo")}", :name => "foo"
-    G
-
-    should_be_installed "foo 1.0"
-  end
-
-  it "sets up executables" do
-    pending_jruby_shebang_fix
-
-    build_lib "foo" do |s|
-      s.executables = "foobar"
-    end
-
-    install_gemfile <<-G
-      path "#{lib_path('foo-1.0')}"
-      gem 'foo'
-    G
-
-    bundle "exec foobar"
-    expect(out).to eq("1.0")
-  end
 
-  it "handles directories in bin/" do
-    build_lib "foo"
-    lib_path("foo-1.0").join("foo.gemspec").rmtree
-    lib_path("foo-1.0").join("bin/performance").mkpath
-
-    install_gemfile <<-G
-      gem 'foo', '1.0', :path => "#{lib_path('foo-1.0')}"
-    G
-    expect(err).to eq("")
-  end
-
-  it "removes the .gem file after installing" do
-    build_lib "foo"
-
-    install_gemfile <<-G
-      gem 'foo', :path => "#{lib_path('foo-1.0')}"
-    G
-
-    expect(lib_path('foo-1.0').join('foo-1.0.gem')).not_to exist
-  end
-
-  describe "block syntax" do
-    it "pulls all gems from a path block" do
-      build_lib "omg"
-      build_lib "hi2u"
-
-      install_gemfile <<-G
-        path "#{lib_path}" do
-          gem "omg"
-          gem "hi2u"
-        end
-      G
-
-      should_be_installed "omg 1.0", "hi2u 1.0"
-    end
-  end
-
-  it "keeps source pinning" do
-    build_lib "foo", "1.0", :path => lib_path('foo')
-    build_lib "omg", "1.0", :path => lib_path('omg')
-    build_lib "foo", "1.0", :path => lib_path('omg/foo') do |s|
-      s.write "lib/foo.rb", "puts 'FAIL'"
-    end
-
-    install_gemfile <<-G
-      gem "foo", :path => "#{lib_path('foo')}"
-      gem "omg", :path => "#{lib_path('omg')}"
-    G
-
-    should_be_installed "foo 1.0"
-  end
-
-  it "works when the path does not have a gemspec" do
-    build_lib "foo", :gemspec => false
-
-    gemfile <<-G
-      gem "foo", "1.0", :path => "#{lib_path('foo-1.0')}"
-    G
-
-    should_be_installed "foo 1.0"
-
-    should_be_installed "foo 1.0"
-  end
-
-  it "installs executable stubs" do
-    build_lib "foo" do |s|
-      s.executables = ['foo']
+      expect(vendored_gems('gems/rack-1.0.0')).to be_directory
+      should_be_installed "rack 1.0.0"
     end
-
-    install_gemfile <<-G
-      gem "foo", :path => "#{lib_path('foo-1.0')}"
-    G
-
-    bundle "exec foo"
-    expect(out).to eq("1.0")
   end
 
-  describe "when the gem version in the path is updated" do
+  describe "when BUNDLE_PATH or the global path config is set" do
     before :each do
-      build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-        s.add_dependency "bar"
+      build_lib "rack", "1.0.0", :to_system => true do |s|
+        s.write "lib/rack.rb", "raise 'FAIL'"
       end
-      build_lib "bar", "1.0", :path => lib_path("foo/bar")
 
-      install_gemfile <<-G
-        gem "foo", :path => "#{lib_path('foo')}"
+      gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "rack"
       G
     end
 
-    it "unlocks all gems when the top level gem is updated" do
-      build_lib "foo", "2.0", :path => lib_path("foo") do |s|
-        s.add_dependency "bar"
+    def set_bundle_path(type, location)
+      if type == :env
+        ENV["BUNDLE_PATH"] = location
+      elsif type == :global
+        bundle "config path #{location}", "no-color" => nil
       end
-
-      bundle "install"
-
-      should_be_installed "foo 2.0", "bar 1.0"
     end
 
-    it "unlocks all gems when a child dependency gem is updated" do
-      build_lib "bar", "2.0", :path => lib_path("foo/bar")
-
-      bundle "install"
-
-      should_be_installed "foo 1.0", "bar 2.0"
-    end
-  end
-
-  describe "when dependencies in the path are updated" do
-    before :each do
-      build_lib "foo", "1.0", :path => lib_path("foo")
-
-      install_gemfile <<-G
-        source "file://#{gem_repo1}"
-        gem "foo", :path => "#{lib_path('foo')}"
-      G
-    end
+    [:env, :global].each do |type|
+      it "installs gems to a path if one is specified" do
+        set_bundle_path(type, bundled_app("vendor2").to_s)
+        bundle "install --path vendor/bundle"
 
-    it "gets dependencies that are updated in the path" do
-      build_lib "foo", "1.0", :path => lib_path("foo") do |s|
-        s.add_dependency "rack"
+        expect(vendored_gems("gems/rack-1.0.0")).to be_directory
+        expect(bundled_app("vendor2")).not_to be_directory
+        should_be_installed "rack 1.0.0"
       end
 
-      bundle "install"
+      it "installs gems to BUNDLE_PATH with #{type}" do
+        set_bundle_path(type, bundled_app("vendor").to_s)
 
-      should_be_installed "rack 1.0.0"
-    end
-  end
+        bundle :install
 
-  describe "switching sources" do
-    it "doesn't switch pinned git sources to rubygems when pinning the parent gem to a path source" do
-      build_gem "foo", "1.0", :to_system => true do |s|
-        s.write "lib/foo.rb", "raise 'fail'"
-      end
-      build_lib "foo", "1.0", :path => lib_path('bar/foo')
-      build_git "bar", "1.0", :path => lib_path('bar') do |s|
-        s.add_dependency 'foo'
+        expect(bundled_app('vendor/gems/rack-1.0.0')).to be_directory
+        should_be_installed "rack 1.0.0"
       end
 
-      install_gemfile <<-G
-        source "file://#{gem_repo1}"
-        gem "bar", :git => "#{lib_path('bar')}"
-      G
+      it "installs gems to BUNDLE_PATH relative to root when relative" do
+        set_bundle_path(type, "vendor")
 
-      install_gemfile <<-G
-        source "file://#{gem_repo1}"
-        gem "bar", :path => "#{lib_path('bar')}"
-      G
+        FileUtils.mkdir_p bundled_app('lol')
+        Dir.chdir(bundled_app('lol')) do
+          bundle :install
+        end
 
-      should_be_installed "foo 1.0", "bar 1.0"
+        expect(bundled_app('vendor/gems/rack-1.0.0')).to be_directory
+        should_be_installed "rack 1.0.0"
+      end
     end
 
-    it "switches the source when the gem existed in rubygems and the path was already being used for another gem" do
-      build_lib "foo", "1.0", :path => lib_path("foo")
-      build_gem "bar", "1.0", :to_system => true do |s|
-        s.write "lib/bar.rb", "raise 'fail'"
-      end
+    it "installs gems to BUNDLE_PATH from .bundle/config" do
+      config "BUNDLE_PATH" => bundled_app("vendor/bundle").to_s
 
-      install_gemfile <<-G
-        source "file://#{gem_repo1}"
-        gem "bar"
-        path "#{lib_path('foo')}" do
-          gem "foo"
-        end
-      G
+      bundle :install
 
-      build_lib "bar", "1.0", :path => lib_path("foo/bar")
+      expect(vendored_gems('gems/rack-1.0.0')).to be_directory
+      should_be_installed "rack 1.0.0"
+    end
 
-      install_gemfile <<-G
-        source "file://#{gem_repo1}"
-        path "#{lib_path('foo')}" do
-          gem "foo"
-          gem "bar"
-        end
-      G
+    it "sets BUNDLE_PATH as the first argument to bundle install" do
+      bundle "install --path ./vendor/bundle"
 
-      should_be_installed "bar 1.0"
+      expect(vendored_gems('gems/rack-1.0.0')).to be_directory
+      should_be_installed "rack 1.0.0"
     end
-  end
 
-  describe "gem install hooks" do
-    it "runs pre-install hooks" do
-      build_git "foo"
-      gemfile <<-G
-        gem "foo", :git => "#{lib_path('foo-1.0')}"
-      G
-
-      File.open(lib_path("install_hooks.rb"), "w") do |h|
-        h.write <<-H
-          require 'rubygems'
-          Gem.pre_install_hooks << lambda do |inst|
-            STDERR.puts "Ran pre-install hook: \#{inst.spec.full_name}"
-          end
-        H
-      end
+    it "disables system gems when passing a path to install" do
+      # This is so that vendored gems can be distributed to others
+      build_gem "rack", "1.1.0", :to_system => true
+      bundle "install --path ./vendor/bundle"
 
-      bundle :install, :expect_err => true,
-        :requires => [lib_path('install_hooks.rb')]
-      expect(err).to eq("Ran pre-install hook: foo-1.0")
+      expect(vendored_gems('gems/rack-1.0.0')).to be_directory
+      should_be_installed "rack 1.0.0"
     end
+  end
 
-    it "runs post-install hooks" do
-      build_git "foo"
-      gemfile <<-G
-        gem "foo", :git => "#{lib_path('foo-1.0')}"
-      G
-
-      File.open(lib_path("install_hooks.rb"), "w") do |h|
-        h.write <<-H
-          require 'rubygems'
-          Gem.post_install_hooks << lambda do |inst|
-            STDERR.puts "Ran post-install hook: \#{inst.spec.full_name}"
-          end
-        H
+  describe "to a dead symlink" do
+    before do
+      in_app_root do
+        `ln -s /tmp/idontexist bundle`
       end
-
-      bundle :install, :expect_err => true,
-        :requires => [lib_path('install_hooks.rb')]
-      expect(err).to eq("Ran post-install hook: foo-1.0")
     end
 
-    it "complains if the install hook fails" do
-      build_git "foo"
+    it "reports the symlink is dead" do
       gemfile <<-G
-        gem "foo", :git => "#{lib_path('foo-1.0')}"
+        source "file://#{gem_repo1}"
+        gem "rack"
       G
 
-      File.open(lib_path("install_hooks.rb"), "w") do |h|
-        h.write <<-H
-          require 'rubygems'
-          Gem.pre_install_hooks << lambda do |inst|
-            false
-          end
-        H
-      end
-
-      bundle :install, :expect_err => true,
-        :requires => [lib_path('install_hooks.rb')]
-      expect(out).to include("failed for foo-1.0")
+      bundle "install --path bundle"
+      expect(out).to match(/invalid symlink/)
     end
   end
 
-end
+end