bundler 1.0.15 → 1.0.17

data/CHANGELOG.md

@@ -1,3 +1,31 @@
+## 1.0.17 (Aug 8, 2011)
+
+Bugfixes:
+
+  - Fix rake issues with rubygems 1.3.x (#1342)
+  - Fixed invalid byte sequence error while installing gem on Ruby 1.9 (#1341)
+
+## 1.0.16 (Aug 8, 2011)
+
+Features:
+
+  - Performance fix for MRI 1.9 (@efficientcloud, #1288)
+  - Shortcuts (like `bundle i`) for all commands (@amatsuda)
+  - Correcly identify missing child dependency in error message
+
+Bugfixes:
+
+  - Allow Windows network share paths with forward slashes (@mtscout6, #1253)
+  - Check for rubygems.org credentials so `rake release` doesn't hang (#980)
+  - Find cached prerelease gems on rubygems 1.3.x (@dburt, #1202)
+  - Fix `bundle install --without` on kiji (@tmm1, #1287)
+  - Get rid of warning in ruby 1.9.3 (@smartinez87, #1231)
+
+Documentation:
+
+  - Documentation for `gem ..., :require => false` (@kmayer, #1292)
+  - Gems provide "executables", they are rarely also binaries (@fxn, #1242)
+
 ## 1.0.15 (June 9, 2011)
 
 Features:

data/ISSUES.md

@@ -50,6 +50,7 @@ Instructions that allow the Bundler team to reproduce your issue are vitally imp
   - What version of Rubygems you are using (run `gem -v`)
   - Whether you are using RVM, and if so what version (run `rvm -v`)
   - Whether you have the `rubygems-bundler` gem, which can break gem binares
+  - Whether you have the `open_gem` gem, which can cause rake activation conflicts
 
 
 If you are using Rails 2.3, please also include:

data/Rakefile

@@ -40,9 +40,9 @@ begin
     end
 
     namespace :rubygems do
-      # Rubygems 1.3.5, 1.3.6, and HEAD specs
+      # Rubygems specs by version
       rubyopt = ENV["RUBYOPT"]
-      %w(master v1.3.6 v1.3.7 v1.4.2 v1.5.3 v1.6.2 v1.7.2 v1.8.3).each do |rg|
+      %w(master v1.3.6 v1.3.7 v1.4.2 v1.5.3 v1.6.2 v1.7.2 v1.8.7).each do |rg|
         desc "Run specs with Rubygems #{rg}"
         RSpec::Core::RakeTask.new(rg) do |t|
           t.rspec_opts = %w(-fs --color)
@@ -95,7 +95,7 @@ begin
         raise "RVM is not available" unless File.exist?(File.expand_path("~/.rvm/scripts/rvm"))
       end
 
-      %w(1.8.6-p399 1.8.7-p302 1.9.2-p0).each do |ruby|
+      %w(1.8.6-p420 1.8.7-p334 1.9.2-p180).each do |ruby|
         ruby_cmd = File.expand_path("~/.rvm/bin/ruby-#{ruby}")
 
         desc "Run specs on Ruby #{ruby}"

data/UPGRADING.md

@@ -61,8 +61,8 @@ Bundler 0.9 removes the following Bundler 0.8 Gemfile APIs:
    via `bundle install /path/to/bundle`. Bundler will remember
    where you installed the dependencies to on a particular
    machine for future installs, loads, setups, etc.
-5. `bin_path`: Bundler no longer generates binaries in the root
-   of your app. You should use `bundle exec` to execute binaries
+5. `bin_path`: Bundler no longer generates executables in the root
+   of your app. You should use `bundle exec` to execute executables
    in the current context.
 
 ### Gemfile Changes

data/lib/bundler/cli.rb

@@ -1,6 +1,4 @@
-$:.unshift File.expand_path('../vendor', __FILE__)
-require 'thor'
-require 'thor/actions'
+require 'bundler/vendored_thor'
 require 'rubygems/user_interaction'
 require 'rubygems/config_file'
 
@@ -16,7 +14,7 @@ module Bundler
       Bundler.rubygems.ui = UI::RGProxy.new(Bundler.ui)
     end
 
-    check_unknown_options! unless ARGV.include?("exec") || ARGV.include?("config")
+    check_unknown_options!
 
     default_task :install
     class_option "no-color", :type => :boolean, :banner => "Disable colorization in output"
@@ -154,10 +152,10 @@ module Bundler
       opts = options.dup
       opts[:without] ||= []
       if opts[:without].size == 1
-        opts[:without].map!{|g| g.split(" ") }
+        opts[:without] = opts[:without].map{|g| g.split(" ") }
         opts[:without].flatten!
       end
-      opts[:without].map!{|g| g.to_sym }
+      opts[:without] = opts[:without].map{|g| g.to_sym }
 
       # Can't use Bundler.settings for this because settings needs gemfile.dirname
       ENV['BUNDLE_GEMFILE'] = File.expand_path(opts[:gemfile]) if opts[:gemfile]
@@ -349,7 +347,7 @@ module Bundler
         exit 126
       rescue Errno::ENOENT
         Bundler.ui.error "bundler: command not found: #{ARGV.first}"
-        Bundler.ui.warn  "Install missing gem binaries with `bundle install`"
+        Bundler.ui.warn  "Install missing gem executables with `bundle install`"
         exit 127
       end
     end

data/lib/bundler/gem_helper.rb

@@ -70,9 +70,12 @@ module Bundler
 
     protected
     def rubygem_push(path)
-      out, _ = sh("gem push '#{path}'")
-      raise "Gem push failed due to lack of RubyGems.org credentials." if out[/Enter your RubyGems.org credentials/]
-      Bundler.ui.confirm "Pushed #{name} #{version} to rubygems.org"
+      if Pathname.new("~/.gem/credentials").expand_path.exist?
+        sh("gem push '#{path}'")
+        Bundler.ui.confirm "Pushed #{name} #{version} to rubygems.org"
+      else
+        raise "Your rubygems.org credentials aren't set. Run `gem push` to set them."
+      end
     end
 
     def built_gem_path

data/lib/bundler/index.rb

@@ -101,10 +101,15 @@ module Bundler
       end
     end
 
-    def same_version?(a, b)
-      regex = /^(.*?)(?:\.0)*$/
-
-      a.to_s[regex, 1] == b.to_s[regex, 1]
+    if RUBY_VERSION < '1.9'
+      def same_version?(a, b)
+        regex = /^(.*?)(?:\.0)*$/
+        a.to_s[regex, 1] == b.to_s[regex, 1]
+      end
+    else
+      def same_version?(a, b)
+        a == b
+      end
     end
 
     def spec_satisfies_dependency?(spec, dep)

data/lib/bundler/lazy_specification.rb

@@ -58,13 +58,16 @@ module Bundler
 
   private
 
+    def to_ary
+      nil
+    end
+
     def method_missing(method, *args, &blk)
-      if Gem::Specification.new.respond_to?(method)
-        raise "LazySpecification has not been materialized yet (calling :#{method} #{args.inspect})" unless @specification
-        @specification.send(method, *args, &blk)
-      else
-        super
-      end
+      raise "LazySpecification has not been materialized yet (calling :#{method} #{args.inspect})" unless @specification
+
+      return super unless respond_to?(method)
+
+      @specification.send(method, *args, &blk)
     end
 
   end

data/lib/bundler/resolver.rb

@@ -279,14 +279,6 @@ module Bundler
             end
             raise GemNotFound, message
           else
-            if @missing_gems[current] >= 5
-              message =  "Bundler could not find find gem #{current.required_by.last},"
-              message << "which is required by gem #{current}."
-              raise GemNotFound, message
-            end
-            @missing_gems[current] += 1
-
-            debug { "    Could not find #{current} by #{current.required_by.last}" }
             @errors[current.name] = [nil, current]
           end
         end
@@ -356,7 +348,8 @@ module Bundler
 
     def search(dep)
       if base = @base[dep.name] and base.any?
-        d = Gem::Dependency.new(base.first.name, *[dep.requirement.as_list, base.first.version].flatten)
+        reqs = [dep.requirement.as_list, base.first.version.to_s].flatten.compact
+        d = Gem::Dependency.new(base.first.name, *reqs)
       else
         d = dep.dep
       end
@@ -456,7 +449,8 @@ module Bundler
           # the rest of the time, the gem cannot be found because it does not exist in the known sources
           else
             if requirement.required_by.first
-              o << "Could not find gem '#{clean_req(requirement)}', required by '#{clean_req(requirement.required_by.first)}', in any of the sources\n"
+              o << "Could not find gem '#{clean_req(requirement)}', which is required by "
+              o << "gem '#{clean_req(requirement.required_by.first)}', in any of the sources."
             else
               o << "Could not find gem '#{clean_req(requirement)} in any of the sources\n"
             end

data/lib/bundler/rubygems_ext.rb

@@ -157,6 +157,7 @@ module Gem
 
     alias eql? ==
   end
+
 end
 
 module Bundler

data/lib/bundler/rubygems_integration.rb

@@ -123,7 +123,7 @@ module Bundler
         if executables.include? File.basename(caller.first.split(':').first)
           return
         end
-        opts = reqs.last.is_a?(Hash) ? reqs.pop : {}
+        reqs.pop if reqs.last.is_a?(Hash)
 
         unless dep.respond_to?(:name) && dep.respond_to?(:requirement)
           dep = Gem::Dependency.new(dep, reqs)
@@ -250,7 +250,17 @@ module Bundler
       Gem.clear_paths
     end
 
-    # Rubygems versions 1.3.6 through 1.6.2
+    # This backports the correct segment generation code from Rubygems 1.4+
+    # by monkeypatching it into the method in Rubygems 1.3.6 and 1.3.7.
+    def backport_segment_generation
+      Gem::Version.send(:define_method, :segments) do
+        @segments ||= @version.scan(/[0-9]+|[a-z]+/i).map do |s|
+          /^\d+$/ =~ s ? s.to_i : s
+        end
+      end
+    end
+
+    # Rubygems 1.4 through 1.6
     class Legacy < RubygemsIntegration
       def stub_rubygems(specs)
         stub_source_index137(specs)
@@ -265,6 +275,14 @@ module Bundler
       end
     end
 
+    # Rubygems versions 1.3.6 and 1.3.7
+    class Ancient < Legacy
+      def initialize
+        super
+        backport_segment_generation
+      end
+    end
+
     # Rubygems 1.7
     class Transitional < Legacy
       def stub_rubygems(specs)
@@ -313,8 +331,10 @@ module Bundler
     @rubygems = RubygemsIntegration::AlmostModern.new
   elsif Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.7.0')
     @rubygems = RubygemsIntegration::Transitional.new
-  else # Rubygems 1.3.6 through 1.6.2
+  elsif Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.4.0')
     @rubygems = RubygemsIntegration::Legacy.new
+  else # Rubygems 1.3.6 and 1.3.7
+    @rubygems = RubygemsIntegration::Ancient.new
   end
 
   class << self

data/lib/bundler/source.rb

@@ -362,9 +362,9 @@ module Bundler
               s.relative_loaded_from = "#{@name}.gemspec"
               s.authors  = ["no one"]
               if expanded_path.join("bin").exist?
-                binaries = expanded_path.join("bin").children
-                binaries.reject!{|p| File.directory?(p) }
-                s.executables = binaries.map{|c| c.basename.to_s }
+                executables = expanded_path.join("bin").children
+                executables.reject!{|p| File.directory?(p) }
+                s.executables = executables.map{|c| c.basename.to_s }
               end
             end
           end
@@ -585,7 +585,7 @@ module Bundler
       end
 
       def base_name
-        File.basename(uri.sub(%r{^(\w+://)?([^/:]+:)},''), ".git")
+        File.basename(uri.sub(%r{^(\w+://)?([^/:]+:)?(//\w*/)?(\w*/)*},''),".git")
       end
 
       def shortref_for_display(ref)

data/lib/bundler/spec_set.rb

@@ -1,21 +1,18 @@
 require 'tsort'
+require 'forwardable'
 
 module Bundler
   class SpecSet
+    extend Forwardable
     include TSort, Enumerable
 
+    def_delegators :@specs, :<<, :length, :add, :remove
+    def_delegators :sorted, :each
+
     def initialize(specs)
       @specs = specs.sort_by { |s| s.name }
     end
 
-    def each
-      sorted.each { |s| yield s }
-    end
-
-    def length
-      @specs.length
-    end
-
     def for(dependencies, skip = [], check = false, match_current_platform = false)
       handled, deps, specs = {}, dependencies.dup, []
       skip << 'bundler'
@@ -68,6 +65,10 @@ module Bundler
       value
     end
 
+    def sort!
+      self
+    end
+
     def to_a
       sorted.dup
     end

data/lib/bundler/templates/newgem/Rakefile.tt

@@ -1 +1 @@
-require 'bundler/gem_tasks'
+require "bundler/gem_tasks"

data/lib/bundler/templates/newgem/newgem.gemspec.tt

@@ -17,4 +17,8 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
+
+  # specify any dependencies here; for example:
+  # s.add_development_dependency "rspec"
+  # s.add_runtime_dependency "rest-client"
 end

data/lib/bundler/vendor/thor.rb

@@ -18,6 +18,23 @@ class Thor
       end
     end
 
+    # Registers another Thor subclass as a command.
+    #
+    # ==== Parameters
+    # klass<Class>:: Thor subclass to register
+    # command<String>:: Subcommand name to use
+    # usage<String>:: Short usage for the subcommand
+    # description<String>:: Description for the subcommand
+    def register(klass, subcommand_name, usage, description, options={})
+      if klass <= Thor::Group
+        desc usage, description, options
+        define_method(subcommand_name) { invoke klass }
+      else
+        desc usage, description, options
+        subcommand subcommand_name, klass
+      end
+    end
+
     # Defines the usage and the description of the next task.
     #
     # ==== Parameters
@@ -252,8 +269,7 @@ class Thor
       # the namespace should be displayed as arguments.
       #
       def banner(task, namespace = nil, subcommand = false)
-        base = File.basename($0).split(" ").first
-        "#{base} #{task.formatted_usage(self, $thor_runner, subcommand)}"
+        "#{basename} #{task.formatted_usage(self, $thor_runner, subcommand)}"
       end
 
       def baseclass #:nodoc:
@@ -295,17 +311,40 @@ class Thor
       # Receives a task name (can be nil), and try to get a map from it.
       # If a map can't be found use the sent name or the default task.
       def normalize_task_name(meth) #:nodoc:
-        meth = map[meth.to_s] || meth || default_task
+        meth = map[meth.to_s] || find_subcommand_and_update_argv(meth) || meth || default_task
         meth.to_s.gsub('-','_') # treat foo-bar > foo_bar
       end
 
+      # terrible hack that overwrites ARGV
+      def find_subcommand_and_update_argv(subcmd_name) #:nodoc:
+        return unless subcmd_name
+        cmd = find_subcommand(subcmd_name)
+        ARGV[0] = cmd if cmd
+        cmd
+      end
+
+      def find_subcommand(subcmd_name)
+        possibilities = find_subcommand_possibilities subcmd_name
+        if possibilities.size > 1
+          raise "Ambiguous subcommand #{subcmd_name} matches [#{possibilities.join(', ')}]"
+        elsif possibilities.size < 1
+          return nil
+        end
+
+        possibilities.first
+      end
+
+      def find_subcommand_possibilities(subcmd_name)
+        len = subcmd_name.length
+        all_tasks.map {|t| t.first}.select { |n| subcmd_name == n[0, len] }
+      end
+
       def subcommand_help(cmd)
         desc "help [COMMAND]", "Describe subcommands or one specific subcommand"
         class_eval <<-RUBY
           def help(task = nil, subcommand = true); super; end
         RUBY
       end
-
   end
 
   include Thor::Base

data/lib/bundler/vendor/thor/actions.rb

@@ -1,10 +1,12 @@
 require 'fileutils'
 require 'uri'
 require 'thor/core_ext/file_binary_read'
-
-Dir[File.join(File.dirname(__FILE__), "actions", "*.rb")].each do |action|
-  require action
-end
+require 'thor/actions/create_file'
+require 'thor/actions/create_link'
+require 'thor/actions/directory'
+require 'thor/actions/empty_directory'
+require 'thor/actions/file_manipulation'
+require 'thor/actions/inject_into_file'
 
 class Thor
   module Actions
@@ -158,13 +160,23 @@ class Thor
     #
     def inside(dir='', config={}, &block)
       verbose = config.fetch(:verbose, false)
+      pretend = options[:pretend]
 
       say_status :inside, dir, verbose
       shell.padding += 1 if verbose
       @destination_stack.push File.expand_path(dir, destination_root)
 
-      FileUtils.mkdir_p(destination_root) unless File.exist?(destination_root)
-      FileUtils.cd(destination_root) { block.arity == 1 ? yield(destination_root) : yield }
+      # If the directory doesnt exist and we're not pretending
+      if !File.exist?(destination_root) && !pretend
+        FileUtils.mkdir_p(destination_root)
+      end
+
+      if pretend
+        # In pretend mode, just yield down to the block
+        block.arity == 1 ? yield(destination_root) : yield
+      else
+        FileUtils.cd(destination_root) { block.arity == 1 ? yield(destination_root) : yield }
+      end
 
       @destination_stack.pop
       shell.padding -= 1 if verbose
@@ -210,7 +222,7 @@ class Thor
     #
     # ==== Parameters
     # command<String>:: the command to be executed.
-    # config<Hash>:: give :verbose => false to not log the status. Specify :with
+    # config<Hash>:: give :verbose => false to not log the status, :capture => true to hide to output. Specify :with
     #                to append an executable to command executation.
     #
     # ==== Example
@@ -231,7 +243,10 @@ class Thor
       end
 
       say_status :run, desc, config.fetch(:verbose, true)
-      `#{command}` unless options[:pretend]
+
+      unless options[:pretend]
+        config[:capture] ? `#{command}` : system("#{command}")
+      end
     end
 
     # Executes a ruby script (taking into account WIN32 platform quirks).
@@ -251,8 +266,9 @@ class Thor
     # ==== Parameters
     # task<String>:: the task to be invoked
     # args<Array>:: arguments to the task
-    # config<Hash>:: give :verbose => false to not log the status. Other options
-    #                are given as parameter to Thor.
+    # config<Hash>:: give :verbose => false to not log the status, :capture => true to hide to output.
+    #                Other options are given as parameter to Thor.
+    #
     #
     # ==== Examples
     #
@@ -266,12 +282,13 @@ class Thor
       config  = args.last.is_a?(Hash) ? args.pop : {}
       verbose = config.key?(:verbose) ? config.delete(:verbose) : true
       pretend = config.key?(:pretend) ? config.delete(:pretend) : false
+      capture = config.key?(:capture) ? config.delete(:capture) : false
 
       args.unshift task
       args.push Thor::Options.to_switches(config)
       command = args.join(' ').strip
 
-      run command, :with => :thor, :verbose => verbose, :pretend => pretend
+      run command, :with => :thor, :verbose => verbose, :pretend => pretend, :capture => capture
     end
 
     protected