bundler-stats 1.3.4 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: eee76f69e73d6036e090b2bee0eba231f835ebc2
-  data.tar.gz: '09f8d3089540158fd2a06e8bd53ff0fbd2154bfd'
+SHA256:
+  metadata.gz: fad76aec2c17866fce619ae8dbdaa4e580a58f1c0d89c53681a35dba5e266998
+  data.tar.gz: 27d5b7a9ac01d7f7c0856cd2422b127d18fcd4de1cda1b2bcb0bf5c596528ad6
 SHA512:
-  metadata.gz: 83527495fddca9076679e2a409854e33c08654307aed35e0ca29daefef1f48726bfb8287430d5fab681f7401c0664ec6a86309560fee8442c0da805105fd132e
-  data.tar.gz: 6710d3f9948e9c4721fc11767bd736184776db218db45895f019df84c66a8837ba75d6401d86f1bb79e8de523f8de5f167e758f57b5e4f688124cad688bda3aa
+  metadata.gz: 57c12161cd51c19804cfd15fb17903c1a1a9a82fe1347cd303230f5979539c7306165b926d5db4e65434d43c19c9a8649afbe0c30ee58a41cfebc2cdc653b250
+  data.tar.gz: ee3ffeaa9580d4866a8fb11a947274ecd70e926cfdd3db83147a04500ab2a76e15ce89384268911e7e45587d483501d81d44d13e5733fe4c79f5746820887563

data/.github/workflows/main.yml

@@ -0,0 +1,27 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+        ruby-version: [3.1, 3.0, 2.7, 2.6, 2.5, 2.4, 2.3]
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rspec

data/.gitignore

@@ -1 +1,2 @@
 Gemfile.lock
+bundler-stats-*.gem

data/.rspec

@@ -0,0 +1 @@
+--color

data/.ruby-version

@@ -0,0 +1 @@
+2.7.3

data/CHANGELOG.md

@@ -1,19 +1,105 @@
 Changelog
 =============
 
-## [1.1.0] - 2018-03-16
+## [2.2.0] - 2022-02-09
+
+### Added
+- Support for gems.rb and gems.locked files.
+- Proper exit codes from thor when errors occur
+- Looser dependency on thor
+
+## [2.1.1] - 2021-11-30
+
+### Changed
+- Symlink isn't the recommended way to alias a command. Patterned current
+  solution after bundle-audit. Boy that naming convention was unfortunate.
+- Pin down dependencies a bit.
+
+### Added
+- Moved to Github test workflow, by @etagwerker.
+- New default ruby version to be most current non-3 ruby.
+- Build artifacts now ignored.
+- Moved to a real spec_helper so tests can be filtered during runs if desired.
+
 ### Fixed
+- Failing test from previous version.
 
-- Remove unintentional inclusion of pry outside of dev environment
+## [2.1.0] - 2021-11-29
+
+### Changed
+- Add Travis targets for more modern rubies, by @etagwerker.
+- Make sorting predictable across platforms, by @etagwerker.
+
+### Fixed
+- Fix error in CI when `tput` isn't available, by @etagwerker.
+
+## [2.0.1] - 2018-05-04
 
-## [1.1.0] - 2018-03-15
 ### Added
+- Complete custom table printer for some nicer output.
+
+## [2.0.0] - 2018-05-04
+Broken as hell.
 
+## [1.3.4] - 2019-04-18
+
+### Changed
+- Allow use of either `bundle-stats` or `bundler-stats` since the gem name was
+  a confusing choice. Live and learn.
+
+### Added
+- Display resolved version of a gem when using `bundler-stats show`.
+
+## [1.3.3] - 2019-04-18
+
+### Changed
+- Only print missing system dependency warning once per target gem, rather than
+  blowing up the console when a complicated gem is affected.
+
+## [1.3.2] - 2019-04-17
+
+### Fixed
+- Fix issue when testing removability and a system gem from another platform
+  is "required", thx @rwojnarowski.
+
+## [1.3.1] - 2019-04-05
+
+### Changed
+- Nicer table printing, still committed to not adding a table printing gem.
+
+## [1.3.0] - 2019-04-05
+
+### Changed
+- Reversed the order in which gems are printed to worst-offenders-first.
+
+## [1.2.1] - 2019-04-05
+
+### Fixed
+- When a system gem is missing from the lockfile (but is depended upon), warn
+  the user rather than exploding.
+
+## [1.2.0] - 2019-04-05
+
+### Fixed
+- Loosen dependency on thor gem, by localhostdotdev.
+
+## [1.1.2] - 2018-03-16
+Wonkiness w/ versioning. Apparently I was bad at this.
+
+## [1.1.0] - 2018-03-16
+Eventually superseded by 1.1.2 for reasons.
+
+### Fixed
+- Remove unintentional inclusion of pry outside of dev environment, per @Tuxified
+
+## [1.1.0] - 2018-03-15
+
+### Added
 - Adds a way to view dependency version restrictions for a given gem, by @olivierlacan
 
 ## [1.0.0] - 2016-04-13
-### Added
 
+### Added
 - Base library, woo!
 - List all transitive dependencies and how many other deps rely on them
 - View list of Github-specified dependencies

data/Guardfile

@@ -15,18 +15,6 @@
 #
 # and, you'll have to watch "config/Guardfile" instead of "Guardfile"
 
-guard :bundler do
-  require 'guard/bundler'
-  require 'guard/bundler/verify'
-  helper = Guard::Bundler::Verify.new
-
-  files = ['Gemfile']
-  files += Dir['*.gemspec'] if files.any? { |f| helper.uses_gemspec?(f) }
-
-  # Assume files are symlinked from somewhere
-  files.each { |file| watch(helper.real_path(file)) }
-end
-
 guard :rspec, cmd: 'rspec' do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }

data/README.md

@@ -1,15 +1,16 @@
 Bundler Stats
 =============
 
-You remember that time [someone yanked their library](http://blog.npmjs.org/post/141577284765/kik-left-pad-and-npm)
-and the entire Node universe fell apart? Yeah, me too. And all the
+You remember that time [someone yanked their
+library](http://blog.npmjs.org/post/141577284765/kik-left-pad-and-npm) and the
+entire Node universe fell apart? Yeah, me too. And all the
 [thinkpieces](http://www.haneycodes.net/npm-left-pad-have-we-forgotten-how-to-program/)
-that came out just afterward were right: you should be careful about
-what dependencies you include in your project.
+that came out just afterward were right: you should be careful about what
+dependencies you include in your project.
 
 This project gives you some tools you can use with an existing Gemfile to
-determine which gems are including long trees of their own dependencies,
-and which you can potentially remove.
+determine which gems are including long trees of their own dependencies, and
+which you can potentially remove.
 
 This is an exploratory tool, and I'd be interested to hear what other criteria
 would be useful in determining what tools to remove.
@@ -33,75 +34,106 @@ Usage
         bundle-stats version          # Prints the bundler-stats version
         bundle-stats versions TARGET  # Shows versions requirements for target in other dependencies
 
-The most obvious thing to do is run the command by itself, which should help identify problem areas:
+The most obvious thing to do is run the command by itself, which should help
+identify problem areas:
 
     > bundle-stats
 
-    +------------------------------|-----------------|-----------------+
-    | Name                         | Total Deps      | 1st Level Deps  |
-    +------------------------------|-----------------|-----------------+
-    ... omitted stuff here ...
-    | fog                          | 15              | 6               |
-    | fancybox2-rails              | 15              | 1               |
-    | quiet_assets                 | 15              | 1               |
-    | coffee-rails                 | 18              | 2               |
-    | angular-rails-templates      | 19              | 3               |
-    | devise                       | 19              | 6               |
-    | rspec-rails                  | 20              | 7               |
-    | sass-rails                   | 21              | 4               |
-    | foundation-icons-sass-rails  | 22              | 2               |
-    | rails                        | 29              | 9               |
-    | angular_rails_csrf           | 30              | 1               |
-    | ngannotate-rails             | 31              | 2               |
-    | activeadmin                  | 48              | 12              |
-    +------------------------------|-----------------|-----------------+
-
-    Declared Gems:     35
-    Total Gems:        113
-
-    Unpinned Versions: 30
-    Github Refs:       1
-
-It looks like activeadmin is a huge problem. Use `show` to investigate:
-
-    > bundle-stats show activeadmin
-    bundle-stats for activeadmin
-
-    depended upon by (0) |
-    depends on (48)      | arbre, bourbon, coffee-rails, formtastic, formtastic_i18n, inherited_resources, jquery-rails, jquery-ui-rails, kaminari, rails, ransack, sass-rails, activesupport, i18n, json, minitest, thread_safe, tzinfo, sass, thor, coffee-script, railties, coffee-script-source, execjs, actionpack, rake, actionview, rack, rack-test, builder, erubis, has_scope, responders, actionmailer, activemodel, activerecord, bundler, sprockets-rails, mail, mime-types, treetop, polyglot, arel, sprockets, hike, multi_json, tilt, polyamorous
-    unique to this (12)   | arbre, bourbon, formtastic, formtastic_i18n, inherited_resources, jquery-rails, jquery-ui-rails, kaminari, ransack, has_scope, bundler, polyamorous
-
-Removing the dep will only actually remove 12 gems. The rest are shared dependencies with rails. We can also omit trees we aren't going to remove (hi rails) by not following them:
+    +----------------------------|------------|----------------+
+    |                       Name | Total Deps | 1st Level Deps |
+    +----------------------------|------------|----------------+
+    |                rails_admin | 60         | 12             |
+    |                      rails | 40         | 12             |
+    |              compass-rails | 35         | 3              |
+    |                 haml-rails | 29         | 5              |
+    |                rspec-rails | 27         | 7              |
+    |                 sass-rails | 26         | 5              |
+    |                     devise | 26         | 5              |
+    |                     scenic | 25         | 2              |
+    |               coffee-rails | 25         | 2              |
+    |              guard-rubocop | 24         | 2              |
+    |                 versionist | 23         | 3              |
+    |          factory_bot_rails | 23         | 2              |
+    | ... omitted stuff here ...                               |
+    +----------------------------|------------|----------------+
+
+          Declared Gems   56
+             Total Gems   170
+      Unpinned Versions   54
+            Github Refs   0
+
+It looks like rails_admin is a huge problem. Use `show` to investigate:
+
+    > bundle-stats show rails_admin
+    bundle-stats for rails_admin
+
+    +--------------------------------|----------------------------------------+
+    |           Depended Upon By (0) |                                        |
+    |                Depends On (60) | builder, coffee-rails                  |
+    |                                | font-awesome-rails, haml, jquery-rails |
+    |                                | jquery-ui-rails, kaminari, nested_form |
+    |                                | rack-pjax, rails, remotipart           |
+    |                                | sass-rails, coffee-script, railties    |
+    |                                | coffee-script-source, execjs           |
+    |                                | actionpack, activesupport              |
+    |                                | method_source, rake, thor, actionview  |
+    |                                | rack, rack-test, rails-dom-testing     |
+    |                                | rails-html-sanitizer, erubi            |
+    |                                | concurrent-ruby, i18n, minitest        |
+    |                                | tzinfo, thread_safe, nokogiri          |
+    |                                | mini_portile2, loofah, crass, temple   |
+    |                                | tilt, kaminari-actionview              |
+    |                                | kaminari-activerecord, kaminari-core   |
+    |                                | activerecord, activemodel, arel        |
+    |                                | actioncable, actionmailer, activejob   |
+    |                                | activestorage, bundler                 |
+    |                                | sprockets-rails, nio4r                 |
+    |                                | websocket-driver, websocket-extensions |
+    |                                | mail, globalid, mini_mime, marcel      |
+    |                                | mimemagic, sprockets, sass             |
+    |             Unique to This (9) | font-awesome-rails, kaminari           |
+    |                                | nested_form, rack-pjax, remotipart     |
+    |                                | kaminari-actionview                    |
+    |                                | kaminari-activerecord, kaminari-core   |
+    |                                | bundler                                |
+    +--------------------------------|----------------------------------------+
+
+Removing the dep will only actually remove 9 gems. The rest are shared
+dependencies with other gems like rails. We can also omit trees we aren't going
+to remove (hi rails) by not following them:
 
     > bundle-stats show sass-rails --nofollow="railties,activesupport,actionpack"
     bundle-stats for sass-rails
 
-    depended upon by (2) | activeadmin, foundation-icons-sass-rails
-    depends on (10)      | railties, sass, sprockets, sprockets-rails, hike, multi_json, rack, tilt, actionpack, activesupport
-    unique to this (0)   |
+    +--------------------------------|----------------------------------------+
+    |           Depended Upon By (2) | compass-rails, rails_admin             |
+    |                 Depends On (9) | railties, sass, sprockets              |
+    |                                | sprockets-rails, tilt, concurrent-ruby |
+    |                                | rack, actionpack, activesupport        |
+    |             Unique to This (0) |                                        |
+    +--------------------------------|----------------------------------------+
 
 To consume information with a build job or somesuch, all commands can emit JSON:
 
     > bundle-stats show sass-rails --nofollow="railties,activesupport,actionpack" -f json
     {
       "name": "sass-rails",
-      "total_dependencies": 10,
-      "first_level_dependencies": 4,
+      "total_dependencies": 9,
+      "first_level_dependencies": 5,
       "top_level_dependencies": {
-        "activeadmin": "activeadmin (1.0.0.pre)",
-        "foundation-icons-sass-rails": "foundation-icons-sass-rails (3.0.0)"
+        "compass-rails": "compass-rails (3.1.0)",
+        "rails_admin": "rails_admin (1.3.0)"
       },
       "transitive_dependencies": [
-        "railties (< 5.0, >= 4.0.0)",
-        "sass (~> 3.2.0)",
-        "sprockets (<= 2.11.0, ~> 2.8)",
-        "sprockets-rails (~> 2.0)",
-        "hike (~> 1.2)",
-        "multi_json (~> 1.0)",
-        "rack (~> 1.0)",
-        "tilt (!= 1.3.0, ~> 1.1)",
-        "actionpack (>= 3.0)",
-        "activesupport (>= 3.0)"
+        "railties (< 6, >= 4.0.0)",
+        "sass (~> 3.1)",
+        "sprockets (< 4.0, >= 2.8)",
+        "sprockets-rails (< 4.0, >= 2.0)",
+        "tilt (< 3, >= 1.1)",
+        "concurrent-ruby (~> 1.0)",
+        "rack (< 3, > 1)",
+        "actionpack (>= 4.0)",
+        "activesupport (>= 4.0)"
       ],
       "potential_removals": [
 
@@ -119,12 +151,13 @@ Contribution is expected to conform to the [Contributor Covenant](https://github
 Credits
 -------
 
-Thanks to the many kind people at [RailsCamp East 2016](http://east.railscamp.com)
-for the help, the ideas, and the support.
+Thanks to the many kind people at [RailsCamp East
+2016](http://east.railscamp.com) for the help, the ideas, and the support.
 
-Thanks to Isaac Bowen for being pedantic about speeling.
+Also, many other folks for their feature / fix contributions. ❤️
 
 License
 -------
 
-This software is released under the [MIT License](https://github.com/jmmastey/bundler-stats/blob/master/MIT-LICENSE).
+This software is released under the [MIT
+License](https://github.com/jmmastey/bundler-stats/blob/master/MIT-LICENSE).

data/bin/bundle-stats

@@ -1,6 +1,5 @@
 #!/usr/bin/env ruby
 
-
 require 'rubygems'
 
 lib_dir = File.expand_path(File.join(File.dirname(__FILE__),'..','lib'))

data/bin/bundler-stats

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+
+load File.expand_path('../bundle-stats', __FILE__)

data/bundler-stats.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
   gem.licenses    = "MIT"
   gem.authors     = "Joseph Mastey"
   gem.email       = "jmmastey@gmail.com"
-  gem.homepage    = ""
+  gem.homepage    = "http://github.com/jmmastey/bundler-stats"
 
   gem.metadata    = {
     "homepage_uri" => "http://github.com/jmmastey/bundler-stats",
@@ -35,10 +35,12 @@ Gem::Specification.new do |gem|
 
   gem.require_paths = %w[ext lib].select { |dir| File.directory?(dir) }
 
-  gem.add_dependency "bundler", ">= 1.9"
-  gem.add_dependency "thor", "~> 0.19"
+  gem.add_dependency "bundler", ">= 1.9", "< 3"
+  gem.add_dependency "thor", ">= 0.19.0", "< 2.0"
 
   gem.add_development_dependency "rspec", "~> 3.4"
   gem.add_development_dependency "guard", "~> 2.13"
+  gem.add_development_dependency "guard-rspec", "< 5"
   gem.add_development_dependency "pry", "~> 0.10"
+  gem.add_development_dependency "rb-readline", "< 1"
 end

data/lib/bundler/stats/calculator.rb

@@ -64,7 +64,7 @@ module Bundler
         stats = @gemfile.map do |gem|
           @tree.summarize(gem.name)
         end
-        stats.sort_by { |row| row[:total_dependencies] }.reverse
+        stats.sort_by { |row| [row[:total_dependencies] * -1, row[:name]] }
       end
     end
   end

data/lib/bundler/stats/cli.rb

@@ -59,56 +59,65 @@ module Bundler
 
       private
 
-      # TODO: just install table_print, 'eh?
+      def self.exit_on_failure?
+        true
+      end
+
       def draw_stats(gem_stats, summary)
         max_name_length = gem_stats.map { |gem| gem[:name].length }.max
 
-        say "+-#{"-" * max_name_length}-|-----------------|-----------------+"
-        say "| %-#{max_name_length}s | Total Deps      | 1st Level Deps  |" % ["Name"]
-        say "+-#{"-" * max_name_length}-|-----------------|-----------------+"
-
-        gem_stats.each do |stat_line|
-          say "| %-#{max_name_length}s | %-15s | %-15s |" % [stat_line[:name], stat_line[:total_dependencies], stat_line[:first_level_dependencies]]
-        end
-        say "+-#{"-" * max_name_length}-|-----------------|-----------------+"
+        say Printer.new(
+          headers: ["Name", "Total Deps", "1st Level Deps"],
+          data: gem_stats.map { |stat_line|
+            [stat_line[:name], stat_line[:total_dependencies], stat_line[:first_level_dependencies]]
+        }).to_s
+
+        say Printer.new(
+          headers: nil,
+          borders: false,
+          data: [
+            ["Declared Gems",      summary[:declared]],
+            ["Total Gems",         summary[:total]],
+            ["", ""],
+            ["Unpinned Versions",  summary[:unpinned]],
+            ["Github Refs",        summary[:github]],
+        ]).to_s
         say ""
-        say "Declared Gems:     #{summary[:declared]}"
-        say "Total Gems:        #{summary[:total]}"
-        say ""
-        say "Unpinned Versions: #{summary[:unpinned]}"
-        say "Github Refs:       #{summary[:github]}"
       end
 
       def draw_show(stats, target)
         say "bundle-stats for #{target}"
         say ""
-        say "depended upon by (#{stats[:top_level_dependencies].count}) | #{stats[:top_level_dependencies].values.map(&:name).join(', ')}\n"
-        say "depends on (#{stats[:transitive_dependencies].count})      | #{stats[:transitive_dependencies].map(&:name).join(', ')}\n"
-        say "unique to this (#{stats[:potential_removals].count})   | #{stats[:potential_removals].map(&:name).join(', ')}\n"
-        say ""
+
+        say Printer.new(
+          data: [
+            ["Depended Upon By (#{stats[:top_level_dependencies].count})",  stats[:top_level_dependencies].values.map(&:name)],
+            ["Depends On (#{stats[:transitive_dependencies].count})",       stats[:transitive_dependencies].map(&:name)],
+            ["Unique to This (#{stats[:potential_removals].count})",        stats[:potential_removals].map(&:name)],
+        ]).to_s
       end
 
       def draw_versions(stats, target)
         dependers = stats[:top_level_dependencies] # they do the depending
         say "bundle-stats for #{target}"
-        say ""
-        say "Depended upon by #{stats[:top_level_dependencies].count}\n"
+        say Printer.new(
+          headers: nil,
+          borders: false,
+          data: [
+            ["Depended Upon By", stats[:top_level_dependencies].count],
+            ["Resolved Version", stats[:resolved_version]],
+        ]).to_s
 
-        if stats[:resolved_version]
-          say "Resolved version is #{stats[:resolved_version]}"
-        end
         if dependers.count > 0
-          max_name_length = dependers.map { |gem| gem[:name].length }.max
-
-          say "+-#{"-" * max_name_length}-|-------------------+"
-          say "| %-#{max_name_length}s | Required Version  |" % ["Name"]
-          say "+-#{"-" * max_name_length}-|-------------------+"
-          dependers.each do |stat_line|
-            say "| %-#{max_name_length}s | %-17s |" % [stat_line[:name], stat_line[:version]]
-          end
-          say "+-#{"-" * max_name_length}-|-------------------+"
           say ""
+          say Printer.new(
+            headers: ["Name", "Required Version"],
+            data: dependers.map { |stat_line|
+              [stat_line[:name], stat_line[:version]]
+          }).to_s
         end
+
+        say ""
       end
 
       def build_calculator(options)
@@ -124,19 +133,23 @@ module Bundler
       def gemfile_path
         cwd = Pathname.new("./")
         until cwd.realdirpath.root? do
-          return (cwd + "Gemfile") if File.exist?(cwd + "Gemfile")
+          %w(gems.rb Gemfile).each do |gemfile|
+            return (cwd + gemfile) if File.exist?(cwd + gemfile)
+          end
           cwd = cwd.parent
         end
-        raise ArgumentError, "Couldn't find Gemfile in this directory or parents"
+        raise ArgumentError, "Couldn't find gems.rb nor Gemfile in this directory or parents"
       end
 
       def lockfile_path
         cwd = Pathname.new(".")
         until cwd.realdirpath.root? do
-          return (cwd + "Gemfile.lock") if File.exist?(cwd + "Gemfile.lock")
+          %w(gems.locked Gemfile.lock).each do |lockfile|
+            return (cwd + lockfile) if File.exist?(cwd + lockfile)
+          end
           cwd = cwd.parent
         end
-        raise ArgumentError, "Couldn't find Gemfile in this directory or parents"
+        raise ArgumentError, "Couldn't find gems.locked nor Gemfile.lock in this directory or parents"
       end
     end
   end

data/lib/bundler/stats/printer.rb

@@ -0,0 +1,143 @@
+# this is somewhat duplicative of the table_print gem, but tbh I like that we
+# don't have many dependencies yet, so I'd rather keep it this way.
+class Bundler::Stats::Printer
+  attr_accessor :headers, :data, :borders
+
+  MIN_COL_SIZE = 10
+
+  BORDERS = {
+    on: { corner: "+", horizontal: "-", vertical: "|" },
+    off: { corner: " ", horizontal: " ", vertical: " " },
+  }
+
+  def initialize(headers: nil, data: [], borders: true)
+    @headers  = headers
+    @data     = data
+    @borders  = borders ? BORDERS[:on] : BORDERS[:off]
+  end
+
+  def to_s
+    table_data = ([headers] + data).compact
+    col_widths = column_widths(table_data)
+
+    lines = []
+    lines << separator_row(col_widths)
+
+    if headers
+      lines << aligned_row(headers, col_widths)
+      lines << separator_row(col_widths)
+    end
+
+    data.each do |row|
+      lines += split_rows(row, col_widths)
+    end
+    lines << separator_row(col_widths)
+
+    lines.join("\n")
+  end
+
+  def terminal_width
+    Integer(Kernel.send(:"`", "tput cols"))
+  rescue StandardError
+    80
+  end
+
+  def column_widths(table_data)
+    num_cols  = table_data.first.length
+    chrome    = 2 + 2 + (num_cols - 1) * 3
+
+    # doesn't fit at all
+    if chrome + (num_cols * MIN_COL_SIZE) > terminal_width
+      raise ArgumentError, "Table smooshed. Refusing to print table."
+    end
+
+    data_widths = 0.upto(num_cols - 1).map do |idx|
+      max_width(table_data.map { |row| row[idx] })
+    end
+
+    # fits comfortably
+    if data_widths.inject(&:+) + chrome < terminal_width
+      return data_widths
+    end
+
+    free_space = terminal_width
+    free_space -= chrome
+    free_space -= MIN_COL_SIZE * num_cols
+
+    # fit uncomfortably
+    widths = [MIN_COL_SIZE] * num_cols
+    data_widths.each_with_index do |width, idx|
+      next unless width > widths[idx]
+
+      allocated = [width, free_space].min
+
+      if allocated > 0
+        widths[idx] += allocated
+        free_space  -= allocated
+      end
+    end
+
+    widths
+  end
+
+  private
+
+  def max_width(data)
+    data.map do |value|
+      Array(value).join(", ").length
+    end.max
+  end
+
+  def separator_row(col_widths)
+    sep = "#{borders[:horizontal]}#{borders[:vertical]}#{borders[:horizontal]}"
+
+    "#{borders[:corner]}#{borders[:horizontal]}" +
+      col_widths.map { |width| borders[:horizontal] * width }.join(sep) +
+      "#{borders[:horizontal]}#{borders[:corner]}"
+  end
+
+  def split_rows(row, col_widths)
+    return [] unless row.find { |v| v && v.length > 0 }
+
+    rows_with_splits = [row]
+    next_row = []
+
+    joined_data = row.each_with_index.map do |val, idx|
+      words         = Array(val).map(&:to_s)
+      target_width  = col_widths[idx]
+
+      (cell, remainder) = row_and_remainder(words, target_width)
+
+      next_row[idx] = remainder
+      cell
+    end
+
+    ([aligned_row(joined_data, col_widths)] +
+      split_rows(next_row, col_widths)).compact
+  end
+
+  def row_and_remainder(words, target_width)
+    if(words.join(", ").length < target_width)
+      return [words.join(", "), nil]
+    end
+
+    this_row = []
+    while words.length > 0 && (this_row.join(", ").length + words[0].length) <= target_width
+      this_row << words.shift
+    end
+
+    [this_row.join(", "), words]
+  end
+
+  def aligned_row(row, col_widths)
+    aligned_values = row.each_with_index.map do |data, idx|
+      if idx == 0
+        data.rjust(col_widths[idx])
+      else
+        data.ljust(col_widths[idx])
+      end
+    end
+
+    "#{borders[:vertical]} " + aligned_values.join(" #{borders[:vertical]} ") + " #{borders[:vertical]}"
+  end
+end

data/lib/bundler/stats/version.rb

@@ -1,5 +1,5 @@
 module Bundler
   module Stats
-    VERSION = '1.3.4'
+    VERSION = '2.2.0'
   end
 end

data/lib/bundler/stats.rb

@@ -1,4 +1,5 @@
-require_relative 'stats/version'
-require_relative 'stats/tree'
-require_relative 'stats/remover'
 require_relative 'stats/calculator'
+require_relative 'stats/printer'
+require_relative 'stats/remover'
+require_relative 'stats/tree'
+require_relative 'stats/version'

data/spec/lib/bundler/stats/calculator_spec.rb

@@ -1,5 +1,4 @@
-require 'bundler'
-require 'bundler/stats'
+require 'spec_helper'
 
 describe Bundler::Stats::Calculator do
   subject { described_class }
@@ -77,6 +76,16 @@ describe Bundler::Stats::Calculator do
   end
 
   context "#gem_stats" do
+    let(:partial_sorted_result) do
+      [
+        ["rolify", 0],
+        ["rubocop-rspec", 0],
+        ["spring", 0],
+        ["state_machine", 0],
+        ["will_paginate", 0]
+      ]
+    end
+
     it "includes entries for each gem" do
       calculator = subject.new(gemfile_path, lockfile_path)
 
@@ -85,6 +94,14 @@ describe Bundler::Stats::Calculator do
       expect(target).to be_a(Array)
       expect(target.length).to eq(calculator.gemfile.length)
     end
+
+    it "sorts entries by total dependencies descending and name ascending" do
+      calculator = subject.new(gemfile_path, lockfile_path)
+
+      target = calculator.gem_stats
+      tuple = target.map {|x| [x[:name], x[:total_dependencies]] }
+      expect(tuple).to end_with(*partial_sorted_result)
+    end
   end
 
   context "#summary" do

data/spec/lib/bundler/stats/printer_spec.rb

@@ -0,0 +1,224 @@
+require 'spec_helper'
+
+describe Bundler::Stats::Printer do
+  subject { described_class }
+
+  def set_term_width(width)
+    allow(Kernel).to receive(:"`").and_return(width)
+  end
+
+  describe "#terminal_width" do
+    context "*nix systems" do
+      it "return the kernel width" do
+        set_term_width(180)
+
+        printer   = subject.new
+        response  = printer.terminal_width
+
+        expect(response).to eq(180)
+      end
+    end
+
+    context "non-*nix systems" do
+      it "always returns a small number" do
+        set_term_width(nil)
+
+        printer   = subject.new
+        response  = printer.terminal_width
+
+        expect(response).to eq(80)
+      end
+    end
+
+    context "tput returns an error" do
+      it "returns the default value" do
+        allow(Kernel).to receive(:send).and_return("tput: No value for $TERM and no -T specified")
+
+        printer   = subject.new
+        response  = printer.terminal_width
+
+        expect(response).to eq(80)
+      end
+    end
+  end
+
+  describe "#column_widths" do
+    it "comfortably prints tables of comfortable data" do
+        set_term_width(80)
+        printer     = subject.new
+        table_data  = [
+          [ "name", "data" ],
+          [ "*" * 10, "*" * 20 ],
+        ]
+
+        widths = printer.column_widths(table_data)
+
+        expect(widths).to eq([10, 20])
+    end
+
+    it "smooshes uncomfortably long data" do
+        set_term_width(60)
+        printer     = subject.new
+        table_data  = [
+          [ "name", "data" ],
+          [ "*" * 10, "*" * 60 ],
+        ]
+
+        widths = printer.column_widths(table_data)
+
+        target_widths = [10, 43] # 7 for gutters
+        expect(widths).to eq(target_widths)
+    end
+
+    it "always allows some amount of space for data" do
+        set_term_width(60)
+        printer     = subject.new
+        table_data  = [
+          [ "name", "data1", "data2", "data3" ],
+          [ "*" * 10, "*" * 60, "*" * 60, "*" * 60 ],
+        ]
+
+        widths = printer.column_widths(table_data)
+
+        target_widths = [10, 17, 10, 10] # 13 for gutters
+        expect(widths).to eq(target_widths)
+    end
+
+    it "bails if it can't handle that data" do
+        set_term_width(10)
+        printer     = subject.new
+        table_data  = [
+          [ "name", "data" ],
+          [ "*" * 10, "*" * 20 ],
+        ]
+
+        expect {
+          printer.column_widths(table_data)
+        }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe "#to_s" do
+    it "prints a pretty table" do
+      set_term_width(80)
+      printer = subject.new(headers: ["stars", "stripes"],
+                            data: [["*****", "*****"]]
+                           )
+
+      output  = printer.to_s
+      table   = <<-TABLE
++-------|---------+
+| stars | stripes |
++-------|---------+
+| ***** | *****   |
++-------|---------+
+      TABLE
+
+      expect(output).to eq(table.chomp)
+    end
+
+    it "deals with data alignment" do
+      set_term_width(80)
+      printer = subject.new(headers: ["name", "value"],
+                            data: [
+                              ["one", "*****"],
+                              ["seventeen", "///////////////"]
+                            ])
+
+      output  = printer.to_s
+      table   = <<-TABLE
++-----------|-----------------+
+|      name | value           |
++-----------|-----------------+
+|       one | *****           |
+| seventeen | /////////////// |
++-----------|-----------------+
+      TABLE
+
+      expect(output).to eq(table.chomp)
+    end
+
+    it "wraps data as necessary" do
+      set_term_width(35)
+      printer = subject.new(headers: ["name", "value"],
+                            data: [
+                              ["words", ["one", "two", "three", "four", "five"]],
+                            ])
+
+      output  = printer.to_s
+      table   = <<-TABLE
++------------|--------------------+
+|       name | value              |
++------------|--------------------+
+|      words | one, two, three    |
+|            | four, five         |
++------------|--------------------+
+      TABLE
+
+      expect(output).to eq(table.chomp)
+    end
+
+    it "can wrap multiple columns" do
+      set_term_width(45)
+      printer = subject.new(headers: ["name", "value", "other value"],
+                            data: [
+                              [ "words",
+                               ["one", "two", "three", "four", "five"],
+                               ["six", "seven", "eight", "nine", "ten"],
+                              ]
+                            ])
+
+      output  = printer.to_s
+      table   = <<-TABLE
++------------|-----------------|------------+
+|       name | value           | other value |
++------------|-----------------|------------+
+|      words | one, two, three | six, seven |
+|            | four, five      | eight, nine |
+|            |                 | ten        |
++------------|-----------------|------------+
+      TABLE
+
+      expect(output).to eq(table.chomp)
+    end
+
+    it "can print without a header" do
+      set_term_width(80)
+      printer = subject.new(headers: nil,
+                            data: [
+                              ["*****", "********"],
+                              ["++++++++", "+++++"],
+                            ])
+
+      output  = printer.to_s
+      table   = <<-TABLE
++----------|----------+
+|    ***** | ******** |
+| ++++++++ | +++++    |
++----------|----------+
+      TABLE
+
+      expect(output).to eq(table.chomp)
+    end
+
+    it "can print without separators at all!" do
+      set_term_width(80)
+      printer = subject.new(headers: nil,
+                            borders: false,
+                            data: [
+                              ["*****", "********"],
+                              ["++++++++", "+++++"],
+                            ])
+
+      output  = printer.to_s
+      table   = <<-TABLE
+                       
+     *****   ********  
+  ++++++++   +++++     
+                       
+      TABLE
+
+      expect(output).to eq(table.chomp)
+    end
+  end
+end

data/spec/lib/bundler/stats/remover_spec.rb

@@ -1,5 +1,4 @@
-require 'bundler'
-require 'bundler/stats'
+require 'spec_helper'
 
 LazyLazySpec = Struct.new(:name, :dependencies)
 FakeLockfileParser = Struct.new(:specs)

data/spec/lib/bundler/stats/tree_spec.rb

@@ -1,5 +1,4 @@
-require 'bundler'
-require 'bundler/stats'
+require 'spec_helper'
 
 describe Bundler::Stats::Tree do
   subject { described_class }

data/spec/spec_helper.rb

@@ -0,0 +1,11 @@
+require 'bundler'
+require 'bundler/stats'
+
+RSpec.configure do |config|
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bundler-stats
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 2.2.0
 platform: ruby
 authors:
 - Joseph Mastey
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-18 00:00:00.000000000 Z
+date: 2022-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -17,6 +17,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.9'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,20 +27,29 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.9'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: 0.19.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: 0.19.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +78,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.13'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +106,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
+- !ruby/object:Gem::Dependency
+  name: rb-readline
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
 description: Looks through your lockfile and tries to identify problematic use of
   dependencies
 email: jmmastey@gmail.com
@@ -92,8 +132,10 @@ extra_rdoc_files:
 - CODE_OF_CONDUCT.md
 - README.md
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rspec"
+- ".ruby-version"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -106,22 +148,25 @@ files:
 - lib/bundler/stats.rb
 - lib/bundler/stats/calculator.rb
 - lib/bundler/stats/cli.rb
+- lib/bundler/stats/printer.rb
 - lib/bundler/stats/remover.rb
 - lib/bundler/stats/tree.rb
 - lib/bundler/stats/version.rb
 - spec/lib/bundler/stats/calculator_spec.rb
+- spec/lib/bundler/stats/printer_spec.rb
 - spec/lib/bundler/stats/remover_spec.rb
 - spec/lib/bundler/stats/tree_spec.rb
+- spec/spec_helper.rb
 - spec/test_gemfile
 - spec/test_gemfile.lock
-homepage: ''
+homepage: http://github.com/jmmastey/bundler-stats
 licenses:
 - MIT
 metadata:
   homepage_uri: http://github.com/jmmastey/bundler-stats
   changelog_uri: https://github.com/jmmastey/bundler-stats/blob/master/CHANGELOG.md
   source_code_uri: http://github.com/jmmastey/bundler-stats
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -136,9 +181,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2.3
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Dependency investigation for Bundler
 test_files: []

data/.travis.yml

@@ -1,6 +0,0 @@
-language: ruby
-script: bundle exec rspec
-rvm:
- - 2.3
- - 2.4
- - 2.5

data/bin/bundler-stats

@@ -1 +0,0 @@
-bundle-stats