bundler-source-aws-s3 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4d5919d913b511b4bd0cc2bbc5cb08bed308eb5ccc10d8790d094c107eb88e1
-  data.tar.gz: 120ca809b0c776de957420b09c6ce851d3cd1b02f67ab0fd66c0ca8f122c9c81
+  metadata.gz: b9108559ce8bed82c1fb1a00a68aa3bd2d774da2fe14ac3b3dbfeb848e58127a
+  data.tar.gz: de681ec7243bac4cda46e035a77dd0e42a0f6b03fe69c2dd01ca6fd9f5928d33
 SHA512:
-  metadata.gz: 458a8571991308cc317c652a6aabeebf37eaaa58572ee2e6829135dd369ca653419fb6138574258cdf9da47f272996750c714d8301915a68c625ef421a044b5a
-  data.tar.gz: ff95b41d255ce9e9a8e691c0778f15e2b32c5bda6daa6829ab5bdaf47f1159e4753cd8f2956233ab329d687ad0ab6f5cc2dbc297bc1ca96248a89a72bdf1de9a
+  metadata.gz: b259dbc6a4dabac784bf002b44f42f6326b3103a24f97517db085d2c434bb1190af6bfc1ba443add24e1591946eddcbd54d61d68ab4369c352d35166cfc4726d
+  data.tar.gz: f5a2e7271c218d303844975265e56d92e41c354632f06ac845eaa362d19514e9511b9411f68aa591961bf3e6d2afaa6b2a9a2bed579ebc4f7d9dcf13a07e8027

data/README.md

@@ -29,13 +29,35 @@ etc) to be able to run that command.
 In your Gemfile, add a source like this:
 
 ```ruby
-source('s3://my-bucket/gems', type: 'aws-s3') do
+source 's3://my-bucket/gems', type: 'aws-s3' do
   gem 'my-cool-gem'
 end
 ```
 
-When Bundler sees the `type: 'aws-s3'` it will automatically install and use
-this plugin to install gems from your s3 source.
+Bundler will infer that this gem is the plugin for the 'aws-s3' type and fetch
+and install it automatically.
+
+For libraries, it can be normal to declare your dependencies in your gemspec
+file. In those cases, your Gemfile will normall be mostly empty. You can still
+use your s3 sourced gems in your gemspec if you add the plugin and source to
+your Gemfile. For example:
+
+```ruby
+# In your gemspec you might have some dependencies like:
+
+spec.add_development_dependency 'private-gem-in-my-s3'
+spec.add_dependency 'another-private-gem-in-s3'
+
+# And, your Gemfile would contain:
+
+source 'https://rubygems.org'
+source 's3://my-super-private-bucket-of-gems', type: 'aws-s3' do
+  # It's okay to leave this empty. Unfortunately, bundler currently requires
+  # the block for sources which have a `type`.
+end
+
+gemspec
+```
 
 ## Development
 

data/plugins.rb

@@ -49,7 +49,7 @@ class BundlerSourceAwsS3 < Bundler::Plugin::API
     end
 
     def remote?
-      @remote
+      @remote ||= false
     end
 
     # TODO What is bundler telling us if unlock! is called?
@@ -80,7 +80,7 @@ class BundlerSourceAwsS3 < Bundler::Plugin::API
     end
 
     # We will use this value as the given spec's loaded_from. It should be the
-    # path fo the installed gem's gemspec.
+    # path of the installed gem's gemspec.
     def loaded_from_for(spec)
       destination = install_path.join(spec.full_name)
       destination.join("#{spec.full_name}.gemspec").to_s
@@ -110,9 +110,9 @@ class BundlerSourceAwsS3 < Bundler::Plugin::API
 
       Bundler.mkdir_p(s3_gems_path)
 
-      output, status = Open3.capture2e(sync_cmd)
-
-      @pull = status.success?
+      unless @pull = system(sync_cmd)
+        raise "[aws-s3] #{sync_cmd.inspect} failed."
+      end
     end
 
     # Produces a list of Gem::Package for the s3 gems.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bundler-source-aws-s3
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Eric K Idema
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-29 00:00:00.000000000 Z
+date: 2019-06-30 00:00:00.000000000 Z
 dependencies: []
 description: Add aws-s3 source to bundler via plugin.
 email: