bundler-multilock 1.3.0 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4143c13ccc6c8b7ef05ce4372cd1e77b293b3b55c8c1eafbb478e87ce195ae4f
-  data.tar.gz: 4e5ea6d45852f02823c578b3ad78eb95109f16dbbf4d2652cc2dc3f9addb1330
+  metadata.gz: 7796ee7b54f841aa9c6d127e05f878a1045078c94e842f04bf4e4f0ebb09ac1d
+  data.tar.gz: f1a35917e5fcfdf2eab572b4052d14766506e13253130c373114779d4598420e
 SHA512:
-  metadata.gz: 8c45ae78248dcee0436eadde12ed749fc81112a514d43454998b1c4c238164060998713477f2689db433a753d652a6d419d45fa19650ec612f4ff0933ce82242
-  data.tar.gz: ff5e788cb22be790791b2f99d9abcd2fb7d1da717954fd7fd5644fd06274d12b0e7d98e01b917a3247e47ab08856ae9f994b99ed74f9d257972adc636c4ac3f4
+  metadata.gz: e1b5840035aab37b5a54bcb289649c40e6dd9451aff3d5858d45faea4750452381e7af904ac7c96146edd595e173143db07c827aa4f590701a513ac9e426979a
+  data.tar.gz: 9abece5b78beb3c5005a96577bf714ca3477865a4bfa897899628a2fd7556596f0697b2cef5cd530866079483e01c5aa46d1511a69343c3229fcebe7fe65acd4

data/lib/bundler/multilock/cache.rb

@@ -57,11 +57,27 @@ module Bundler
       end
 
       def specs(lockfile_name)
-        @specs[lockfile_name] ||= parser(lockfile_name).specs.to_h do |spec|
-          [[spec.name, spec.platform], spec]
+        @specs[lockfile_name] ||= begin
+          specs = {}
+          parser(lockfile_name).specs.each do |spec|
+            (specs[spec.name] ||= {})[spec.platform] = spec
+          end
+          specs
         end
       end
 
+      # sometimes a gem changes platforms with a new version, such as from aarch64-linux
+      # to aarch64-linux-gnu. we need to still sync it
+      def find_matching_spec(specs, spec)
+        specs = self.specs(specs) unless specs.is_a?(Hash)
+        platform_specs = specs[spec.name]
+        return unless platform_specs
+
+        parent_spec = platform_specs[spec.platform]
+        parent_spec ||= platform_specs.find { |platform, _| platform =~ spec.platform }&.last
+        parent_spec || platform_specs.find { |platform, _| platform == "ruby" }&.last
+      end
+
       # @param lockfile_name [Pathname]
       # @return [Hash<String, Set<String>>] hash of gem name to set of gem names that depend on it
       def reverse_dependencies(lockfile_name)

data/lib/bundler/multilock/check.rb

@@ -88,7 +88,7 @@ module Bundler
 
       # this checks for mismatches between the parent lockfile and the given lockfile,
       # and for pinned dependencies in lockfiles requiring them
-      def deep_check(lockfile_definition)
+      def deep_check(lockfile_definition, conflicts: nil)
         lockfile_name = lockfile_definition[:lockfile]
         @cache.deep_check(lockfile_name) do
           success = true
@@ -120,7 +120,7 @@ module Bundler
 
           # check for conflicting requirements (and build list of pins, in the same loop)
           parser.specs.each do |spec|
-            parent_spec = @cache.specs(parent_lockfile_name)[[spec.name, spec.platform]]
+            parent_spec = @cache.find_matching_spec(parent_lockfile_name, spec)
 
             if lockfile_definition[:enforce_pinned_additional_dependencies]
               # look through what this spec depends on, and keep track of all pinned requirements
@@ -156,6 +156,7 @@ module Bundler
                              "does not match the parent lockfile's version " \
                              "(@#{parent_spec.version}#{parent_spec.git_version}); " \
                              "this may be due to a conflicting requirement, which would require manual resolution.")
+            conflicts&.add(spec.name)
             success = false
           end
 

data/lib/bundler/multilock/ext/cli.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Bundler
+  module Multilock
+    module Ext
+      module CLI
+        module ClassMethods
+          def instance
+            return @instance if instance_variable_defined?(:@instance)
+
+            # this is a little icky, but there's no other way to determine which command was run
+            @instance = ObjectSpace.each_object(::Bundler::CLI).first
+          end
+        end
+
+        ::Bundler::CLI.extend(ClassMethods)
+      end
+    end
+  end
+end

data/lib/bundler/multilock/ext/dsl.rb

@@ -20,7 +20,8 @@ module Bundler
             builder = new
             builder.eval_gemfile(gemfile, &Multilock.prepare_block) if Multilock.prepare_block
             builder.eval_gemfile(gemfile)
-            if (ruby_version_requirement = builder.instance_variable_get(:@ruby_version))
+            if (ruby_version_requirement = builder.instance_variable_get(:@ruby_version)) &&
+               Multilock.lockfile_definitions[lockfile]
               Multilock.lockfile_definitions[lockfile][:ruby_version_requirement] = ruby_version_requirement
             elsif (parent_lockfile = Multilock.lockfile_definitions.dig(lockfile, :parent)) &&
                   (parent_lockfile_definition = Multilock.lockfile_definitions[parent_lockfile]) &&

data/lib/bundler/multilock/lockfile_generator.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "delegate"
+
 require "bundler/lockfile_generator"
 
 module Bundler

data/lib/bundler/multilock/version.rb

@@ -2,6 +2,6 @@
 
 module Bundler
   module Multilock
-    VERSION = "1.3.0"
+    VERSION = "1.3.2"
   end
 end

data/lib/bundler/multilock.rb

@@ -82,17 +82,13 @@ module Bundler
           enforce_pinned_additional_dependencies: enforce_pinned_additional_dependencies
         })
 
-        if (defined?(CLI::Check) ||
-            defined?(CLI::Install) ||
-            defined?(CLI::Lock) ||
-            defined?(CLI::Update)) &&
-           !defined?(CLI::Cache) && !env_lockfile
+        # If they're using BUNDLE_LOCKFILE, then they really do want to
+        # use a particular lockfile, and it overrides whatever they
+        # dynamically set in their gemfile
+        if !env_lockfile && defined?(CLI) &&
+           %i[check install lock update].include?(CLI.instance&.current_command_chain&.first)
           # always use Gemfile.lock for `bundle check`, `bundle install`,
-          # `bundle lock`, and `bundle update`. `bundle cache` delegates to
-          # `bundle install`, but we want that to run as normal.
-          # If they're using BUNDLE_LOCKFILE, then they really do want to
-          # use a particular lockfile, and it overrides whatever they
-          # dynamically set in their gemfile
+          # `bundle lock`, and `bundle update`.
           active = lockfile == Bundler.default_lockfile(force_original: true)
         end
 
@@ -179,10 +175,11 @@ module Bundler
 
             # already up to date?
             up_to_date = false
+            conflicts = Set.new
             Bundler.settings.temporary(frozen: true) do
               Bundler.ui.silence do
                 up_to_date = checker.base_check(lockfile_definition, check_missing_deps: true) &&
-                             checker.deep_check(lockfile_definition)
+                             checker.deep_check(lockfile_definition, conflicts: conflicts)
               end
             end
             if up_to_date
@@ -206,7 +203,6 @@ module Bundler
               Bundler.ui.info("Syncing to #{relative_lockfile}...") if attempts == 1
               synced_any = true
 
-              specs = lockfile_name.exist? ? cache.specs(lockfile_name) : {}
               parent_lockfile_name = lockfile_definition[:parent]
               parent_root = parent_lockfile_name.dirname
               parent_specs = cache.specs(parent_lockfile_name)
@@ -222,7 +218,7 @@ module Bundler
                 end
 
               # add a source for the current gem
-              gem_spec = parent_specs[[File.basename(Bundler.root), "ruby"]]
+              gem_spec = parent_specs.dig(File.basename(Bundler.root), "ruby")
 
               if gem_spec
                 adjusted_parent_lockfile_contents += <<~TEXT
@@ -252,32 +248,22 @@ module Bundler
                   next :self if parent_spec.nil?
                   next spec_precedences[spec.name] if spec_precedences.key?(spec.name)
 
-                  precedence = :self if cache.conflicting_requirements?(lockfile_name,
-                                                                        parent_lockfile_name,
-                                                                        spec,
-                                                                        parent_spec)
-
-                  # look through all reverse dependencies; if any of them say it
-                  # has to come from self, due to conflicts, then this gem has
-                  # to come from self as well
-                  [cache.reverse_dependencies(lockfile_name),
-                   cache.reverse_dependencies(parent_lockfile_name)].each do |reverse_dependencies|
-                    break if precedence == :self
-
-                    reverse_dependencies[spec.name].each do |dep_name|
-                      precedence = check_precedence.call(specs[dep_name], parent_specs[dep_name])
-                      break if precedence == :self
-                    end
-                  end
+                  precedence = if !(cache.reverse_dependencies(lockfile_name)[spec.name] & conflicts).empty?
+                                 :parent
+                               elsif cache.conflicting_requirements?(lockfile_name,
+                                                                     parent_lockfile_name,
+                                                                     spec,
+                                                                     parent_spec)
+                                 :self
+                               end
 
                   spec_precedences[spec.name] = precedence || :parent
                 end
 
                 # replace any duplicate specs with what's in the parent lockfile
                 lockfile.specs.map! do |spec|
-                  parent_spec = parent_specs[[spec.name, spec.platform]]
+                  parent_spec = cache.find_matching_spec(parent_specs, spec)
                   next spec unless parent_spec
-
                   next spec if check_precedence.call(spec, parent_spec) == :self
 
                   dependency_changes ||= spec != parent_spec
@@ -577,25 +563,29 @@ end
 Bundler::LazySpecification.include(Bundler::MatchMetadata) if defined?(Bundler::MatchMetadata)
 Bundler::Multilock.inject_preamble unless Bundler::Multilock.loaded?
 
-# this is terrible, but we can't prepend into these modules because we only load
-# _inside_ of the CLI commands already running
-if defined?(Bundler::CLI::Check)
-  require_relative "multilock/check"
-  at_exit do
-    next unless $!.nil?
-    next if $!.is_a?(SystemExit) && !$!.success?
+if defined?(Bundler::CLI)
+  require_relative "multilock/ext/cli"
+
+  # this is terrible, but we can't prepend into these modules because we only load
+  # _inside_ of the CLI commands already running
+  if Bundler::CLI.instance&.current_command_chain&.first == :check
+    require_relative "multilock/check"
+    at_exit do
+      next unless $!.nil?
+      next if $!.is_a?(SystemExit) && !$!.success?
 
-    next if Bundler::Multilock::Check.run
+      next if Bundler::Multilock::Check.run
 
-    Bundler.ui.warn("You can attempt to fix by running `bundle install`")
-    exit 1
+      Bundler.ui.warn("You can attempt to fix by running `bundle install`")
+      exit 1
+    end
   end
-end
-if defined?(Bundler::CLI::Lock)
-  at_exit do
-    next unless $!.nil?
-    next if $!.is_a?(SystemExit) && !$!.success?
+  if Bundler::CLI.instance&.current_command_chain&.first == :lock
+    at_exit do
+      next unless $!.nil?
+      next if $!.is_a?(SystemExit) && !$!.success?
 
-    Bundler::Multilock.after_install_all(install: false)
+      Bundler::Multilock.after_install_all(install: false)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bundler-multilock
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.2
 platform: ruby
 authors:
 - Instructure
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-29 00:00:00.000000000 Z
+date: 2024-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -82,6 +82,7 @@ files:
 - lib/bundler/multilock/cache.rb
 - lib/bundler/multilock/check.rb
 - lib/bundler/multilock/ext/bundler.rb
+- lib/bundler/multilock/ext/cli.rb
 - lib/bundler/multilock/ext/definition.rb
 - lib/bundler/multilock/ext/dsl.rb
 - lib/bundler/multilock/ext/plugin.rb
@@ -113,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.7
+rubygems_version: 3.5.10
 signing_key: 
 specification_version: 4
 summary: Support Multiple Lockfiles