bundlegem 1.1.1 → 1.2.0.pre.rc.2

data/lib/bundlegem/cli/gem.rb

@@ -1,8 +1,11 @@
 require 'pathname'
 require 'yaml'
+require 'erb'
 
-module Bundlegem
-  class CLI::Gem
+$TRACE = false
+
+module Bundlegem::CLI
+  class Gem
     attr_reader :options, :gem_name, :name, :target
 
     def initialize(options, gem_name)
@@ -11,14 +14,15 @@ module Bundlegem
 
       @name = @gem_name
       @target = Pathname.pwd.join(gem_name)
-      @template_src = TemplateManager.get_template_src(options)
+      @template_src = ::Bundlegem::TemplateManager.get_template_src(options)
 
       @tconf = load_template_configs
 
-      validate_ext_name if options[:ext]
+      validate_ext_name if options[:ext] # FIXME: Useless now?
     end
 
     def build_interpolation_config
+      title = name.tr('-', '_').split('_').map(&:capitalize).join(" ")
       pascal_name = name.tr('-', '_').split('_').map(&:capitalize).join
       unprefixed_name = name.sub(/^#{@tconf[:prefix]}/, '')
       underscored_name = name.tr('-', '_')
@@ -28,7 +32,7 @@ module Bundlegem
       git_user_name = `git config user.name`.chomp
       git_user_email = `git config user.email`.chomp
 
-      # domain = provider.com
+      # git_repo_domain = provider.com
       git_repo_domain = `git config user.repo-domain`.chomp
 
       if git_repo_domain.empty?
@@ -38,18 +42,19 @@ module Bundlegem
       if git_user_name.empty?
         raise "git config user.name didn't return a value.  Please double check your username configurations in ~/.gitconfig"
       else
-        # path = provider.com/user/name
+        # git_repo_path = provider.com/user/name
         git_repo_path = "#{git_repo_domain}/#{git_user_name}/#{name}".downcase # downcasing for languages like go that are creative
       end
 
-      # url = https://provider.com/user/name
+      # git_repo_url = https://provider.com/user/name
       git_repo_url = "https://#{git_repo_domain}/#{git_user_name}/#{name}"
 
       config = {
         :name             => name,
+        :title            => title,
         :unprefixed_name  => unprefixed_name,
-        :unprefixed_pascal=> unprefixed_name.tr('-', '_').split('_').map(&:capitalize).join,
-        :underscored_name => underscored_name,
+        unprefixed_pascal: unprefixed_name.tr('-', '_').split('_').map(&:capitalize).join,
+        underscored_name:  underscored_name,
         :pascal_name      => pascal_name,
         :camel_name       => pascal_name.sub(/^./, &:downcase),
         :screamcase_name  => name.tr('-', '_').upcase,
@@ -62,10 +67,10 @@ module Bundlegem
         :git_repo_domain  => git_repo_domain,
         :git_repo_url     => git_repo_url,
         :git_repo_path    => git_repo_path,
-        :template         => options[:template],
-        :test             => options[:test],
-        :ext              => options[:ext],
-        :bin              => options[:bin],
+        :template         => @options[:template],
+        :test             => @options[:test],
+        :ext              => @options[:ext],
+        :bin              => @options[:bin],
         :bundler_version  => bundler_dependency_version
       }
     end
@@ -75,16 +80,24 @@ module Bundlegem
     end
 
     def run
+      puts "Beginning run" if $TRACE
       raise_project_with_that_name_already_exists! if File.exist?(target)
 
+      puts "ensure_safe_gem_name" if $TRACE
       ensure_safe_gem_name(name, config[:constant_array])
 
       template_src = match_template_src
-      template_directories = dynamically_generate_template_directories
+
+      puts "dynamically_generate_template_directories" if $TRACE
+      time_it("dynamically_generate_template_directories") do
+        @template_directories = dynamically_generate_template_directories
+      end
+
+      puts "dynamically_generate_templates_files" if $TRACE
       templates = dynamically_generate_templates_files
 
       puts "Creating new project folder '#{name}'\n\n"
-      create_template_directories(template_directories, target)
+      create_template_directories(@template_directories, target)
 
       templates.each do |src, dst|
         template("#{template_src}/#{src}", target.join(dst), config)
@@ -95,9 +108,10 @@ module Bundlegem
 
       if @tconf[:bootstrap_command]
         puts "Executing bootstrap_command"
-        puts @tconf[:bootstrap_command]
+        cmd = safe_gsub_template_variables(@tconf[:bootstrap_command])
+        puts cmd
         Dir.chdir(target) do
-          `#{@tconf[:bootstrap_command]}`
+          `#{cmd}`
         end
       end
 
@@ -106,6 +120,10 @@ module Bundlegem
 
     private
 
+    def safe_gsub_template_variables(user_string)
+      user_string.gsub(/\#{\s*config\[\s*:(\w+)\s*\]\s*}/) { |m| config[$1.to_sym] }
+    end
+
     # TODO: Extract these notes to the docs or delete them
     # The language and purpose configurations of the bundlegem.yml file
     # can be used to make sure when you create a folder named
@@ -136,53 +154,39 @@ module Bundlegem
     end
 
     # Returns a hash of source directory names and their destination mappings
+    # This might not be needed???
     def dynamically_generate_template_directories
-      template_dirs = {}
-      Dir.glob("#{@template_src}/**/*", File::FNM_DOTMATCH).each do |f|
-        next if f == "#{@template_src}/." || f == "#{@template_src}/.."
-        next unless File.directory? f
+      template_dirs = Dir.glob("#{@template_src}/**/*", File::FNM_DOTMATCH).filter_map do |f|
         base_path = f[@template_src.length+1..-1]
-        next if ignored_by_git?(@template_src, base_path)
-        template_dirs.merge!(base_path => substitute_template_values(base_path))
-      end
+        next if base_path.start_with?(".git" + File::SEPARATOR) || base_path == ".git"
+        next if f == "#{@template_src}/." || f == "#{@template_src}/.."
+        next unless File.directory?(f)
+        # next if ignored_by_git?(@template_src, base_path)
+
+        [base_path, substitute_template_values(base_path)]
+      end.to_h
+      filter_ignored_files!(@template_src, template_dirs)
+
       template_dirs
     end
 
-    # This function should be eliminated over time so that other methods conform to the
-    # new algo for generating templates automatically.
-    # Really, this function generates a template_src to template_dst naming
-    # structure so that a later method can copy all the template files from the
-    # source and rename them properly
-    def generate_templates_for_built_in_gems(config)
-      # Hmmm... generate dynamically instead?  Yes, overwritten below
-      templates = {
-        'Gemfile.tt'   => "Gemfile",
-        'changelog.tt' => "changelog",
-        'gitignore.tt' => ".gitignore",
-        'lib/#{name}.rb.tt' => "lib/#{config[:namespaced_path]}.rb",
-        'lib/#{name}/version.rb.tt' => "lib/#{config[:namespaced_path]}/version.rb",
-        '#{name}.gemspec.tt' => "#{config[:name]}.gemspec",
-        'Rakefile.tt'  => "Rakefile",
-        'README.md.tt' => "README.md",
-        'bin/console.tt' => "bin/console"
-      }
+    # Figures out the translation between all the .tt file to their
+    # destination names
+    def dynamically_generate_templates_files
+      template_files = Dir.glob("#{@template_src}/**/*.tt", File::FNM_DOTMATCH).filter_map do |f|
+        base_path = f[@template_src.length+1..-1]
+        # next if ignored_by_git?(@template_src, base_path)
 
-      prompt_coc!(templates)
-      prompt_mit!(templates, config)
-      prompt_test_framework!(templates, config)
+        [base_path, substitute_template_values(base_path).sub(/\.tt$/, "")]
+      end.to_h
 
-      templates.merge!("exe/newgem.tt" => "exe/#{config[:name]}") if config[:bin]
+      raise_no_files_in_template_error! if template_files.empty?
+      filter_ignored_files!(@template_src, template_files)
 
-      if config[:ext]
-        templates.merge!(
-          "ext/newgem/extconf.rb.tt" => "ext/#{config[:name]}/extconf.rb",
-          "ext/newgem/newgem.h.tt" => "ext/#{config[:name]}/#{config[:underscored_name]}.h",
-          "ext/newgem/newgem.c.tt" => "ext/#{config[:name]}/#{config[:underscored_name]}.c"
-        )
-      end
-      templates
+      return template_files
     end
 
+
     # Applies every possible substitution within config to the fs_obj_name
     def substitute_template_values(fs_obj_name)
       config.keys.inject(fs_obj_name) do |accu, key|
@@ -194,19 +198,12 @@ module Bundlegem
       end
     end
 
-    # Figures out the translation between all the .tt file to their
-    # destination names
-    def dynamically_generate_templates_files
-      templates = {}
-      Dir.glob("#{@template_src}/**/*.tt", File::FNM_DOTMATCH).each do |f|
-        base_path = f[@template_src.length+1..-1]
-        next if ignored_by_git?(@template_src, base_path)
-        templates.merge!( base_path => substitute_template_values(base_path).sub(/\.tt$/, "") )
-      end
-
-      raise_no_files_in_template_error! if templates.empty?
+    def filter_ignored_files!(repo_root, path_hash)
+      cmd = "git -C #{repo_root} check-ignore #{Shellwords.join(path_hash.keys)}"
+      stdout, _, status = Open3.capture3(cmd)
+      filter_these_paths = stdout.split
 
-      return templates
+      path_hash.delete_if { |key, _| filter_these_paths.include?(key) }
     end
 
     def ignored_by_git?(repo_root, path)
@@ -224,7 +221,7 @@ module Bundlegem
 
     # returns the full path of the template source
     def match_template_src
-      template_src = TemplateManager.get_template_src(options)
+      template_src = ::Bundlegem::TemplateManager.get_template_src(@options)
 
       if File.exist?(template_src)
         return template_src    # 'newgem' refers to the built in template that comes with the gem
@@ -248,7 +245,7 @@ module Bundlegem
     end
 
     def bundler_dependency_version
-      v = Gem::Version.new(Bundler::VERSION)
+      v = ::Gem::Version.new(Bundler::VERSION)
       req = v.segments[0..1]
       req << 'a' if v.prerelease?
       req.join(".")
@@ -265,7 +262,7 @@ module Bundlegem
     # ==== Parameters
     # source<String>:: the relative path to the source root.
     # destination<String>:: the relative path to the destination root.
-    # config<Hash>:: give :verbose => false to not log the status.
+    # config<Hash>:: give verbose:  false to not log the status.
     #
     # ==== Examples
     #
@@ -277,7 +274,7 @@ module Bundlegem
       config = args.last.is_a?(Hash) ? args.pop : {}
       destination = args.first || source.sub(/#{TEMPLATE_EXTNAME}$/, "")
 
-      source  = File.expand_path(TemplateManager.find_in_source_paths(source.to_s))
+      source  = File.expand_path(::Bundlegem::TemplateManager.find_in_source_paths(source.to_s))
       context = instance_eval("binding")
 
       make_file(destination, config) do
@@ -290,21 +287,15 @@ module Bundlegem
       File.chmod(original_mode, destination)
     end
 
-
-    #
-    # EDIT:  Reworked from Thor to not rely on Thor (or do so much unneeded stuff)
-    #
     def make_file(destination, config, &block)
       FileUtils.mkdir_p(File.dirname(destination))
       puts " Writing   #{destination} ..."
       File.open(destination, "wb") { |f| f.write block.call }
     end
 
-
-
     def raise_no_files_in_template_error!
       err_no_files_in_template = <<-HEREDOC
-Ooops, the template was found for '#{options['template']}' in ~/.bundlegem/templates,
+Ooops, the template was found for '#{@options[:template]}' in ~/.bundlegem/templates,
 but no files within it ended in .tt.  Did you forget to rename the extensions of your files?
 
 Exiting...
@@ -325,92 +316,18 @@ Exiting...
     end
 
     def raise_template_not_found!
-      err_missing_template = "Could not find template folder '#{options["template"]}' in `~/.bundle/templates/`. Please check to make sure your desired template exists."
+      err_missing_template = "Could not find template folder '#{@options[:template]}' in `~/.bundle/templates/`. Please check to make sure your desired template exists."
       puts err_missing_template
       Bundler.ui.error err_missing_template
       raise
     end
 
-
-    ############# STUFF THAT SHOULD BE REMOVED DOWN THE ROAD
-
-    # This asks the user if they want to setup rspec or test...
-    # It's not class based, it's additive based... Plus bundlegem does this already
-    def ask_and_set_test_framework
-      test_framework = options[:test] || Bundler.settings["gem.test"]
-
-      if test_framework.nil?
-        Bundler.ui.confirm "Do you want to generate tests with your gem?"
-        result = Bundler.ui.ask "Type 'rspec' or 'minitest' to generate those test files now and " \
-          "in the future. rspec/minitest/(none):"
-        if result =~ /rspec|minitest/
-          test_framework = result
-        else
-          test_framework = false
-        end
-      end
-
-      if Bundler.settings["gem.test"].nil?
-        Bundler.settings.set_global("gem.test", test_framework)
-      end
-
-      test_framework
-    end
-
-    def ask_and_set(key, header, message)
-      choice = options[key]  # || Bundler.settings["gem.#{key}"]
-
-      if choice.nil?
-        Bundler.ui.confirm header
-        choice = (Bundler.ui.ask("#{message} y/(n):") =~ /y|yes/)
-        Bundler.settings.set_global("gem.#{key}", choice)
-      end
-
-      choice
-    end
-
-    def prompt_coc!(templates)
-      if ask_and_set(:coc, "Do you want to include a code of conduct in gems you generate?",
-          "Codes of conduct can increase contributions to your project by contributors who " \
-          "prefer collaborative, safe spaces. You can read more about the code of conduct at " \
-          "contributor-covenant.org. Having a code of conduct means agreeing to the responsibility " \
-          "of enforcing it, so be sure that you are prepared to do that. For suggestions about " \
-          "how to enforce codes of conduct, see bit.ly/coc-enforcement."
-        )
-        templates.merge!("CODE_OF_CONDUCT.md.tt" => "CODE_OF_CONDUCT.md")
-      end
-    end
-
-    def prompt_mit!(templates, config)
-      if ask_and_set(:mit, "Do you want to license your code permissively under the MIT license?",
-          "This means that any other developer or company will be legally allowed to use your code " \
-          "for free as long as they admit you created it. You can read more about the MIT license " \
-          "at choosealicense.com/licenses/mit."
-        )
-        config[:mit] = true
-        templates.merge!("LICENSE.txt.tt" => "LICENSE.txt")
-      end
-    end
-
-    def prompt_test_framework!(templates, config)
-      namespaced_path = config[:namespaced_path]
-      if test_framework = ask_and_set_test_framework
-        templates.merge!(".travis.yml.tt" => ".travis.yml")
-
-        case test_framework
-        when 'rspec'
-          templates.merge!(
-            "rspec.tt" => ".rspec",
-            "spec/spec_helper.rb.tt" => "spec/spec_helper.rb",
-            'spec/#{name}_spec.rb.tt' => "spec/#{namespaced_path}_spec.rb"
-          )
-        when 'minitest'
-          templates.merge!(
-            "test/minitest_helper.rb.tt" => "test/minitest_helper.rb",
-            "test/test_newgem.rb.tt" => "test/test_#{namespaced_path}.rb"
-          )
-        end
-      end
+    def time_it(label = nil)
+      start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      yield
+      end_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      elapsed_ms = ((end_time - start_time) * 1000).round(2)
+      puts "#{label || 'Elapsed'}: #{elapsed_ms} ms"
     end
 
     # This checks to see that the gem_name is a valid ruby gem name and will 'work'

data/lib/bundlegem/strings.rb

@@ -6,7 +6,7 @@ Use bundlegem to start a new project folder based on a predefined template.
 Usage Examples:
 
   # Download all my template files (configured in ~/.bundlegem/config)
-  $ bundlegem --install-best-templates
+  $ bundlegem --install-public-templates
 
   # List available teplates
   $  bundlegem --list

data/lib/bundlegem/template_manager.rb

@@ -10,10 +10,10 @@ module Bundlegem
 
       def internal_template_location() = File.expand_path("#{File.dirname(__FILE__)}/templates")
       def custom_template_location() = File.expand_path("~/.bundlegem/templates")
-      def default_template_name() = "cli_gem"
+      def default_template_name() = "ruby-cli-gem"
 
       def get_template_src(options)
-        template_name = options["template"] || default_template_name
+        template_name = options[:template] || default_template_name
         template_location = template_exists_within_repo?(template_name) ?
                         internal_template_location :
                         custom_template_location

data/lib/bundlegem/templates/test_template/#{name}.rb.tt

@@ -2,6 +2,7 @@ This file shows all the variables in one place!
 See "lib/bundlegem/templates/test_template/#{name}.rb.tt"
 
 config[:name]:             <%= config[:name] %>
+config[:title]:            <%= config[:title] %>
 config[:unprefixed_name]:  <%= config[:unprefixed_name] %>
 config[:unprefixed_pascal]:<%= config[:unprefixed_pascal] %>
 config[:underscored_name]: <%= config[:underscored_name] %>

data/lib/bundlegem/version.rb

@@ -1,3 +1,3 @@
 module Bundlegem
-  VERSION = "1.1.1"
+  VERSION = "1.2.0-rc.2"
 end

data/lib/bundlegem.rb

@@ -6,7 +6,7 @@ require 'bundlegem/template_manager'
 require 'bundlegem/core/core'
 require 'bundlegem/cli/cli'
 
-require 'bundlegem/cli'
+require 'uri'
 
 SOURCE_ROOT = File.expand_path("#{File.dirname(__FILE__)}/..")
 
@@ -28,11 +28,12 @@ module Bundlegem
       mark_default_template(output_string, configurator.default_template)
     end
 
-    def install_best_templates
+    def install_public_templates
+      validate_git_is_installed!
       configurator = Configurator.new
       config_file_data = configurator.config_file_data
-      puts "Downloading templates from the following locations: \n  #{config_file_data['best_templates'].split(" ").join("\n  ")}"
-      config_file_data['best_templates'].split.each do |url|
+      puts "Downloading templates from the following locations: \n  #{config_file_data['public_templates'].split(" ").join("\n  ")}"
+      config_file_data['public_templates'].split.each do |url|
         uri = URI.parse(url)
         template_folder_name = File.basename(uri.path).sub(/\.git$/, "")
         if !File.exist?("#{ENV['HOME']}/.bundlegem/templates/#{template_folder_name}")
@@ -45,12 +46,24 @@ module Bundlegem
       end
     end
 
+    def validate_git_is_installed!
+      exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
+      ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
+        exts.each do |ext|
+          exe = File.join(path, "git#{ext}")
+          return if File.executable?(exe) && !File.directory?(exe)
+        end
+      end
+
+      puts "Error: `git` command not found. Please install Git and ensure it's in your PATH."
+      exit 1
+    end
+
     def dir_to_template
-      puts Cli::DirToTemplate.go
+      puts CLI::DirToTemplate.go
     end
 
     def gem(options, gem_name)
-      require 'bundlegem/cli'
       require 'bundlegem/cli/gem'
 
       Bundlegem::CLI::Gem.new(options, gem_name).run
@@ -80,17 +93,16 @@ module Bundlegem
     #           { "MISC" => ["my_thing"] }
     #         ]
     def convert_grouped_hashes_to_output(available_templates)
-      s = ""
-      available_templates.each do |hash|
-        k = hash.first.upcase
-        a = hash.last
-        s << " #{k}:\n"
-        a.each do |el|
-          s << "   #{el}\n"
+      template_list_output = ""
+      available_templates.each do |category, template_names|
+
+        template_list_output << " #{category&.upcase || "UNSPECIFIED"}:\n"
+        template_names.each do |el|
+          template_list_output << "   #{el}\n"
         end
-        s << "\n"
+        template_list_output << "\n"
       end
-      s
+      template_list_output
     end
 
     def mark_default_template(output_string, default_template)

data/spec/bundlegem_spec.rb

@@ -46,25 +46,8 @@ describe Bundlegem do
 
   # Generate
 
-  # This bulids the default gem template
-  it "can generate the default built-in gem fine" do
-    options = {"bin"=>false, "ext"=>false, :coc=> false}
-    gem_name = "tmp_gem"
-
-    capture_stdout { Bundlegem.gem(options, gem_name) }
-    expect(File).to exist("#{@dst_dir}/#{gem_name}/README.md")
-  end
-
-  it "can generate the c_ext gem fine" do
-    options = {"bin"=>false, "ext"=>false, :coc=> false, "template" => "c_extension_gem"}
-    gem_name = "tmp_gem"
-
-    capture_stdout { Bundlegem.gem(options, gem_name) }
-    expect(File).to exist("#{@dst_dir}/#{gem_name}/ext/tmp_gem/#{gem_name}.c")
-  end
-
   it "finds the template-test template even if the template- prefix was omitted" do
-    options = {"bin"=>false, "ext"=>false, :coc=> false, "template" => "test"}
+    options = {bin: false, ext: false, coc:  false, template: "test"}
     gem_name = "tmp_gem"
 
     capture_stdout { Bundlegem.gem(options, gem_name) }
@@ -73,7 +56,7 @@ describe Bundlegem do
   end
 
   it "has a useful dynamically_generate_template_directories method" do
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "test_template" }
+    options = { bin: false, ext: false, coc:  false, template: "test_template" }
     gem_name = "good-dog"
     my_gem = Bundlegem::CLI::Gem.new(options, gem_name)
 
@@ -85,7 +68,7 @@ describe Bundlegem do
   end
 
   it "returns the expected interpolated string when substitute_template_values is called" do
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "test_template" }
+    options = { bin: false, ext: false, coc:  false, template: "test_template" }
     gem_name = "good-dog"
     my_gem = Bundlegem::CLI::Gem.new(options, gem_name)
 
@@ -100,7 +83,7 @@ describe Bundlegem do
   end
 
   it "has a useful dynamically_generate_templates_files method" do
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "test_template" }
+    options = { bin: false, ext: false, coc:  false, template: "test_template" }
     gem_name = "good-dog"
     my_gem = Bundlegem::CLI::Gem.new(options, gem_name)
 
@@ -114,7 +97,7 @@ describe Bundlegem do
 
   it "won't generate template files that are listed under the gitignore" do
     template_dir = create_user_defined_template("testing", "template-user-supplied")
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "template-user-supplied" }
+    options = { bin: false, ext: false, coc:  false, template: "template-user-supplied" }
     gem_name = "good-dog"
 
     File.write("#{template_dir}/.gitignore", "node_modules/")
@@ -131,7 +114,7 @@ describe Bundlegem do
 
   it "executes the bootstrap_command if supplied" do
     template_dir = create_user_defined_template("testing", "template-user-supplied")
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "template-user-supplied" }
+    options = { bin: false, ext: false, coc:  false, template: "template-user-supplied" }
     gem_name = "good-dog"
 
     File.write("#{template_dir}/bundlegem.yml", "bootstrap_command: echo hihihi")
@@ -143,16 +126,34 @@ describe Bundlegem do
     expect(output).to include "hihihi"
   end
 
+  it "interpolates variables into the bootstrap_command" do
+    # this is quite pointless, we're literally allowing the user to execute a command on their shell...
+    template_dir = create_user_defined_template("testing", "template-user-supplied")
+    options = { bin: false, ext: false, coc:  false, template: "template-user-supplied" }
+    gem_name = "good-dog"
+
+    File.write("#{template_dir}/bundlegem.yml", 'bootstrap_command: "echo #{config[:name]}"')
+    File.write("#{template_dir}/README.md.tt", "# Readme...")
+    `git init #{template_dir}`
+
+    output = capture_stdout { Bundlegem.gem(options, gem_name) }
+
+    expect(output).to include "echo #{gem_name}"
+  end
+
   it "has a test proving every interpolation in one file" do
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "test_template" }
+    expected_manifest = File.read("#{ENV['SPEC_DATA_DIR']}/variable_manifest_test.rb")
+    options = { bin: false, ext: false, coc:  false, template: "test_template" }
     gem_name = "good-dog"
 
     capture_stdout { Bundlegem.gem(options, gem_name) }
-    expect(File.read("#{@dst_dir}/#{gem_name}/#{gem_name}.rb")).to eq File.read("#{ENV['SPEC_DATA_DIR']}/variable_manifest_test.rb")
+
+    resulting_manifest = File.read("#{@dst_dir}/#{gem_name}/#{gem_name}.rb")
+    expect(resulting_manifest).to eq expected_manifest
   end
 
   it "has config[:unprefixed_name] removing purpose-tool- from name" do
-    options = { "bin"=>false, "ext"=>false, :coc=> false, "template" => "test_template" }
+    options = { bin: false, ext: false, coc:  false, template: "test_template" }
     gem_name = "tool-go-good-dog"
     my_gem = Bundlegem::CLI::Gem.new(options, gem_name)
 
@@ -161,7 +162,7 @@ describe Bundlegem do
     expect(config[:unprefixed_name]).to eq "good-dog"
   end
 
-  describe "install best templates" do
+  describe "install public templates" do
     before :each do
       setup_mock_web_template
     end
@@ -169,8 +170,8 @@ describe Bundlegem do
       remove_mock_web_template
     end
 
-    it "can download best templates from the web" do
-      capture_stdout { Bundlegem.install_best_templates }
+    it "can download public templates from the web" do
+      capture_stdout { Bundlegem.install_public_templates }
       expect(File).to exist("#{ENV['HOME']}/.bundlegem/templates/template-arduino/README.md")
     end
   end

data/spec/data/variable_manifest_test.rb

@@ -2,6 +2,7 @@ This file shows all the variables in one place!
 See "lib/bundlegem/templates/test_template/#{name}.rb.tt"
 
 config[:name]:             good-dog
+config[:title]:            Good Dog
 config[:unprefixed_name]:  good-dog
 config[:unprefixed_pascal]:GoodDog
 config[:underscored_name]: good_dog

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 $test_env = true
 require 'bundlegem'
-require 'bundlegem/cli'
 require 'bundlegem/cli/gem'
 require 'fileutils'
 require 'pry'
@@ -12,7 +11,7 @@ ENV['SPEC_DATA_DIR'] = File.expand_path("./spec/data") # I fell into this from s
 
 
 def setup_mock_web_template
-  ENV['best_templates'] = "#{ENV['HOME']}/arduino.git"
+  ENV['public_templates'] = "#{ENV['HOME']}/arduino.git"
   FileUtils.mkdir("#{ENV['HOME']}/arduino.git")
   FileUtils.touch("#{ENV['HOME']}/arduino.git/README.md")