bumps 0.0.3 → 0.0.4

data/History.txt

@@ -1,3 +1,7 @@
+== 0.0.4 2009-10-13
+
+* Handle missing connection to push server more gracefully 
+
 == 0.0.3 2009-09-28
 
 * Compatibility with Cucumber 0.3.104 and above

data/Rakefile

@@ -31,5 +31,6 @@ task :features => :create_tmp
 require 'newgem/tasks' # load /tasks/*.rake
 Dir['tasks/**/*.rake'].each { |t| load t }
 
+# IS THIS NEEDED?
 Rake::Task[:default].clear_prerequisites # clear out test-unit
 task :default => [:spec, :features]

data/TODO

@@ -1,7 +1,3 @@
-- release
-  - tag
-  - release to rubyforge
-  - announce on bumps group + twitter
 
 --- LATER ---
 

data/features/pull_remote_features.feature

@@ -5,13 +5,11 @@ Feature: Pull remote features
   So that the features can be authored using a separate tool
     
   Scenario: Remote features pulled successfully
-
     Given that a feature server is running
     When a cucumber run is performed
     Then the feature report will contain all remote features
 
   Scenario: Feature server not reachable
-
     Given that a feature server is not running
     When a cucumber run is performed
     Then the command output should show that features could not be pulled

data/features/push_feature_results.feature

@@ -5,7 +5,11 @@ Feature: Serve feature results
   So that I can format my local feature data accordingly
     
   Scenario: Push all feature results after a run
-
     Given that a feature server is running
     When a cucumber run is performed
-    Then the results of the feature run will be sent to the feature server
+    Then the results of the feature run will be sent to the feature server
+
+  Scenario: Feature server not reachable
+    Given that a feature server is not running
+    When a cucumber run is performed
+    Then the command output should show that features could not be pushed

data/features/steps/command_output.rb

@@ -1,3 +1,7 @@
 Then /^the command output should show that features could not be pulled$/ do
   command_output.should match(/Could not pull features/)
-end
+end
+
+Then /^the command output should show that features could not be pushed$/ do
+  command_output.should match(/Failed to push results/)
+end

data/lib/bumps/feature.rb

@@ -9,11 +9,11 @@ module Bumps
     end  
     
     def self.pull
-      Configuration.output_stream << "\nRetrieving features from #{Configuration.pull_url} ...\n"
+      Configuration.output_stream << "Retrieving features from #{Configuration.pull_url} ...\n"
       begin
         features = RemoteFeature.fetch(Configuration.pull_url)
       rescue Exception => e
-        Configuration.output_stream << "\nCould not pull features: #{e}\n"
+        Configuration.output_stream << "Could not pull features: #{e}\n"
         features = []
       end
         

data/lib/bumps/results_push_formatter.rb

@@ -26,12 +26,15 @@ module Bumps
     
     def push results
       uri = URI.parse(Bumps::Configuration.push_url)
-      response, body = Net::HTTP.post_form uri, {:results => results}
-      if response.code_type == Net::HTTPOK
-        @io << "Successfully pushed results to #{Bumps::Configuration.push_url}\n\n"
-      else
-        @io << "Failed to push results to #{Bumps::Configuration.push_url} - HTTP #{response.code}: \n#{response.body}\n\n"
+      begin
+        response, body = Net::HTTP.post_form uri, {:results => results}
+      rescue Exception => e
+        @io << failure_message(e.message)
+        return
       end
+      
+      response_ok = response.code_type == Net::HTTPOK 
+      @io << (response_ok ? success_message : failure_message("HTTP #{response.code}: \n#{response.body}"))
     end
     
     def method_missing(method, *args, &block)
@@ -42,5 +45,14 @@ module Bumps
       super(message, include_private) || formatter.respond_to?(message, include_private)
     end
     
+    private
+    
+    def failure_message(message)
+      "Failed to push results to #{Bumps::Configuration.push_url} - #{message}\n"
+    end
+    
+    def success_message
+      "Successfully pushed results to #{Bumps::Configuration.push_url}\n"
+    end  
   end
 end

data/lib/bumps_core.rb

@@ -14,7 +14,7 @@ require 'cucumber'
 
 module Bumps
   
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
   
   def self.configure &block
     Configuration.configure(&block)

data/spec/bumps/configuration_spec.rb

@@ -5,56 +5,56 @@ describe Bumps::Configuration do
   before {@output_stream = mock('output stream').as_null_object}
   subject {Bumps::Configuration.new}
 
-  it 'should provide access to the output stream' do
+  it 'provides an output stream for writing messages' do
     out_stream = mock 'out stream'
     subject.output_stream = out_stream
     
     subject.output_stream.should == out_stream
   end  
   
-  it 'should allow configuration using a block' do
+  it 'is configured using a block' do
     subject.should_receive(:configuration_call)
     
     subject.configure { configuration_call }
   end
   
-  it 'should derive pull URL from server' do
+  it 'derives pull URL from server' do
     subject.use_server 'http://server'
     
     subject.pull_url.should == 'http://server/features/content'
   end
   
-  it 'should derive push URL from server' do
+  it 'derives push URL from server' do
     subject.use_server 'http://server'
     
     subject.push_url.should == 'http://server/features/results'
   end
   
-  it 'should be able to handle a server URL with a trailing slash' do
+  it 'recognises a server URL with a trailing slash' do
     subject.use_server 'http://server/'
     
     subject.pull_url.should match(/^http:\/\/server\/[a-z]/)
   end
   
-  it 'should allow a non-default push URL to be specified' do
+  it 'allows a non-default push URL to be specified' do
     subject.push_to 'http://url.com'
     
     subject.push_url.should == 'http://url.com'    
   end
 
-  it 'should allow a non-default pull URL to be specified' do
+  it 'allows a non-default pull URL to be specified' do
     subject.pull_from 'http://url.com'
     
     subject.pull_url.should == 'http://url.com'    
   end
     
-  it 'should allow the feature directory to be set' do
+  it 'allows the feature directory to be set' do
     subject.feature_directory = 'feature_directory'
     
     subject.feature_directory.should == 'feature_directory'
   end
   
-  it 'should allow results formatter to be specified' do
+  it 'allows results formatter to be specified' do
     formatter_class = mock 'formatter class'
     
     subject.format_results_with formatter_class
@@ -62,11 +62,11 @@ describe Bumps::Configuration do
     subject.results_formatter.should == formatter_class
   end
   
-  it 'should default the results formatter to Cucumber HTML formatter' do
+  it 'defaults the results formatter to Cucumber HTML formatter' do
     subject.results_formatter.should == Cucumber::Formatter::Html
   end
   
-  it 'should allow access to configuration via class' do
+  it 'can have only one instance' do
     singleton = mock 'singleton'
     Bumps::Configuration.stub!(:singleton).and_return singleton
     

data/spec/bumps/cucumber_config_spec.rb

@@ -1,6 +1,6 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
-describe Bumps::CucumberConfig, 'processing' do
+describe Bumps::CucumberConfig do
   before do
     @source_config = mock('source Cucumber config')
     @config = Bumps::CucumberConfig.new @source_config
@@ -8,7 +8,7 @@ describe Bumps::CucumberConfig, 'processing' do
   
   describe 'processing' do
 
-    it 'should validate cucumber configuration, update Bumps config then register formatter' do
+    it 'validates cucumber configuration, updates Bumps config then registers formatter' do
       @config.should_receive(:validate).ordered
       @config.should_receive(:update_bumps_config).ordered
       @config.should_receive(:register_formatter).ordered
@@ -20,13 +20,13 @@ describe Bumps::CucumberConfig, 'processing' do
   
   describe 'validation' do
     
-    it 'should succeed if a single directory is specified' do
+    it 'passes when a single directory is specified' do
       @source_config.stub!(:feature_dirs).and_return ['one']
 
       lambda{ @config.validate }.should_not raise_error
     end
     
-    it 'should fail if there is more than one feature directory specified' do
+    it 'fails when there is more than one feature directory specified' do
       @source_config.stub!(:feature_dirs).and_return ['one', 'two']
 
       lambda{ @config.validate }.should raise_error('More than one feature directory/file was specified. Please only specify a single feature directory when using bumps')
@@ -34,9 +34,9 @@ describe Bumps::CucumberConfig, 'processing' do
     
   end
   
-  describe 'updating Bumps configuration' do
+  describe 'update' do
     
-    it 'should use fields from source Cucumber config' do
+    it 'uses fields from source Cucumber config' do
       @source_config.stub!(:feature_dirs).and_return ['dir']
       @source_config.stub!(:out_stream).and_return 'out stream'
       
@@ -48,7 +48,7 @@ describe Bumps::CucumberConfig, 'processing' do
     
   end
   
-  describe 'registering formatter' do
+  describe 'registering a formatter' do
     
     before do
       # law of demeter seems like an even better idea after mocking a chain of three objects
@@ -58,13 +58,13 @@ describe Bumps::CucumberConfig, 'processing' do
       @source_config.stub!(:options).and_return options
     end
     
-    it 'should add the class name of the push formatter to the cucumber configuration' do
+    it 'adds the class name of the push formatter to the Cucumber configuration' do
       @formats.should_receive(:<<).with ['Bumps::ResultsPushFormatter', anything]
 
       @config.register_formatter
     end
     
-    it 'should use the configured output stream for output' do
+    it 'uses the configured output stream to write messages' do
       output_stream = mock 'output stream'
       Bumps::Configuration.stub!(:output_stream).and_return output_stream
 

data/spec/bumps/feature_spec.rb

@@ -1,7 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
 describe Bumps::Feature do
-  describe 'when pulling' do
+  describe 'pulling feature content' do
     
     before do
       @output_stream = mock('output stream').as_null_object
@@ -10,7 +10,7 @@ describe Bumps::Feature do
 
     subject {Bumps::Feature}
 
-    it 'should write fetched features to the feature directory' do
+    it 'writes fetched features to the feature directory' do
       Bumps::Configuration.stub!(:feature_directory).and_return 'feature_directory'
       Bumps::Configuration.stub!(:pull_url).and_return 'location'
   
@@ -27,27 +27,27 @@ describe Bumps::Feature do
       subject.pull
     end 
     
-    it 'should output an error message if the features could not be fetched' do
+    it 'displays an error message if the features could not be fetched' do
       Bumps::Configuration.stub! :pull_url
       Bumps::Configuration.stub! :feature_directory
       Bumps::RemoteFeature.stub!(:fetch).and_raise "exception message"
       
-      @output_stream.should_receive(:<<).with "\nCould not pull features: exception message\n" 
+      @output_stream.should_receive(:<<).with "Could not pull features: exception message\n" 
       
       subject.pull
     end
     
-    it 'should display which location the features are being retrieved from' do
+    it 'displays which location the features are being retrieved from' do
       Bumps::RemoteFeature.stub!(:fetch).and_return []
       Bumps::Configuration.stub!(:pull_url).and_return 'pull_url'
       Bumps::Configuration.stub! :feature_directory
       
-      @output_stream.should_receive(:<<).with "\nRetrieving features from pull_url ...\n"
+      @output_stream.should_receive(:<<).with "Retrieving features from pull_url ...\n"
       
       subject.pull
     end  
     
-    it 'should display the total number of features retrieved and location they were written to' do
+    it 'displays the total number of features retrieved and location they were written to' do
       features = (1..3).collect{|index| mock("feature #{index}").as_null_object}
       Bumps::RemoteFeature.stub!(:fetch).and_return features
       Bumps::Configuration.stub!(:feature_directory).and_return 'feature_directory'
@@ -59,36 +59,30 @@ describe Bumps::Feature do
     end
   end
 
-  describe 'when writing self to file' do 
+  describe 'writing to file' do 
     
-    it 'should determine absolute path before writing contents' do
+    it 'uses absolute path' do
       subject.stub(:absolute_path_under).with('directory').and_return 'path'
       
       subject.should_receive(:write_content_to).with 'path'
       
       subject.write_to 'directory'
     end
-  end
-  
-  describe 'when determining absolute feature file path' do
       
-    it 'should construct file name from expanded directory and feature name' do
+    it 'uses expanded directory and feature name' do
       subject.stub!(:name).and_return 'name'
       
       subject.absolute_path_under('/a/b/c/..').should == '/a/b/name'
     end
       
-    it 'should fail if given path does not resolve to one below the feature directory' do
+    it 'fails if given path does not resolve to one below the feature directory' do
       subject.stub!(:name).and_return '../../etc/bashrc'
       File.stub! :open # just in case
       
       lambda {subject.absolute_path_under '/stuff/features'}.should raise_error('Could not write feature to path /etc/bashrc, path is not below /stuff/features')
     end
-  end
-  
-  describe 'when writing content' do
     
-    it 'should overwrite existing files' do
+    it 'overwrites existing files' do
       FileUtils.stub! :makedirs
       
       File.should_receive(:open).with anything, 'w'
@@ -96,7 +90,7 @@ describe Bumps::Feature do
       subject.write_content_to ''
     end
 
-    it 'should force the creation of directories in the feature name' do
+    it 'forces the creation of directories in the feature name' do
       File.stub! :open
       
       FileUtils.should_receive(:makedirs).with 'features_dir/subdir'
@@ -104,7 +98,7 @@ describe Bumps::Feature do
       subject.write_content_to 'features_dir/subdir/featurename.feature'
     end
   
-    it 'should write content to file' do
+    it 'writes content' do
       FileUtils.stub! :makedirs
       @file = mock 'file'
       File.stub!(:open).and_yield @file

data/spec/bumps/remote_feature_spec.rb

@@ -4,15 +4,15 @@ describe Bumps::RemoteFeature do
   
   subject {Bumps::RemoteFeature}
   
-  describe 'when fetching' do
-    it 'should retrieve features from the given location' do
+  describe 'fetching' do
+    it 'uses the given location' do
       subject.should_receive(:open).with('location')
       subject.stub! :parse
       
       subject.fetch 'location'
     end
     
-    it 'should parse the given document to obtain features' do
+    it 'parses the given document to obtain features' do
       subject.stub!(:open).and_return 'document'
       
       subject.should_receive(:parse).with 'document'
@@ -21,8 +21,8 @@ describe Bumps::RemoteFeature do
     end  
   end
   
-  describe 'when parsing' do
-    it 'should extract all features from XML' do
+  describe 'parsing' do
+    it 'extracts all features from XML' do
       features = (0..1).collect do |idx|
         feature = Bumps::Feature.new
         feature.name = "feature #{idx}"
@@ -41,7 +41,7 @@ XML
       subject.parse(xml).should eql(features)
     end 
     
-    it 'should trim leading and trailing whitespace from content' do
+    it 'trims leading and trailing whitespace from content' do
       xml = <<-XML
 <?xml version="1.0"?>
 <features>
@@ -57,7 +57,7 @@ XML
       subject.parse(xml).first.content.should == 'I am the content for feature 0'
     end  
     
-    it 'should return an empty feature list when none were found' do
+    it 'returns an empty list when no features were found' do
       xml = <<-XML
 <?xml version="1.0"?>
 <features>
@@ -66,7 +66,7 @@ XML
       subject.parse(xml).should eql([])
     end
 
-    it 'should preserve CDATA in feature content' do
+    it 'preserves CDATA in feature content' do
       xml = <<-XML
 <?xml version="1.0"?>
 <features>

data/spec/bumps/results_push_formatter_spec.rb

@@ -18,7 +18,7 @@ describe Bumps::ResultsPushFormatter do
     )
   end
   
-  describe 'when capturing results' do
+  describe 'responding to' do
  
     before do
       @formatter_class = mock 'formatter class'
@@ -26,31 +26,46 @@ describe Bumps::ResultsPushFormatter do
       Bumps::Configuration.stub!(:results_formatter).and_return @formatter_class
     end
     
-    describe 'responding to events' do
+    describe 'events' do
       
       before do
         @formatter_class.stub!(:new).and_return @formatter
         Bumps::Configuration.stub!(:results_formatter).and_return @formatter_class
       end
       
-      it 'should recognise events that the wrapped formatter handles' do
+      it 'recognises events that the wrapped formatter handles' do
         @formatter.stub!(:respond_to?).with('event', anything).and_return true
        
         subject.before_features @features
         subject.respond_to?('event').should == true
       end
       
-      it 'should recognise events that it handles on its own' do
+      it 'recognises events that it handles on its own' do
         @formatter.stub!(:respond_to?).with('after_features', anything).and_return false
     
         subject.before_features @features
         subject.respond_to?('after_features').should == true
       end
+      
+      it 'notifies the wrapped formatter of all events' do
+        @formatter_class.stub!(:new).and_return @formatter
+        Bumps::Configuration.stub!(:results_formatter).and_return @formatter_class
+        events = [
+          :before_feature, :after_feature, :before_comment, :after_comment,
+          :comment_line, :after_tags, :before_background, :after_background,
+          # there are more, add as needed
+        ]
+        
+        events.each { |event| @formatter.should_receive(event).with('arguments')}
+     
+        subject.before_features @features
+        events.each { |event| subject.send(event, 'arguments')}
+      end
     end
        
-    describe 'before the running of features' do
+    describe 'before features' do
       
-      it 'should construct the wrapped formatter using the step mother' do
+      it 'constructs the wrapped formatter using the step mother' do
         @formatter_class.should_receive(:new).with(
           @step_mother, anything, anything
         ).and_return @formatter
@@ -58,7 +73,7 @@ describe Bumps::ResultsPushFormatter do
         subject.before_features @features
       end   
       
-      it 'should construct the wrapped formatter using the options' do
+      it 'constructs the wrapped formatter using the options' do
         @formatter_class.should_receive(:new).with(
           anything, anything, @options
         ).and_return @formatter
@@ -66,7 +81,7 @@ describe Bumps::ResultsPushFormatter do
         subject.before_features @features
       end
       
-      it 'should obtain the results formatter from the configuration' do
+      it 'obtains the results formatter from the configuration' do
         @formatter_class.stub!(:new).and_return @formatter
 
         Bumps::Configuration.should_receive(:results_formatter).and_return @formatter_class
@@ -74,7 +89,7 @@ describe Bumps::ResultsPushFormatter do
         subject.before_features @features
       end
       
-      it 'should notify the wrapped formatter of the before_features event' do
+      it 'notifies the wrapped formatter of the before_features event' do
         Bumps::Configuration.stub!(:results_formatter).and_return @formatter_class
         @formatter_class.stub!(:new).and_return @formatter
 
@@ -85,26 +100,8 @@ describe Bumps::ResultsPushFormatter do
          
     end
     
-    describe 'during the running of features' do
-
-      it 'should notify the wrapped formatter of all events' do
-        @formatter_class.stub!(:new).and_return @formatter
-        Bumps::Configuration.stub!(:results_formatter).and_return @formatter_class
-        events = [
-          :before_feature, :after_feature, :before_comment, :after_comment,
-          :comment_line, :after_tags, :before_background, :after_background,
-          # there are more, add as needed
-        ]
-        
-        events.each { |event| @formatter.should_receive(event).with('arguments')}
-     
-        subject.before_features @features
-        events.each { |event| subject.send(event, 'arguments')}
-      end
+    describe 'after features' do
       
-    end
-    
-    describe 'after the running of features' do
       before do
         @results = mock('results').as_null_object
         subject.stub!(:results).and_return @results
@@ -112,48 +109,47 @@ describe Bumps::ResultsPushFormatter do
         subject.stub!(:push)
       end
     
-      it 'should notify the wrapped formatter after all features have been run' do
+      it 'notifies the wrapped formatter after all features have been run' do
         @formatter.should_receive(:after_features).with @features
       
         subject.after_features @features
       end
     
-      it 'should ready the captured results for pushing' do     
+      it 'readies the captured results for pushing' do     
         @results.should_receive :close
       
         subject.after_features @features  
       end
     end
     
-    describe 'over the entire run' do
-      it 'should capture then push results' do
-        class FormatterTestDouble
-          def initialize(step_mother, io, options)
-            @io = io
-          end
-          
-          def before_features features
-          end
-          
-          def after_features features
-          end
-
-          def after_feature feature
-            @io << "After feature: #{feature}"
-          end
-        end
-        Bumps::Configuration.stub(:results_formatter).and_return FormatterTestDouble
-
-        subject.should_receive(:push).with 'After feature: walk the dog' 
+  end
+  
+  it 'captures then pushes results' do
+    class FormatterTestDouble
+      def initialize(step_mother, io, options)
+        @io = io
+      end
+      
+      def before_features features
+      end
+      
+      def after_features features
+      end
 
-        subject.before_features @features
-        subject.after_feature 'walk the dog'
-        subject.after_features @features
+      def after_feature feature
+        @io << "After feature: #{feature}"
       end
     end
+    Bumps::Configuration.stub(:results_formatter).and_return FormatterTestDouble
+
+    subject.should_receive(:push).with 'After feature: walk the dog' 
+
+    subject.before_features @features
+    subject.after_feature 'walk the dog'
+    subject.after_features @features
   end
   
-  describe 'when pushing results' do
+  describe 'pushing results' do
     
     before do
       @response = mock 'response'
@@ -162,7 +158,7 @@ describe Bumps::ResultsPushFormatter do
       Bumps::Configuration.stub!(:push_url).and_return @push_url
     end
   
-    it 'should post results to configured push URL' do
+    it 'posts results to configured push URL' do
       parsed_uri = mock 'parsed uri'
       URI.stub!(:parse).with(@push_url).and_return parsed_uri
       
@@ -171,28 +167,36 @@ describe Bumps::ResultsPushFormatter do
       subject.push 'results'
     end
     
-    it 'should send captured results in request' do
+    it 'sends captured results in request' do
       Net::HTTP.should_receive(:post_form).with(anything, {:results => 'results'}).and_return([@response, ''])
       
       subject.push 'results'
     end
   
-    it 'should output a success message if results were pushed successfully' do
+    it 'displays a success message if results were pushed successfully' do
       Net::HTTP.stub!(:post_form).and_return @response, ''
       
-      @io.should_receive(:<<).with "Successfully pushed results to #{@push_url}\n\n"
+      @io.should_receive(:<<).with "Successfully pushed results to #{@push_url}\n"
       
       subject.push 'results'
     end
   
-    it 'should output a failure message if results could not be pushed' do
+    it "displays a failure message if push server doesn't respond with OK" do
       @response.stub!(:code_type).and_return Net::HTTPInternalServerError
       @response.stub!(:code).and_return 500
       @response.stub!(:body).and_return 'response body'
 
       Net::HTTP.stub!(:post_form).and_return @response, ''
     
-      @io.should_receive(:<<).with "Failed to push results to #{@push_url} - HTTP 500: \nresponse body\n\n"
+      @io.should_receive(:<<).with "Failed to push results to #{@push_url} - HTTP 500: \nresponse body\n"
+    
+      subject.push 'results'
+    end
+    
+    it "displays a failure message if request to push server fails" do
+      Net::HTTP.stub!(:post_form).and_raise 'exception message'
+    
+      @io.should_receive(:<<).with "Failed to push results to #{@push_url} - exception message\n"
     
       subject.push 'results'
     end

data/spec/bumps_spec.rb

@@ -7,9 +7,9 @@ end
 
 describe Bumps do
     
-  describe 'execution of Cucumber AfterConfiguration hook' do
+  describe 'AfterConfiguration hook' do
 
-    it 'should process Cucumber config then perform a feature pull' do
+    it 'processes the Cucumber config then performs a feature pull' do
       Bumps::CucumberConfig.stub!(:new).with('source config').and_return(cukes_config = mock('Cukes config'))
       cukes_config.should_receive(:process!).ordered
       Bumps::Feature.should_receive(:pull).ordered
@@ -19,16 +19,12 @@ describe Bumps do
 
   end
     
-  describe 'configuration' do
-
-    it 'should configure the new configuration using the given directives' do
-
-      # how can we specify that it should be passed a reference to a block?
-      Bumps::Configuration.should_receive(:configure)
-    
-      Bumps.configure {}
-    end
+  it 'is configured using the given directives' do
 
+    # how can we specify that it should be passed a reference to a block?
+    Bumps::Configuration.should_receive(:configure)
+  
+    Bumps.configure {}
   end
 
 end

data/spec/spec.opts

@@ -1 +1,2 @@
---colour
+--colour
+-fs

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: bumps
 version: !ruby/object:Gem::Version 
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors: 
 - Brent Snook
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-28 00:00:00 +01:00
+date: 2009-10-13 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency