bummr 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d8473b4f3a06e36c229bf26a1e3616772f7d3990
-  data.tar.gz: ab6ce39aeecddd616183755cf4a434639b52a76d
+  metadata.gz: d64478d84437a8076bae2b39e12563ba56db1490
+  data.tar.gz: bd338fc27a9e6ca323262e59d4eee1ae25d9a0bf
 SHA512:
-  metadata.gz: c41d64f81b11a1c8a7874925cde87c0a745ea20a2a0102bc0472abeef74424704a67f6ebd37a38b63fc9f5ed743d881a4ba44f9b28ce413efbd5032673e13e23
-  data.tar.gz: de76a97147722a12995845c759ddb0f4f80272303e38c09ae4536b8d59b7d15e342b6d4ae20b608c5435435c4690101f7498198a16ed72fa1a418a4b2d59f0ba
+  metadata.gz: 764ff33ffa322006846138d751383de83451830fbc25e622aaaa7e7186e0cbd3bed34039c846cdf9e022eea0e14fe061f8dc723513821453e8b96d8ea4568989
+  data.tar.gz: 4d93f0de632b3c4111aaeca80201ff691c696fa32d42c79062a114953389367fa2be520576f38fb1c1e2a7d0fa5c9eb479733eada7c52dbdd721d441f52be419

data/README.md

@@ -12,8 +12,8 @@ Gems should be updated in [separate commits](http://ilikestuffblog.com/2012/07/0
 The bummr gem allows you to automatically update all gems which pass your
 build in separate commits, and logs the name and sha of each gem that fails.
 
-Bummr assumes you have good test coverage and follow a [pull-request workflow] (https://help.github.com/articles/using-pull-requests/) with `master` as your
-default branch.
+Bummr assumes you have good test coverage and follow a [pull-request workflow]
+with `master` as your default branch.
 
 Please note that this gem is *alpha* stage and may have bugs.
 
@@ -27,13 +27,14 @@ By default, bummr will use `bundle exec rake` to run your build.
 
 To customize your build command, `export BUMMR_TEST="./bummr-build.sh"`
 
-If you prefer, you can [run the build more than once]
-(https://gist.github.com/lpender/f6b55e7f3649db3b6df5), to protect against
+If you prefer, you can [run the build more than once], to protect against
 brittle tests and false positives.
 
 By default, bummr will assume your base branch is named `master`. If you would
 like to designate a different base branch, you can set the `BASE_BRANCH`
-environment variable: `export BASE_BRANCH='develop'
+environment variable: `export BASE_BRANCH='develop'`
+
+[run the build more than once]: https://gist.github.com/lpender/f6b55e7f3649db3b6df5
 
 ## Usage:
 
@@ -60,6 +61,8 @@ instructions in the Installation section of this README.
 - Finds all your outdated gems
 - Updates them each individually, using `bundle update --source #{gemname}`
 - Commits each gem update separately, with a commit message like:
+- Options:
+  - `--all` to include indirect dependencies (`bummr` defaults to direct dependencies only)
 
 `Update gemname from 0.0.1 to 0.0.2`
 
@@ -81,8 +84,7 @@ instructions in the Installation section of this README.
 ## Notes
 
 - Bummr assumes you have good test coverage and follow a [pull-request workflow]
-  (https://help.github.com/articles/using-pull-requests/) with `master` as your
-  default branch.
+  with `master` as your default branch.
 - Once the build passes, you can push your branch and create a pull-request!
 - You may wish to `tail -f log/bummr.log` in a separate terminal window so you
   can see which commits are being removed.
@@ -114,3 +116,5 @@ issue](https://github.com/bjoernalbers/aruba-doubles/issues/5)
 
 Thanks to Ryan Sonnek for the [Bundler
 Updater](https://github.com/wireframe/bundler-updater) gem.
+
+[pull-request workflow]: https://help.github.com/articles/using-pull-requests

data/lib/bummr/cli.rb

@@ -11,6 +11,7 @@ module Bummr
     end
 
     desc "update", "Update outdated gems, run tests, bisect if tests fail"
+    method_option :all, type: :boolean, default: false
     def update
       ask_questions
 
@@ -19,7 +20,7 @@ module Bummr
         log("Bummr update initiated #{Time.now}")
         system("bundle")
 
-        outdated_gems = Bummr::Outdated.instance.outdated_gems
+        outdated_gems = Bummr::Outdated.instance.outdated_gems(all_gems: options[:all])
 
         if outdated_gems.empty?
           puts "No outdated gems to update".color(:green)

data/lib/bummr/outdated.rb

@@ -5,23 +5,24 @@ module Bummr
   class Outdated
     include Singleton
 
-    def outdated_gems
-      @outdated_gems ||= begin
-        results = []
-
-        Open3.popen2("bundle outdated --strict") do |_std_in, std_out|
-          while line = std_out.gets
-            puts line
-            gem = parse_gem_from(line)
-
-            if gem && gemfile_contains(gem[:name])
-              results.push gem
-            end
+    def outdated_gems(all_gems: false)
+      results = []
+
+      options = []
+      options << "--strict" unless all_gems
+
+      Open3.popen2("bundle outdated", *options) do |_std_in, std_out|
+        while line = std_out.gets
+          puts line
+          gem = parse_gem_from(line)
+
+          if gem && (all_gems || gemfile_contains(gem[:name]))
+            results.push gem
           end
         end
-
-        results
       end
+
+      results
     end
 
     def parse_gem_from(line)

data/lib/bummr/version.rb

@@ -1,3 +1,3 @@
 module Bummr
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

data/spec/lib/cli_spec.rb

@@ -60,6 +60,30 @@ describe Bummr::CLI do
           cli.update
         end
       end
+
+      describe "all option" do
+        it "requests all outdated gems be listed" do
+          options[:all] = true
+
+          expect_any_instance_of(Bummr::Outdated)
+            .to receive(:outdated_gems).with({ all_gems: true })
+            .and_return outdated_gems
+
+          updater = double
+          allow(updater).to receive(:update_gems)
+
+          expect(cli).to receive(:ask_questions)
+          expect(cli).to receive(:yes?).and_return(true)
+          expect(cli).to receive(:check)
+          expect(cli).to receive(:log)
+          expect(cli).to receive(:system).with("bundle")
+          expect(Bummr::Updater).to receive(:new).with(outdated_gems).and_return updater
+          expect(cli).to receive(:system).with("git rebase -i #{BASE_BRANCH}")
+          expect(cli).to receive(:test)
+
+          cli.update
+        end
+      end
     end
   end
 

data/spec/lib/outdated_spec.rb

@@ -7,6 +7,7 @@ describe Bummr::Outdated do
     output += "  * devise (newest 4.1.1, installed 3.5.2) in group \"default\"\n"
     output += "  * rake (newest 11.1.2, installed 10.4.2)\n"
     output += "  * rails (newest 4.2.6, installed 4.2.5.1, requested ~> 4.2.0) in group \"default\"\n"
+    output += "  * indirect_dep (newest 1.0.0, installed 0.0.1)\n"
     StringIO.new(output)
   }
 
@@ -38,6 +39,30 @@ describe Bummr::Outdated do
       expect(result[2][:newest]).to eq('4.2.6')
       expect(result[2][:installed]).to eq('4.2.5.1')
     end
+
+    describe "all gems option" do
+      it "lists all outdated dependencies by omitting the strict option" do
+        allow(Open3).to receive(:popen2).with("bundle outdated").and_yield(nil, stdoutput)
+
+        allow(Bummr::Outdated.instance).to receive(:gemfile).and_return gemfile
+
+        results = Bummr::Outdated.instance.outdated_gems(all_gems: true)
+        gem_names = results.map { |result| result[:name] }
+
+        expect(gem_names).to include "indirect_dep"
+      end
+
+      it "defaults to false" do
+        expect(Open3).to receive(:popen2).with("bundle outdated", "--strict").and_yield(nil, stdoutput)
+
+        allow(Bummr::Outdated.instance).to receive(:gemfile).and_return gemfile
+
+        results = Bummr::Outdated.instance.outdated_gems
+        gem_names = results.map { |result| result[:name] }
+
+        expect(gem_names).to_not include "indirect_dep"
+      end
+    end
   end
 
   describe "#parse_gem_from" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bummr
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Lee Pender
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-03 00:00:00.000000000 Z
+date: 2017-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor