bullet_train 1.4.9 → 1.4.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 433bfb9d02ab90a900aa78aa7918b9b33a644738756ca001d75571e889faa111
-  data.tar.gz: 4a0fb6994451fb11ac8bd268bb2df790e994ff7b1a4e9ac3ca6f9c71e3187808
+  metadata.gz: 140dbaf8f86eba011c5c4e5b5a01a6901d4ab16b669acbffeed08a3dc75f5dfb
+  data.tar.gz: 9a1153ecb4219a98ee472aa6f56a2ac1070f2f893f79735112fad5d17464bb74
 SHA512:
-  metadata.gz: 18bf21a0212e080b886d045a25cce43f6a05f60844c2bc97f73bd062190d9d01968fcf0e8946c9a98f2a3784958685e90ff321edf471b583be7dcf0a0c3d7683
-  data.tar.gz: aea9776250358a2436400ed63c4ee89bc80b1bb31537dcb082f249fd6ae3522bddcc008a6d275c6a046514a351a209ba8a49741fd66b7fcbbe9c755171969d1e
+  metadata.gz: aaee080da3b6620766f71c0f9c064640246f392b1a95d20451dbb205182ba2c2db84f97475311feb5dfa7e4637ddbaf4bf9fabb808184ef44ac9f585bc89f6fd
+  data.tar.gz: 42307b6892bd7946f2be04a1a184003e88c041b150233bb36c0d135045736ea3491679fb7d10a0f14f4a15515ed37ec9aa2cde25041421e3becb5ee69443c44f

data/docs/upgrades/notable-versions.md

@@ -0,0 +1,63 @@
+# Notable Versions
+
+## v1.4.11 / v1.5.0
+
+In v1.5.0 we made some fairly big changes to the format of system tests. In order to ease the
+transition we shipped a helper in 1.4.11 that you can use to modify your copy of the tests before
+you merge in version 1.5.0. Doing this should reduce the chances for merge conflicts.
+
+To use the helper to modify your tests run this in a console (after updating to v1.4.11):
+
+```
+bin/update/system_tests/use_device_test
+```
+
+Then you should:
+
+* Run the tests to make sure they still pass
+* Commit the updated test files
+* Update to v1.5.0
+
+### About this change
+
+We've introduced a new `device_test` helper that wraps up some of the implementation
+details about running system tests on a variety of devices.
+
+It simplifies the way that we write system tests like this:
+
+```diff
+-  @@test_devices.each do |device_name, display_details|
+-    test "user can so something on a #{device_name}" do
+-      resize_for(display_details)
+-      # actual tests here
+-    end
+-  end
++  device_test "user can do something" do
++    # actual test code
++  end
+```
+
+The specific changes are:
+
+* Remove the enclosing @@test_devices.each do block
+* Remove one level of indentation from test inside those blocks
+* Remove the resize_for(display_details) from tests in those blocks
+* Use `device_test` helper to handle running the test on different devices
+
+
+## v1.3.22
+
+In version 1.3.22 we added an `Address` model. If your app already had an `Address` model you'll
+probably want to reject some of the updates made to the starter repo in this version.
+
+TODO: Can we offer more direction here?
+
+
+## v1.3.0
+
+Version 1.3.0 is when we started explicitly bumping the Bullet Train gems within the starter repo
+every time that we release a new version of the `core` gems. Unfortunately, at that time we were
+only making changes to Gemfile.lock which kind of hides the dependencies, and is often a source of
+merge conflicts that can be hard to sort out.
+
+[See the upgrade guide for getting your app to version 1.3.0](/docs/upgrades/yolo-130)

data/docs/upgrades/options.md

@@ -7,6 +7,8 @@
 * [Upgrade from any version to `1.4.0`](/docs/upgrades/yolo-140.md)
 * [Upgrade from any version to `1.3.0`](/docs/upgrades/yolo-130.md)
 * [Upgrade from `1.3.x` to `1.4.0`](/docs/upgrades/yolo-140.md)
+* [Notable versions](/docs/upgrades/notable-versions)
+
 
 ## About the upgrade process
 
@@ -27,6 +29,8 @@ which is less hidden and is not as prone to having merge conflicts as `Gemfile.l
 As a result of these changes, there are a few different ways that you might choose to upgrade your application
 depending on which version you're currently on.
 
+[Be sure to check our Notable Versions list to see if there's anything tricky about the version you're moving to.](/docs/upgrades/notable-versions)
+
 ## How to find your current version
 
 You can easily find your current version by running `bundle show | grep "bullet_train "`.

data/docs/upgrades/yolo-130.md

@@ -173,6 +173,8 @@ Before doing this you should have already followed the instructions above to get
 
 For purposes of this example we'll assume that you're stepping up from `1.3.0` to `1.3.1`.
 
+[Be sure to check our Notable Versions list to see if there's anything tricky about the version you're moving to.](/docs/upgrades/notable-versions)
+
 ### 1. Make sure you're working with a clean local copy.
 
 ```

data/docs/upgrades/yolo-140.md

@@ -12,6 +12,8 @@
 
 ## Getting to `1.4.0`
 
+[Be sure to check our Notable Versions list to see if there's anything tricky about the version you're moving to.](/docs/upgrades/notable-versions)
+
 ### 1. Make sure you're working with a clean local copy.
 
 ```

data/docs/upgrades/yolo.md

@@ -58,7 +58,7 @@ generate a new one that matches what you need:
 
 ```
 git checkout HEAD -- Gemfile.lock
-bundle update
+bundle install
 ```
 
 If you choose to sort out `Gemfile.lock` by hand it's a good idea to run `bundle install` just to make

data/docs/upgrades.md

@@ -36,6 +36,8 @@ your application.
 
 For the purposes of these instructions we'll assume that you're on version `1.4.0` and are going to upgrade to version `1.4.1`.
 
+[Be sure to check our Notable Versions list to see if there's anything tricky about the version you're moving to.](/docs/upgrades/notable-versions)
+
 ### 2. Make sure you're working with a clean local copy.
 
 ```
@@ -85,7 +87,7 @@ generate a new one that matches what you need:
 
 ```
 git checkout HEAD -- Gemfile.lock
-bundle update
+bundle install
 ```
 
 If you choose to sort out `Gemfile.lock` by hand it's a good idea to run `bundle install` just to make

data/lib/bullet_train/resolver.rb

@@ -58,17 +58,8 @@ module BulletTrain
               # Look for showcase preview.
               file_name = source_file[:absolute_path].split("/").last
               showcase_partials = Dir.glob(`bundle show bullet_train-themes-light`.chomp + "/app/views/showcase/**/*.html.erb")
-              has_showcase_partial = false
-              showcase_partial = nil
-              showcase_partials.each do |partial|
-                has_showcase_preview = partial.match?(/#{file_name}$/)
-                if has_showcase_preview
-                  showcase_partial = partial
-                  break
-                end
-              end
-
-              if has_showcase_partial
+              showcase_preview = showcase_partials.find { _1.end_with?(file_name) }
+              if showcase_preview
                 puts "Ejecting showcase preview for #{source_file[:relative_path]}"
                 partial_relative_path = showcase_preview.scan(/(?=app\/views\/showcase).*/).last
                 directory = partial_relative_path.split("/")[0..-2].join("/")

data/lib/bullet_train/version.rb

@@ -1,3 +1,3 @@
 module BulletTrain
-  VERSION = "1.4.9"
+  VERSION = "1.4.11"
 end

data/lib/bullet_train.rb

@@ -9,6 +9,8 @@ require "bullet_train/super_load_and_authorize_resource"
 require "bullet_train/has_uuid"
 require "bullet_train/scope_validator"
 
+require "exceptions"
+
 require "colorizer"
 require "bullet_train/core_ext/string_emoji_helper"
 

data/lib/exceptions.rb

@@ -0,0 +1,3 @@
+class RemovingLastTeamAdminException < RuntimeError; end
+
+class RemovingLastTeamException < RuntimeError; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train
 version: !ruby/object:Gem::Version
-  version: 1.4.9
+  version: 1.4.11
 platform: ruby
 authors:
 - Andrew Culver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-09-27 00:00:00.000000000 Z
+date: 2023-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: standard
@@ -753,6 +753,7 @@ files:
 - docs/trademark.md
 - docs/tunneling.md
 - docs/upgrades.md
+- docs/upgrades/notable-versions.md
 - docs/upgrades/options.md
 - docs/upgrades/yolo-130.md
 - docs/upgrades/yolo-140.md
@@ -767,6 +768,7 @@ files:
 - lib/bullet_train/resolver.rb
 - lib/bullet_train/version.rb
 - lib/colorizer.rb
+- lib/exceptions.rb
 - lib/tasks/bullet_train_tasks.rake
 homepage: https://github.com/bullet-train-co/bullet_train-core/tree/main/bullet_train
 licenses: